Re: [PATCH V3] Driver for Elantech I2C touchpad

2023-07-07 Thread Jonathan Gray
On Thu, Jul 06, 2023 at 06:44:47PM +0200, Vladimir 'phcoder' Serbinenko wrote: > This patch adds support for I2C Elantech touchpad as used on Chromebooks > and some other laptops. Tested on Elemi Chromebook. Based on FreeBSD ietp > driver and OpenBSD ihidev.c driver. Ietp uses HID endpoint

Re: gitignore: got + cvs coexistence

2023-07-07 Thread Tobias Heider
On Fri, Jul 07, 2023 at 02:02:49PM +0200, Alexander Hall wrote: > On July 7, 2023 12:50:55 PM GMT+02:00, Stefan Sperling wrote: > >On Fri, Jul 07, 2023 at 12:26:16PM +0200, Tobias Heider wrote: > >> For bigger changesets I have started experimenting with using got. > >> I don't like to have the

Re: gitignore: got + cvs coexistence

2023-07-07 Thread Alexander Hall
On July 7, 2023 12:50:55 PM GMT+02:00, Stefan Sperling wrote: >On Fri, Jul 07, 2023 at 12:26:16PM +0200, Tobias Heider wrote: >> For bigger changesets I have started experimenting with using got. >> I don't like to have the whole tree on disk twice so I keep my got and CVS >> checkouts in the

Re: gitignore: got + cvs coexistence

2023-07-07 Thread Stefan Sperling
On Fri, Jul 07, 2023 at 12:26:16PM +0200, Tobias Heider wrote: > For bigger changesets I have started experimenting with using got. > I don't like to have the whole tree on disk twice so I keep my got and CVS > checkouts in the same directory. Curious. I am not sure how well that will work in

Re: Use u_long for struct mstat

2023-07-07 Thread Vitaliy Makkoveev
On Fri, Jul 07, 2023 at 12:31:02PM +0300, YASUOKA Masahiko wrote: > Hi, > > I'd like to expand the counters in struct mbstat from u_short to u_long. > > When I was debugging a mbuf leak, I saw the result of "netstat -m" > --- > 28647 mbufs in use: > 28551 mbufs allocated to data >

Re: Use u_long for struct mstat

2023-07-07 Thread Alexander Bluhm
On Fri, Jul 07, 2023 at 12:31:02PM +0300, YASUOKA Masahiko wrote: > Hi, > > I'd like to expand the counters in struct mbstat from u_short to u_long. > > When I was debugging a mbuf leak, I saw the result of "netstat -m" > --- > 28647 mbufs in use: > 28551 mbufs allocated to data >

gitignore: got + cvs coexistence

2023-07-07 Thread Tobias Heider
For bigger changesets I have started experimenting with using got. I don't like to have the whole tree on disk twice so I keep my got and CVS checkouts in the same directory. A downside of this approach is of course that got always lists all the unknown CVS dirs in got status. Does anything speak

[PATCH V4] Driver for Elantech I2C touchpad

2023-07-07 Thread Vladimir 'phcoder' Serbinenko
Changes: * Removed couple of dead functions Le jeu. 6 juil. 2023, 18:44, Vladimir 'phcoder' Serbinenko < phco...@gmail.com> a écrit : > This patch adds support for I2C Elantech touchpad as used on Chromebooks > and some other laptops. Tested on Elemi Chromebook. Based on FreeBSD ietp > driver

Re: acpi: move acpiioctl to x86

2023-07-07 Thread Tobias Heider
On Wed, Jul 05, 2023 at 04:53:33PM +0200, Tobias Heider wrote: > I am planning to restructure the APM/sleep APIs to make it easier to suspend > from more places like as a suspend keyboard shortcut. > > The acpiioctl handler is x86 specific code which is currently built on all > platforms but only

Use u_long for struct mstat

2023-07-07 Thread YASUOKA Masahiko
Hi, I'd like to expand the counters in struct mbstat from u_short to u_long. When I was debugging a mbuf leak, I saw the result of "netstat -m" --- 28647 mbufs in use: 28551 mbufs allocated to data 4 mbufs allocated to packet headers 92 mbufs allocated to socket names and

ix(4) shouldn't crash on memory allocation failure

2023-07-07 Thread Jonathan Matthew
One of the problems described here: https://www.mail-archive.com/tech@openbsd.org/msg71790.html amounts to ix(4) not checking that it allocated a dma map before trying to free it. ok? Index: if_ix.c === RCS file:

Re: tcp timer wrap around, use 64 bit

2023-07-07 Thread Alexander Bluhm
On Fri, Jul 07, 2023 at 12:07:36PM +0300, YASUOKA Masahiko wrote: > Hi, > > This netstat diff is already needed to avoid compiler warnings since > it uses struct tcpcb directly. > > ok? OK bluhm@ > Index: usr.bin/netstat/inet.c >

Re: tso lo keep mss

2023-07-07 Thread Vitaliy Makkoveev
On Fri, Jul 07, 2023 at 11:48:13AM +0300, Alexander Bluhm wrote: > Hi, > > When we preserve M_TCP_TSO we also must keep ph_mss. In lo(4) > LRO/TSO this logic was missing. As this may be relevant only for > weird pf configs that forward from loopback and ifconfig tcplro is > disabled by default,

Re: tcp timer wrap around, use 64 bit

2023-07-07 Thread YASUOKA Masahiko
Hi, This netstat diff is already needed to avoid compiler warnings since it uses struct tcpcb directly. ok? Index: usr.bin/netstat/inet.c === RCS file: /cvs/src/usr.bin/netstat/inet.c,v retrieving revision 1.177 diff -u -p -r1.177

Re: tcp timer wrap around, use 64 bit

2023-07-07 Thread Alexander Bluhm
On Fri, Jul 07, 2023 at 10:43:21AM +0200, Claudio Jeker wrote: > On Fri, Jul 07, 2023 at 11:38:58AM +0300, YASUOKA Masahiko wrote: > > Hi, > > > > Does using 64 bit for timer in tcpcb require this? > > Not sure about this but one comment below. When we introduced struct tcp_info, we discussed

Re: tcp timer wrap around, use 64 bit

2023-07-07 Thread YASUOKA Masahiko
On Fri, 7 Jul 2023 10:43:21 +0200 Claudio Jeker wrote: >> @@ -411,7 +412,7 @@ tcp_stats_display(unsigned long long tot >> P(tcpi, rcv_up, "%u") >> P(tcpi, rcv_wscale, "%hhu") >> P(tcpi, rfbuf_cnt, "%u") >> -P(tcpi,

tso lo keep mss

2023-07-07 Thread Alexander Bluhm
Hi, When we preserve M_TCP_TSO we also must keep ph_mss. In lo(4) LRO/TSO this logic was missing. As this may be relevant only for weird pf configs that forward from loopback and ifconfig tcplro is disabled by default, it is not relevant yet. ok? bluhm Index: net/if.c

Re: tcp timer wrap around, use 64 bit

2023-07-07 Thread Claudio Jeker
On Fri, Jul 07, 2023 at 11:38:58AM +0300, YASUOKA Masahiko wrote: > Hi, > > Does using 64 bit for timer in tcpcb require this? Not sure about this but one comment below. > ok? > > Index: sys/netinet/tcp.h > === > RCS file:

Re: tcp timer wrap around, use 64 bit

2023-07-07 Thread YASUOKA Masahiko
Hi, Does using 64 bit for timer in tcpcb require this? ok? Index: sys/netinet/tcp.h === RCS file: /cvs/src/sys/netinet/tcp.h,v retrieving revision 1.24 diff -u -p -r1.24 tcp.h --- sys/netinet/tcp.h 19 May 2023 01:04:39 -