Re: signify xr sysupgrade.8

2019-04-26 Thread Claudio Jeker
On Fri, Apr 26, 2019 at 02:49:57PM -0600, Theo de Raadt wrote: > Ted Unangst wrote: > > > Simplify examples section. The magic recipe is contained in sysupgrade, so > > we > > can omit it, and instead add a .xr to sysupgrade.8. > > > > > > Index: signify.1 > > =

Re: ospf(6)d: check rdomain for depend on interfaces

2019-04-29 Thread Claudio Jeker
On Sun, Apr 28, 2019 at 10:23:02PM +0200, Sebastian Benoit wrote: > Remi Locherer(remi.loche...@relo.ch) on 2019.04.28 11:43:41 +0200: > > Hi, > > > > the parser in ospf(6)d accepts depend on interfaces that are in a > > different rdomain. This works on startup of the daemon. But since it > > filt

OpenBGPD 6.5p0 released

2019-04-30 Thread Claudio Jeker
We have released OpenBGPD 6.5p0, which will be arriving in the OpenBGPD directory of your local OpenBSD mirror soon. OpenBGPD is a free, functional, and secure implementation of the Border Gateway Protocol (BGP-4). It is a fairly complete BGP implementation and praised for ease of use, as well as

[cje...@diehard.n-r-g.com: Re: bgpd acting up, dropping connected/static network statements]

2019-05-04 Thread Claudio Jeker
For those people not on misc@. This bgpd diff fixes reload issues with all non fixed (those not using a prefix but e.g. static or rtlabel). On Fri, May 03, 2019 at 09:59:40AM +0200, open...@kene.nu wrote: > Hello, > > I am seeing strange behaviour of bgpd in 6.5. > > Not sure what causes the ne

bgpd TCP MD5 and pfkey shuffle

2019-05-04 Thread Claudio Jeker
This diff changes a bit the way tcp md5sum (and ike) is setup. The big change is that the pfkey handling is moved from the session engine to the parent process. In a later step this should allow to no longer distribute autentication data to the unprivileged childs (but this is not done yet since th

bgpd, filterstate can never be NULL so don't check for it

2019-05-09 Thread Claudio Jeker
This is cleanup. rde_filter() and rde_apply_set() are no longer called with a NULL filterstate (since introduction of the Adj-RIB-Out). So remove all those extra checks to make sure state is not NULL. -- :wq Claudio Index: rde_filter.c

Proper prototype for upgrade() in boot code

2019-05-10 Thread Claudio Jeker
See subject -- :wq Claudio Index: cmd.h === RCS file: /cvs/src/sys/stand/boot/cmd.h,v retrieving revision 1.17 diff -u -p -r1.17 cmd.h --- cmd.h 8 Apr 2019 13:55:46 - 1.17 +++ cmd.h 8 May 2019 23:12:10 - @@

bgpd refactor UPDATE attribute writer

2019-05-10 Thread Claudio Jeker
This change is from a much larger patch I'm working on. This cleans up up_generate_attr() from a hardcoded implementation to a loop-switch construct. This way attributes are always dumped in ascending order as suggested by the RFC and adding special attributes is simpler than in the current way. Th

tcpdump support extended bgp shutdown communication

2019-05-11 Thread Claudio Jeker
bgpd already got support for extended shutdown communication messages. This adds the same support to tcpdump. OK? -- :wq Claudio Index: print-bgp.c === RCS file: /cvs/src/usr.sbin/tcpdump/print-bgp.c,v retrieving revision 1.27 diff

Re: ripd: typo

2019-05-12 Thread Claudio Jeker
On Sun, May 12, 2019 at 10:17:13AM +0200, Denis Fondras wrote: > additional "s" laying around. OK > Index: printconf.c > === > RCS file: /cvs/src/usr.sbin/ripd/printconf.c,v > retrieving revision 1.7 > diff -u -p -r1.7 printconf.c >

bgpd set nexthop 198.51.100.42 clarifications

2019-05-13 Thread Claudio Jeker
When using a rule forcing the nexthop to a specific address bgpd currently does not mark that nexthop as no-modify. In other words the default rules for nexthop propagation applies. This means that for ebgp it only sends out the set nexthop when this nexthop is connected and on the same network as

bgpd communities rewrite

2019-05-13 Thread Claudio Jeker
This diff changes the way communites are stored and modified in bgpd. The current implementation was showing that community_*_delete() consumed a lot of CPU time because of the way rde_attr was used. Communities are extensivly used by filters (e.g. arouteserver) and therefor they are stored in an o

bgpd: better tcp md5sig handling

2019-05-21 Thread Claudio Jeker
Hi, The last refactor of the pfkey handling uncovered an issue deep down in the pfkey handling. Some long time ago henning@ added a sleep(1) into pfkey_md5sig_establish(). This is now hunting us back because bgpd ends up with no tcp md5sig flow for 1 sec while a connection is established. Because

Re: efiboot: allow bigger ucodes

2019-05-22 Thread Claudio Jeker
On Wed, May 22, 2019 at 08:02:14PM +0200, Alexander Bluhm wrote: > On Wed, May 22, 2019 at 05:54:35PM +0200, Mark Kettenis wrote: > > Should we also fix biosboot? The machines that are affected are all > > fairly recent and should boot using UEFI by default... > > If we change fewer things, we ma

bgpctl show mrt neighbors

2019-05-23 Thread Claudio Jeker
The MRT TABLE_DUMP_V2 format includes a list of all peers at the start of the dump. I find it useful to be able to dump this table independent of the rest. Especially useful if used together with bgpctl show mrt nei to limit the output to a single neighbor. Possible out looks like: view: master BG

bgpd session engine optimization

2019-05-24 Thread Claudio Jeker
Running bgpd with 500+ peers shows that per poll loop more then 1000 clock_gettime() syscalls are made (it is actually 2 * num peers). This diff changes this by caching the clock_gettime() value before the loop over all peers and using the cached value for the timer calculation. This is no big deal

Re: rpki-client change way TAL are loaded

2019-10-30 Thread Claudio Jeker
On Mon, Oct 21, 2019 at 02:14:15PM +0200, Claudio Jeker wrote: > On Sun, Oct 20, 2019 at 12:46:44PM -0600, Theo de Raadt wrote: > > There has been an update to > > > > https://www.ietf.org/rfcdiff?url2=draft-ietf-sidrops-https-tal-05 > > > > Which perm

OpenBGPD 6.6p0 released

2019-10-31 Thread Claudio Jeker
We have released OpenBGPD 6.6p0, which will be arriving in the OpenBGPD directory of your local OpenBSD mirror soon. This is the first stable release for the 6.6 version. It includes the following changes: * Changed the Adj-RIB-Out to a per-peer set of RB trees, improving speed. * Rewrot

fix rpki-client regress

2019-11-02 Thread Claudio Jeker
Refactor the TAL loading code a bit (move the file parsing back into tal.c) and adjust the regress test to use this new function. This fixes the regress test and makes the code a bit nicer. OK? -- :wq Claudio Index: usr.sbin/rpki-client/extern.h ==

Re: [PATCH] remove sysctl net.mpls.maxloop_inkernel

2019-11-05 Thread Claudio Jeker
On Mon, Nov 04, 2019 at 06:42:20AM -0500, tho...@habets.se wrote: > (adding claudio as the most recent contributor) > > As per https://marc.info/?l=openbsd-misc&m=157191651123338&w=2 this is > no longer used and can be removed. > > Before: > $ sysctl -a | grep mpls > net.mpls.ttl=255 > net.mpls.m

Re: [rpki-client] Patch submission (tal.c)

2019-11-05 Thread Claudio Jeker
On Tue, Nov 05, 2019 at 11:01:56AM -0300, Alexandre Hamada wrote: > Hi Claudio, > > I was testing some tal files, and when it contains an https url (RFC 8630), > it generates a segmentation fault. > > Thus, I would like to suggest adding the following on tal_parse/tal_free. > > Example: > https:

Re: [rpki-client] Patch submission (tal.c)

2019-11-06 Thread Claudio Jeker
On Tue, Nov 05, 2019 at 01:57:09PM -0300, Alexandre Hamada wrote: > Hi Claudio. > > FYI, I've added some support for https. Not sure if this might be useful, > but here is the code for ta_parse_buffer. > > I´ve also modified tal_parse to display a warn message instead of exiting on > invalid base

Re: iwm: support more than one frame per interrupt

2019-11-09 Thread Claudio Jeker
On Sat, Nov 09, 2019 at 03:20:10PM +0100, Florian Obser wrote: > My 7260 doesn't like it. Same problem as last time. > These counters go through the roof and network stalls. > Also when packets are flowing throughput varies a lot. > 30131 input block ack window slides > 30171 input

Re: ospfd: correct function name in error message

2019-11-09 Thread Claudio Jeker
On Sat, Nov 09, 2019 at 03:27:31PM +0100, Denis Fondras wrote: > Fix function name in error message. > > Index: kroute.c > === > RCS file: /cvs/src/usr.sbin/ospfd/kroute.c,v > retrieving revision 1.112 > diff -u -p -r1.112 kroute.c >

Re: ospfd: type p2p

2019-11-15 Thread Claudio Jeker
On Fri, Nov 15, 2019 at 06:06:42PM +0100, Remi Locherer wrote: > On Mon, Nov 04, 2019 at 02:01:57PM +0200, Kapetanakis Giannis wrote: > > On 25/10/2019 13:57, Remi Locherer wrote: > > > Hi tech@, > > > > > > earlier this year I sent a diff that allowed to change an interface > > > from broadcast to

Re: ospfd: type p2p

2019-11-17 Thread Claudio Jeker
On Sun, Nov 17, 2019 at 12:44:44PM +0100, Remi Locherer wrote: > On Sat, Nov 16, 2019 at 06:58:35AM +0100, Claudio Jeker wrote: > > On Fri, Nov 15, 2019 at 06:06:42PM +0100, Remi Locherer wrote: > > > On Mon, Nov 04, 2019 at 02:01:57PM +0200, Kapetanakis Giannis wrote: > >

Re: rpki-client: check empty TAL file

2019-11-17 Thread Claudio Jeker
On Sun, Nov 17, 2019 at 10:05:11PM +0100, Kristaps Dzonsons wrote: > If tal_read_file() returns a NULL buffer, which can happen with an empty > file or one containing only comments, the NULL value eventually > propogates to tal_parse_buffer() where it crashes on strchr(). > > This patch also adds/

Re: rpki-client: remove unused variables

2019-11-17 Thread Claudio Jeker
On Sun, Nov 17, 2019 at 10:12:15PM +0100, Kristaps Dzonsons wrote: > This removes some unused variables from the output files. Indeed, OK claudio@ > ? remove-unused-variables.patch > Index: output-bird.c > === > RCS file: /cvs/src/us

Re: rpki-client: validate.c, roa.c, main.c docs

2019-11-17 Thread Claudio Jeker
On Sun, Nov 17, 2019 at 10:25:02PM +0100, Kristaps Dzonsons wrote: > This causes validate.c's valid_cert() doc not to lie, makes the language > consistent with other functions, and cleans a typo. > > In main.c, this documents tal_load_default() (which it marks static), > moves a #define to the top

Re: unwind: log missing config file

2019-11-18 Thread Claudio Jeker
On Mon, Nov 18, 2019 at 07:57:09PM -0700, Theo de Raadt wrote: > Florian Obser wrote: > > > On Tue, Nov 19, 2019 at 12:15:34AM +0100, Klemens Nanni wrote: > > > On Mon, Nov 18, 2019 at 10:19:47PM +0100, Klemens Nanni wrote: > > > > With that, my initial case is no longer misleading; alternativel

Re: Fixes for padding in OpenFlow header match fields

2019-11-27 Thread Claudio Jeker
On Tue, Nov 26, 2019 at 04:17:46PM -0800, Ayaka Koshibe wrote: > Currently, we assume that OpenFlow 1.3 set_field actions can contain > multiple header match fields (OXMs). According to specification, a > set_field action contains exactly one OXM, followed by padding to align > the action field in

Re: massage tcpdump ip and encapsulation output

2019-12-05 Thread Claudio Jeker
On Tue, Dec 03, 2019 at 10:00:01PM +1000, David Gwynne wrote: > this is a significant reworking of tcpdump with a couple of goals > twisted together. > > it is becoming increasingly common to encapsulate protocols, leading > to situations where you have some kind of ip packet inside another > ip p

Re: massage tcpdump ip and encapsulation output

2019-12-06 Thread Claudio Jeker
On Fri, Dec 06, 2019 at 12:16:09PM +0100, Sebastian Benoit wrote: > David Gwynne(da...@gwynne.id.au) on 2019.12.06 15:14:42 +1000: > > > > > > > On 5 Dec 2019, at 21:14, Sebastian Benoit wrote: > > > > > > Claudio Jeker(cje...@diehard.n-r-g.com) on

first part of output splitting in bgpctl

2019-12-06 Thread Claudio Jeker
The output processing in bgpctl is not very extensible. And output flags like ssv have to hacked into the output in a bad way. This is the first bit of a much bigger shuffling action to make the output handling more extensible. For now this just moves the header and body generation into two functi

Re: ripd: remove unused line

2019-12-09 Thread Claudio Jeker
On Sun, Dec 08, 2019 at 11:20:16PM +0100, Remi Locherer wrote: > Hi, > > iface is not used afterwards. I think it should have been removed > in revision 1.8. > > OK? OK claudio@ > Remi > > > Index: ripe.c > === > RCS file: /cvs/s

Re: ripd: fix error message

2019-12-09 Thread Claudio Jeker
On Sun, Dec 08, 2019 at 11:23:31PM +0100, Remi Locherer wrote: > Hi, > > this fixes an error message to reflect the correct function name. > > OK? OK claudio@ > Remi > > > Index: message.c > === > RCS file: /cvs/src/usr.sbin/rip

Re: ripd: fix split-horizon simple

2019-12-09 Thread Claudio Jeker
On Sun, Dec 08, 2019 at 11:29:43PM +0100, Remi Locherer wrote: > Hi, > > when "split-horizon simple" is used, ripd might send out messges with 0 > routes in it. This is because nentries is counted up even if the route > was not added to buf. Moving nentries++ up is fixing this. > > Below log mess

Re: attention please: host's IP stack behavior got changed slightly

2019-12-09 Thread Claudio Jeker
On Mon, Dec 09, 2019 at 10:58:32AM +0500, Alexander E. Patrakov wrote: > 08.12.2019 16:42, Alexandr Nedvedicky wrote: > > Hello, > > > > commit from today [1] makes IP stack more paranoid. Up to now OpenBSD > > implemented so called 'weak host model' [2]. The today's commit alters > > that for hos

Re: ospf6d: convert sendto() to sendmsg()

2019-12-11 Thread Claudio Jeker
On Wed, Dec 11, 2019 at 04:52:53PM +0100, Denis Fondras wrote: > Use sendmsg() instead of sendto() like ospfd(8) does. > > Index: database.c > === > RCS file: /cvs/src/usr.sbin/ospf6d/database.c,v > retrieving revision 1.16 > diff -u

Re: ospf6d: convert sendto() to sendmsg()

2019-12-11 Thread Claudio Jeker
On Wed, Dec 11, 2019 at 04:52:53PM +0100, Denis Fondras wrote: > Use sendmsg() instead of sendto() like ospfd(8) does. > > Index: database.c > === > RCS file: /cvs/src/usr.sbin/ospf6d/database.c,v > retrieving revision 1.16 > diff -u

Re: first part of output splitting in bgpctl

2019-12-13 Thread Claudio Jeker
On Fri, Dec 06, 2019 at 05:46:52PM +0100, Claudio Jeker wrote: > The output processing in bgpctl is not very extensible. And output flags > like ssv have to hacked into the output in a bad way. > > This is the first bit of a much bigger shuffling action to make the output >

bgpctl output refactoring part 2

2019-12-13 Thread Claudio Jeker
This is the next step in refactoring the output functions in bgpctl. This diff changes the way individual show_XY() functions are called. Up until now they got passed an imsg and then did stuff based on the imsg type. Now show() will look at the imsg and based on the type call the right function f

bgpd rde refactor

2019-12-13 Thread Claudio Jeker
This diff changes the way session or peer related imsgs are handled. Instead of passing the imsg.hdr.peerid down and doing the lookup for the peer in each function move that code up into the imsg handler. The plan is to add an imsg queue per peer later on to make the processing of messages more fai

piixpm(4) add support for newer AMD chipsets

2019-12-16 Thread Claudio Jeker
This diff should add support for newer smbus controllers used on newer AMD chipsets. Especially Hudson-2 and Kerncz based chipsets. On my Ryzen 5 the iic(4) busses attach but there is nothing detected on them (well possible that I missed something). I also implemented the up to 4 busses available o

Re: piixpm(4) add support for newer AMD chipsets

2019-12-16 Thread Claudio Jeker
On Mon, Dec 16, 2019 at 08:46:21AM -0500, Bryan Steele wrote: > On Mon, Dec 16, 2019 at 12:37:51PM +0100, Claudio Jeker wrote: > > This diff should add support for newer smbus controllers used on newer AMD > > chipsets. Especially Hudson-2 and Kerncz based chipsets. On my Ryzen

Re: attention please: host's IP stack behavior got changed slightly

2019-12-16 Thread Claudio Jeker
On Mon, Dec 16, 2019 at 02:13:50PM +0100, Alexander Bluhm wrote: > On Sun, Dec 15, 2019 at 03:17:26PM +0100, Alexandr Nedvedicky wrote: > > Hello Daniel, > > > > thanks for reporting back. > > > > > > > Should the rdr-to rule still work? I fixed it with using the "Port foo" > > > directive in my s

Re: piixpm(4) add support for newer AMD chipsets

2019-12-16 Thread Claudio Jeker
On Mon, Dec 16, 2019 at 08:02:55PM +0100, Mark Kettenis wrote: > > Date: Mon, 16 Dec 2019 12:37:51 +0100 > > From: Claudio Jeker > > > > This diff should add support for newer smbus controllers used on newer AMD > > chipsets. Especially Hudson-2 and Kerncz bas

bgpct minor cleanup

2019-12-19 Thread Claudio Jeker
This is just some minor cleanup needed before starting to split out functions into a new file. First it shuffles and changes the fmt_timecore functions. It adds an additional check to not print negative timeframes (the result would most probably be wrong anyway). Second switch show_mrt_dump to use

bgpctl: split out show functions into own file

2019-12-19 Thread Claudio Jeker
bgpctl.c --- bgpctl.c20 Dec 2019 07:18:51 - 1.253 +++ bgpctl.c20 Dec 2019 07:20:27 - @@ -2,6 +2,7 @@ /* * Copyright (c) 2003 Henning Brauer + * Copyright (c) 2004-2019 Claudio Jeker * Copyright (c) 2016 Job Snijders * Copyright (c) 2016 Peter Hessler * @@ -38,49

Re: DDR4 spdmem(4) fix

2019-12-21 Thread Claudio Jeker
On Sat, Dec 21, 2019 at 12:11:23PM +0100, Mark Kettenis wrote: > Currently my mini-PC with AMD Ryzen CPU shows: > > spdmem0 at iic0 addr 0x50: 0MB DDR4 SDRAM PC4-21300 SO-DIMM > > problem here is in the calculation of the DIMM size: > > dimm_size = datawidth - (chipwidth + 2); >

Re: ospf6d: rename & move function

2019-12-22 Thread Claudio Jeker
On Sun, Dec 22, 2019 at 10:55:39AM +0100, Denis Fondras wrote: > Rename and move calc_nexthop_clear()/calc_nexthop_add() to > vertex_nexthop_clear()/vertex_nexthop_add() > > It brings ospf6d closer to ospfd. > OK claudio@ > > Index: rde.h > =

Re: ospf6d: add basic regress tests

2019-12-23 Thread Claudio Jeker
On Mon, Dec 23, 2019 at 03:24:31PM +0100, Remi Locherer wrote: > On Sun, Dec 22, 2019 at 08:36:41PM +0100, Denis Fondras wrote: > > Add basic regress test to ospf6d. > > Works for me. OK remi@ > > The tests also succeed when I reduce the sleep from 120 to 60. > A few lines end with a space. I mar

Re: ifconfig: fix maximum SSID length with WPA

2019-12-27 Thread Claudio Jeker
On Fri, Dec 27, 2019 at 01:12:42PM +0100, Stefan Sperling wrote: > If an SSID uses the maximum allowed length, ifconfig overwrites > the last byte with \0 when hashing the WPA key. > This leads to a wrong WPA key being installed in the kernel: > > iwm0: SCAN -> AUTH > iwm0: sending auth to xx:xx:x

bgpd, fairer imsg processing

2019-12-30 Thread Claudio Jeker
+voidpeer_imsg_flush(struct rde_peer *); + /* rde_attr.c */ int attr_write(void *, u_int16_t, u_int8_t, u_int8_t, void *, Index: rde_peer.c === RCS file: rde_peer.c diff -N rde_peer.c --- /dev/null 1 Jan 1970 00:00:00 -000

Re: snmpd(8): filter pf table addresses

2019-12-31 Thread Claudio Jeker
On Tue, Dec 31, 2019 at 11:16:37AM +0100, Martijn van Duren wrote: > I'm on the fence about this. So if you feel strongly about this go > ahead if it works. In some regard I agree but in this case I think it makes sense. > I am however somewhat confused about your description. You say it > times

bgpd and time stamps

2019-12-31 Thread Claudio Jeker
This changes bgpd to only use CLOCK_MONOTONIC via the getmonotime() function. Additionally it changes the export of RIB entries to report the last modified time relative to now. Other places also needed some fixup, like the mrt dump code since the Originated Time field in those messages is epoch ba

piixpm(4) on ATI SBx00

2020-01-07 Thread Claudio Jeker
In -current I added support for the additional I2C busses on piixpm(4) now I noticed that on my old AMD system the I2C bus seems to either connect all those 4 busses together (or there is a bug in the driver). I would like to know if people with ATI SBx00 SMBus chips see the same effect as I do. H

Re: piixpm(4) on ATI SBx00

2020-01-07 Thread Claudio Jeker
On Tue, Jan 07, 2020 at 09:27:50AM +0100, Claudio Jeker wrote: > In -current I added support for the additional I2C busses on piixpm(4) > now I noticed that on my old AMD system the I2C bus seems to either > connect all those 4 busses together (or there is a bug in the driver). Looks lik

fix confusion between rtlabel and rtable / rdomain

2020-01-07 Thread Claudio Jeker
rt_ifa_add() and rt_ifa_del() have a major confusion when it comes to rtlabelid (as in labels on a route) vs rtableid (as in routing table id). Because of this 'ifconfig rtlabel XYZ' fails to add route labels to the routing table. The following diff fixes this issue. To test: ifconfig tap1001 rtl

correctly detach rdomain in lo(4) destroy

2020-01-08 Thread Claudio Jeker
In loop_clone_destroy() the routing table is reset too early. The issue is that if_detach does all the route cleanup and so the rdomain should not be changed until if_detach() finished. My previoous diff (fixing the rtlabel confusion) adds a KASSERT() in rt_ifa_del() which triggers because of this

Re: fix confusion between rtlabel and rtable / rdomain

2020-01-08 Thread Claudio Jeker
On Wed, Jan 08, 2020 at 09:27:27AM +0100, Klemens Nanni wrote: > On Wed, Jan 08, 2020 at 08:45:50AM +0100, Claudio Jeker wrote: > > rt_ifa_add() and rt_ifa_del() have a major confusion when it comes to > > rtlabelid (as in labels on a route) vs rtableid (as in routing table id).

bgpd, move peer related functions to rde_peer.c

2020-01-09 Thread Claudio Jeker
This diff just moves some of the code from rde.c to rde_peer.c where it should be. Apart from moving the code peer_down() was modified so that it can be used as callback of peer_foreach(). Also peer_foreach() was changed to just walk the peer list instead of traversing the peer hash table. OK? --

Re: bgpd, move peer related functions to rde_peer.c

2020-01-09 Thread Claudio Jeker
On Thu, Jan 09, 2020 at 09:42:39AM +0100, Claudio Jeker wrote: > This diff just moves some of the code from rde.c to rde_peer.c where it > should be. Apart from moving the code peer_down() was modified so that it > can be used as callback of peer_foreach(). Also peer_foreach() was cha

bgpd, remove getifaddrs call in RDE

2020-01-09 Thread Claudio Jeker
The RDE needs to know the local v4 and v6 address of a session so that nexthop self works. Until now the lookup for the other AF address was done in the RDE when the session got established. This diff moves this code over to the SE where it fits better. Especially this allows to remove the route pl

bgpd sofreconfigure and export default

2020-01-09 Thread Claudio Jeker
When using 'export default-route' you still need an output filter to allow the default route out. I'm probably not the only one forgetting this fact from time to time. Now to make things worse adding the filter rule to allow the route plus config reload does not work since the softreconfigure code

small bgpd performance improvement

2020-01-09 Thread Claudio Jeker
The path_hash function is called reasonably often. Calling SipHash24_Update() over and over for small data is not optimal. Inspired by /sys/sys/proc.h add a aspath_hashstart and aspath_hashend to the struct rde_aspath and use that for the hash. -- :wq Claudio Index: rde.h ===

Re: dwiic(4) improvements

2020-01-10 Thread Claudio Jeker
On Sun, Dec 22, 2019 at 04:55:59PM +0100, Mark Kettenis wrote: > The diff below contains a couple of improvements to dwiic(4). They're > mostly for making ipmi(4) on the Ampere/Lenovo arm64 boxes work > better. But they need testing on x86 machines with > keyboards.touchpads/touchscreens connecte

Re: pcmcia(4): malo(4): tsleep(9) -> tsleep_nsec(9)

2020-01-10 Thread Claudio Jeker
On Fri, Jan 10, 2020 at 08:33:43PM -0600, Scott Cheloha wrote: > This sleep has no unit, though most architectures are 100hz. > > Is it fair to assume 500 ticks -> 5 seconds and move on? I think this is actually an error and should be 500ms, I doubt it takes more than a second for a command to co

Re: dwiic(4) improvements

2020-01-11 Thread Claudio Jeker
On Sat, Jan 11, 2020 at 12:46:17PM +0100, Mark Kettenis wrote: > > Date: Fri, 10 Jan 2020 12:07:51 +0100 > > From: Claudio Jeker > > > > On Sun, Dec 22, 2019 at 04:55:59PM +0100, Mark Kettenis wrote: > > > The diff below contains a couple of improvements to dw

Re: ospf(6)d.conf: define interface parameters per area or globally

2020-01-12 Thread Claudio Jeker
On Sun, Jan 12, 2020 at 03:46:15PM +0100, Remi Locherer wrote: > On Wed, Jan 08, 2020 at 01:13:45PM +0100, Denis Fondras wrote: > > On Wed, Jan 08, 2020 at 09:14:48AM +0100, Remi Locherer wrote: > > > > I have a diff to allow parameters after interface or area definition. > > > > Not sure if we wan

Re: umb(4) WIP diff and questions

2020-01-14 Thread Claudio Jeker
On Tue, Jan 14, 2020 at 02:40:45PM +0100, Stefan Sperling wrote: > On Tue, Jan 14, 2020 at 09:51:05PM +0900, leeb wrote: > > Hello again tech@ > > > > I've included diffs of what I've got so far at the bottom > > of this mail, but first a couple of questions: > > > > - Using the full 510-charact

Re: carp: send only IPv4 carp packets on dual stack interface

2020-01-18 Thread Claudio Jeker
On Sat, Jan 18, 2020 at 01:45:18PM +, Stuart Henderson wrote: > On 2020/01/18 06:18, chr...@openbsd.org wrote: > > Anyway, my main concern indeed is the broadcast noise generated by carp and > > I would be equally happy if we had a ``carppeer6`` option. Would that be > > considered? > > Adding

Re: piixpm(4) on ATI SBx00

2020-01-20 Thread Claudio Jeker
On Tue, Jan 07, 2020 at 12:44:59PM +0100, Claudio Jeker wrote: > On Tue, Jan 07, 2020 at 09:27:50AM +0100, Claudio Jeker wrote: > > In -current I added support for the additional I2C busses on piixpm(4) > > now I noticed that on my old AMD system the I2C bus seems to either > >

Re: bgpd, remove getifaddrs call in RDE

2020-01-20 Thread Claudio Jeker
On Thu, Jan 09, 2020 at 02:45:46PM +0100, Claudio Jeker wrote: > The RDE needs to know the local v4 and v6 address of a session so that > nexthop self works. Until now the lookup for the other AF address was done > in the RDE when the session got established. This diff moves this code

bgpctl show neighbor errors better

2020-01-21 Thread Claudio Jeker
So the 'Last error:' message for sessions that failed do often not include the suberror and also it is only shown for NOTIFICATIONS we sent but not for received notifications. The following diff fixes this. So instead of: Last error: Cease or Last error: unknown error code I now get: Last e

Re: ospf6d: simplify lsa_snap()

2020-01-21 Thread Claudio Jeker
On Tue, Jan 21, 2020 at 03:58:58PM +0100, Remi Locherer wrote: > On Tue, Jan 21, 2020 at 01:09:30PM +0100, Denis Fondras wrote: > > On Tue, Jan 21, 2020 at 09:35:06AM +0100, Remi Locherer wrote: > > > > @@ -235,6 +233,7 @@ lsa_check(struct rde_nbr *nbr, struct ls > > > > case LSA_TYPE_NETWO

bgpd max-prefix out limit

2020-01-21 Thread Claudio Jeker
This diff implements 'max-prefix NUM out' which is a simple way to avoid leaking full tables to upstream or peers. If the limit is triggered the session will be closed with a NOTIFICATION (kind of suicide for the good of the Internet). In bgpctl the counters are visible in the 'bgpctl show nei' ou

Re: semicolon reduction

2020-01-21 Thread Claudio Jeker
On Wed, Jan 22, 2020 at 01:05:31AM -0500, Ted Unangst wrote: > don't need semicolon after } in statements. OK claudio@ > > Index: ifconfig/brconfig.c > === > RCS file: /home/cvs/src/sbin/ifconfig/brconfig.c,v > retrieving revision 1

Re: umb(4) WIP diff and questions

2020-01-22 Thread Claudio Jeker
On Thu, Jan 23, 2020 at 10:48:06AM +0900, Lee B wrote: > On Tue Jan 14, 2020 at 5:59 PM, Claudio Jeker wrote: > > > > Since the credentials should not be passed back to userland I would not > > add them to struct umb_parameter but instead to struct umb_softc. > > Then y

fix possible nexthop list corruption in bgpd

2020-01-24 Thread Claudio Jeker
Adam Thompson reported a bgpd crash he sees in 6.6. Using kern.nosuidcoredump=3 he was able to get me a back trace of the crash. The RDE chokes on the TAILQ_REMOVE in nexthop_runner() which indicates that the nexthop_runners list gets corrupted. After staring at the code for a while I realized that

Re: PT_ATTACH wait(2) and reparent

2020-02-11 Thread Claudio Jeker
On Tue, Feb 11, 2020 at 02:03:40PM +0100, Martin Pieuchot wrote: > On 06/02/20(Thu) 12:08, Martin Pieuchot wrote: > > As exposed recently via the t_ptrace regression and some make changes an > > exit status might reported twice to its parent via wait(2). > > > > The diff below fixes that by making

Re: piixpm(4) support for AMD FCH watchdog

2020-02-11 Thread Claudio Jeker
On Sat, Feb 08, 2020 at 01:07:01PM +0800, Nathanael Rensen wrote: > The diff below adds support for the watchdog as found in the embedded > AMD FCH (fusion controller hub) as found on APU2. > > Index: sys/dev/pci/piixpm.c > === > RCS

Re: [PATCH] pledge: allow kern.somaxconn sysctl for inet

2020-02-11 Thread Claudio Jeker
On Mon, Feb 03, 2020 at 12:52:05AM +, Jimmy Brush wrote: > No golang tcp server can be pledged without this change because it > queries kern.somaxconn before it listens on a tcp socket[1][2][3]. > > I cannot think of any advantage this change would give an attacker > who has compromised a pled

Re: em(4) reset I210 wake status

2020-02-11 Thread Claudio Jeker
On Wed, Feb 05, 2020 at 10:32:09PM +0800, Nathanael Rensen wrote: > When I boot an APU2 using wake-on-lan and then attempt to power off with > shutdown -hp it wakes itself up again. To prevent this it is necessary to > clear the I210 PME_STATUS flag. This is described in section 5.6.2 of the > I210

Re: remove needless #ifdef

2020-02-13 Thread Claudio Jeker
On Thu, Feb 13, 2020 at 11:50:46PM +0100, Jan Stary wrote: > On Feb 10 09:28:38, yasu...@openbsd.org wrote: > > Hi, > > > > On Sun, 09 Feb 2020 19:28:50 +0100 > > Jeremie Courreges-Anglas wrote: > > > On Sun, Feb 09 2020, Jan Stary wrote: > > >> Currently, sys/net/pipex_local.h asks #ifdef __Ope

minor bgpd cleanup

2020-02-14 Thread Claudio Jeker
Move and rename copy_filterset to rde_filter.c as filterset_copy. This way it matches the other filterset_* functions. OK? -- :wq Claudio Index: bgpd.h === RCS file: /cvs/src/usr.sbin/bgpd/bgpd.h,v retrieving revision 1.400 diff -u

Adjust some DLT_IEEE802_11_RADIO bpf taps

2020-02-17 Thread Claudio Jeker
As already done on iwm(4) and one of the athn(4), there is no need to pass the radio tap structure to bpf_mtap by faking up an mbuf. The code can just use bpf_mtap_hdr() (which does a similar dance but with far less memory on the stack). There are many other wifi driver that do the same thing so I

Re: IPv6 Support for umb(4)

2020-02-17 Thread Claudio Jeker
On Tue, Feb 04, 2020 at 09:16:34AM +0100, Gerhard Roth wrote: > Hi Alex, > > thanks for looking into it. > > > On Tue, 4 Feb 2020 00:20:42 +0100 Alexander Bluhm > wrote: > > On Tue, Jan 28, 2020 at 03:03:47PM +0100, Gerhard Roth wrote: > > > this patch adds IPv6 support to umb(4). > > > > I

Re: pppx(4): rwsleep(9) -> rwsleep_nsec(9)

2020-02-17 Thread Claudio Jeker
On Mon, Feb 17, 2020 at 06:35:38PM -0600, Scott Cheloha wrote: > Infinite sleep, trivial. > > ok? OK claudio@ > Index: net/if_pppx.c > === > RCS file: /cvs/src/sys/net/if_pppx.c,v > retrieving revision 1.74 > diff -u -p -r1.74 if_p

Re: IPv6 Support for umb(4)

2020-02-17 Thread Claudio Jeker
eople play with it. > > On Mon, 17 Feb 2020 17:30:03 +0100 Claudio Jeker > wrote: > > On Tue, Feb 04, 2020 at 09:16:34AM +0100, Gerhard Roth wrote: > > > Hi Alex, > > > > > > thanks for looking into it. > > > > > > > > > On Tue, 4 F

Re: IPv6 Support for umb(4)

2020-02-18 Thread Claudio Jeker
On Tue, Feb 18, 2020 at 11:16:54PM +, Stuart Henderson wrote: > On 2020/02/18 13:40, Gerhard Roth wrote: > > > > Yes, I tried MBIM_CONTEXT_IPTYPE_IPV4ANDV6 myself first but to no > > > > avail. The switched to MBIM_CONTEXT_IPTYPE_IPV4V6 and everything > > > > was fine. > > > > > > Obviously

Re: vfs cache diff, that needs some testing.

2009-06-11 Thread Claudio Jeker
On Fri, Jun 12, 2009 at 07:51:48AM +0200, Otto Moerbeek wrote: > On Thu, Jun 11, 2009 at 03:51:12PM -0600, Bob Beck wrote: > > > > > I could use some assistance in testing this, particularly on some of > > the more odd archetectures. > > > > This diff makes a bunch of changes to the vfs

Re: more of em(4) support for iCH10 chip

2009-06-24 Thread Claudio Jeker
On Wed, Jun 24, 2009 at 04:28:10PM +0200, Dariusz Swiderski wrote: > On Wed, 24 Jun 2009, Dariusz Swiderski wrote: > > > On Jun 24, 2009, at 2:30 AM, Brad wrote: > > > > > On Fri, Jun 19, 2009 at 09:06:34PM -, sfi...@kefir.sfires.net wrote: > > > > hi, > > > > > > > > following diff brings s

ppp(8) cleanup/fix

2009-06-30 Thread Claudio Jeker
So ppp(8) did insane routing message handling in its sysctl handlers. The worst thing about them are that their actually not needed and better replaced with libc functions (getifaddrs and if_nametoindex). This diff is not haevily tested (my last ppp usage is years ago) so I'm hopeing people with p

bgpctl show next try 2

2009-07-22 Thread Claudio Jeker
So here is another try and I guess some people will not like it. BGP unlike other routing protocols needs to find the true nexthop because the passed IP in the NEXT_HOP attribute can be more then one hop away. So bgpd uses the fib (as stored in the parent) to figure out the gateway for a nexthop. I

Re: bgpctl show next try 2

2009-07-23 Thread Claudio Jeker
On Wed, Jul 22, 2009 at 04:37:03PM +0200, Henning Brauer wrote: > this still removes the interface info I want to see. > > why do you keep ignoring the advice of replaceing the long > valid/invalid words by some kind of marker like we do in the RIB? > > $ bgpctl sh ri as 24640 > flags: * = Vali

Re: bgpctl show next try 2

2009-07-23 Thread Claudio Jeker
On Thu, Jul 23, 2009 at 02:39:02PM +0100, Stuart Henderson wrote: > On 2009/07/23 14:46, Claudio Jeker wrote: > > On Wed, Jul 22, 2009 at 04:37:03PM +0200, Henning Brauer wrote: > > > this still removes the interface info I want to see. > > > > > > wh

Re: No More Multi Routing Table on 4.6-current?

2009-07-25 Thread Claudio Jeker
On Sat, Jul 25, 2009 at 10:54:55AM +0100, Stuart Henderson wrote: > (moved from misc to tech) > > On 2009-07-07, Insan Praja SW wrote: > > After updating to i386 4.6-current, my multirouting tables is no longer > > working. I wonder if this because of the new rodomain thingy.. which is > > cool.

Re: [PATCH] RFC: Changes to tcpbench.

2009-08-05 Thread Claudio Jeker
On Sat, Aug 01, 2009 at 07:33:00PM -0300, Christiano Farina Haesbaert wrote: > Hi there, > > Here is a much better diff proposal than my previous one. > > - Don't fork use poll instead. > > - Collect usefull overall statistics, as % bandwith being used by each > connection, total and average rat

Re: [PATCH] RFC: Changes to tcpbench.

2009-08-10 Thread Claudio Jeker
On Sat, Aug 08, 2009 at 05:08:45PM -0300, Christiano Farina Haesbaert wrote: > I've discovered that my patch reads the wrong tcp table entry, as soon > as I fix this I'll mail the final patch. > I had to add rdomain support to tcpbench so that I can use it in my test setup. Diff is attached, I ho

<    11   12   13   14   15   16   17   18   19   20   >