Le Tue, Oct 17, 2023 at 10:14:25PM +0100, Chris Narkiewicz a écrit :
> Hi,
>
> Tomohiro Kusumi is currently working on HAMMER2 implementation
> for OpenBSD, FreeBSD and NetBSD.
>
> The repository is here:
> https://github.com/kusumi/openbsd_hammer2
>
>
> He maintains repositories for NetBSD, Fr
Allow detection of AMD EPYC Embedded 3000 10Gig NIC.
OK ?
Index: dev/pci/pcidevs
===
RCS file: /cvs/src/sys/dev/pci/pcidevs,v
retrieving revision 1.2036
diff -u -p -r1.2036 pcidevs
--- dev/pci/pcidevs 12 May 2023 11:42:22 -
Le Tue, Apr 18, 2023 at 02:43:26PM +0200, Theo Buehler a écrit :
> On Tue, Apr 18, 2023 at 02:06:46PM +0200, Claudio Jeker wrote:
> > This and the others are IIRC streight from pfctl. So if someone wants a
> > free commit :)
>
> How about this. pfctl and bgpd are the same, except that the bgpd on
Hello,
It looks to me that unmap_1 and unmap_2 in bnxt_attach() are reversed.
When pci_mapreg_map() is called for sc_db_* and fails we unmap
sc_db_* when we should unmap previous pci_mapreg_map() call for sc_hwrm_*.
Index: if_bnxt.c
Le Wed, Oct 19, 2022 at 08:36:46AM +0200, Martijn van Duren a écrit :
> As pointed out by Alec on misc@, there's a discrepancy between the
> name and description of several objects inside the pfIfTable.
>
> Looks like a simple copy-paste error.
>
> OK?
>
OK denis@
> martijn@
>
> Index: OPENBS
Le Mon, Oct 17, 2022 at 01:02:01PM +0200, Claudio Jeker a écrit :
>
> Also I'm not sure if bgpd_peer_up_seconds and bgpd_peer_down_seconds are
> sensible metrics. Having metric depend on some state seems like a bad idea.
>
I agree. My current tool presents only one metric for uptime and I get a
Le Mon, Oct 17, 2022 at 11:49:31AM +0200, Claudio Jeker a écrit :
> On Wed, Oct 12, 2022 at 12:12:25PM +0200, Theo Buehler wrote:
> > On Fri, Oct 07, 2022 at 12:37:10PM +0200, Claudio Jeker wrote:
>
> > > +void
> > > +ometric_set_state(struct ometric *om, const char *state, struct olabels
> > > *
Le Tue, Aug 23, 2022 at 06:28:12PM +0200, Claudio Jeker a écrit :
> I noticed that the "connection from non-peer" message can fill the log and
> be so chatty that it is hard to see the other messages. The system I see
> this on is a bit special since it gets hammered by incorrectly configured
> sys
Le Wed, Jul 06, 2022 at 10:45:39PM +0200, Mark Kettenis a écrit :
> Now that the kernel supports the extended BOOTARG_CONSDEV struct and
> snaps with that change are out there, here is the diff that changes
> the amd64 bootloaders to switch to the extended struct and provide the
> parameters necess
Le Mon, May 02, 2022 at 01:40:37PM +0100, Jason McIntyre a écrit :
> On Mon, May 02, 2022 at 11:48:49AM +0200, Denis Fondras wrote:
> > Le Mon, Apr 04, 2022 at 01:02:53PM +0200, Denis Fondras a ?crit :
> > > Le Mon, Apr 04, 2022 at 08:23:35PM +1000, Da
Le Mon, Apr 04, 2022 at 01:02:53PM +0200, Denis Fondras a écrit :
> Le Mon, Apr 04, 2022 at 08:23:35PM +1000, David Gwynne a écrit :
> >
> >
> > > On 3 Apr 2022, at 21:46, Denis Fondras wrote:
> > >
> > > Hi,
> > >
> > >
VXLANMTU appears nowhere else in the codebase.
OK to remove it ?
Index: if_vxlan.c
===
RCS file: /cvs/src/sys/net/if_vxlan.c,v
retrieving revision 1.90
diff -u -p -r1.90 if_vxlan.c
--- if_vxlan.c 26 Feb 2022 04:46:34 - 1.9
Le Tue, Mar 22, 2022 at 02:57:31PM +0100, Alexander Bluhm a écrit :
> anyone?
>
It looks OK denis@
> On Fri, Mar 04, 2022 at 12:09:03PM +0100, Alexander Bluhm wrote:
> > Hi,
> >
> > syzkaller has found this race in arp.
> >
> > https://syzkaller.appspot.com/bug?id=e3dc94533ddee95b6d69c2e704936
This is a recurring complaint so better document it.
Denis
Index: route.8
===
RCS file: /cvs/src/sbin/route/route.8,v
retrieving revision 1.102
diff -u -p -r1.102 route.8
--- route.8 26 Oct 2021 15:48:25 - 1.102
+++ rout
Le Tue, Mar 15, 2022 at 04:03:20PM +0100, Claudio Jeker a écrit :
> Currently EoR markers use a full byte in struct prefix what can be done in
> a bit. Use the last flags field so that that 1 byte is available again.
> I already have a need for that byte this is why I came up with this
> change.
>
Le Mon, Jan 17, 2022 at 02:25:27PM +, Stuart Henderson a écrit :
> On 2022/01/17 14:54, Christian Weisgerber wrote:
> > usr.sbin/ospf6d: fix -Wunused-but-set-variable warnings
> >
> > merge_config() sets "rchange", but doesn't use it. Comparing the
> > code to osfpd/ospfd.c makes me think tha
Hi
When static routes are redistributed with bgpd(8), they are not removed when the
interface used by the static is destroyed.
When an interface is destroyed the routes using this interface are flagged with
RTP_DOWN, this means kroute(6)_find() is not able to find them (inserted with
RTP_STATIC a
Le Sat, Jan 01, 2022 at 11:38:14AM +0100, Florian Obser a écrit :
> ping
> On 2021-12-27 17:01 +01, Florian Obser wrote:
> > Prefix life time is independent from router life time.
> > Form an IPv6 address even if the router announcing the prefix isn't a
> > default router.
> > Problem reported by
Le Sat, Dec 18, 2021 at 10:02:32AM +0100, Florian Obser a écrit :
> On 2021-12-17 22:12 +01, Denis Fondras wrote:
> > Here is an attempt to fix ping(8) and traceroute(8) source selection.
> >
> > Currently these tools do not obey route sourceaddr set by the operator. This
>
Here is an attempt to fix ping(8) and traceroute(8) source selection.
Currently these tools do not obey route sourceaddr set by the operator. This
leads to frustration at best and erroneous diagnosis at worse on multi-homed
systems.
The "real" fix would be to rework source selection in the kernel
Raw sockets do not comply with route sourceaddr.
Use set address if source is not set by the caller.
Index: netinet/ip_output.c
===
RCS file: /cvs/src/sys/netinet/ip_output.c,v
retrieving revision 1.377
diff -u -p -r1.377 ip_output.c
Le Sun, Dec 12, 2021 at 04:05:39PM +0100, Claudio Jeker a écrit :
> I did not do this because it is not supposed to be the same as the human
> ouutput.
>
Oh, that's fine then :)
Le Sun, Dec 12, 2021 at 01:43:06PM +, Stuart Henderson a écrit :
> On 2021/12/12 14:13, Denis Fondras wrote:
> > Number of received prefixes appear in `bgpctl sh` but not in `bgpctl -j sh`.
> >
> > Here is a diff to add this piece of information.
> >
> &
Number of received prefixes appear in `bgpctl sh` but not in `bgpctl -j sh`.
Here is a diff to add this piece of information.
OK ?
Index: output_json.c
===
RCS file: /cvs/src/usr.sbin/bgpctl/output_json.c,v
retrieving revision 1.12
Le Tue, Nov 09, 2021 at 07:44:41PM +0100, Claudio Jeker a écrit :
> ip_addr_print() can be simplified. ip4_addr2str() and ip6_addr2str() are
> the same apart from the different AF argument to inet_ntop(). Just collaps
> all into ip_addr_print().
>
OK denis@
> --
> :wq Claudio
>
> Index: ip.c
>
Document commands used to send VM IP to Xen host.
Index: xen.4
===
RCS file: /cvs/src/share/man/man4/xen.4,v
retrieving revision 1.2
diff -u -p -r1.2 xen.4
--- xen.4 21 Jul 2017 18:27:32 - 1.2
+++ xen.4 21 Oct 202
While testing OpenBSD with XCP-ng (https://xcp-ng.org/), I noticed changing the
virtual interface state (connecting/disconnecting) was leading to a panic.
The following diff fixes the problem on my test host.
(this is kind of "backported" from OpenBSD 6.1...)
If you are using OpenBSD on a Xen-bas
Le Sat, Sep 04, 2021 at 09:57:10PM +0100, Jason McIntyre a écrit :
> the diff looks ok to me. but run any doc changes through "mandoc
> -Tlint", and look at any issues your diff may have introduced. in this
> case it's just trailing whitespace, but it's super helpful to check your
> work.
>
Thank
Le Thu, Sep 02, 2021 at 08:36:06AM -0600, Theo de Raadt a écrit :
> I think the following approach will work.
>
> 1. changes from tcpdump.8 -r1.00 to -rHEAD need merging into pcap-filter.5
>
Here is a diff for this step.
I have one question though.
tcpdump.8 has :
" tcpdump does not currently
Le Thu, Sep 02, 2021 at 07:49:25AM +0100, Jason McIntyre a écrit :
> why not just paste in the body of pcap-filter in then and we can try and
> keep them in sync thereafter?
>
OK, I will do that. I am not confident it will stay in sync over time :D
Le Wed, Sep 01, 2021 at 06:42:54PM +0100, Jason McIntyre a écrit :
> On Wed, Sep 01, 2021 at 06:15:04PM +0200, Denis Fondras wrote:
> > I was searching for the sampling command of tcpdump but could not find it
> > in the
> > manual. In fact it is missing some primitives co
I was searching for the sampling command of tcpdump but could not find it in the
manual. In fact it is missing some primitives compared to pcap-filter manual.
Index: tcpdump.8
===
RCS file: /cvs/src/usr.sbin/tcpdump/tcpdump.8,v
retrie
Le Mon, May 03, 2021 at 03:01:13PM +0200, Claudio Jeker a écrit :
> The RTR connect code calls addr2sa() as an argument to connect() but also
> uses the len argument in both calls. It seems in some cases this is
> optimised the wrong way. I think it is better to write this code using two
> steps li
The 16-bit total count of sectors is set by newfs_msdos(8) when the number of
sectors is less than MAXU16 even if asked to format in FAT32.
This diff fixes that according to the FAT32 spec : "For FAT32 volumes, this
field [BPB_TotSec16] must be 0"
OK ?
Index: newfs_msdos.c
==
Le Mon, Apr 26, 2021 at 04:21:16PM +0200, Claudio Jeker a écrit :
> The bgpctl show neighbor output is a bit missleading for capabilities.
> It currently shows the capabilities sent by the neighbor and not the ones
> that then got selected for the session. This matters especially for the
> multipro
If partition is smaller than 32MB, mount_msdos(8) will yield "not an MSDOS
filesystem".
pmp->pm_Sectors is set by newfs_msdos(8) when the number of sectors is less
than MAXU16 even if asked to format in FAT32.
I choosed to fix mounting instead of formatting (newfs_msdos.c frightens me...)
FreeBS
Le Mon, Feb 01, 2021 at 01:49:09PM +0100, Alexandr Nedvedicky a écrit :
> Hello Denis,
>
> I think we need to refresh expected value in 'flags'
> with every loop iteration. does diff below help?
>
Thank you but it does not help. Same panic and also same panic if I test with
loop++ > 10.
If
I am using XCP-ng with the latest OpenBSD snapshot.
Whenever I make an hardware change in networking on the VM (connect or
disconnect an interface, change associated network), the VM panics :
openbsd# panic: grant table reference 5912 is held by domain 0: frame 0x1f1a4
flags 0x19
Stopped at db
Le Sat, Jan 09, 2021 at 06:50:50PM +0100, Denis Fondras a écrit :
> This diff place the user-set source address outside of struct art_root and
> make
> the code more readable (to me).
>
> Based on a concept by mpi@
>
ping.
Le Thu, Jan 14, 2021 at 02:20:26PM +0100, Claudio Jeker a écrit :
> The aspath_neighbor function returns the first AS of a path. Now if the
> first element is an AS_SET then this does not really make sense.
> RFC4271 has this bit in section 9.1.2.2
>
> Similarly, neighborAS(n) is a functi
Le Tue, Jan 12, 2021 at 10:06:46AM +0100, Claudio Jeker a écrit :
> On Tue, Jan 05, 2021 at 11:17:22AM +0100, Claudio Jeker wrote:
> > While changing log_addr() I noticed that struct bgpd_addr could benefit
> > from changing the encoding of AID_VPN_IPv4 and AID_VPN_IPv6 addrs.
> > Instead of having
Le Tue, Jan 12, 2021 at 05:39:02PM +0100, Claudio Jeker a écrit :
> This diff changes two things:
> - First, it move the kroute update into rde_generate_updates() simplifying
> prefix_evaluate a little bit.
>
> - Second, it changes prefix_evaluate to take an additional argument for the
> old prefi
This diff place the user-set source address outside of struct art_root and make
the code more readable (to me).
Based on a concept by mpi@
Index: net/art.h
===
RCS file: /cvs/src/sys/net/art.h,v
retrieving revision 1.20
diff -u -p -r
Le Thu, Jan 07, 2021 at 12:03:54PM +0100, Hiltjo Posthuma a écrit :
> Hi Denis,
>
> I like this feature. For example it would be useful for using relayd as a
> reverse-proxy to forward it to an internal network running a httpd with some
> service. Then the path can be stripped without having to to
Le Mon, Jan 04, 2021 at 05:04:51PM +0100, Claudio Jeker a écrit :
> bgpd will get a new process for RTR handling. Because of this it makes
> sense to cleanup the startup code a bit and not use flags to indicate
> which process to run but instead use the enum bgpd_process.
> Additionally change the
Le Fri, Dec 11, 2020 at 10:53:56AM +, Olivier Cherrier a écrit :
>
> Hello tech@,
>
> Is there any interest for this feature to be commited?
> I find it very useful. Thank you Denis!
>
Here is an up to date diff, looking for OKs.
Index: parse.y
===
Le Tue, Dec 29, 2020 at 12:36:22PM -0700, Todd C. Miller a écrit :
> On Sat, 26 Dec 2020 15:07:36 -0700, "Theo de Raadt" wrote:
>
> > Well in that case this should still be a multistep process.
> >
> > Add STAILQ
> >
> > Convert things, including everything in ports
> >
> > No diff should change a
Le Sat, Dec 26, 2020 at 06:55:09PM +0100, Mark Kettenis a écrit :
> > Date: Sat, 26 Dec 2020 18:39:36 +0100
> > From: Denis Fondras
> >
> > Le Sat, Dec 26, 2020 at 06:23:41PM +0100, Mark Kettenis a écrit :
> > > > > This diff renames SIMPLEQ_* t
Le Sat, Dec 26, 2020 at 06:23:41PM +0100, Mark Kettenis a écrit :
> > > This diff renames SIMPLEQ_* to STAILQ_* in /usr/src/sys/sys to unify with
> > > FreeBSD and Linux.
> > >
> > > I added aliases at the end of queue.h to avoid breaking base too much.
> > > they will
> > > be removed as soon a
Rename SIMPLEQ_* to STAILQ_* in /usr/src/usr.bin
Index: ctfconv/dw.c
===
RCS file: /cvs/src/usr.bin/ctfconv/dw.c,v
retrieving revision 1.4
diff -u -p -r1.4 dw.c
--- ctfconv/dw.c27 Sep 2017 08:59:38 - 1.4
+++ ctfconv/d
Rename SIMPLEQ_* to STAILQ_* in /usr/src/usr.sbin
Index: bgpd/bgpd.c
===
RCS file: /cvs/src/usr.sbin/bgpd/bgpd.c,v
retrieving revision 1.230
diff -u -p -r1.230 bgpd.c
--- bgpd/bgpd.c 5 Nov 2020 11:52:59 - 1.230
+++ bgpd/bgpd
Rename SIMPLEQ_* to STAILQ_* in /usr/src/share and /usr/src/regress
Index: regress/usr.sbin/bgpd/unittests/rde_sets_test.c
===
RCS file: /cvs/src/regress/usr.sbin/bgpd/unittests/rde_sets_test.c,v
retrieving revision 1.7
diff -u -p -r1
Rename SIMPLEQ_* to STAILQ_* in /usr/src/sbin
Index: iked/iked.h
===
RCS file: /cvs/src/sbin/iked/iked.h,v
retrieving revision 1.179
diff -u -p -r1.179 iked.h
--- iked/iked.h 21 Dec 2020 22:49:36 - 1.179
+++ iked/iked.h 25 De
Rename SIMPLEQ_ to STAILQ_ in /usr/src/lib
Index: libc/gen/posix_spawn.c
===
RCS file: /cvs/src/lib/libc/gen/posix_spawn.c,v
retrieving revision 1.10
diff -u -p -r1.10 posix_spawn.c
--- libc/gen/posix_spawn.c 28 Jun 2019 13:32:41
mpi@ reminded me I had this diff cooking.
This diff renames SIMPLEQ_* to STAILQ_* in /usr/src/sys/sys to unify with
FreeBSD and Linux.
I added aliases at the end of queue.h to avoid breaking base too much. they will
be removed as soon as diff 2,3,4,5,6,7 are commited.
net/sniproxy has a patch t
On Wed, Nov 11, 2020 at 05:25:25AM -0300, Martin Pieuchot wrote:
> While discussing the new source address mechanism with denis@, I figured
> those ought to be documented.
>
> Note that `ar_rtableid' is unused and can die. The ART code is actually
> free from any network knowledge.
>
> ok?
>
i
ICMP error replies are sent from the IP of the interface the packet came in even
when the source IP was forced with route(8).
Index: netinet/ip_icmp.c
===
RCS file: /cvs/src/sys/netinet/ip_icmp.c,v
retrieving revision 1.183
diff -u -p
Hi,
route(8) sourceaddr is not used with p2p interfaces.
My initial fear was about tunnel interfaces but after some more testing, there
is no need to be so.
Here is the diff:
Index: sbin/route/route.8
===
RCS file: /cvs/src/sbin/rou
On Fri, Oct 30, 2020 at 09:53:08AM +0100, Martijn van Duren wrote:
> I think metrics is a better word than statistics and it might help
> people if they knew where to query for these metrics.
>
> OK?
I also find it more accurate.
OK denis@
> martijn@
>
> Index: relayd.conf.5
> =
On Thu, Oct 29, 2020 at 03:51:24PM +0100, Martijn van Duren wrote:
> 6.8 is out in the wild. I guess this is as good a time as any to remove
> the old snmp keyword.
>
> OK?
>
OK denis@
And while it is fresh, is this the right time to update plus.html and
current.html ?
On Tue, Oct 27, 2020 at 12:02:18PM +0100, Matthias Pressfreund wrote:
> True. Updated patch below.
>
Thanks, I have been using the diff (from your GH account) since a few weeks.
OK denis@
I will commit tonight if nobody stands against.
>
>
> Index: usr.sbin/httpd/httpd.conf.5
>
Thanks Matthias,
comment below.
On Tue, Oct 27, 2020 at 08:37:39AM +0100, Matthias Pressfreund wrote:
> Index: usr.sbin/httpd/httpd.conf.5
> ===
> RCS file: /cvs/src/usr.sbin/httpd/httpd.conf.5,v
> retrieving revision 1.113
> diff -u
With this config :
---
relay "proxy" {
listen on {{publicip}} port 443 tls
protocol "httpproxy"
forward with tls to port 443
forward to port 10100
}
---
relayd(8) will currently use TLS for all backends.
This diff will use TLS only if 'with tls' is used. In the example above, relayd
w
On Mon, Oct 26, 2020 at 09:28:54AM +0100, m...@fn.de wrote:
> Ping. Latest diff below.
>
OK denis@
I will commit tonight if nobody stands against.
Thank you.
> Index: usr.sbin/httpd/parse.y
> ===
> RCS file: /cvs/src/usr.sbin/httpd
Previous one had a typo... :/
On Sat, Oct 24, 2020 at 08:01:36PM +0200, Hiltjo Posthuma wrote:
> Thanks for working on this. I haven't tested the patch yet except compiling,
> but this feature would be very nice to have imho.
>
> I find the current "path replace" syntax confusing and it doesn't
On Sat, Oct 24, 2020 at 08:01:36PM +0200, Hiltjo Posthuma wrote:
> Thanks for working on this. I haven't tested the patch yet except compiling,
> but this feature would be very nice to have imho.
>
> I find the current "path replace" syntax confusing and it doesn't work for
> this
> use-case.
>
The 'strip' directive from httpd(8) is useful when forwarding to another server.
This diff adds the feature to relayd(8).
With :
match request path "/server/*" tag psonoserver
match request tagged psonoserver path strip 1
match request tagged psonoserver forward to
https://psono
On Sun, Oct 18, 2020 at 02:04:31PM +1000, David Gwynne wrote:
> or is there a way i can do this without a diff already?
>
I am also curious...
> thoughts?
>
The diff works as advertise.
Is anyone interested in this ?
This diff allows to select the default source IP address (for TCP/UDP
connections) on multi-homed & "multi-addressed" machines.
Looking for feedbacks on what I broke.
Do not test with ping(8) as it uses another source address selection codepath.
`curl ifconfig.co` i
On Thu, Oct 08, 2020 at 05:32:15AM -0600, Todd C. Miller wrote:
> We can use find's built-in -delete primary to remove old /tmp files
> and directories. This is somewhat less error-prone than execing
> rm or rmdir.
>
OK denis@
> - todd
>
> Index: etc/daily
> ==
On Wed, Oct 07, 2020 at 01:01:29PM +0200, Claudio Jeker wrote:
> On Wed, Oct 07, 2020 at 12:27:04PM +0200, Denis Fondras wrote:
> > All tunnels & point-to-point addresses are separated by "->" but inet.
> >
> > Before :
> > gre0: flags=8051 mtu
All tunnels & point-to-point addresses are separated by "->" but inet.
Before :
gre0: flags=8051 mtu 1476
index 6 priority 0 llprio 6
encap: vnetid none txprio payload rxprio packet
groups: gre
tunnel: inet 192.0.2.1 -> 198.51.100.1 ttl 64 nodf ecn
inet 172.
On Fri, Oct 02, 2020 at 02:01:09AM +0200, Jan Klemkow wrote:
> Hi,
>
> The new intra area db entry has to be saved into the tree before
> orig_intra_area_prefix_lsas() is called. If not, the ospf6d will not
> announce the new intra area db for a newly learned link from another
> ospf router of th
This updated diff unbreak P2P links where local address was not the same as
preferred source address.
Sending to tech@ may help get more feedback on what I broke.
Example usage :
Set 2001:db8::1 as source : route source 2001:db8::1
Unset previously set IPv6 address on rdomain 10 : route -T10 sour
All tunnels & point-to-point addresses are separated by "->" but inet.
Denis
Index: ifconfig.c
===
RCS file: /cvs/src/sbin/ifconfig/ifconfig.c,v
retrieving revision 1.426
diff -u -p -r1.426 ifconfig.c
--- ifconfig.c 15 Sep 2020 15:2
All tunnels & point-to-point addresses are separated by "->" but inet.
Denis
Index: ifconfig.c
===
RCS file: /cvs/src/sbin/ifconfig/ifconfig.c,v
retrieving revision 1.426
diff -u -p -r1.426 ifconfig.c
--- ifconfig.c 15 Sep 2020 15:2
This updated diff unbreak P2P links where local address was not the same as
preferred source address.
Sending to tech@ may help get more feedback on what I broke.
Example usage :
Set 2001:db8::1 as source : route source 2001:db8::1
Unset previously set IPv6 address on rdomain 10 : route -T10 sour
I can't see where these two lines are printed.
Index: route.8
===
RCS file: /cvs/src/sbin/route/route.8,v
retrieving revision 1.91
diff -u -p -r1.91 route.8
--- route.8 19 Jan 2020 18:22:31 - 1.91
+++ route.8 10 Sep
On Wed, Sep 09, 2020 at 07:45:32AM +0200, Martijn van Duren wrote:
> On Tue, 2020-09-08 at 19:33 +0200, Denis Fondras wrote:
> > On Sun, Sep 06, 2020 at 10:11:02PM +0200, Martijn van Duren wrote:
> > > Moving towards individual transport mappings, it's becoming more
>
On Sun, Sep 06, 2020 at 10:11:02PM +0200, Martijn van Duren wrote:
> Moving towards individual transport mappings, it's becoming more
> convenient to have the protocol directly after the listen on statement.
> This gives me more flexibility in using mapping-specific APIs, also
> when other transpo
On Sun, Sep 06, 2020 at 06:37:17PM +0200, Martijn van Duren wrote:
> going for another easy picking: snmpe_dispatch_parent is just an empty
> stub. proc.c assigns proc_dispatch_null to p_cb if it's null, which
> effectively does the same thing.
>
> OK?
>
OK denis@
> martijn@
>
> Index: snmpe.
On Mon, Aug 24, 2020 at 06:42:02PM +0200, Florian Obser wrote:
> To clarify, this is independent of my recent work in
> in6_ifawithscope(), -ifa did not work with the old code, either.
>
Of course ! Sorry if my message led to think you were responsible for it.
While working on source selection, I noticed the IPv6 source was not honored
when set from route(8) with -ifa.
After discussing with florian@, here is a proposed change. It chooses the source
address associated with the route (hence honoring -ifa) instead of the first
address of the output interfa
On Tue, Jul 14, 2020 at 02:14:55PM +0100, Stuart Henderson wrote:
> On 2020/07/14 15:03, Denis Fondras wrote:
> > I was upgrading an EdgeRouter and it restarted multiple times instead of
> > booting
> > /bsd
> >
> > When I had a chance to boot it corre
I was upgrading an EdgeRouter and it restarted multiple times instead of booting
/bsd
When I had a chance to boot it correctly, I noticed that sysmerge and fw_update
were run multiple times.
This diff avoids filling rc.firsttime and rc.sysmerge.
Index: distrib/miniroot/install.sub
=
On Fri, Jun 26, 2020 at 02:45:53PM +0200, Stefan Sperling wrote:
> This patch adds support for 11n Tx aggregation to iwm(4).
iwm0 at pci2 dev 0 function 0 "Intel Dual Band Wireless AC 7260" rev
0x73, msi
AP is Zyxel USG40W
Before :
bandwidth min/avg/max/std-dev = 9.800/14.000/14.214/0.606 Mbps
vxlan(4) actually supports IPv6 tunnel endpoints.
Only multicast endpoints are unsupported.
Index: vxlan.4
===
RCS file: /cvs/src/share/man/man4/vxlan.4,v
retrieving revision 1.8
diff -u -p -r1.8 vxlan.4
--- vxlan.4 22 Nov 2018 17
On Fri, Jun 05, 2020 at 12:56:21PM +0200, Prof. Dr. Steffen Wendzel wrote:
> Dear all:
>
> just in case this appears useful to you: I found some redundant code
> lines in the following files.
>
> sys/net/pipex.h:
>struct pipex_session *pipex_pppoe_lookup_session (struct mbuf *);
>struct
This diff provides a working 'ospf6ctl reload'.
Must be applied after https://marc.info/?l=openbsd-tech&m=159084971620177&w=2
Index: ospf6ctl/ospf6ctl.c
===
RCS file: /home/denis/dev/cvs/src/usr.sbin/ospf6ctl/ospf6ctl.c,v
retrieving
This diff updates how ospf6d(8) handles interfaces.
It is now in line with what ospfd(8) does.
Last step before enabling reload.
Tested against Mikrotik and Zebra implementations.
Warning: it changes the default behaviour. No prefix is announced if no
"redistribute" statement is present in confi
On Mon, May 18, 2020 at 12:18:47PM +0200, Martijn van Duren wrote:
> Anyone feeling like trimming a little fat?
>
OK denis@
> On Fri, 2020-05-08 at 11:41 +0200, Martijn van Duren wrote:
> > Diff below removes fields from struct oid used by snmpd but not useful
> > for snmp(1). Minus 503LoC and -
On Mon, May 18, 2020 at 09:04:06AM +0200, Claudio Jeker wrote:
> There is a file missing in the diff.
>
> One thing I have seen in the original diff from Richard was that the
> copyright in the new file should be copied from ospfctl.c since this is
> mostly a copy paste action and not new work.
>
On Fri, May 15, 2020 at 11:34:58AM +0100, Richard Chivers wrote:
> Hi,
>
> I have now resolved the spacing/tabbing issues I think correctly
> following style(9), along with a couple of other indent issues.
>
> Would appreciate a cursory look at this stage to spot any further common
> issues.
>
> This implements a way to add a limit for bgpctl show rib output.
> When a limit is set then the output will include a token (at the end)
> that can be used to get the next batch of output. These two things allow
> to build a frontend that puts the output onto multiple pages.
> Both regular output
This information is never used/checked.
Index: kroute.c
===
RCS file: /cvs/src/usr.sbin/ospf6d/kroute.c,v
retrieving revision 1.63
diff -u -p -r1.63 kroute.c
--- kroute.c16 May 2020 15:54:12 - 1.63
+++ kroute.c16 May
Small diff to fix size printing.
Before :
$ doas scan_ffs -v sd0
block 55167 id 758d4818,f2894c98 size -859043093
After:
$ doas ./obj/scan_ffs -v sd0
block 55167 id 758d4818,f2894c98 size 3435924203
Index: scan_ffs.c
===
RCS file: /
On Thu, May 14, 2020 at 07:15:41PM +0100, Richard Chivers wrote:
> Shall I effectively fix issues in the original code at this stage, or only
> where I have moved and refactored?
>
Thanks. Limit the changes to what is relative to json support. The diff is
already big enough :)
Following https://marc.info/?l=openbsd-tech&m=158946552515632&w=2, when
IMSG_IFADD is removed, IMSG_IFDELETE becomes useless...
Index: kroute.c
===
RCS file: /home/denis/dev/cvs/src/usr.sbin/ospf6d/kroute.c,v
retrieving revision 1.62
On Thu, May 14, 2020 at 05:51:58PM +0100, Richard Chivers wrote:
> Let me know if this now works for you.
>
This is better, I can apply it :)
However, there are many style(9) issues. Can you fix them please before I review
the changes ?
Thank you.
IMSG_IFADD is never used, wipe it.
Index: ospf6d.h
===
RCS file: /cvs/src/usr.sbin/ospf6d/ospf6d.h,v
retrieving revision 1.46
diff -u -p -r1.46 ospf6d.h
--- ospf6d.h5 Apr 2020 18:19:04 - 1.46
+++ ospf6d.h14 May 2020
1 - 100 of 342 matches
Mail list logo