Re: allow usermod to remove user from secondary groups

2011-04-12 Thread Ingo Schwarze
Hi, Frank Brodbeck wrote on Tue, Apr 12, 2011 at 07:50:22PM +0200: Here's a diff leaving -G alone and introducing -S I don't really see the point in adding functionality to adduser, useradd and friends. Both are low-quality, bloaty, mostly useless code in the first place. And each is a

Re: permit daily(8) to use DUID in /etc/fstab for ROOTBACKUP

2011-03-23 Thread Ingo Schwarze
Hi Mattieu, Mattieu Baptiste wrote on Fri, Mar 18, 2011 at 04:28:40PM +0100: This diff enables daily(8) to use DUID instead of pathname in /etc/fstab for backing up root filesystem. I see the point, but i am not thrilled. I'm not a shell expert... comments are welcome. Already now, the

Re: ISO-8859-1 character in manpage

2011-03-16 Thread Ingo Schwarze
Hi Anthony, Anthony J. Bentley wrote on Wed, Mar 16, 2011 at 01:37:50PM -0600: $ mandoc -Tlint /usr/src/share/man/man4/udl.4 /usr/src/share/man/man4/udl.4:42:6: ERROR: skipping bad character: ignoring byte Thanks for reporting! Indeed, that character had to

Re: security(8) setuid checks and space character in file name

2010-12-29 Thread Ingo Schwarze
I consider this a bug in security(8). The following is the best i could come up with so far; make sure to wear your sed-peril-proof sunglasses before reading the patch. This still mangles the file name, but at least you have a chance to find it on your disk. Anybody has a better plan? I

Re: mv example fix

2010-12-26 Thread Ingo Schwarze
Hi Ted, Ted Unangst wrote on Sun, Dec 26, 2010 at 12:39:16AM -0500: A 3 line example with 3 bugs. 1. destination and destination_path should be the same. Sure, and both should be destination_path, because that's the term used consistently in the DESCRIPTION. Unambiguous terminology is

Re: mv example fix

2010-12-26 Thread Ingo Schwarze
Hi Jason, Jason McIntyre wrote on Sun, Dec 26, 2010 at 05:39:54PM +0001: On Sun, Dec 26, 2010 at 06:23:02PM +0100, Ingo Schwarze wrote: Index: mv.1 === i have no problem with this diff, but some tweak/concerns below

Re: mv example fix

2010-12-26 Thread Ingo Schwarze
Hi Jason, Jason McIntyre wrote on Sun, Dec 26, 2010 at 08:25:11PM +: On Sun, Dec 26, 2010 at 07:41:53PM +0100, Ingo Schwarze wrote: Index: mv.1 === RCS file: /cvs/src/bin/mv/mv.1,v retrieving revision 1.26 diff -u

Re: small nit in nsd.conf manpage.

2010-10-30 Thread Ingo Schwarze
Hi Janne, hi Jakob, Janne Johansson wrote on Sat, Oct 30, 2010 at 10:03:51PM +0200: The word slave will not appear in the manpage when the nsd.conf source looks like it does. OK schwarze@; but please make sure this is also sent upstream, ideally coordinated with the rest of the cleanup

switch man.conf(5) to mandoc(1)

2010-10-18 Thread Ingo Schwarze
As matthieu@ pointed out on tech@, man.conf(5) must be switched. Now that groff doesn't even exist any more in base, it's high time. Regarding base and new style ports (those now installing mandoc- or groff-preformatted manuals), it makes no difference. Regarding Xenocara and old style ports

Re: mandoc(1) grows tbl(1) support, and groff(1) moves to ports

2010-10-16 Thread Ingo Schwarze
Hi Jason, Jason McIntyre wrote on Sat, Oct 16, 2010 at 07:23:47PM +0059: On Sat, Oct 16, 2010 at 06:34:25PM +0200, Ingo Schwarze wrote: (3) tomorrow: send patches to switch tbl | nroff over to mandoc in the base build system (4) tomorrow: send patches to unlink the last me(7) and ms(7

Re: getmntinfo(3) sanity

2010-10-14 Thread Ingo Schwarze
Hi Vladimir, Vladimir Kirillov wrote on Fri, Oct 15, 2010 at 02:31:21AM +0300: The getmntinfo(3) page says that the mentioned function uses static storage which cannot be freed, however this storage is being actually malloced and can be freed without consequences. Err, no. Reading the code

Re: add rc.firsttime to rc(8)

2010-09-26 Thread Ingo Schwarze
Hi Tilo, Tilo Stritzky wrote on Sun, Sep 26, 2010 at 11:03:19PM +0200: OK, but then it needs a link too (patch included), right? To paraphrase what jmc@ said: In theory, yes, but it is so trivial it's probably not worth it. I tend to agree with that sentiment. I'm not opposed to the link,

Re: add rc.firsttime to rc(8)

2010-09-22 Thread Ingo Schwarze
It turned out this one needed a bit more tweaking: - a SYNOPSIS entry - one place to mention it in the DESCRIPTION - a brief hint how to create rc.firsttime (because that's indeed non-obvious) Regarding FILES, i took oga@'s wording. While nicm@'s bikeshed is more yellow, it doesn't fit on

Re: find(1) manpage patch

2010-09-13 Thread Ingo Schwarze
Hi, I like these two and have tweaked them a bit. Joachim Schipper wrote on Mon, Sep 13, 2010 at 02:49:58PM +0200: The first diff changes the last example in find(1). This diff: - makes it clear that it, in fact, works on all files *under* (not just in) the current working directory; -

Re: patch: diff(1) mentioning patch(1)

2010-08-18 Thread Ingo Schwarze
Hi Thomas, Thomas de Grivel wrote on Sun, Aug 15, 2010 at 04:39:04PM +0200: May seem useless but diff(1) definitely ought to mention patch(1) Done, thanks. Ingo

Re: [PATCH] flip order of steps in release(8)

2010-08-01 Thread Ingo Schwarze
Theo de Raadt wrote on Sun, Aug 01, 2010 at 11:28:01AM -0600: There is great harm. The first person who extends the distrib-dirs target to depend on a /usr/obj already being there is going to damage the tree of every person who is doing this wrong. jmc@ wrote: anyway, it is not really

Re: [PATCH] change exit status of env(1)

2010-07-22 Thread Ingo Schwarze
Hi Daniel, Daniel Dickman wrote on Thu, Jul 22, 2010 at 04:47:59PM -0400: exit 126 means utility was found but could not be invoked. exit 1-125 means some other error in env(1) Not quite; the -current manual says: 1-125 utility was invoked but failed in some way; see its manual page

Re: [patch] less: filename globbing/expansion

2010-03-28 Thread Ingo Schwarze
Hi Matthew, less(1) fails to write its buffer to pathnames with environment variables or the tilda home directory shortcut in them. The following patch corrects this by using the shell to glob filenames with lessecho instead of glob(3). I don't like this. It looks like the wrong approach in

Re: [patch] file descriptor leak fix

2010-03-21 Thread Ingo Schwarze
The leak reported by Igor is in opentemp(). The only place opentemp() is called from is diffreg(). When diffreg() is called from main(), the only calls that follow are print_status() and exit(), so we do not really leak anything: opentemp() leaks ifd, returns NULL, diffreg() returns, main()

#include sys/types.h in sys/mman.h

2010-02-24 Thread Ingo Schwarze
Christopher Zimmermann wrote on misc@, Wed, Feb 24, 2010 at 08:53:28PM +0100: I just got some errors while trying to compile ptlib: error: type specifier omitted for parameter `size_t' [...] They resulted from size_t not being defined in sys/mmap.h I guess you are talking about

Re: /etc/security

2010-02-21 Thread Ingo Schwarze
Tobias Ulmer wrote on Sun, Feb 21, 2010 at 12:56:48PM +0100: On Sun, Feb 21, 2010 at 12:19:47PM +0100, Ingo Schwarze wrote: Tobias Ulmer wrote on Sun, Feb 21, 2010 at 02:36:43AM +0100: I've got a bunch of users with no password/no way to log in, just to keep services tidy and separated

Re: xargs -0 and -L

2010-02-04 Thread Ingo Schwarze
Hi Atte, Atte Peltomdki wrote on Thu, Feb 04, 2010 at 12:48:47PM +0200: On Tue, Feb 02, 2010 at 09:32:43PM +0100, Ingo Schwarze wrote: Antti Harri wrote on Tue, Feb 02, 2010 at 07:31:57PM +0200: xargs' -L switch isn't working when using -0 flag. After checking POSIX.1 (2008), i conclude

Re: xargs -0 and -L

2010-02-02 Thread Ingo Schwarze
Hi Antti, Antti Harri wrote on Tue, Feb 02, 2010 at 07:31:57PM +0200: xargs' -L switch isn't working when using -0 flag. After checking POSIX.1 (2008), i conclude that our implementation and manual are correct in this respect. The -L option is concerned with lines of arguments from standard

Re: games/fortune/strfile/strfile.8

2010-01-17 Thread Ingo Schwarze
Hi Lars, The output made by strfile currently gets the suffix '.dat' by default. Fixed, thanks. Note that strfile(8) is not installed by default, neither the utility nor the manual. It's only used by the build process. Yours, Ingo Index: strfile.8

Re: games/fortune/strfile/strfile.8

2010-01-17 Thread Ingo Schwarze
Hi Lars, I missed a second change. Well, i already fixed that one, and two more details, in my commit. ;-) Index: strfile.8 === RCS file: /cvs/src/games/fortune/strfile/strfile.8,v retrieving revision 1.13 diff -u -p -r1.13

Re: [patch] user/6104: newsyslog count off by one

2010-01-09 Thread Ingo Schwarze
Hi David, --- newsyslog.c.bak Thu Oct 22 21:18:12 2009 +++ newsyslog.c Thu Oct 22 22:00:09 2009 @@ -756,6 +756,9 @@ char file1[MAXPATHLEN], file2[MAXPATHLEN], *suffix; int numdays = ent-numlogs; + /* We start counting at 0 so reduce for correct maximum */ +

Re: ping and host names that start with numbers

2009-12-29 Thread Ingo Schwarze
Hi Brad, Since ping takes either an int or a string as a host name arg, it would be neat if a flag could be passed that forces ping to treat the host argument as a string rather than an int I'd say that flag already exists: just give the FQDN. So i don't think we need yet another flag. If

Re: [PATCH] /usr/bin/sort posix patch

2009-12-22 Thread Ingo Schwarze
Hi Daniel, Daniel Dickman wrote on Mon, Dec 21, 2009 at 12:03:28AM -0500: The patch below adds support for sort's missing -C option (as per POSIX:2008). This option behaves like -c except that it suppresses output on STDERR. This one just got committed (with minimal tweaking of the code

Re: [PATCH] /usr/bin/find posix patch

2009-12-20 Thread Ingo Schwarze
Hi Daniel, Daniel Dickman wrote on Sat, Dec 19, 2009 at 07:53:53PM -0500: I think something like the following might be needed for 'find' to adhere to posix a little more closely. The posix spec says that if the mutually exclusive -H and -L options are both specified, the last one specified

Re: phrase 'log rotation' in newsyslog.8

2009-11-23 Thread Ingo Schwarze
Jason McIntyre just said: i'll change it to rotate log files. Good. As Matthew observed, files are renamed and deleted, but not trimmed. While here, i must admit i don't like the first two sentences of newsyslog(8) at all. * The text doesn't start by saying what the tool really does. *

Re: Signal handling question

2009-10-17 Thread Ingo Schwarze
Hi Matt, Matt Fisher wrote on Thu, Oct 15, 2009 at 11:39:39PM -0400: Stuart Henderson referred me to the tech list for this question. Here's a diff showing one line of possible cruft deleted from m4. This is one of 9 similar occurrences I've found in the src tree. I guess you are changing

Re: Missing header file in synopsis section of authenticate(3) man page.

2009-07-05 Thread Ingo Schwarze
Ian Darwin wrote on Sun, Jul 05, 2009 at 04:18:00PM -0400: There's no value getting the wrong answer quickly. Ouch. I should have noticed, i did look at getgrent(3) and such before. Thanks for the explanations and sorry for wasting your time... So i will simply do the following *after unlock*:

Re: Missing header file in synopsis section of authenticate(3) man page.

2009-07-05 Thread Ingo Schwarze
Jason McIntyre wrote on Sun, Jul 05, 2009 at 09:52:13PM +0100: On Sun, Jul 05, 2009 at 10:19:14PM +0200, Mark Kettenis wrote: So I think the man pages should be amended to #include sys/types.h. pages (plural)? there are more than this one to fix? Indeed, *two* need a fix, whereas

Re: add long option names to mount_nfs' man page

2009-06-25 Thread Ingo Schwarze
Hi Jason, hi Thordur, just to warn you, i had a brief look at this, and what you have does not seem right yet. This looks like a can of worms. Jason McIntyre wrote on Thu, Jun 25, 2009 at 02:11:08PM +0100: On Wed, Jun 24, 2009 at 01:42:58PM +, Thordur I. Bjornsson wrote: I like this a

<    5   6   7   8   9   10