Re: start cleaning up UTF-8 processing in less(1)

Hi, Stefan Sperling wrote on Sat, Feb 23, 2019 at 04:19:02PM +0100: > Your diff looks good to me. > And I can't see how it could make this situation any worse either. thanks for checking; i committed the first patch. To be able to continue with the less cleanup i started, i have to explain

Re: start cleaning up UTF-8 processing in less(1)

Hi Todd, Todd C. Miller wrote on Mon, Feb 25, 2019 at 01:06:02PM -0700: > On Mon, 25 Feb 2019 19:43:36 +0100, Ingo Schwarze wrote: >> Todd C. Miller wrote on Mon, Feb 25, 2019 at 09:45:12AM -0700: >>> On Mon, 25 Feb 2019 12:39:41 +0100, Ingo Schwarze wrote:

less(1) UTF-8 cleanup: backc()

Hi, the first step in cleaning up do_append() is the subroutine backc(), which is only called from a single place, namely in do_append(). Its purpose is to back up over the previous positive-width character during the application of backspace-encoding for "bold" or "underlined". The task here is

Re: mandoc -Tlint systat.1 fix

Hi David, David Gwynne wrote on Mon, Mar 04, 2019 at 08:59:12PM +1000: > lint thinks uvm_swap_get() looks like a function name, > so this uses .Fn to mark it up as one. > > ok? Sure. Given that the function uvm_swap_get() appears to be important enough to be mentioned even in a userland

Re: update ctype data to unicode 10

Hi Andrew, Lauri Tirkkonen wrote on Fri, Feb 22, 2019 at 01:57:01AM +0200: > Hi, the recent perl-5.28.1 and related unicore update brought the > unicode data from version 8.0.0 to version 10.0.0. That fixes some > character classifications (eg. emoji characters gained East_Asian_Width > value

Re: update ctype data to unicode 10

Hi Andrew, Andrew Fresh wrote on Thu, Feb 21, 2019 at 08:22:16PM -0700: > On Fri, Feb 22, 2019 at 01:57:01AM +0200, Lauri Tirkkonen wrote: >> Hi, the recent perl-5.28.1 and related unicore update brought the >> unicode data from version 8.0.0 to version 10.0.0. That fixes some >> character

Re: start cleaning up UTF-8 processing in less(1)

Hi, Nicholas Marriott wrote on Mon, Feb 25, 2019 at 10:14:03AM +: > Ingo Schwarze wrote: >> During the upcoming cleanup steps, let use retain full support for >> the first (ESC-[) syntax and lets us completely delete support for >> the second and third CSI syntaxes (sing

Re: nm(1): return on malloc error

Hi, Benjamin Baier wrote on Sat, Mar 02, 2019 at 10:10:40AM +0100: > On malloc error symtab is unmapped, so proceeding on will lead > to a NULL pointer dereference. > When malloc fails we should return like the MMAP case does. while i'm certainly not experienced with nm(1), this change looks

Re: nm(1): return on malloc error

Hi, Benjamin Baier wrote on Sat, Mar 02, 2019 at 10:10:40AM +0100: > On malloc error symtab is unmapped, so proceeding on will lead > to a NULL pointer dereference. > When malloc fails we should return like the MMAP case does. Committed. Thanks for the patch (and to those who checked it).

less(1) UTF-8 cleanup: store_char()

Hi, Nicholas Marriott wrote on Tue, Feb 26, 2019 at 07:20:47AM +: > Looks good, ok nicm Thanks to all of you for checking. Here is the next step, slowly coming closer to the meat of the matter: Start cleaning up the function store_char(), which takes a wide character, receiving both the

Re: archaic quotes in calendar

Hi, Anthony J. Bentley wrote on Wed, Jan 30, 2019 at 04:01:30AM -0700: > Jason McIntyre writes: >> in the man page you have used Sq. that will make it mark up the same as >> it already does: >> >> (`*') > There's a difference: Ted uses a UTF-8 locale where Sq shows up as > pretty Unicode

start cleaning up UTF-8 processing in less(1)

Hi, Evan Silberman, by posting a well-founded bug report to bugs@, just drew my attention to the pigsty of having a hand-rolled re-implemention of Unicode character property handling within less(1). The root of the evil is the existence of the custom definition typedef unsigned long LWCHAR;

less(1) UTF-8 bugfix and cleanup: search.c

Hi, the following is a very simple patch to completely clean up the file less/search.c with respect to UTF-8 handling. It also fixes an outright bug: Searching for uppercase UTF-8 characters currently doesn't work because passing a Unicode codepoint (in this case, the "ch" retrieved with

Re: less(1) UTF-8 bugfix and cleanup: search.c

Hi Stefan, Stefan Sperling wrote on Thu, Mar 14, 2019 at 04:11:00PM +0100: > Yes, OK. Thanks for checking. Here is the next step outside line.c, completely cleaning up the file less/filename.c with respect to UTF-8 handling. The loop needed is very similar to the one in search.c except that

Re: mount(8): remove unnecessary white space in man page

Hi Alessandro, Alessandro Gallo wrote on Sun, Mar 10, 2019 at 02:12:21PM +0100: > There seems to be an unneeded extra space in the mount(8) man page. > The following diff fixes that: Committed, thanks. Ingo > Index: mount.8 >

less(1) UTF-8 cleanup: pappend()

Hi Todd, Todd C. Miller wrote on Tue, Mar 12, 2019 at 09:14:43AM -0600: > This looks like an improvement to me. OK millert@ Thanks for checking the do_append() patch, i committed it. The next step is to clean up pappend(), which reads one byte of a multibyte character per call and outputs the

Re: xman.man: typo in mandesc section

Hi Alejandro, we normally avoid trivial changes to X11 documentation. Such changes provide little benefit but make life harder for matthieu@. If the typo still exists upstream, please report it upstream, and it will automatically appear in OpenBSD with the next regular update. Yours, Ingo

Re: xterm and wcwidth()

Hi, Lauri Tirkkonen wrote on Fri, Mar 08, 2019 at 12:43:11PM +0200: > I feel like xterm should just use the system wcwidth() to avoid these > mismatches, so rudimentary diff to do that below. Absolutely, i strongly agree with that sentiment. Having a local character width table in an

Re: xterm and wcwidth()

Hi, Ted Unangst wrote on Fri, Mar 08, 2019 at 03:24:56PM -0500: > Matthieu Herrb wrote: >> I would prefer a diff that just add a &&!defined(__OpenBSD__) to the >> condition before the definition of systemWcwidthOk(). This will cause >> less risk of conflicts in future updates and clearly show

Re: xterm and wcwidth()

Hi, Ted Unangst wrote on Fri, Mar 08, 2019 at 12:57:17PM -0500: > Lauri Tirkkonen wrote: >> in other words, xterm is (and was) using its own idea of how many >> columns characters take up. The way this manifested itself to me was >> that I received some email that contained emoji characters in

Re: EC_POINT_new.3 glitch

Hi Jan, Jan Stary wrote on Mon, Mar 18, 2019 at 08:38:04AM +0100: > This seems to be a missed newline. Committed, thanks. Ingo > Index: EC_POINT_new.3 > === > RCS file: /cvs/src/lib/libcrypto/man/EC_POINT_new.3,v > retrieving

Re: Unescaped backslashes in manual pages

Hi Peter, Peter Piwowarski wrote on Tue, Mar 19, 2019 at 10:03:20PM -0400: > qsort(3) has in its EXAMPLE a C \n with its backslash unescaped; a quick > grep through manpages showed similar errors in CONF_modules_load_file.3. Ouch! Thanks for the report, committed. Ingo > Index:

Re: Adding fstab(5) fs_mntops to mount_nfs(8)

Hi Kurt, Kurt Mosiejczuk wrote on Mon, Mar 11, 2019 at 09:32:41AM -0400: > As far as I can tell, no man page documents the fs_mntops form of the > mount_nfs(8) options for fstab(5). Most of us who use them either know > from some other documentation, reading the source, or just doing a >

less(1) UTF-8 cleanup: do_append()

Hi Nicholas, Nicholas Marriott wrote on Tue, Mar 12, 2019 at 11:05:07AM +: > Sorry, ok nicm if you haven't committed this already. No i hadn't, but now i have, thank you very much for checking the patch. Here is the next step, cleaning up most parts of the crucial function do_append()

delete useless setlocale(3) in spell(1)

Hi, looking through my trees for diffs that were forgotten, i found this one. Spell uses nothing locale-dependent, and it will never need support for non-English characters because the basic algorithms used are specific to the English language in the first place. So delete and setlocale(3)

delete useless setlocale(3) in uuencode(1)

Hi, uuencode(1) and uudecode(1) do nothing locale-related and i don't see how they ever might. So delete and setlocale(3). While here, sort headers, make usage() static, return from main rather than exit(3), and drop two redundant case statements. This is also a minimally tweaked version of a

delete useless setlocale(3) from touch(1)

Hi, i initially thought touch(1) might be tricky because it is concerned with times, but it turned out is does almost all of the parsing by hand, supporting only specific numeric formats and nothing like month names. It does use strptime(3), but only for %F and %T neither of which is

Re: games/fortune translation fix

Hi Scott, Scott Cheloha wrote on Tue, Feb 05, 2019 at 12:02:39AM -0600: > Oof, folks I think we've missed the forest for the trees here. > > By focussing on the minutiae of the Latin translation we've discarded > the English motto ("through to the stars") that imho > anchored the whole thing.

Re: install(1) could fail due to race

Ted Unangst wrote on Sun, Jan 27, 2019 at 10:37:52AM -0500: > Ingo Schwarze wrote: >> If people here agree with the general direction of making -S the >> default and removing the fragile non-S mode (see the patch below), >> i'll run a full make build and make release and then

Re: install(1) could fail due to race

Hi Ted, Ted Unangst wrote on Sun, Jan 27, 2019 at 10:37:52AM -0500: > Ingo Schwarze wrote: >> If people here agree with the general direction of making -S the >> default and removing the fragile non-S mode (see the patch below), >> i'll run a full make build and make release

Re: ASN1_get_object.3

Hi Kristaps, Kristaps Dzonsons BSD.LV wrote on Wed, Jan 30, 2019 at 12:17:16PM +0100: >> Attached is a manpage for ASN1_get_object(3), ASN1_put_object(3), and >> ASN1_put_eoc(3). > This is not complete without ASN1_object_size(), as otherwise one can't > scan over children, which is necessary

Re: games/fortune translation fix

Hi Jason, oh well, these files are a mess, a random collection of funny and not so funny stuff... I dislike this one, too, for several reasons. 1. While "ad astra per aspera" sometimes occurs, the word order "per aspera ad astra" is much more commonly used. It sounds much better - not

Re: games/fortune translation fix

Hi Pascal, Pascal Stumpf wrote on Sun, Feb 03, 2019 at 11:13:12AM +0100: > That is not correct because [...] Which illustrates yet again that getting good grades at school doesn't imply real understanding; i dared to try and research the matter anyway because i forgot that with pascal@, we have

Re: update to PF pfctl(8) and pf.conf(5) manpages

Hi Alexandr, Alexandr Nedvedicky wrote on Wed, Apr 17, 2019 at 12:09:10AM +0200: > my oracle fellow pointed out [1] a PF documentation can be improved > a bit, when it comes to newly introduced 'pfctl -FR' (a reset flush > modifier). I've decided to make manpage changes in separate diff as > I

Re: 63 bit certificate ID is libressl affected?

Hi Tom, Tom Smyth wrote on Wed, Mar 13, 2019 at 08:32:20PM +: > Just saw the following article and i was wondering if libressl > Might be affected by the bug also > Top bit being set to 0 always making an effective 63 bits rather than 64 > bits If i understand the article you quote

Re: caesar(6) to accept negative argument

Hi, tleguern wrote on Wed, May 15, 2019 at 03:36:57PM +0100: > This little patch makes caesar(6) useful at both encrypting and > decrypting texts by allowing a negative rotation. Committed, thanks. > A similar patch was proposed by Dieter Rauschenberger in 2008 with > little response Well,

Re: intro.8: .Xr rcctl 8 -- http://man.openbsd.org/intro.8

Hi Christian, Christian Weisgerber wrote on Sun, May 26, 2019 at 01:19:01AM -: > Not sure what do about "ELF(3)" in elf(3). Index: elf.3 === RCS file: /cvs/src/lib/libelf/elf.3,v retrieving revision 1.2 diff -u -p -r1.2 elf.3

Re: proot.1: Formatting fix

Hi Fabio, Fabio Scotoni wrote on Sat, Jun 08, 2019 at 12:15:57PM +0200: > This patch fixes a newline in proot.1 preventing LOCKDIR from > being rendered correctly. Thanks for reporting. I committed the patch shown below. > Note that this causes the input line to be very long, which > seemed

Re: [diff] events.html - video links for BSDCan 2019

Hi Ross, Ross L Richardson wrote on Tue, Jun 18, 2019 at 08:34:41PM +1000: > The patch below just adds links for the videos currently available. Committed, thanks. > Notes: > - Lines were already > 80 characters, so I haven't folded. I took the liberty to fold the lines touched. I think that

Re: sftp(1) manual diff

Hi, Jason McIntyre wrote on Mon, Jun 17, 2019 at 04:58:26PM +0100: > On Mon, Jun 17, 2019 at 05:31:16PM +0200, Tim van der Molen wrote: >> Jason McIntyre (2019-06-17 15:02 +0200): >>> On Mon, Jun 17, 2019 at 02:47:09PM +0200, Tim van der Molen wrote: sftp(1) has this: reput [-Ppr]

Re: [patch] improve strptime(3) %z timezone parsing

Hi, > That one looks correct. OK millert@ Committed, thanks for checking! While here, i noticed ugly preprocessor macros. Let's make our future life easier by unifdefing a bit. When compiling with -g0, there is no object change. Note that if TM_ZONE is not defined, wcsftime.c doesn't

Re: [patch] remove reference to HOSTALIASES in hostname(7)

Hi, Theo de Raadt wrote on Mon, Apr 15, 2019 at 12:56:35PM -0600: > Hiltjo Posthuma wrote: >> I noticed the man page hostname(7) still references the environment >> variable HOSTALIASES. This functionality seems to be removed in the >> commit: >>

Re: [patch] improve strptime(3) %z timezone parsing

Hi, Theo de Raadt wrote on Sun, Mar 24, 2019 at 12:48:03PM -0600: > Hiltjo Posthuma wrote: >> On Sun, Feb 24, 2019 at 01:11:39PM +0100, Hiltjo Posthuma wrote: >>> 2. The military/nautical UTC offsets are [...] broken by design. >> As discussed previously for point 2 I think it is fine to

Re: [patch] improve strptime(3) %z timezone parsing

Hi Todd, Todd C. Miller wrote on Fri, May 10, 2019 at 02:08:45PM -0600: > On Fri, 10 May 2019 16:52:35 +0200, Ingo Schwarze wrote: >> Here is a patch to fix the code. > OK millert@ for that part. Thanks, committed. >> The change to %Z is exactly what Hiltjo sent. >>

less(1) UTF-8 cleanup: cmd_putstr()

Hi, let's start tackling the last file which is using stuff from charset.c: the file cmdbuf.c. The first dirty function is cmd_putstr(). Fortunately, it doesn't actually need to handle non-ASCII characters. The function cmd_putstr() is called only from command.c. Almost all callers pass literal

Re: grep ".one\|.two" doesn't work on OpenBSD. Is it expected?

Hi, Todd C. Miller wrote on Mon, May 20, 2019 at 01:22:21PM -0600: > On Mon, 20 May 2019 20:01:12 +0200, Juan Francisco Cantero Hurtado wrote: >> The grep command works with GNU, NetBSD, FreeBSD and BusyBox. It fails >> on OpenBSD and Solaris 11. I'm suggesting upstream to change the command >>

Re: cp(1) add -l hard link -s symlink options

Hi Tracey, Tracey Emery wrote on Thu, May 23, 2019 at 02:35:10PM -0600: > Attached is a proposed diff for cp(1). It adds the -l (hard link) > and -s (symlink) options. I don't like that. That's exactly what can be done with ln(1) in a standard way. There is no value in making every tool do

Re: update to PF pfctl(8) and pf.conf(5) manpages

Hi Alexandr, Alexandr Nedvedicky wrote on Wed, May 08, 2019 at 04:55:57PM +0200: > below is third iteration of pf.conf.5 manpage. OK schwarze@ A few final nits inline. Thank you again for doing this work. Ingo > diff --git a/share/man/man5/pf.conf.5 b/share/man/man5/pf.conf.5 [...] > @@

Re: [patch] improve strptime(3) %z timezone parsing

Hi Ted, Ted Unangst wrote on Thu, May 09, 2019 at 04:16:40PM -0400: > Ingo Schwarze wrote: >> I'm not mixing anything else into this diff. The other bugs should >> be handled separately. > Works for me. (with additional comment removal) Thanks for checking, committ

Re: mdoc.7: fix Dd example

Hi Klemens, Jason McIntyre wrote on Sun, May 19, 2019 at 08:58:35PM +0100: > On Sun, May 19, 2019 at 09:52:39PM +0200, Klemens Nanni wrote: >> On Sun, May 19, 2019 at 07:31:19PM +0100, Jason McIntyre wrote: >>> no. just use $Mdocdate$ and it gets expanded on commit. just like >>> when you add

Re: print regress results

Hi Alexander, Alexander Bluhm wrote on Wed, May 15, 2019 at 12:01:00AM -0400: > Regress prints FAILED in the middle of the make output, this is > hard to watch. I agree this is a nuisance. I have often wondered whether the result was "PASS" or "FAIL" after doing longer regression runs in the

Re: remove regress maxtime

Hi Alexander, Alexander Bluhm wrote on Tue, May 14, 2019 at 02:16:19AM -0400: > Does anyone use the REGRESS_MAXTIME feature? Not me. > I would like to remove it. > > - The timeout based on CPU seconds is pretty useless. > Most hanging tests sleep and do not spin. > - A timeout cannot be

Re: Don't use '.Sx' to refer to external sections

Hi Stephen, Stephen Gregoratto wrote on Tue, May 14, 2019 at 01:08:00PM +1000: > It was mentioned previously that the use of .Sx to refer to a section in > a different manual page is incorrect. I grepped through the src tree to > see if there were any cases of this and I found a couple. Thanks,

clean up LC_COLLATE and LC_CTYPE in sort(1)

Hi, after my LC_NUMERIC cleanup for sort(1) went in (thanks to tb@ for the review), i'd like to adress the rest of locale dependency. Large amounts of extremely ugly code in sort(1) - many hundreds of lines - deal with LC_COLLATE, which we don't support now and have no intention to support in

Re: update to PF pfctl(8) and pf.conf(5) manpages

Hi Alexandr, here are a few additional minor remarks... Alexandr Nedvedicky wrote on Mon, Apr 29, 2019 at 08:59:55PM +0200: > diff --git a/sbin/pfctl/pfctl.8 b/sbin/pfctl/pfctl.8 > index b7e941991ba..5e2c57f6bc2 100644 > --- a/sbin/pfctl/pfctl.8 > +++ b/sbin/pfctl/pfctl.8 > @@ -198,7 +198,11 @@

Re: [PATCH] [www] innovations.html - add unwind(8) to the list

Hi Raf, Raf Czlonka wrote on Tue, Apr 30, 2019 at 12:18:17PM +0100: > unwind(8) looks like a good candidate for inclusion into > innovations.html[0]. > > While there, add "released with ..." to the preceding entry. > > [0] https://www.openbsd.org/innovations.html Thanks, committed. Ingo >

Re: update to PF pfctl(8) and pf.conf(5) manpages

Hi, Jason McIntyre wrote on Mon, Apr 29, 2019 at 09:53:03PM +0100: > ah, so singular is correct. but it needs an article of some sort. how > about: > > .Xr pfctl 8 > .Fl F Cm Reset > restores this value to its default. > > to be honest, i don;t like it when we Xr like this,

less(1) UTF-8 cleanup: pshift()

Hi, thanks for checking the pappend() and filename.c patches, those are now committed. Here is basic cleanup of the last major function in line.c, pshift(). Several minor issues still remain in the file, but those are for later. This gets rid of two LWCHAR variables, one call to utf_len(),

clean up LC_NUMERIC in sort(1)

Hi, it was noticed years ago that our implementation of sort(1) is very messy. It contains huge amounts of dead code -- many hundreds of lines -- and many wrapper functions around standard C library functions that are in very bad taste and mostly pointless. However, nobody ever came round to

Re: perldoc: fix man output & formatting

Hi Andrew, Andrew Daugherity wrote on Thu, May 02, 2019 at 10:53:37AM -0500: > Also, their ToMan patch has a previously-included hunk > for MANWIDTH=tty, All that does is suppress a warning message "non-numeric MANWIDTH" when a user has MANWIDTH=tty in their environment. No idea why any user

Re: perldoc: fix man output & formatting

Hi Todd & Andrew, Andrew Fresh wrote on Thu, May 02, 2019 at 09:53:29AM -0700: > On Thu, May 02, 2019 at 10:21:15AM -0600, Todd C. Miller wrote: >> On Thu, 02 May 2019 10:53:37 -0500, Andrew Daugherity wrote: >>> I reported this to FreeBSD ports a couple months ago [2], and they >>> provided a

Re: kqueue.2: formatting fixes and minor HISTORY expansion

Hi Fabio, Fabio Scotoni wrote on Thu, May 02, 2019 at 03:33:42PM +0200: > I've taken a stab at improving kqueue.2 formatting. > Most of the changes are markup fixes. All your formatting decisions are good. > I used ".Dv NULL" over plain "null" in accordance with > lib/libc/stdlib/malloc.3 rev.

Re: perldoc: fix man output & formatting

Hi Andrew, Andrew Fresh wrote on Fri, May 03, 2019 at 06:24:16PM -0700: > I committed this after moving the waitpid down a few lines, after the > last read from the filehandle. Oops. Sorry for missing that, and thanks for committing it, and for catching that additional issue. > I will say

Re: perldoc: fix man output & formatting

Hi Andrew, Andrew Fresh wrote on Sun, May 05, 2019 at 02:44:58PM -0700: > On Sun, May 05, 2019 at 04:53:05PM +0200, Ingo Schwarze wrote: >> The first chunk in the patch below seems to be all that is needed. >> IIRC, we already do a similar thing in pod2man(1). > This is t

less(1) UTF-8 cleanup: cvt.c

Hi Todd, Todd C. Miller wrote on Wed, May 08, 2019 at 06:36:30AM -0600: > On Tue, 07 May 2019 23:32:20 +0200, Ingo Schwarze wrote: >> Here is basic cleanup of the last major function in line.c, pshift(). > Looks good. OK millert@ Thanks for checking, i will commit the line.c

Re: rtable_walk(9)

Hi Martin, Martin Pieuchot wrote on Thu, Jul 11, 2019 at 05:18:41PM -0300: > Index: rtable_walk.9 > === > RCS file: rtable_walk.9 > diff -N rtable_walk.9 > --- /dev/null 1 Jan 1970 00:00:00 - > +++ rtable_walk.9 11 Jul 2019

Re: sysupgrade: select sets to install

Hi Theo, Theo de Raadt wrote on Tue, Jul 09, 2019 at 09:23:25AM -0600: > Klemens Nanni wrote: >> I think sysupgrade should, if at all, use the same semantics as the >> installer. That is, something like `sysugprade -S '-* b*'" to upgrade >> nothing but kernels and base. >> >> Such options

Re: ed(1) man page doesn't mention use of single / and ?

Hi Jason, Jason McIntyre wrote on Sun, Jul 07, 2019 at 08:56:43PM +0100: > this is getting silly - we're mixing talking about how /re/ and ?re? > work as addresses and as regular expressions in other places. dropping > the trailing [/?] does not apply to regular expressions everywhere.

Re: ldomctl: improve usage

Hi Klemens, Klemens Nanni wrote on Sun, Jun 30, 2019 at 01:04:17PM +0200: > On Sat, Jun 22, 2019 at 11:20:10AM -0600, Theo de Raadt wrote: >> The problem is when I'm on screens that don't have scroll-back, those 9 >> lines have scrolled other information off the top, and then I've had to >>

Re: sleep(1): simplify argument parsing

Hi Scott, Scott Cheloha wrote on Sun, Jun 30, 2019 at 06:49:28AM -0500: > This is cleaner, shorter. > > - Remove the intermediate variables and just build the timespec >directly. > > - Use for-loops to consolidate initialization/incrementation of cp >into one spot in each loop. > >

Re: new man page: rcsfile.5

Hi Fabio, Fabio Scotoni wrote on Tue, Apr 23, 2019 at 01:45:22PM +0200: > While familiarizing myself with OpenRCS, > I noticed that there's no rcsfile(5). > This may be handy for people whose RCS file got corrupted for whatever > reasons. > Other *NIXes that ship SCCS tend to have a sccsfile(4),

Re: new man page: rcsfile.5

Hi Fabio, i applied a very small number of minor tweaks and plan to commit the patch below tomorrow based on OK jmc@ deraadt@ millert@, unless i hear objections. Fabio Scotoni wrote on Tue, Apr 23, 2019 at 05:19:48PM +0200: > I've adjusted the updated man page (inline) .Dt and .Nm to match

Re: new man page: rcsfile.5

Hi Fabio, Fabio Scotoni wrote on Tue, Apr 23, 2019 at 07:46:31PM +0200: > On 4/23/19 7:15 PM, Ingo Schwarze wrote: >> Is it correct that you wrote all the text in the file? >> If so, your name needs to be there. > It is indeed correct that I wrote all the text i

Re: new man page: rcsfile.5

Hi Fabio, Fabio Scotoni wrote on Wed, Apr 24, 2019 at 06:14:07AM +0200: > On 4/23/19 9:30 PM, Ingo Schwarze wrote: >> Fabio Scotoni wrote: >>> Ingo Schwarze wrote: >>>> +.\" OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. >>>> +.\&qu

Re: [diff] events.html - add 2 more BSDCan 2019 videos

Hi Ross, Ross L Richardson wrote on Sat, Jun 22, 2019 at 02:17:26PM +1000: > Probably in acceptable form :-) Committed, thanks. Ingo > Index: events.html > === > RCS file: /cvs/www/events.html,v > retrieving revision 1.1174 >

Re: [diff] www/libressl/papers.html - add video link

Hi Ross, Ross L Richardson wrote on Sat, Jun 22, 2019 at 02:24:46PM +1000: > The following corresponds with the events.html patch... Almost... Committed with the correct YT ID MCVIBwGOwNY instead of gvmGfpMgny4 which is beck@'s unveil(2) talk. Thanks anyway, Ingo > Index: papers.html >

Re: add pkg-config files for readline, editline, ncurses

Hi Stephen, Stephen Gregoratto wrote on Fri, Jul 26, 2019 at 01:23:21AM +1000: > mrsh[1], a cross-platform shell, can use readline in interactive mode. > It's configure script detects the presence of readline using > pkg-config(1). Thus, this patch adds a pkg-config file for our readline. It is

less(1): utility function to step one multibyte character to the left

Hi, the file less/line.c currently contains three copies of code to step one multibyte character to the left in a char * buffer, and cleaning up the file less/cmdbuf.c will require similar functionality in the future. So let's introduce a new function for that purpose. Keep it as similar as

Re: delete ligature support for Arabic "la" from the less(1) command line

Hello Mohammadreza, Mohammadreza Abdollahzadeh wrote on Sun, Sep 01, 2019 at 09:40:16AM +0430: > Persian is my native language and I think that the major problem that > all RTL (Right-To-Left) languages like Persian and Arabic currentlly suffer > from is the lack of BiDi (Bidirectionality)

Re: libedit: Does not run input command in vi mode

Hello Masato-san, Masato Asou wrote on Tue, Sep 03, 2019 at 02:39:11PM +0900: > Does not run input command by vi editor with vi mode. > > I do the following: > > 1. set vi mode. >$ echo "bind -v" > ~/.editrc > > 2. launch /usr/bin/ftp command. >$ ftp > > 3. launch vi editor with ESC

Re: typo in man page of sysupgrade option -s

Hi Florian, Florian Obser wrote on Fri, Aug 23, 2019 at 02:43:22PM +0200: > This is not a typo as such, it describes the default. It is a bit > awkward since it uses the same text for -r and -s. I think we can just > remove it from -s: The following seems more straightforward. I don't feel

less(1): replace the last step_char(-1)

Hi, The command line handling code in less/cmdbuf.c is very complicated. >From the top level function cmd_char(), the stack can go down nine levels before finally reaching the bottom level function cmd_step_common(). One of the functions traversed during that descent is the recursive function

delete ligature support for Arabic "la" from the less(1) command line

Hi, i have to admit that i am neither able to speak nor to write nor to understand the Arabic language nor the Arabic script, but here is my current, probably incomplete understanding of what our less(1) program is trying to do with Arabic ligatures. If somebody is reading this who is able to

Re: remove chroot(2) from spamd(8)

Hi, Theo de Raadt wrote on Wed, Jul 31, 2019 at 09:48:57AM -0600: > Ricardo Mestre wrote: >> By now we are already confident that pledge(2) "just works(tm)" >> and that it can be used to effectively remove filesystem access. >> >> That being said, in spamd(8) when I pledge(2)d it the main priv

Re: remove chroot(2) from spamd(8)

Hi, Ricardo Mestre wrote on Wed, Jul 31, 2019 at 07:41:08PM +0100: > On 11:22 Wed 31 Jul , Theo de Raadt wrote: >> Ingo Schwarze wrote: >>> /* >>> * When porting this program to a platform lacking pledge(2), >>> * don't forget to at least

Re: printf(1) man page has a small omission

Hi Andras, please do not cross-post on OpenBSD lists, choose whatever list fits best. I trimmed bugs@ for this followup. On Mon, Jun 3, 2019 at 2:12 PM Andras Farkas wrote: > https://man.openbsd.org/man1/printf.1 > The section on the b format (%b) neglects to mention that for that > format,

Re: Remove some sigvec Xr's

Hi Philip, Philip Guenther wrote on Thu, Jul 25, 2019 at 07:21:48PM -0900: > Hmm: sh(1) and ksh(1) have *nothing* from sections 2 or 3 in their SEE > ALSO. That doesn't seem like a wrong choice, Indeed. Jason generally discourages linking from section 1 to sections 2 and 3, arguing that

Re: SIGSEGV in libedit

Hello Yasuoka-san, YASUOKA Masahiko wrote on Mon, Aug 05, 2019 at 04:20:41PM +0900: > This is the diff which fixes the problem by replacing malloc by calloc. > > Initialize the line buffer by zero when allocation. This fixes the > problem a crash happens after the window size change.

Re: SIGSEGV in libedit

Hello Yasuoka-san, YASUOKA Masahiko wrote on Thu, Aug 01, 2019 at 08:42:35PM +0900: > I noticed the upstream NetBSD recently replaced almost all malloc(3)s > by calloc(3) in libedit. > > https://github.com/NetBSD/src/commit/b91b3c48e0edb116bd797586430cb426b575d717 > > This also fixes the

Re: less -S does not "truncate" lines

Hi George, George Brown wrote on Sat, Jul 20, 2019 at 01:29:37PM +0100: > When viewing a file with "less -S" that has lines longer than $COLUMNS > said lines are simply not wrapped. The contents of said lines is still > available, one simply needs to scroll horizontally. I would have > expected

Re: [patch] Re-add 'proc' to vi(1) when running in secure mode.

Hi, Bryan Steele wrote on Fri, Jul 19, 2019 at 06:14:56PM -0400: > On Sat, Jul 20, 2019 at 12:03:03AM +0200, Jesper Wallin wrote: >> On Fri, Jul 19, 2019 at 05:14:03PM -0400, Bryan Steele wrote: >>> I suspect that in secure/-S mode, the :pre[serve] should either be >>> disabled, or modified to

Re: make msgsnd(2) more posix

Hi Moritz, Moritz Buhl wrote on Thu, Jul 18, 2019 at 01:38:49PM +0200: > bluhm@ wrote: >> Moritz, can you create a man page ERRORS diff? > Is the attached diff ok? Yes, committed with some additional tweaks. Thank you, Ingo CVSROOT:/cvs Module name:src Changes by:

Re: Diff to stop using reserved words for smtpd.conf(5) examples

Hi Gilles, Gilles Chehade wrote on Tue, Jul 23, 2019 at 08:27:06AM +0200: > On Mon, Jul 22, 2019 at 05:05:01PM -0400, Kurt Mosiejczuk wrote: >> This is a diff for that changes the example smtpd.conf and smtpd.conf.5 >> so that it no longer uses words that are parts of the configuration >> syntax

Re: Diff to stop using reserved words for smtpd.conf(5) examples

Hi Kurt, Kurt Mosiejczuk wrote on Wed, Jul 24, 2019 at 09:28:26AM -0400: > On Wed, Jul 24, 2019 at 02:17:47PM +0200, Klemens Nanni wrote: >> On Wed, Jul 24, 2019 at 01:32:52PM +0200, Gilles Chehade wrote: >>> Well I think we should remove the reserved keywords as suggested by Kurt >>> but keep

Re: ctags.1: Xr vgrind

Hi, Jason McIntyre wrote on Mon, Jul 15, 2019 at 06:43:09PM +0100: > On Mon, Jul 15, 2019 at 04:56:29PM +0200, Klemens Nanni wrote: >> This tool comes from the textproc/vgrind port so base does not have it, >> is that the reason we do not reference it? >> >> I think it is still useful, so

Re: ctags.1: Xr vgrind

Hi Jason, Jason McIntyre wrote on Mon, Jul 15, 2019 at 09:04:23PM +0100: > On Mon, Jul 15, 2019 at 09:35:26PM +0200, Ingo Schwarze wrote: >> Jason McIntyre wrote on Mon, Jul 15, 2019 at 06:43:09PM +0100: >>> On Mon, Jul 15, 2019 at 04:56:29PM +0200, Klemens Nanni wrote: >>

Re: [patch] Re-add 'proc' to vi(1) when running in secure mode.

Hi, Bryan Steele wrote on Sun, Jul 21, 2019 at 01:53:49PM -0400: > On Sat, Jul 20, 2019 at 12:03:03AM +0200, Jesper Wallin wrote: >> Oh, you're right. A bit ironic that I didn't notice the exec violation >> due to the fork being permitted now. Thanks for pointing this out! >> Scrap my old

Re: [patch] Re-add 'proc' to vi(1) when running in secure mode.

Hi Jesper, Jesper Wallin wrote on Mon, Jul 22, 2019 at 06:09:03PM +0200: > On Mon, Jul 22, 2019 at 03:23:16PM +0200, Ingo Schwarze wrote: >> 3. Jesper, including a patch according to the best of your >> understanding is always welcome. Even if it turns out to be a &

Re: ascii(7): add a reference to the ANSI X3.4

Hello, Masanori Ogino wrote on Tue, Sep 17, 2019 at 11:49:17AM +0900: > Unlike utf8(7), ascii(7) does not contain a reference to its standard. > This patch just adds the reference. Thanks for pointing out the omission, i committed the following version. Yours, Ingo CVSROOT:/cvs

Re: timeout.9: cite our sources

Hi Scott & Jason, Jason McIntyre wrote on Sat, Nov 02, 2019 at 06:16:49PM +: > On Sat, Nov 02, 2019 at 12:32:30PM -0500, Scott Cheloha wrote: >> Cite the paper describing the timing wheel. PDF here: >> >> http://www.cs.columbia.edu/~nahum/w6998/papers/ton97-timing-wheels.pdf >> >> The

<    2   3   4   5   6   7   8   9   10   >