Re: vmctl show

Peter Hessler(phess...@openbsd.org) on 2018.02.11 00:51:57 +0100: > My fingers have typed "vmctl show" instead of "vmctl status" for over a > year now, so add it as an alias. oh yes please, i thought i was the only stupid one. > OK? ok > Index: main.c > =

route socket filter on priority

- add ROUTE_PRIOFILTER - it has one argument that is interpreted as a route priority - all route updates with prio lower or equal will pass the filter, all with higher priority value will be filtered. - example use in ospfd comments/oks? (benno_ospfd_route_priofilter_1.diff) diff --git sys/n

Re: Introduce killjobc()

Martin Pieuchot(m...@openbsd.org) on 2018.02.09 21:31:55 +0100: > Diff below moves some job control bits out of exit1(). It is extracted > from guenther@'s proctreelk diff. It's currently a noop so I'd like to > get it in to reduce the locking diff. > > ok? ok > Index: kern/kern_exit.c >

Re: minimize routing socket desync

please skip over the #if 0, thats debugging to find the right values. As i said work in progress, feedback welcome. Sebastian Benoit(be...@openbsd.org) on 2018.02.09 04:49:43 +0100: > Hi, > > when bgpd changes a lot of routes (and runs with fib-updates yes), the > routing socket o

minimize routing socket desync

Hi, when bgpd changes a lot of routes (and runs with fib-updates yes), the routing socket of ospfd (and ospf6d, ripd, eigrpd) will get a lot of routing messages. When the kernel cannot write all the messages intothe recipients route socket, it will set the desync flag, and the daemon has to read t

ospf6d only needs AF_INET6 route messages

can someone confirm that ospf6d still works with this change? oks? (benno_ospf6d_kroute.diff) diff --git usr.sbin/ospf6d/kroute.c usr.sbin/ospf6d/kroute.c index 58e4f72f287..df7d56f09dd 100644 --- usr.sbin/ospf6d/kroute.c +++ usr.sbin/ospf6d/kroute.c @@ -102,7 +102,7 @@ kr_init(int fs) k

Re: ospfd: depend on interface (new feature)

Remi Locherer(remi.loche...@relo.ch) on 2018.02.04 00:42:22 +0100: > Hi > > This adds a new feature to ospfd: depend on interface. > > A ospfd.conf using it looks like this: > > --%<-- > redistribute default depend on carp0 > area 0.0.0.0 { > interface em2 { depend on carp0 } > [...]

[no subject]

Hi, this removes the currently unused arguments *warnmess and ratecap from pool_sethardlimit(). ok? diff --git share/man/man9/pool.9 share/man/man9/pool.9 index 75742cf12ab..27226e14a25 100644 --- share/man/man9/pool.9 +++ share/man/man9/pool.9 @@ -72,8 +72,6 @@ .Fo pool_sethardlimit .Fa "str

Re: ksh: open HISTFILE only if set

Jeremie Courreges-Anglas(j...@wxcvbn.org) on 2018.01.15 21:45:56 +0100: > > This quirk has been there since rev 1.1: if HISTFILE isn't set, str_val > should return null, not NULL. Since the check against NULL fails we try > to open("", ...), which of course fails. > > ok? ok > Index: history.c

Re: inteldrm(4) tests needed

Mark Kettenis(mark.kette...@xs4all.nl) on 2018.01.15 01:02:58 +0100: > The diff below adopts more of the Linux code to manage i2c > transactions on hardware supported by inteldrm(4). The i2c stuff is > reponsible for detecting panels and monitors, so it is somewhat > important that this works righ

Re: httpd response mimetype bug

Hiltjo Posthuma(hil...@codemadness.org) on 2018.01.13 13:08:38 +0100: > On Sat, Jan 13, 2018 at 09:39:44AM +0100, Anton Lindqvist wrote: > > On Tue, Jan 09, 2018 at 05:38:57PM +0100, Hidv?gi G?bor wrote: > > > >Synopsis: httpd reports wrong mimetype when item is in the browser cache > > > >Category

Re: ksh: Update comments

commited, thanks Klemens Nanni(k...@posteo.org) on 2018.01.08 23:13:39 +0100: > There were left behind in the recent unifdef JOB commit. > > diff --git a/bin/ksh/jobs.c b/bin/ksh/jobs.c > index c2742ebf72c..7f528f7e68d 100644 > --- a/bin/ksh/jobs.c > +++ b/bin/ksh/jobs.c > @@ -921,7 +921,7 @@ j_a

Re: relayd stops processing traffic intermittently

ok Claudio Jeker(cje...@diehard.n-r-g.com) on 2017.12.28 14:21:27 +0100: > Forwarding to tech, since people may have missed this. > Hope to commit this soon. > > - Forwarded message from Claudio Jeker - > > Date: Sun, 24 Dec 2017 19:07:11 +0100 > From: Claudio Jeker > To: Mischa Peters

Re: w: don't print any header with -h

Martijn van Duren(openbsd+t...@list.imperialat.at) on 2017.12.14 14:03:24 +0100: > On 12/14/17 13:56, Jasper Lievisse Adriaanse wrote: > > On Thu, Dec 14, 2017 at 01:35:18PM +0100, Martijn van Duren wrote: > >> Hello Jasper, > >> > >> On 12/14/17 13:22, Jasper Lievisse Adriaanse wrote: > >>> Hi, >

Re: w: don't print any header with -h

ok Jasper Lievisse Adriaanse(jas...@openbsd.org) on 2017.12.14 13:22:48 +0100: > Hi, > > currently w(1) on OpenBSD differs from other implementations > (GNU/Darwin/FreeBSD/SmartOS) in that 'w -h' does print the > 'USER TTY FROM ...' header whereas the others don't. > > Is there a specific reason

httpd: send location: header for 307 and 308 status codes

308 and 307 are the new 301 and 302 HTTP Status Codes: https://tools.ietf.org/html/rfc7538 https://tools.ietf.org/html/rfc7231#section-6.4.7 ... The server SHOULD generate a Location header field ([RFC7231], Section 7.1.2) in the response containing a preferred URI reference ... ok

TL-WN722N usb ids and attach as urtwn(4)

Dec 13 23:49:08 blap /bsd: urtwn0 at uhub0 port 1 configuration 1 interface 0 "Realtek 802.11n NIC" rev 2.00/0.00 addr 4 Dec 13 23:49:08 blap /bsd: urtwn0: MAC/BB RTL8188EU, RF 6052 1T1R, address and i am writing this mail using this device. ok? (benno_urtwn_tl-wn722n.diff) diff --git share/

Re: background scan for iwn(4)

Stefan Sperling(s...@stsp.name) on 2017.12.13 17:17:41 +0100: > Since nobody is reporting problems with iwm(4), I took some time to write the > corresponding diff for iwn(4) as well. I hope this increases test coverage :) > > Works for me on: > iwn0 at pci3 dev 0 function 0 "Intel Centrino Advance

Re: dc: strdup -> bstrdup

Michael W. Bombardieri(m...@ii.net) on 2017.12.06 16:58:27 +0800: > Hello, > > Mostly dc(1) uses its own bstrdup() which exits on error. > It can be used in two more places. i like to read if ((a = strdup(b)) == NULL) err(1, NULL); much more than start looking what bstrdup() does... b

Re: pf neighbor discovery hop limit

Alexander Bluhm(alexander.bl...@gmx.net) on 2017.12.04 14:55:16 +0100: > Hi, > > RFC 4861 requires that all neighbor discovery packets have 255 in > their IPv6 header hop limit field. Let pf drop neighbor solicitation, > neighbor advertisement, router solicitation, router advertisement, > and red

Re: mess with regression tests

Sergey Bronnikov(serg...@bronevichok.ru) on 2017.12.02 15:31:21 +0300: > Hello, > > openbsd has a regression testuite in a base tree. Testset for each > component is in a separate directory, Makefiles for each testsuite uses > bsd.regress.mk framework and connected to the root Makefile. So it is >

Re: relayd/ctl alternative control socket

Kapetanakis Giannis(bil...@edu.physics.uoc.gr) on 2017.11.29 11:40:41 +0200: > On 28/11/17 17:06, Sebastian benoit wrote: > > Hi, > > > > your diff looks good, but i would rather do it the way bgpd/bgpctl do it: > > > > there the default is? /var/run/bgpd.sock.

Re: relayd/ctl alternative control socket

Hi, your diff looks good, but i would rather do it the way bgpd/bgpctl do it: there the default is /var/run/bgpd.sock. where is the routing domain bgpctl is running in. To administer bgpd(8) in a different routing domain, run bgpctl in said routing domain. i.e. it detects the rdomain at s

change auto-allocation for /usr/src

Hi, 1G is too smallto hold a cvs checkout, its 1.1G right now. ok? (benno_disklabel_editor) Index: editor.c === RCS file: /cvs/src/sbin/disklabel/editor.c,v retrieving revision 1.308 diff -u -p -r1.308 editor.c --- editor.c

Re: diff for ssh/sftp/scp -j

Holger Mikolon(hol...@mikolon.com) on 2017.11.25 23:16:54 +0100: > Hi tech@ > > at work I can ssh (hence cvs) to public servers only via a ProxyCommand > specified in /etc/ssh/ssh_config. > > However, with the ProxyCommand set I cannot ssh into servers in the > internal network. So I end up chang

relayd status code handling

Hi, relayd enforces a rule in rfc section 3.3.2: rfc 7230 3.3 Message Body All 1xx (Informational), 204 (No Content), and 304 (Not Modified) responses do not include a message body. All other responses do include a message body, although the body might be of zero length. rfc 7230 3.3.

ifconfig gif0 deletetunnel is different

ifconfig deletetunnel is different from other ifconfig commands, as others have options "something" and "-something". Here i add "-tunnel" and keep "deletetunnel", but undocumented to be removed 2 releases hence. I would update current.html with this. ok? (benno_ifconfig_tunnel2.diff) diff --

Re: hide wpakey from root by default

Stefan Sperling(s...@stsp.name) on 2017.11.17 11:41:57 +0100: > There have been several instances of people mailing out WPA keys as > part of ifconfig output, e.g. in bug reports. This happens when you > run ifconfig as root and copy/paste without thinking. > > I see no real need to ever show the

Re: netintro.4: sync struct ifreq with if.h

ok Theo Buehler(t...@theobuehler.org) on 2017.11.16 12:12:55 +0100: > ifr_vnetid is now a proper member of struct ifreq and is no longer > overloaded with ifr_metric. Moreover, ifr_index and ifr_llprio were > missing and mandoc -Tlint complained about a "useless macro: Tn". > > ok? > > Index: s

Re: maximum size of http headers in relayd

Alexander Bluhm(alexander.bl...@gmx.net) on 2017.11.16 14:05:43 +0100: > On Wed, Nov 15, 2017 at 08:15:15PM +0100, Sebastian Benoit wrote: > > Thanks, here is a diff on top of the last to check that. > > > > If you manage to set the default headerlen on non http protocols,

Re: iked: fixup config reload for ocsp

Patrick Wildt(patr...@blueri.se) on 2017.11.15 13:31:48 +0100: > Hi, > > when basic OCSP support was committed in 2014, a bit of code was > forgotten that resets the OCSP URL back to NULL on config reload. > Otherwise we end up not being able to disable OCSP with a config > change and reload. > >

Re: maximum size of http headers in relayd

Alexander Bluhm(alexander.bl...@gmx.net) on 2017.11.15 18:08:07 +0100: > On Tue, Nov 14, 2017 at 06:15:05PM +0100, Sebastian Benoit wrote: > > +.It Ic http Ar option > > +Set the HTTP options and session settings. > > +This is only used if HTTP is enabled in the relay. > &

Re: maximum size of http headers in relayd

rediff, i fixed the two lines that were too long. Sebastian Benoit(be...@openbsd.org) on 2017.11.14 18:01:26 +0100: > Currently relayd limits the size of all http headers to > RELAY_MAXHEADERLENGTH = 8192. > > Current webbrowsers support for example as default > > httpd: 8k &

maximum size of http headers in relayd

Currently relayd limits the size of all http headers to RELAY_MAXHEADERLENGTH = 8192. Current webbrowsers support for example as default httpd: 8k Apache: 8190 byte per header line, 100 header nginx: 32k (max 8k per line) iis: 16k per line Tomcat: 8k All except httpd are configurable and headers

Re: README patch

Jason McIntyre(j...@kerhand.co.uk) on 2017.11.09 19:45:53 +: > On Thu, Nov 09, 2017 at 08:42:32PM +0100, Ingo Schwarze wrote: > > Hi, > > > > Jason McIntyre wrote on Thu, Nov 09, 2017 at 07:26:32PM +: > > > On Wed, Nov 08, 2017 at 08:14:24PM -0600, Edgar Pettijohn wrote: > > > > >> --- RE

Re: netinet DPRINTF

ok! Martin Pieuchot(m...@openbsd.org) on 2017.11.06 14:06:58 +0100: > I'm auditing code related to pr_input() to take them outside of the > KERNEL_LOCK(). It's hard because many DPRINTF() statements include > the name of the function they are in. Diff below convert most of > them to "%s" + __fun

ifconfig tunnel: replace deletetunnel with -tunnel

most options use -something to undo something, do that for tunnel as well. makes the manpage nicer too. keep the deletetunnel option for two releases. If commited i will mention this in current.html. I dont think it will cause problems on boot because i dont expect the "deletetunnel" to be used

ifconfig giftunnel was deprecated in 2001

ok? Index: ifconfig.c === RCS file: /cvs/src/sbin/ifconfig/ifconfig.c,v retrieving revision 1.349 diff -u -p -r1.349 ifconfig.c --- ifconfig.c 30 Oct 2017 10:04:07 - 1.349 +++ ifconfig.c 5 Nov 2017 20:06:57 - @@ -424,8

Re: forbid config reloads in ospf6d

yep, ok Jeremie Courreges-Anglas(j...@wxcvbn.org) on 2017.11.05 15:50:42 +0100: > > ospf6d consistently fails when I ask it to reload its config, even > though I have a very basic test setup: > > area 0.0.0.0 { > interface em0 { passive } > interface vether0 > } > > Fixing ospf

Re: nsd(8): make ip-transparent option work on OpenBSD

ok Florian Obser(flor...@openbsd.org) on 2017.11.01 12:17:44 +0100: > OK? > > diff --git server.c server.c > index c0835ce8c11..fe74f9a1b56 100644 > --- server.c > +++ server.c > @@ -567,7 +567,7 @@ server_init_ifs(struct nsd *nsd, size_t from, size_t to, > int* reuseport_works) > { > str

Re: unbound(8): make ip-transparent option work on OpenBSD

ok benno@ Florian Obser(flor...@openbsd.org) on 2017.11.01 12:00:45 +0100: > This is useful on systems where IP addresses are dynamically > configured (dhclient(8), slaacd(8)) and are not yet up when unbound > starts. > > To quote the man page: > >ip-transparent: > If yes,

Re: ksh: remove the deprecated emacs-usemeta option

Jeremie Courreges-Anglas(j...@wxcvbn.org) on 2017.10.18 22:16:48 +0200: > > This would make ''set -o emacs-usemeta'' a fatal error, which means that > subsequent lines in your kshrc will not be run. I think people were > given enough time to cope with this (6.2 users get a warning). > > ok? no

Re: ksh: skip long history lines

Jeremie Courreges-Anglas(j...@wxcvbn.org) on 2017.10.19 00:22:51 +0200: > > Hi Ori, > > thanks for your feedback. Reply and updated diff below, > > On Wed, Oct 18 2017, Ori Bernstein wrote: > > On Wed, 18 Oct 2017 22:33:51 +0200 > > Jeremie Courreges-Anglas wrote: > > > >> > >> It would be n

Re: ksh: extra rewind call

Jeremie Courreges-Anglas(j...@wxcvbn.org) on 2017.10.19 00:36:00 +0200: > > This call was added along with the magic check, but it not actually > needed: history_load already calls rewind(3). I feel like the magic > check should also be in history_load(), so that a ksh process can > recover at ru

Re: fix memory handling in acme-client config parser

sure ok benno@ Jonathan Gray(j...@jsg.id.au) on 2017.10.19 16:33:35 +1100: > Use after free and a memory leak. > > Index: parse.y > === > RCS file: /cvs/src/usr.sbin/acme-client/parse.y,v > retrieving revision 1.17 > diff -u -p -U4 -

Re: uninitialised variable crashes in bgpd config parser

ok benno@ Jonathan Gray(j...@jsg.id.au) on 2017.10.19 16:34:35 +1100: > Index: parse.y > === > RCS file: /cvs/src/usr.sbin/bgpd/parse.y,v > retrieving revision 1.315 > diff -u -p -r1.315 parse.y > --- parse.y 21 Aug 2017 14:41:22 -0

Re: Installer support to fetch/verify bsd.rd for release upgrade

Robert Peichaer(rob...@peichaer.org) on 2017.10.08 09:56:15 +: > Up to now, the upgrade procedure from one to the next release meant > that you had to manually download and verify the new ramdisk kernel. > > What about if you just needed to boot into the existing bsd.rd and > it would support

Re: inetd & ipv4-compatible ipv6 addresses

Jeremie Courreges-Anglas(j...@wxcvbn.org) on 2017.10.04 22:02:55 +0200: > > We don't and won't support this, so let's not even try. > > ok? > > > Index: inetd.c > === > RCS file: /cvs/src/usr.sbin/inetd/inetd.c,v > retrieving revis

Re: inetd: kill a few unsupported socket types

ok benno@ Jeremie Courreges-Anglas(j...@wxcvbn.org) on 2017.10.04 21:19:18 +0200: > > In my tests, only SOCK_STREAM and SOCK_DGRAM effectively work (even > seqpacket on a unix socket is broken), so kill the others. We don't > even have SOCK_RDM support. > > ok? > > > Index: inetd.8 >

Re: [patch] exiting bgplgsh with ^D

Jeremie Courreges-Anglas(j...@wxcvbn.org) on 2017.10.04 20:25:26 +0200: > On Wed, Oct 04 2017, Denis Fondras wrote: > > Hi, > > > > Here is a patch to make ^D (CTRL-D) escape from bgplgsh instead of > > displaying > > help. > > This makes sense, but I'm wondering if this changes anything when >

Re: [patch bgpd] Remove unused argument

ok benno@ *peer_l was needed until revision 1.42 in 2005. Denis Fondras(de...@openbsd.org) on 2017.10.03 20:56:19 +0200: > Hi, > > The "struct peer" input of merge_config() is never used. > Here is a patch to remove it. > > Denis > > Index: config.c > ==

Re: relayd http read line

Alexander Bluhm(alexander.bl...@gmx.net) on 2017.09.22 19:54:56 +0200: > Hi, > > The relayd regression tests for chunked http traffic fail sometimes. > Ktrace reveals that this happens when the \r and \n at the end of > a header line are read in separate chunks. Then evbuffer_readline() > interpr

Re: slaacd(8), mention that it's a client, hint at rtadvd

Stuart Henderson(s...@spacehopper.org) on 2017.09.13 12:27:40 +0100: > A user knowing that they want to provide services for slaac on > a network might do 'man -k slaac' and from the title and at least a > quick read of the manual it's not clear that this is the client side. > > I think it would b

Re: don't spam console with pflogd exiting messages, misc cleanup

Bryan Steele(bry...@openbsd.org) on 2017.09.05 16:17:46 -0400: > pflogd(8) currently spams the console on shutdown if syslogd wins the > race to die, this logging probably comes from the fact that pflogd was > largely based on syslogd. i looked at that some time ago: a and found that lot of our da

Re: diff: pledge snmpd

ok with 2 comments below Rob Pierce(r...@2keys.ca) on 2017.08.11 16:35:21 -0400: > The following diff pledges two of three processes in snmpd: the parent snmpd > process and the trap handler. We cannot currently pledge snmpe as snmp > requests > asking for privileged kernel info are disallowed by

pfctl -N: no dns resolution

Hi, this adds a -N option to pfctl that turns of dns resolution for all the things where a dns entry is a possible thing, i.e. in rules ("pass in from www.openbsd.org") or table entries. Its usefull to make sure the configuration will load when DNS is not available. ok? diff --git regress/sbin

Re: ifstated: improve routing socket error handling

Rob Pierce(r...@2keys.ca) on 2017.08.06 00:04:46 -0400: > Improve error checking during processing of routing messages. Handling of > RTM_DESYNC encouraged by deraadt. Regression tests pass. > > I have another diff ready to go that handles interface depature, but I thought > it best to separate th

Re: netstat: uint32_t is never < 0

Florian Obser(flor...@openbsd.org) on 2017.07.27 19:48:24 +: > /usr/src/usr.bin/netstat/inet.c:342:19: warning: comparison of unsigned > expression < 0 is always false [-Wtautological-compare] > if (kf->t_state < 0 || kf->t_state >= TCP_NSTATES) >

Re: bgplg: an array is never NULL

Florian Obser(flor...@openbsd.org) on 2017.07.27 19:51:38 +: > ... pointed out by clang > > OK? ok benno@ > diff --git usr.bin/bgplg/misc.c usr.bin/bgplg/misc.c > index 38837cc88c8..1834f38fa0d 100644 > --- usr.bin/bgplg/misc.c > +++ usr.bin/bgplg/misc.c > @@ -51,7 +51,7 @@ lg_checkperm(str

Re: [patch/route] Allow short commands

Denis Fondras(open...@ledeuns.net) on 2017.07.26 18:42:13 +0200: > Hi, > > I use route(8) a lot and I thought being able to use shorter commands/keywords > could be nice. Like : > > route a default 192.0.2.1 > route del default > > Regards, > Denis This will lead to usage and documentation issu

Re: em link state change

wow, and ok benno@ Alexander Bluhm(alexander.bl...@gmx.net) on 2017.07.25 18:07:19 +0200: > Hi, > > The LINK_STATE_IS_UP() macro considers LINK_STATE_UNKNOWN as up. > So the em driver never gets out of that state. The change was in > sys/net/if.h > > revision 1.123 > date: 2011/07/03 17:41:50;

Re: pflogd: cope with interface departure

Jeremie Courreges-Anglas(j...@wxcvbn.org) on 2017.07.22 21:40:53 +0200: > > If you destroy the interface pflogd(8) listens on, you get killed > because socket(2) is denied by the current pledge(2) restrictions: > > pflogd(15868): syscall 97 "inet" > > The ioctl(SIOCGIFDATA) call would be fatal

Re: simple ifstated pledge

ok benno@ Jeremie Courreges-Anglas(j...@wxcvbn.org) on 2017.07.23 02:10:35 +0200: > On Sat, Jul 22 2017, Rob Pierce wrote: > > On Sun, Jul 23, 2017 at 12:26:53AM +0200, Jeremie Courreges-Anglas wrote: > >> On Sat, Jul 22 2017, Rob Pierce wrote: > >> > With the most recent commit ifstated can no

Re: [patch] ospfd: exporting default gateway via route label (fix ROUNDUP)

Florian Riehm(m...@friehm.de) on 2017.07.21 15:42:21 +0200: > On 03/03/14 00:33, Florian Riehm wrote: > > Hi all, > > > > ospfd can't export the default gateway via route label because > > get_rtaddrs gets confused by a netmask (RTAX_NETMASK) of 0 because > > sa->sa_len in get_rtaddrs is 0 and ROU

Re: add simple ifstated regression test script

Hi, i wanted to commit this, but saw that it does not have a licence yet. Can i add /usr/share/misc/license.template with your name and email-Adress? /Benno Rob Pierce(r...@2keys.ca) on 2017.07.06 13:12:26 -0400: > On Sun, Jul 02, 2017 at 06:29:07PM +0200, Sebastian Benoit wrote: >

Re: relayd ipv6 ttl check_icmp / check_tcp

Jeremie Courreges-Anglas(j...@wxcvbn.org) on 2017.07.12 21:00:44 +0200: > Jeremie Courreges-Anglas writes: > > > Kapetanakis Giannis writes: > > > >> On 10/07/17 17:22, Jeremie Courreges-Anglas wrote: > >>> Using -1 for IPV6_UNICAST_HOPS is correct. > >>> > >>> Note that you can also use -1 for

Re: rtadvd: use log_warnx when errno is not set

Florian Obser(flor...@openbsd.org) on 2017.07.11 19:30:37 +: > > OK? yes > diff --git if.c if.c > index 95f83d8e822..cc878bd5916 100644 > --- if.c > +++ if.c > @@ -435,7 +435,7 @@ parse_iflist(struct if_msghdr ***ifmlist_p, char *buf, > size_t bufsize) > lim = buf + bufsize; >

Re: rtadvd: use fatalx like normal people

ok with one question. Florian Obser(flor...@openbsd.org) on 2017.07.11 19:29:44 +: > replace > log_warnx("foo"): > exit(1); > with >fatalx("foo): > > OK? > > diff --git config.c config.c > index 85d14efedca..e6f48fffec7 100644 > --- config.c > +++ config.c > @@ -85,9 +85,8 @@ get

Re: rtadvd: don't clobber errno

ok Florian Obser(flor...@openbsd.org) on 2017.07.11 19:25:58 +: > ... we want to log_warn what went wrong. > OK? > > diff --git if.c if.c > index 4683bcffac9..c4a4fea1984 100644 > --- if.c > +++ if.c > @@ -111,7 +111,7 @@ if_nametosdl(char *name) > int > if_getmtu(char *name) > { > - i

Re: rtadvd: format strings for fatal{x,}

Florian Obser(flor...@openbsd.org) on 2017.07.11 19:27:54 +: > from bgpd. > > OK? ok > benno, is this the right way to do it? I kinda lost track on your > log merging efforts... yes thats ok. I neglected rtadvd a bit. > diff --git log.c log.c > index 357ef35b79c..08afcebcac0 100644 > ---

Re: ifstated diff rename variables to avoid state confusion

Rob Pierce(r...@2keys.ca) on 2017.07.04 07:34:27 -0400: > On Mon, Jul 03, 2017 at 04:24:30PM -0400, Rob Pierce wrote: > > ifstated monitors interface state and the return state of invoked commands, > > and takes action accordingly, all of which is managed with the help of a > > finite state machine

Re: relayd ipv6 ttl check_icmp / check_tcp

Florian Obser(flor...@openbsd.org) on 2017.07.04 19:27:15 +: > On Fri, Jun 23, 2017 at 01:52:52PM +0300, Kapetanakis Giannis wrote: > > Hi, > > > > Using relayd's redirect/forward on ipv6 addresses I discovered problems > > relating to setting TTL. > > > > There is no check for address famil

Re: ifstated readability diff

commited, thanks. Rob Pierce(r...@2keys.ca) on 2017.07.03 09:45:35 -0400: > On Sun, Jul 02, 2017 at 11:50:56PM -0400, Rob Pierce wrote: > > Remove obvious clear_config() comments and misleading state_change() > > comments. > > > > Also relocate do_action() calls for the init block from change_st

Re: add simple ifstated regression test script

Rob Pierce(r...@2keys.ca) on 2017.07.02 12:06:25 -0400: > I am currently using this regression script for basic ifstated sanity testing. > > Still a work in progress. Requesting commit for safe keeping. Hi, this should go into /usr/src/regress/usr.sbin/ifstated (which does not esist yet). Also

Re: ifstated unused variable

Thanks, i commited all three. /Benno Rob Pierce(r...@2keys.ca) on 2017.07.02 00:32:27 -0400: > Remove unused variable from header file. > > Index: ifstated.h > === > RCS file: /cvs/src/usr.sbin/ifstated/ifstated.h,v > retrieving rev

Re: netstat(1) print PID for sockets.

Sebastian Benoit(be...@openbsd.org) on 2017.07.01 20:40:17 +0200: > Sebastian Benoit(be...@openbsd.org) on 2017.07.01 16:44:14 +0200: > > This makes netstat show only listening sockets for tcp sockets > > when invoked as netstat -l. > > > > With it "netstat -l

netstat(1) print PID for sockets.

Sebastian Benoit(be...@openbsd.org) on 2017.07.01 16:44:14 +0200: > This makes netstat show only listening sockets for tcp sockets > when invoked as netstat -l. > > With it "netstat -l -finet -p tcp" is equivalent to > "netstat -a -finet | grep LISTEN" >

netstat(1) show only listening sockets

This makes netstat show only listening sockets for tcp sockets when invoked as netstat -l. With it "netstat -l -finet -p tcp" is equivalent to "netstat -a -finet | grep LISTEN" I (re)used -l because Linux has the same option. FreeBSD does not have -l, but it does not error out when invoked with

Re: remove errant ifstated whitespace

commited, thx Rob Pierce(r...@2keys.ca) on 2017.06.27 21:33:06 -0400: > > Index: ifstated.c > === > RCS file: /cvs/src/usr.sbin/ifstated/ifstated.c,v > retrieving revision 1.43 > diff -u -p -r1.43 ifstated.c > --- ifstated.c2

Re: [PATCH] bin: Add -v option to cp(1), mv(1), rm(1)

3 lines are longer than 80 chars. otherwise ok benno@ Job Snijders(j...@instituut.net) on 2017.06.27 11:00:55 +0200: > Dear all, > > This patch adds a '-v' option to cp(1), mv(1), and rm(1). If the '-v' > option is used, the utility will display the name of each file after it > has been successf

Re: ifstated.c hoist code in prep for future work

commited with the (int)(long)arg cast. Thanks! (waiting for more...) /Benno Rob Pierce(r...@2keys.ca) on 2017.06.27 12:45:43 -0400: > Hoist some privileged code in preparation for future work. > > Is this the correct use of intptr_t? > > Based on an approach in vmd with mc146818/ns8250. > > N

Re: [PATCH 2/3] openbgpd: Add support for 'unknown' well-known communities

ok as wor the WELLKNOWN, what do other implementations do? If others print it or accept it as input, lets keep it. If not, remove it from both your diff and bgpctls output. /Benno Job Snijders(j...@instituut.net) on 2017.06.25 14:59:21 +0200: > Small update. > > I renamed the 'msb' argument ('m

Re: [PATCH 3/3] openbgpd: Add well-known community GRACEFUL_SHUTDOWN

ok Job Snijders(j...@instituut.net) on 2017.06.23 16:02:13 +0200: > Dear team, > > This patch adds support for the "graceful shutdown" well-known > community as described in draft-ietf-grow-bgp-gshut. > > An example implementation would be to add the following to your > bgpd.conf: > > matc

Re: make it easier to configure IPv6 on gif(4)

ok Stefan Sperling(s...@stsp.name) on 2017.06.24 07:09:20 +0200: > The kernel rejects IPv6 destination addresses on point-to-point > interfaces if the prefixlen is not 128. Because ifconfig defaults > to prefixlen 64, configuring IPv6 on e.g. gif(4) requires an > explicit prefix length, for instan

Re: update logging in ifstated

Rob Pierce(r...@2keys.ca) on 2017.06.13 19:12:18 -0400: > On Tue, Jun 13, 2017 at 08:44:46AM +0200, Sebastian Benoit wrote: > > Rob Pierce(r...@2keys.ca) on 2017.06.11 18:04:31 -0400: > > > This minimizes differences with the latest log.c. > > > > > > I was

Re: update logging in ifstated

Rob Pierce(r...@2keys.ca) on 2017.06.11 18:04:31 -0400: > This minimizes differences with the latest log.c. > > I was not sure how to handle verbosity, as the current implementation is > verbose by default in debug mode. The diff below requires actually > requesting (double) verbosity on the comma

Re: ifconfig.8 doco for vnetid and parent options

Claudio Jeker(cje...@diehard.n-r-g.com) on 2017.06.07 16:05:15 +0200: > Be careful, AFAIK the capitalisation of IEEE standards does matter. > You're right 802.1Q is the correct spelling but not for 802.1ad (where the > lowercase version is the offical standard). IIRC the status of the > standard is

Re: rework bgpd ext community and support origin validation state

Claudio Jeker(cje...@diehard.n-r-g.com) on 2017.05.31 00:27:21 +0200: > After looking at what IETF and IANA did to extended communities I decided > to refactor the code a major bit and hopefully that will work a bit better > than what we had before. When I implemented it first I foolishliy assumed

Re: remove vlan(4) specific ifconfig output

ok David Gwynne(da...@gwynne.id.au) on 2017.05.31 15:34:53 +1000: > the vlan specific output is redundant because vlan supports the > generic vnetid and parent ioctls now. > > this leaves the code for setting vlan specific stuff because there's > a slight semantic change i want to discuss separat

Re: Properly serialize pflow's sc_outputqueue

this is basically the code i had before mpi told me that mq_ was not needed. *sigh* ok. Visa Hankala(v...@openbsd.org) on 2017.05.30 16:19:46 +: > On Wed, May 31, 2017 at 01:52:31AM +1000, Jonathan Matthew wrote: > > On Tue, May 30, 2017 at 01:04:07PM +, Visa Hankala wrote: > > > Index:

id -R: getrtable

add option -R for printing the routing table id is running under ok? diff --git usr.bin/id/id.1 usr.bin/id/id.1 index 35728ee53ee..c5727927bc6 100644 --- usr.bin/id/id.1 +++ usr.bin/id/id.1 @@ -55,6 +55,8 @@ .Fl p .Op Ar user .Nm id +.Fl R +.Nm id .Fl u Op Fl nr .Op Ar user .Sh DESCRIPTION

Re: shorten ifconfig output for vnetids and parent interfaces

David Gwynne(da...@gwynne.id.au) on 2017.05.29 15:34:51 +1000: > this rolls vnetid and parent into a single encap line in ifconfig. > > eg: > > - vnetid: 7 > - parent: ix1 > + encap: vnetid: 7 parent: ix1 > > after this i would like to get rid of the vlan compat goo. > > ok?

Re: [PATCH] ntpd: allow to specify a source IP address for outgoing queries

> "servers ntp.ring.nlnog.net \ > local-address 165.254.255.27,2001:728:1808::26" yes > > or allow one to repeat the 'local-address' keyword: > > "servers ntp.ring.nlnog.net \ > local-address 165.254.255.27 \ > local-address 2001:728:1808::26" > > or use differe

Re: bgpd on other rdomains

Peter Hessler(phess...@theapt.org) on 2017.05.28 20:56:39 +0200: > looks fine to me, OK > > > On 2017 May 28 (Sun) at 19:12:34 +0200 (+0200), Sebastian Benoit wrote: > :Hi, > : > :testing hennigs diff i found having to specify the socket on the command > :line annoying:

bgpd on other rdomains

Hi, testing hennigs diff i found having to specify the socket on the command line annoying: bgpctl -s /var/run/rdomain123.bgpd.sock sh rib srly? I figure when you are debuging things in rdomain , you will want to route -T exec ksh anyway, so this makes bgpd create /var/run/bgpd.sock. when r

Re: Fix carp balancing ip-stealth

ok benno@ Florian Riehm(m...@friehm.de) on 2017.05.27 10:15:45 +0200: > Hi, > > This patch fixes the carp mode 'balancing ip-stealth'. > > Problem: > System A > carp1: flags=8843 mtu 1500 > lladdr 00:00:5e:00:01:01 > description: Carp-intern > index 7 priority 15 llprio 3

Re: relayd: use __func__ in log messages

thanks for both this and your httpd diff, both commited. Hiltjo Posthuma(hil...@codemadness.org) on 2017.05.07 20:56:25 +0200: > Hey, > > This replaces the prefix in log messages to __func__. Some older code had > the prefix still set to another name. Patch below: > > > diff --git a/usr.sbin/re

Re: warn on duplicate network statements

Sebastian Benoit(be...@openbsd.org) on 2017.05.27 18:35:06 +0200: > > in a bgpd.conf config with > > network 2a00:15a8:6:100::/56 set ext-community soo 23:42 > network 2a00:15a8:6:100::/56 > > the second line "overwrites" the first line. > > this prints a

warn on duplicate network statements

in a bgpd.conf config with network 2a00:15a8:6:100::/56 set ext-community soo 23:42 network 2a00:15a8:6:100::/56 the second line "overwrites" the first line. this prints a warning, because i wasted 30 minutes wondering why i could not see the community on the wire... ok? (benno_bgpd_parse_dup

Re: [bgpd] enforce local-as no

reads ok and yes on sthens suggestion Peter Hessler(phess...@openbsd.org) on 2017.05.27 14:50:25 +0200: > Allow us to receive our own AS paths from a neighbor. > > Like several of the related diffs, this also invites dragons and grues > into your network. > > Probably needs the most love in th

<    1   2   3   4   5   6   7   8   >