Sergey Bronnikov([email protected]) on 2017.12.02 15:31:21 +0300: > Hello, > > openbsd has a regression testuite in a base tree. Testset for each > component is in a separate directory, Makefiles for each testsuite uses > bsd.regress.mk framework and connected to the root Makefile. So it is > easy to run overall testsuite with 'make regress'. > > But tests for some utilities are placed with sources and not linked to > Makefiles. Looks like it is dead, unusable code and broken tests.
mostly two reasons: (1) probably old like you describe. (2) imported code, updated regularly. Removing them makes updates harder. > It means that no one never run these tests. > I went through these abandoned tests: > > - bin/ed/test (1) > connected to the Makefile in a source directory, tests looks broken. > > - lib/libexpat/tests/ (2), but regress/lib/libexpat exists > tests requires external unit testing framework (check). > > - usr.bin/sed/TEST (1), but regress/usr.bin/sed/ exists > directory contains several tests, but there no infrustructure to run > them and files with expected results. Moreover the same tests are > present in regress/usr.bin/sed dir. > > - gnu/usr.bin/binutils/gdb/testsuite (2) > test suite requires dejagnu package from ports, it is not connected to > the Makefile in sources and tests have many fails (about a couple of > hundreds). > > - usr.bin/m4/TEST (2), but regress/usr.bin/m4/ exists > dir contains examples of m4 files not tests, > Makefile is absent. > > Similar situation with these tests: > > - gnu/usr.bin/gcc/gcc/testsuite (2), even if we dont update it anymore > - usr.bin/ctags/test > - lib/libssl/test previously (2) > - lib/libkeynote/testsuite > > Are there real reasons to keep these tests separately? the ones marked (2) should probably be kept, removing them makes the diff to upstream larger without any gain. For all of them, you are invited to submit new tests based on the regress/ framework or update existing ones if there are any.
