"evp_aead_ctx_st" missing ? when using "EVP_AEAD_CTX" functionality.

I get a "forward declaration of 'struct evp_aead_ctx_st'" message, trying to use the "EVP_AEAD_CTX" functions on: "OpenBSD 7.1 (GENERIC.MP) #448: Tue Mar 29 00:13:47 MDT 2022 dera...@amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/GENERIC.MP" Some definitions, e.g. "evp_aead_ctx_st", appear t

Re: libcrypto: recognize HW acceleration support on arm64

On 19-06-19 07:13, Patrick Wildt wrote: Hi, this diff adds the necessary helpers to arm64 so that libcrypto knows which of the hardware crypto features are available on the machine. Those helpers are used by the existing and matching armv7 code. ok? Patrick Does it make sense to query the I

Re: uaudio: fix detection of a bunch of logitech webcams

Now, i'm pretty sure i managed to properly test the device some days ago and record sound with it, but now i only manage to produce 68-bytes empty wav files, using 'aucat -f rsnd/1 -o /tmp/test.wav' after having ensured kern.audio.record was 1. Something is fishy Oks, testing & feedback welco

Re: uaudio: fix detection of a bunch of logitech webcams

@@ -1814,6 +1827,10 @@ sc->sc_audio_rev = UGETW(acdp->bcdADC); DPRINTFN(2,("%s: found AC header, vers=%03x, len=%d\n", __func__, sc->sc_audio_rev, aclen)); + + /* Some webcams descriptors advertise an off-by-one wTotalLength */ + if (sc->sc_quirks & UAU

Re: uaudio: fix logitech c310 integrated mic

If you don't find any better solution, I'd suggest using a device ID check rather than adding a quirk. Because such quirk cannot be generic. In that case you have an off-by-one, but another device might have a different problem. That was in the case we'd encounter other devices where the descri

Re: snapshot installs

Op 12/30/16 om 19:30 schreef Theo de Raadt: I'm wondering if anyone doing an install/upgrade has noticed any behaviour changes in the last week... There's a secret diff being tested :-) Tried an upgrade on a rarely used, roughly two months old, CURRENT system. Is it related to "wxallowed" ?

Re: [patch] daemon.3

Op 05/18/16 om 13:55 schreef Ingo Schwarze: Hi, Remco wrote on Wed, May 18, 2016 at 10:29:40AM +0200: Op 05/18/16 om 01:49 schreef Edgar Pettijohn: The wording made it hard for me to understand at first. The "unless" "non-zero" seem like double negatives. Actually

Re: [patch] daemon.3

Op 05/18/16 om 01:49 schreef Edgar Pettijohn: The wording made it hard for me to understand at first. The "unless" "non-zero" seem like double negatives. Index: daemon.3 === RCS file: /cvs/src/lib/libc/gen/daemon.3,v retrieving re

[PATCH]: remove references to "outlen" from tls_init.3.

Index: tls_init.3 === RCS file: /cvs/src/lib/libtls/tls_init.3,v retrieving revision 1.54 diff -u -p -u -r1.54 tls_init.3 --- tls_init.3 9 Nov 2015 17:52:07 - 1.54 +++ tls_init.3 23 Apr 2016 09:37:02 - @@ -550,8 +550,7

[PATCH]: bsd.port.mk.5, capitalise the 'k' in PACkAGE_REPOSITORY

Index: bsd.port.mk.5 === RCS file: /cvs/src/share/man/man5/bsd.port.mk.5,v retrieving revision 1.426 diff -u -p -u -r1.426 bsd.port.mk.5 --- bsd.port.mk.5 23 Sep 2015 01:38:36 - 1.426 +++ bsd.port.mk.5 12 Oct 2015

Re: tame userland diff

ctually need exec ?". I understand now that this takes more time and isn't ready yet. Thanks, Remco

Re: tame userland diff

Sebastien Marie wrote: > Just a remark about "proc" request. It won't allow calling exec(2), but > only fork(2) (and some others, see the man page for details). > > exec(2) is really special for a tamed program: allowing it could permit > to defeat the purpose of tame. > I'm trying to understan

Re: faq: remove references to aucat -M option

Alexandre Ratchov wrote: > The -M option of aucat was removed long time ago, and as we're at > it mention about softsynths. > > OK? > > +The later are handly for testing the hardware, bypassing most software Did you mean ... latter are handy ... ?

httpd directory listing not properly encoded.

I think that the directory listing generated by httpd doesn't properly encode strings that are taken from C-variables. (function "server_file_index" in server_file.c) e.g., filenames with spaces, or odd characters, produce non-functioning links. I used the following directory structure to test:

[PATCH]: smtpd makemap, remove superfluous fparseln delimiters.

This program uses fparseln's default delimiters, which can be replaced by NULL. WARNING: I only compiled with this patch applied, I didn't actually run the resulting binary. Index: makemap.c === RCS file: /cvs/src/usr.sbin/smtpd/ma

[PATCH]: fnmatch regress test, remove superfluous lines.

This patch depends on the "fparseln, make the '\0' character not-escapable." patch and was tested with that patch applied. With that patch applied the fparseln skips comments and therefore there's no need to do it separately in this program. Index: fnm_test.c ===

[PATCH]: fparseln, make the '\0' character not-escapable.

Using the fparseln function I wanted to disable the escape character (delim[0]). In my mind the '\0' character isn't really part of a C-string and could possibly be used for this purpose so I chose to set delim[0] to '\0', like: static const char delim[3] = { '\0', '\\', '#' }; ... line = fpars

[PATCH]: fparseln, remove nl variable.

Index: fparseln.c === RCS file: /cvs/src/lib/libutil/fparseln.c,v retrieving revision 1.7 diff -u -p -u -r1.7 fparseln.c --- fparseln.c 5 Dec 2012 23:20:06 - 1.7 +++ fparseln.c 24 Dec 2014 10:14:23 - @@ -71,7 +71,7 @@ f

Re: [PATCH]unused NULL check before calling free

Fritjof Bornebusch wrote: > Hi tech, > > there is an unnecessary NULL check before calling free. > > fritjof > > Index: xmalloc.c > === > RCS file: /cvs/src/usr.bin/rcs/xmalloc.c,v > retrieving revision 1.4 > diff -u -p -r1.4 xmall

Re: increase netcat's buffer...

Ted Unangst wrote: > On Mon, Jun 09, 2014 at 21:54, Theo de Raadt wrote: >>> > A better patch is probably the following which also increases the size >>> > of the buffer to at least 64k: >>> >>> Agreed. >> >> One thing to be aware of. That function is syncronous. It will read >> as much as it c

potential NULL pointer dereference in ifconfig.c

I think there is a potential NULL pointer dereference in ifconfig.c. (I'm not aware of this causing actual problems, I just spotted it by accident) Index: ifconfig.c === RCS file: /cvs/src/sbin/ifconfig/ifconfig.c,v retrieving revisio

follow up on uaudio revision 1.96.

tch doesn't seem to hurt my USB audio devices, though I don't think any of them hit this code path ... very briefly tested on OpenBSD 5.4) Lacking the problematic hardware myself, I don't know exactly what was fixed originally and what might break by changing someth

Re: d-link usb wifi device ids

frantisek holop wrote: Unless you include the code to make these devices work in your mail, I think you should send stuff like this to misc@. > hi there, > > after inserting this D-LINK DWA-125 rev A3 usb wifi, i get: > > ugen1 at uhub0 port 6 "Ralink 11n Adapter" rev 2.00/1.01 addr 5 > > whi

video.4 correction.

This should be more in line with the header. Index: video.4 === RCS file: /home/cvs/src/share/man/man4/video.4,v retrieving revision 1.9 diff -u -r1.9 video.4 --- video.4 29 Mar 2011 20:30:51 - 1.9 +++ video.4 27 Sep

missing bit in audio.4 ?

Index: audio.4 === RCS file: /home/cvs/src/share/man/man4/audio.4,v retrieving revision 1.62 diff -u -r1.62 audio.4 --- audio.4 15 Jul 2010 03:43:11 - 1.62 +++ audio.4 28 Aug 2013 07:22:57 - @@ -154,7 +154,7 @@ .V

Re: adduser: better locked password

Remco wrote: > Tobias Ulmer wrote: > >> Adding a user with a locked password is a deliberate action. >> Set the password to "*" to stop security(8) from >> complaining about the new user. >> > > I suppose this is about the "Set t

Re: adduser: better locked password

Tobias Ulmer wrote: > Adding a user with a locked password is a deliberate action. > Set the password to "*" to stop security(8) from > complaining about the new user. > I suppose this is about the "Set the password so that user cannot logon? (y/n) [n]:" question. AFAICT there are (

Re: set ifp->if_baudrate with IF_Gbps() / IF_Mbps()

It might be me not understanding this code, but is it correct that you appear to convert 10Mb numbers into 100Mb in several places ? e.g.: > Index: if_txp.c > === > RCS file: /cvs/src/sys/dev/pci/if_txp.c,v > retrieving revision 1.1

Re: Threads related SIGSEGV in random.c

Stefan Sperling wrote: > On Wed, Sep 19, 2012 at 10:37:09PM +0300, Alexey Suslikov wrote: >> Could you guide me how to rebuild/reinstall libc in a proper way? > > It's easy, just needs 11 steps. This is how I did it: > > 1) $ cd /usr/src/lib/libc > 2) edit files > 3) $ make obj > 4) $ make clean

Re: sndio: more cleanup + multiple devices support

On Wednesday 09 November 2011 22:39:44 Alexandre Ratchov wrote: > > sun, sun: or sun:0 for the device and all three of them will play > > sound. I'd expect only sun:0 to work. > > I agree, the number is mandatory. > Sorry for sending a patch on top of my previous patch but is something like this

Re: sndio: more cleanup + multiple devices support

Alexandre Ratchov wrote: > Initially aucat was designed to handle one device only so multiple > audio devices used to be supported simply by starting multiple aucat > processes (one per device), very simple. Then (~1.5 years ago) we > added support for multiple audio devices (ie multiple -f option

Re: A step towards support for Message Signaled Interrupts

Mark Kettenis wrote: > Index: pci.c > === > RCS file: /cvs/src/sys/dev/pci/pci.c,v > retrieving revision 1.89 > diff -u -p -r1.89 pci.c > --- pci.c 12 Apr 2011 20:29:35 - 1.89 > +++ pci.c 13 May 2011 21:05:11 - >

[PATCH]: mention -U as global position-independent parameter in aucat.1

Index: aucat.1 === RCS file: /cvs/src/usr.bin/aucat/aucat.1,v retrieving revision 1.73 diff -u -r1.73 aucat.1 --- aucat.1 31 Jul 2010 08:48:01 - 1.73 +++ aucat.1 2 Mar 2011 12:03:46 - @@ -294,7 +294,7 @@ .Pq Fl f

[libsndio]: remove superfluous 'return 0' statements

It seems to me that the following 'return 0' statements are unnecessary. This is just an observation, I didn't actually test-run the patch. Index: mio_rmidi.c === RCS file: /cvs/src/lib/libsndio/mio_rmidi.c,v retrieving revision 1.6

[MAKEDEV]: extra /dev/usb? needed ?

I 'm not 100% certain the attached patch is right way of doing it, but I noticed I needed a /dev/usb6 in order for 'usbdevs -v' to show all USB devices on my system. Surely I can create extra nodes by hand, but I was wondering if it makes sense to add one or more /dev/usb? nodes to the default

update include directives in vscsi(4)

If I'm not mistaken scsi/ and dev/ don't live in sys/. Index: vscsi.4 === RCS file: /cvs/src/share/man/man4/vscsi.4,v retrieving revision 1.5 diff -u -r1.5 vscsi.4 --- vscsi.4 13 Mar 2010 14:33:09 - 1.5 +++ vscsi.4 12

[PATCH] i386: Disable the Pentium3 (model 8) serial number

I don't know if this is still relevant but I noticed that the Pentium III processor serial number isn't disabled for model 8 processors. (patch was tested on 4.6-STABLE) Index: sys/arch/i386/i386/machdep.c === RCS file: /cvs/src/sys/

Re: bioctl.c: leaking memory ?

On Saturday 11 July 2009 11:38:09 Stuart Henderson wrote: > On 2009/07/11 11:15, Remco wrote: > > I was wondering, isn't it true that in code like this, > > > > allocated_mem = malloc(...); > > ... > > if (error_condition) > >err(...);

bioctl.c: leaking memory ?

I was wondering, isn't it true that in code like this, allocated_mem = malloc(...); ... if (error_condition) err(...); ... free(allocated_mem); the 'allocated_mem' will get lost into space if 'error_condition' occurs ? If so, the 'bio_createraid', and the 'bio_parse_devlist' function which is

softraid.c: potential NULL pointer dereference ?

goto stuffup; ... stuffup: if (sd->sd_scsi_sense.error_code) { If I'm not mistaken this leads to dereferencing sd as a NULL pointer. I'm not sure whether this causes an actual real world problem or where to put a guard to avoid this. Regards, Remco