Re: Removing -Wno-format from kernel makefiles, V2

2013-07-04 Thread Stefan Fritsch
On Wednesday 03 July 2013, Stefan Fritsch wrote: > I haven't done any signedness fixes so far, only the size fixes. > But I will look over the patches again and try to fix the > signedness issues in the touched code lines, too. There are quite > a few I guess. For people prefering to review by sou

Re: Removing -Wno-format from kernel makefiles, V2

2013-07-03 Thread Stefan Fritsch
On Wednesday 03 July 2013, Alexander Bluhm wrote: > On Wed, Jul 03, 2013 at 01:46:11PM +0200, Stefan Fritsch wrote: > > which the patches are applied does not matter. Therefore I > > thought that people could either review by patch from the above > > directory or by source file from the combined pa

Re: Removing -Wno-format from kernel makefiles, V2

2013-07-03 Thread Theo de Raadt
Please always include diffs in the emails; don't force us to go to a browser.

Re: Removing -Wno-format from kernel makefiles, V2

2013-07-03 Thread Alexander Bluhm
On Wed, Jul 03, 2013 at 01:46:11PM +0200, Stefan Fritsch wrote: > which the patches are applied does not matter. Therefore I thought that > people could either review by patch from the above directory or by source > file from the combined patch, just as they are comfortable. I would then > commi

Re: Removing -Wno-format from kernel makefiles, V2

2013-07-03 Thread Mark Kettenis
> Date: Wed, 3 Jul 2013 13:46:11 +0200 (CEST) > From: Stefan Fritsch > > Hi, > > I have updated my patchset to enable format string warnings in kernel > builds. Changes from the first version: > > - Regarding pointer differences, this now takes the approach favored by > kettenis@ and adds sup