Re: vmd: simplify fatal/fatalx errno handling

2016-10-17 Thread Reyk Floeter
On Sun, Oct 16, 2016 at 02:55:39PM -0700, Philip Guenther wrote: > > Instead of using errno as a hidden argument to vfatal(), make it an > _actual_ argument named 'code', ala the errc/warnc family, and rename it > to vfatalc() to match the pattern set. > > ok? > OK, makes sense please sync

Re: vmd: simplify fatal/fatalx errno handling

2016-10-17 Thread Reyk Floeter
On Sun, Oct 16, 2016 at 08:03:05PM -0600, Theo de Raadt wrote: > > On Sun, Oct 16, 2016 at 02:55:39PM -0700, Philip Guenther wrote: > > > > > > Instead of using errno as a hidden argument to vfatal(), make it an > > > _actual_ argument named 'code', ala the errc/warnc family, and rename it > >

Re: vmd: simplify fatal/fatalx errno handling

2016-10-17 Thread Sebastian Benoit
Theo de Raadt(dera...@openbsd.org) on 2016.10.16 20:03:05 -0600: > > On Sun, Oct 16, 2016 at 02:55:39PM -0700, Philip Guenther wrote: > > > > > > Instead of using errno as a hidden argument to vfatal(), make it an > > > _actual_ argument named 'code', ala the errc/warnc family, and rename it >

Re: vmd: simplify fatal/fatalx errno handling

2016-10-16 Thread Theo de Raadt
> On Sun, Oct 16, 2016 at 02:55:39PM -0700, Philip Guenther wrote: > > > > Instead of using errno as a hidden argument to vfatal(), make it an > > _actual_ argument named 'code', ala the errc/warnc family, and rename it > > to vfatalc() to match the pattern set. > > > > ok? > > > > Philip

Re: vmd: simplify fatal/fatalx errno handling

2016-10-16 Thread Mike Larkin
On Sun, Oct 16, 2016 at 02:55:39PM -0700, Philip Guenther wrote: > > Instead of using errno as a hidden argument to vfatal(), make it an > _actual_ argument named 'code', ala the errc/warnc family, and rename it > to vfatalc() to match the pattern set. > > ok? > > Philip Guenther > Isn't