Re: bgpctl: enlarge columns for 4-byte ASN display

2014-09-24 Thread Gregor Best
On Sun, Jul 27, 2014 at 10:06:12PM +0100, Stuart Henderson wrote: [...] Nice, I like that a lot. What do you think Claudio? [...] Ping. Are there remaining issues with the patch? -- Gregor Best

Re: bgpctl: enlarge columns for 4-byte ASN display

2014-08-30 Thread Gregor Best
Ping. -- Gregor Best

Re: bgpctl: enlarge columns for 4-byte ASN display

2014-08-04 Thread Gregor Best
Ping? Are there remaining issues with the patch or should I leave you guys alone until the release stress is over? -- Gregor Best

Re: bgpctl: enlarge columns for 4-byte ASN display

2014-07-27 Thread Claudio Jeker
Not a big fan since this makes the bgpctl show output no longer fit 80 chars and so will wrap lines on default terminals. While it is OK to increase the size it should be taken away from other fields in some whay. An option would be to drop the OutQ since that field has only limited value IMO.

Re: bgpctl: enlarge columns for 4-byte ASN display

2014-07-27 Thread Gregor Best
On Sun, Jul 27, 2014 at 11:15:41AM +0200, Claudio Jeker wrote: Not a big fan since this makes the bgpctl show output no longer fit 80 chars and so will wrap lines on default terminals. [...] Agreed, that's not good. While it is OK to increase the size it should be taken away from other

Re: bgpctl: enlarge columns for 4-byte ASN display

2014-07-27 Thread Stuart Henderson
On 2014/07/27 11:15, Claudio Jeker wrote: Not a big fan since this makes the bgpctl show output no longer fit 80 chars and so will wrap lines on default terminals. While it is OK to increase the size it should be taken away from other fields in some whay. An option would be to drop the OutQ

Re: bgpctl: enlarge columns for 4-byte ASN display

2014-07-27 Thread Gregor Best
On Sun, Jul 27, 2014 at 03:36:06PM +0100, Stuart Henderson wrote: On 2014/07/27 11:15, Claudio Jeker wrote: Not a big fan since this makes the bgpctl show output no longer fit 80 chars and so will wrap lines on default terminals. While it is OK to increase the size it should be taken away

Re: bgpctl: enlarge columns for 4-byte ASN display

2014-07-27 Thread Claudio Jeker
On Sun, Jul 27, 2014 at 03:36:06PM +0100, Stuart Henderson wrote: On 2014/07/27 11:15, Claudio Jeker wrote: Not a big fan since this makes the bgpctl show output no longer fit 80 chars and so will wrap lines on default terminals. While it is OK to increase the size it should be taken away

Re: bgpctl: enlarge columns for 4-byte ASN display

2014-07-27 Thread Stuart Henderson
On 2014/07/27 17:24, Gregor Best wrote: On Sun, Jul 27, 2014 at 03:36:06PM +0100, Stuart Henderson wrote: On 2014/07/27 11:15, Claudio Jeker wrote: Not a big fan since this makes the bgpctl show output no longer fit 80 chars and so will wrap lines on default terminals. While it is OK to

bgpctl: enlarge columns for 4-byte ASN display

2014-07-26 Thread Gregor Best
Hi people, I'm running OpenBGPD with a few peers that have large 4-byte AS numbers. Displaying the table of peers with `bgpctl show` shows the stats just fine, but the length of the AS number shifts the content of the statistics confusingly far to the right, such as in the following example: $