Re: [PATCH] [0/1] pf refactoring

On 19 August 2016 at 16:34, Richard Procter wrote: > Hi Mike, > > On Fri, 19 Aug 2016, Mike Belopuhov wrote: > >> I've looked through it and couldn't find anything wrong with it. > > Thanks. > >> I do however find pacthing of values in pf_translate_icmp_af >>

Re: [PATCH] [0/1] pf refactoring

Hi Mike, On Fri, 19 Aug 2016, Mike Belopuhov wrote: > I've looked through it and couldn't find anything wrong with it. Thanks. > I do however find pacthing of values in pf_translate_icmp_af > unneccessary since we'll be throwing away the original header > anyway. Do you mean e.g. circa line

Re: [PATCH] [0/1] pf refactoring

On 19 August 2016 at 11:33, Richard Procter wrote: > Hi, > > I've reduced the pf refactor (phase two) to two patches, which I'll be > committing in 24 hours or so unless there are any objections. > > I'm confident it won't, but supposing post-commit these have in >

[PATCH] [0/1] pf refactoring

Hi, I've reduced the pf refactor (phase two) to two patches, which I'll be committing in 24 hours or so unless there are any objections. I'm confident it won't, but supposing post-commit these have in fact blown up, my first suspect would be the afto paths. This patch removes