Re: [patch] Disklabel message tweak
On Fri, Jul 17, 2015 at 03:53:09PM +0200, Benny Lofgren wrote: On 2015-07-17 08:57, Theo de Raadt wrote: The phrase No label changes. was selected because it is true (there is nothing to save). I don't see what further adds to make this more accurate or understandable. Perhaps phrasing the message No unsaved label changes instead would make both camps happy? In my mind that wording clearly explains what just went on, while also taking into account what might likely have been done earlier in the edit session. Good call. I wasn't really happy with the phrasing I suggested either - yours sounds much better. I should probably cut out my bikeshedding, though.
Re: [patch] Disklabel message tweak
On 2015-07-17 08:57, Theo de Raadt wrote: The phrase No label changes. was selected because it is true (there is nothing to save). I don't see what further adds to make this more accurate or understandable. I would even argue that adding further makes it more INaccurate and also adds confusion, since it introduces a worry in the user that whoops... what changes *did* I just make without noticing...?. However, I do agree with the OP that the original message is a bit confusing, especially given his example use case. I need only look to myself, used to /bin/ed as I am, I often just type w + enter + q + enter without thinking because it's in my muscle memory. Then I see the message and get slightly miffed at myself for forgetting that 'q' in disklabel actually asks me. :-) Perhaps phrasing the message No unsaved label changes instead would make both camps happy? In my mind that wording clearly explains what just went on, while also taking into account what might likely have been done earlier in the edit session. Regards, /Benny -- internetlabbet.se / work: +46 8 551 124 80 / Words must Benny Lofgren/ mobile: +46 70 718 11 90 / be weighed, / fax:+46 8 551 124 89/not counted. /email: benny -at- internetlabbet.se
Re: [patch] Disklabel message tweak
This is another trivial patch, but I've always found the disklabel
message No label changes confusing. For example, if you print (p), add
a label (a), write (w), print to check your changes (p), and then quit
(q), it seems odd to be told No label changes.
Index: sbin/disklabel/editor.c
===
RCS file: /cvs/src/sbin/disklabel/editor.c,v
retrieving revision 1.295
diff -u -p -r1.295 editor.c
--- sbin/disklabel/editor.c8 May 2015 12:15:50 - 1.295
+++ sbin/disklabel/editor.c17 Jul 2015 02:54:59 -
@@ -373,7 +373,7 @@ editor(int f)
*/
if (!dflag !aflag
memcmp(lab, newlab, sizeof(newlab)) == 0) {
- puts(No label changes.);
+ puts(No further label changes.);
/* Save mountpoint info. */
mpsave(newlab);
goto done;
The phrase No label changes. was selected because it is true
(there is nothing to save). I don't see what further adds to
make this more accurate or understandable.
Re: [patch] Disklabel message tweak
This is another trivial patch, but I've always found the disklabel message No label changes confusing. For example, if you print (p), add a label (a), write (w), print to check your changes (p), and then quit (q), it seems odd to be told No label changes. Well, the current message makes sense. You've written the label with the `w' command, and there have been no changes since then. Miod
[patch] Disklabel message tweak
This is another trivial patch, but I've always found the disklabel
message No label changes confusing. For example, if you print (p), add
a label (a), write (w), print to check your changes (p), and then quit
(q), it seems odd to be told No label changes.
Index: sbin/disklabel/editor.c
===
RCS file: /cvs/src/sbin/disklabel/editor.c,v
retrieving revision 1.295
diff -u -p -r1.295 editor.c
--- sbin/disklabel/editor.c 8 May 2015 12:15:50 - 1.295
+++ sbin/disklabel/editor.c 17 Jul 2015 02:54:59 -
@@ -373,7 +373,7 @@ editor(int f)
*/
if (!dflag !aflag
memcmp(lab, newlab, sizeof(newlab)) == 0) {
- puts(No label changes.);
+ puts(No further label changes.);
/* Save mountpoint info. */
mpsave(newlab);
goto done;
