Re: [patch] siphash static functions

2015-01-18 Thread David Gwynne
> On 16 Jan 2015, at 20:45, Fritjof Bornebusch wrote: > > Hi tech@, > > aren't these functions supposed to be static? no, static functions in the kernel means the debugger cant see their names, and we like seeing things in the debugger. they probably should be static in userland though... >

[patch] siphash static functions

2015-01-16 Thread Fritjof Bornebusch
Hi tech@, aren't these functions supposed to be static? fritjof Index: siphash.c === RCS file: /cvs/src/sys/crypto/siphash.c,v retrieving revision 1.1 diff -u -p -r1.1 siphash.c --- siphash.c 4 Nov 2014 03:01:14 - 1.1 +