Re: Another uvm(9) tweak

2015-11-04 Thread Michael McConville
Ted Unangst wrote:
> Michael McConville wrote:
> > It's probably best to say that UVM_MAPFLAG() returns a uvm_flag_t. It's
> > almost exclusively used for uvm_map()'s flag arg, which has that type.
> > Of course, it's an arithmetic macro, so it doesn't actually have a
> > return type.
> 
> I would argue we should delete some of these bullshit types instead.

Fine by me. No strong opinion, though - I'm very new to this code.



Re: Another uvm(9) tweak

2015-11-04 Thread Ted Unangst
Michael McConville wrote:
> It's probably best to say that UVM_MAPFLAG() returns a uvm_flag_t. It's
> almost exclusively used for uvm_map()'s flag arg, which has that type.
> Of course, it's an arithmetic macro, so it doesn't actually have a
> return type.

I would argue we should delete some of these bullshit types instead.



Another uvm(9) tweak

2015-11-04 Thread Michael McConville
It's probably best to say that UVM_MAPFLAG() returns a uvm_flag_t. It's
almost exclusively used for uvm_map()'s flag arg, which has that type.
Of course, it's an arithmetic macro, so it doesn't actually have a
return type.

ok?


Index: share/man/man9/uvm.9
===
RCS file: /cvs/src/share/man/man9/uvm.9,v
retrieving revision 1.61
diff -u -p -r1.61 uvm.9
--- share/man/man9/uvm.930 Oct 2015 04:21:42 -  1.61
+++ share/man/man9/uvm.95 Nov 2015 04:14:30 -
@@ -147,7 +147,7 @@ function initialises the swap subsystem.
 .Fn uvm_uarea_alloc "void"
 .Ft void
 .Fn uvm_uarea_free "struct proc *p"
-.Ft int
+.Ft uvm_flag_t
 .Fn UVM_MAPFLAG "vm_prot_t prot" "vm_prot_t maxprot" "vm_inherit_t inh" "int 
advice" "int flags"
 .nr nS 0
 .Pp