Re: BIRD 1.x/2.x support at rpki-client

2020-03-06 Thread Jeremie Courreges-Anglas
On Fri, Mar 06 2020, Sebastian Benoit wrote: > Job Snijders(j...@openbsd.org) on 2020.03.06 17:31:13 +: >> I have a small suggestion, in some deployments I saw the convention to >> name it as following so it is clear the data came from user provided >> data rather than internal bird structures

Re: BIRD 1.x/2.x support at rpki-client

2020-03-06 Thread Job Snijders
On Fri, Mar 06, 2020 at 07:11:56PM +0100, Robert Scheck wrote: > On Fri, 06 Mar 2020, Sebastian Benoit wrote: > > Note that I haven't tried this with bird 1 or 2 yet ;) > > comments, oks? > > I did not try it yet, but I think BIRD 1 also needs something like "define > force_roa_table_update = %lld

Re: BIRD 1.x/2.x support at rpki-client

2020-03-06 Thread Robert Scheck
On Fri, 06 Mar 2020, Sebastian Benoit wrote: > Note that I haven't tried this with bird 1 or 2 yet ;) > comments, oks? I did not try it yet, but I think BIRD 1 also needs something like "define force_roa_table_update = %lld;" and maybe some table definition. I will try BIRD 1 and 2 during the week

Re: BIRD 1.x/2.x support at rpki-client

2020-03-06 Thread Sebastian Benoit
Robert Scheck(rob...@fedoraproject.org) on 2020.03.06 14:02:26 +0100: > On Fri, 06 Mar 2020, Job Snijders wrote: > > I believe Robert is referring to this snippet of code: > > > > > > https://patch-diff.githubusercontent.com/raw/kristapsdz/rpki-client/pull/21.patch Thanks for the patch. I co

Re: BIRD 1.x/2.x support at rpki-client

2020-03-06 Thread Sebastian Benoit
Job Snijders(j...@openbsd.org) on 2020.03.06 17:31:13 +: > I have a small suggestion, in some deployments I saw the convention to > name it as following so it is clear the data came from user provided > data rather than internal bird structures > > I tested Benno's patch against BIRD 1.6.6 -

Re: BIRD 1.x/2.x support at rpki-client

2020-03-06 Thread Job Snijders
I have a small suggestion, in some deployments I saw the convention to name it as following so it is clear the data came from user provided data rather than internal bird structures I tested Benno's patch against BIRD 1.6.6 - wfm. Index: main.c ===

Re: BIRD 1.x/2.x support at rpki-client

2020-03-06 Thread Claudio Jeker
On Fri, Mar 06, 2020 at 05:53:59PM +0100, Sebastian Benoit wrote: > Hi, > > generate 3 different outputs for BIRD: > - bird v1 with IPv4 routes > - bird v1 with IPv6 routes > - bird v2 > when using command line option -B. > BIRD v2 output from Robert Scheck, robert AT fedoraproject DOT org > > >

Re: BIRD 1.x/2.x support at rpki-client

2020-03-06 Thread Sebastian Benoit
Hi, generate 3 different outputs for BIRD: - bird v1 with IPv4 routes - bird v1 with IPv6 routes - bird v2 when using command line option -B. BIRD v2 output from Robert Scheck, robert AT fedoraproject DOT org Note that I haven't tried this with bird 1 or 2 yet ;) comments, oks? (benno_rpki_bir

Re: BIRD 1.x/2.x support at rpki-client

2020-03-06 Thread Jeremie Courreges-Anglas
On Fri, Mar 06 2020, Sebastian Benoit wrote: > Robert Scheck(rob...@fedoraproject.org) on 2020.03.06 14:02:26 +0100: >> On Fri, 06 Mar 2020, Job Snijders wrote: >> > I believe Robert is referring to this snippet of code: >> > >> > >> > https://patch-diff.githubusercontent.com/raw/kristapsdz/

Re: BIRD 1.x/2.x support at rpki-client

2020-03-06 Thread Sebastian Benoit
Robert Scheck(rob...@fedoraproject.org) on 2020.03.06 14:02:26 +0100: > On Fri, 06 Mar 2020, Job Snijders wrote: > > I believe Robert is referring to this snippet of code: > > > > > > https://patch-diff.githubusercontent.com/raw/kristapsdz/rpki-client/pull/21.patch > > Exactly. Ah, i though

Re: BIRD 1.x/2.x support at rpki-client

2020-03-06 Thread Robert Scheck
On Fri, 06 Mar 2020, Job Snijders wrote: > I believe Robert is referring to this snippet of code: > > > https://patch-diff.githubusercontent.com/raw/kristapsdz/rpki-client/pull/21.patch Exactly. Regards, Robert

Re: BIRD 1.x/2.x support at rpki-client

2020-03-06 Thread Job Snijders
On Fri, Mar 06, 2020 at 12:24:18PM +0100, Sebastian Benoit wrote: > Robert Scheck(rob...@fedoraproject.org) on 2020.03.03 01:20:24 +0100: > > job@ suggested to move this from GitHub to tech@ list (as upstream): > > > > 1. Currently, BIRD 1.x support in rpki-client seems to be broken: As per > >

Re: BIRD 1.x/2.x support at rpki-client

2020-03-06 Thread Sebastian Benoit
Robert Scheck(rob...@fedoraproject.org) on 2020.03.03 01:20:24 +0100: > Hi, > > job@ suggested to move this from GitHub to tech@ list (as upstream): > > 1. Currently, BIRD 1.x support in rpki-client seems to be broken: As per >BIRD upstream the "combined format" produced by rpki-client can't

Re: BIRD 1.x/2.x support at rpki-client

2020-03-04 Thread Claudio Jeker
On Wed, Mar 04, 2020 at 07:48:28AM -0700, Theo de Raadt wrote: > Job Snijders wrote: > > > I think we still need to support BIRD 1 for the foreseeable future, NIC.CZ > > hasn’t communicated plans to deprecate BIRD1 and still supports it; and > > BIRD1 still is widely deployed. > > > > I’m some

Re: BIRD 1.x/2.x support at rpki-client

2020-03-04 Thread Theo de Raadt
Job Snijders wrote: > I think we still need to support BIRD 1 for the foreseeable future, NIC.CZ > hasn’t communicated plans to deprecate BIRD1 and still supports it; and BIRD1 > still is widely deployed. > > I’m somewhat preferential to just generate all 3 BIRD flavors if -B is given > as co

Re: BIRD 1.x/2.x support at rpki-client

2020-03-04 Thread Job Snijders
We are still at the early stages of RPKI deployment, so if we make it easier to plug things into BIRD1 is beneficial given the wide deployment scale. Only /very/ recently was rpki-client packaged for some of the Linux distros, so if we add support for all formats now - it’ll improve the applicab

Re: BIRD 1.x/2.x support at rpki-client

2020-03-04 Thread Stuart Henderson
On 2020/03/04 00:55, Robert Scheck wrote: > On Mon, 02 Mar 2020, Theo de Raadt wrote: > > Can't we assume bird1 will go away eventually? > > Yes, sooner or later. Likely later for OpenBSD when looking to net/bird/1 > and net/bird/2 co-existence, thus ongoing BIRD 1.x compatibility might be > more

Re: BIRD 1.x/2.x support at rpki-client

2020-03-04 Thread Job Snijders
I think we still need to support BIRD 1 for the foreseeable future, NIC.CZ hasn’t communicated plans to deprecate BIRD1 and still supports it; and BIRD1 still is widely deployed. I’m somewhat preferential to just generate all 3 BIRD flavors if -B is given as command line option. Kind regards,

Re: BIRD 1.x/2.x support at rpki-client

2020-03-04 Thread Job Snijders
On Wed, Mar 4, 2020, at 00:55, Robert Scheck wrote: > > The idea is you can specify many outputs. That will make the commandline > > very long, especially for the way we run it in cron. > > Oh! I'm sorry, I didn't see the idea of specifying many outputs. Yeah, its nice to do things in one batch

Re: BIRD 1.x/2.x support at rpki-client

2020-03-03 Thread Robert Scheck
On Mon, 02 Mar 2020, Theo de Raadt wrote: > Can't we assume bird1 will go away eventually? Yes, sooner or later. Likely later for OpenBSD when looking to net/bird/1 and net/bird/2 co-existence, thus ongoing BIRD 1.x compatibility might be more important for OpenBSD than for rpki-client downstreams

Re: BIRD 1.x/2.x support at rpki-client

2020-03-02 Thread Theo de Raadt
More on this: > However, I'm not sure if the current options -B, -c, -j and -o are that > great. Maybe something like "-o " would be > more powerful and more flexible? btw, in almost all other commmands -o (along with -f) indicates an filename, not a format. So that isn't the letter you want. >

Re: BIRD 1.x/2.x support at rpki-client

2020-03-02 Thread Theo de Raadt
> job@ suggested to move this from GitHub to tech@ list (as upstream): > > 1. Currently, BIRD 1.x support in rpki-client seems to be broken: As per >BIRD upstream the "combined format" produced by rpki-client can't be >used as-is with BIRD 1.x due to separated daemons (and configuration >

BIRD 1.x/2.x support at rpki-client

2020-03-02 Thread Robert Scheck
Hi, job@ suggested to move this from GitHub to tech@ list (as upstream): 1. Currently, BIRD 1.x support in rpki-client seems to be broken: As per BIRD upstream the "combined format" produced by rpki-client can't be used as-is with BIRD 1.x due to separated daemons (and configuration file