Re: FIDO/U2F not working with latest snapshot

2021-09-13 Thread Mitchell Riedstra
> Thanks, the diff below should hopefully work as it corrects a > regression > introduced in uhidev_attach(). However, I'm not still convinced that > this is a good idea. The patch applies and works, though I noticed in uhidev_attach osize is being checked twice, was it meant to be fsize? ( patch

Re: FIDO/U2F not working with latest snapshot

2021-09-12 Thread Anton Lindqvist
On Sun, Sep 12, 2021 at 12:53:30PM -0400, Mitchell Riedstra wrote: > > > I have reverted the commit by now. Could you please send me the dmesg > > and ssh-agent FIDO_DEBUG=1 output with and without this commit > > applied. > > > > Sure! See attached. Thanks, the diff below should hopefully work

Re: FIDO/U2F not working with latest snapshot

2021-09-12 Thread Mitchell Riedstra
> I have reverted the commit by now. Could you please send me the dmesg > and ssh-agent FIDO_DEBUG=1 output with and without this commit > applied. > Sure! See attached. OpenBSD 7.0-beta (GENERIC.MP) #4: Sun Sep 12 11:14:43 EDT 2021 mi...@t490.riedstra.dev:/sys/arch/amd64/compile/GENERIC.MP

Re: FIDO/U2F not working with latest snapshot

2021-09-12 Thread Anton Lindqvist
On Sat, Sep 11, 2021 at 07:56:47PM -0400, Mitchell Riedstra wrote: > I see the same issue, it seems to be impacting everything with libfido, > ( ed25519-sk and ecdsa-sk SSH keys as well ) Reverting that commit also > fixes the issue for me. > > I don't see anything obvious in dmesg, running ssh-ag

Re: FIDO/U2F not working with latest snapshot

2021-09-11 Thread Mitchell Riedstra
I see the same issue, it seems to be impacting everything with libfido, ( ed25519-sk and ecdsa-sk SSH keys as well ) Reverting that commit also fixes the issue for me. I don't see anything obvious in dmesg, running ssh-agent with FIDO_DEBUG=1 yields a small bit more information to go on: debug1:

FIDO/U2F not working with latest snapshot

2021-09-11 Thread Renato Aguiar
Using FIDO/U2F (Yubikey) from browser is not working with the latest snapshot. After some testing and bisecting, I found out that the bug was introduced with the following commit: commit adb06565acb8061f0e1ddb764fb29f86eadeb2f6 from: anton date: Fri Sep 10 05:47:38 2021 UTC Instead of letting