Re: Intel i219 network card support

2016-02-17 Thread Stuart Henderson
On 2016/02/17 15:45, Alexander Bluhm wrote: > On Mon, Feb 15, 2016 at 10:37:36AM +0100, Christian Ehrhardt wrote: > > before I post the next iteration of the patch, I'd like > > some more advice on some of the points you commented (inline): > > Christian Ehrhardt has asked me to port his fixes and

Re: Intel i219 network card support

2016-02-17 Thread Alexander Bluhm
On Mon, Feb 15, 2016 at 10:37:36AM +0100, Christian Ehrhardt wrote: > before I post the next iteration of the patch, I'd like > some more advice on some of the points you commented (inline): Christian Ehrhardt has asked me to port his fixes and test his new diff on -current. Works fine on my em0

Re: Intel i219 network card support

2016-02-15 Thread Jonathan Gray
On Mon, Feb 15, 2016 at 10:37:36AM +0100, Christian Ehrhardt wrote: > > Hi, > > before I post the next iteration of the patch, I'd like > some more advice on some of the points you commented (inline): > > > > Odd that I219 advertises itself as I217 > > Hm, I didn't look at this code in detail

Re: Intel i219 network card support

2016-02-15 Thread Christian Ehrhardt
Hi, before I post the next iteration of the patch, I'd like some more advice on some of the points you commented (inline): On Sun, Feb 14, 2016 at 03:34:19PM +1100, Jonathan Gray wrote: > On Mon, Feb 08, 2016 at 01:53:20PM +0100, Christian Ehrhardt wrote: > > retrieving revision 1.329 > > diff -

Re: Intel i219 network card support

2016-02-14 Thread Stuart Henderson
On 2016/02/11 13:59, Jérémie Courrèges-Anglas wrote: > Alexander Bluhm writes: > > > On Mon, Feb 08, 2016 at 01:53:20PM +0100, Christian Ehrhardt wrote: > >> The diff was initially done for 5.7, bluhm@ did the forward port > >> to current. The resulting diff is below. > > > > I am running this di

Re: Intel i219 network card support

2016-02-13 Thread Jonathan Gray
On Mon, Feb 08, 2016 at 01:53:20PM +0100, Christian Ehrhardt wrote: > > Hi everyone, > > based on the latest release of the Intel driver for FreeBSD (em-7.5.2), > I've adapted the em(4) driver to support the skylake based i219 > onboard ethernet chips. > > I do not have access to relevant specs,

Re: Intel i219 network card support

2016-02-11 Thread Jérémie Courrèges-Anglas
Alexander Bluhm writes: > On Mon, Feb 08, 2016 at 01:53:20PM +0100, Christian Ehrhardt wrote: >> The diff was initially done for 5.7, bluhm@ did the forward port >> to current. The resulting diff is below. > > I am running this diff with my Thinkpad T430s, no problems so far. > > em0 at pci0 dev

Re: Intel i219 network card support

2016-02-08 Thread Alexander Bluhm
On Mon, Feb 08, 2016 at 01:53:20PM +0100, Christian Ehrhardt wrote: > The diff was initially done for 5.7, bluhm@ did the forward port > to current. The resulting diff is below. I am running this diff with my Thinkpad T430s, no problems so far. em0 at pci0 dev 25 function 0 "Intel 82579LM" rev 0x

Re: Intel i219 network card support

2016-02-08 Thread Christian Ehrhardt
Hi, On Mon, Feb 08, 2016 at 02:35:32PM +, Stuart Henderson wrote: > On 2016/02/08 13:53, Christian Ehrhardt wrote: > > If you own a skylake based onboard NIC, please give this diff a try. > > The most important bit, especially at this point in the release cycle, > is whether it makes any cha

Re: Intel i219 network card support

2016-02-08 Thread Stuart Henderson
On 2016/02/08 13:53, Christian Ehrhardt wrote: > If you own a skylake based onboard NIC, please give this diff a try. The most important bit, especially at this point in the release cycle, is whether it makes any changes that cause problems with other chips. I don't have time to look closely now b

Intel i219 network card support

2016-02-08 Thread Christian Ehrhardt
Hi everyone, based on the latest release of the Intel driver for FreeBSD (em-7.5.2), I've adapted the em(4) driver to support the skylake based i219 onboard ethernet chips. I do not have access to relevant specs, everything below is based on reading the Intel code referenced above. The diff was