Re: MPLS pseudowire over IPv6 1/2: ifconfig(8) diff

2018-12-23 Thread Denis Fondras
On Sun, Dec 23, 2018 at 10:05:01AM +, Jason McIntyre wrote: > unless you're trying somehow to emphasise that both types of address are > supported, you could simplify the text to just: > > The > .Ar dest-address > is used to find ... > Thank you for your input. Index:

Re: MPLS pseudowire over IPv6 1/2: ifconfig(8) diff

2018-12-23 Thread Jason McIntyre
On Sun, Dec 23, 2018 at 10:28:30AM +0100, Denis Fondras wrote: > On Sat, Dec 22, 2018 at 11:42:36PM +0100, Klemens Nanni wrote: > > I have no clue about MPLS, so this feedback is code-wise only: > > > > Did you consider using more AF agnostic code for parsing the IP address? > > > > You are

Re: MPLS pseudowire over IPv6 1/2: ifconfig(8) diff

2018-12-23 Thread Denis Fondras
On Sat, Dec 22, 2018 at 11:42:36PM +0100, Klemens Nanni wrote: > I have no clue about MPLS, so this feedback is code-wise only: > > Did you consider using more AF agnostic code for parsing the IP address? > You are right, it is simpler. Thank you for the clue :) Updated diff : Index:

MPLS pseudowire over IPv6 1/2: ifconfig(8) diff

2018-12-22 Thread Denis Fondras
Allow the mpw(4) interface to establish VPLS tunnel over an IPv6-only MPLS core. This is the ifconfig(8) bit providing display and configuration of IPv6 neighbor on mpw(4) interface. pe1# ifconfig mpw0 mpw0: flags=51 mtu 1500 index 7 priority 0 llprio 3 encapsulation-type