Re: PATCH: Tell what trailing asterisk in sa output means

[Jason McIntyre]

On Tue, Dec 20, 2016 at 09:27:14PM +0300, Vadim Zhukov wrote:
> 2016-12-20 20:30 GMT+03:00 Theo de Raadt :
> >> I had to dig into sa sources to get know what trailing '*' in
> >> command names mean. IMHO, that's not how manuals should work. :)
> >>
> >> Okay?
> >
> > That seems a little awkward mentioning fork directly.  How about
> >
> > Children which have not yet called
> > .Xr execve 2
> > will have
> > .Sq *
> > appended to their command names.
> 
> Seems fine for me as well.
> 

it reads fine to me too, so please go ahead and fix. the last two
paragraphs of sa(8) are a bit clumsy i think since they more or less
repeat what -m and -u do and then, outwith the descriptions of -m and
-u, say which options are affected by -m and -u. i think we could clean
that whole bit up, and move this new text up, but it could easily be done
separately.

jmc

Re: PATCH: Tell what trailing asterisk in sa output means

[Vadim Zhukov]

2016-12-20 20:30 GMT+03:00 Theo de Raadt :
>> I had to dig into sa sources to get know what trailing '*' in
>> command names mean. IMHO, that's not how manuals should work. :)
>>
>> Okay?
>
> That seems a little awkward mentioning fork directly.  How about
>
> Children which have not yet called
> .Xr execve 2
> will have
> .Sq *
> appended to their command names.

Seems fine for me as well.

--
  WBR,
  Vadim Zhukov

Re: PATCH: Tell what trailing asterisk in sa output means

[Theo de Raadt]

> I had to dig into sa sources to get know what trailing '*' in
> command names mean. IMHO, that's not how manuals should work. :)
> 
> Okay?

That seems a little awkward mentioning fork directly.  How about

Children which have not yet called
.Xr execve 2
will have
.Sq *
appended to their command names.


> Index: sa.8
> ===
> RCS file: /cvs/src/usr.sbin/sa/sa.8,v
> retrieving revision 1.19
> diff -u -p -r1.19 sa.8
> --- sa.8  16 Jul 2013 11:13:34 -  1.19
> +++ sa.8  20 Dec 2016 12:26:51 -
> @@ -205,6 +205,14 @@ flag is specified, only the
>  and
>  .Fl s
>  flags are honored.
> +.Pp
> +Processes created with
> +.Xr fork 2
> +without
> +.Xr exec 3
> +will have
> +.Sq *
> +appended to their command names.
>  .Sh FILES
>  .Bl -tag -width /var/account/usracct -compact
>  .It Pa /var/account/acct
> 

PATCH: Tell what trailing asterisk in sa output means

[Vadim Zhukov]

Hi all.

I had to dig into sa sources to get know what trailing '*' in
command names mean. IMHO, that's not how manuals should work. :)

Okay?

--
WBR,
  Vadim Zhukov


Index: sa.8
===
RCS file: /cvs/src/usr.sbin/sa/sa.8,v
retrieving revision 1.19
diff -u -p -r1.19 sa.8
--- sa.816 Jul 2013 11:13:34 -  1.19
+++ sa.820 Dec 2016 12:26:51 -
@@ -205,6 +205,14 @@ flag is specified, only the
 and
 .Fl s
 flags are honored.
+.Pp
+Processes created with
+.Xr fork 2
+without
+.Xr exec 3
+will have
+.Sq *
+appended to their command names.
 .Sh FILES
 .Bl -tag -width /var/account/usracct -compact
 .It Pa /var/account/acct