Re: acme-client: remove free() before exits in main()

2019-03-09 Thread Otto Moerbeek
On Sat, Mar 09, 2019 at 08:50:10AM -0700, Theo de Raadt wrote: > Otto Moerbeek wrote: > > > On Sat, Mar 09, 2019 at 11:23:22AM +0100, Sebastian Benoit wrote: > > > > > We free a few strings in main(), some others we dont. We should either > > > free() all strings consistently or not free them a

Re: acme-client: remove free() before exits in main()

2019-03-09 Thread Theo de Raadt
Otto Moerbeek wrote: > On Sat, Mar 09, 2019 at 11:23:22AM +0100, Sebastian Benoit wrote: > > > We free a few strings in main(), some others we dont. We should either > > free() all strings consistently or not free them at all, because it does not > > hurt to keep them until exit(). > > > > The

Re: acme-client: remove free() before exits in main()

2019-03-09 Thread Otto Moerbeek
On Sat, Mar 09, 2019 at 11:23:22AM +0100, Sebastian Benoit wrote: > We free a few strings in main(), some others we dont. We should either > free() all strings consistently or not free them at all, because it does not > hurt to keep them until exit(). > > The chances of the main() function being

acme-client: remove free() before exits in main()

2019-03-09 Thread Sebastian Benoit
We free a few strings in main(), some others we dont. We should either free() all strings consistently or not free them at all, because it does not hurt to keep them until exit(). The chances of the main() function being repurposed and that leading to memleaks is slim, readability is more importan