Re: bt.5: Document exit, zero and delete functions

2020-03-20 Thread Martin Pieuchot
On 19/03/20(Thu) 19:58, Klemens Nanni wrote: > On Thu, Mar 19, 2020 at 07:25:05PM +0100, Martin Pieuchot wrote: > > > +.It Fn exit > > > +Terminate with exit code 0 > > > > I don't see the value of mentioning the exit code. What about: > > > > Terminate the execution. > "Terminate" is already

Re: bt.5: Document exit, zero and delete functions

2020-03-19 Thread Jason McIntyre
On Thu, Mar 19, 2020 at 08:17:10PM +0100, Klemens Nanni wrote: > On Thu, Mar 19, 2020 at 07:07:10PM +, Jason McIntyre wrote: > > hi. i think you need to end these descriptions with a full stop. you did > > it with the last list item already! > Right, haven't done it for consistency with the oth

Re: bt.5: Document exit, zero and delete functions

2020-03-19 Thread Klemens Nanni
On Thu, Mar 19, 2020 at 07:07:10PM +, Jason McIntyre wrote: > hi. i think you need to end these descriptions with a full stop. you did > it with the last list item already! Right, haven't done it for consistency with the other lists in there, but then again function descriptions are proper sent

Re: bt.5: Document exit, zero and delete functions

2020-03-19 Thread Jason McIntyre
On Thu, Mar 19, 2020 at 07:58:44PM +0100, Klemens Nanni wrote: > Totally fine with me, just wanted to keep the diff clear, but I'll do so > now before the manual grows further. > > OK? > hi. i think you need to end these descriptions with a full stop. you did it with the last list item already!

Re: bt.5: Document exit, zero and delete functions

2020-03-19 Thread Klemens Nanni
On Thu, Mar 19, 2020 at 07:25:05PM +0100, Martin Pieuchot wrote: > A map contains (key, value) pairs. In that sense delete() deletes a > pair. What about: Correct, but I wanted to keep it short and therefore implied that removing a key also removes the value. > Delete the pair indexed by `key'

Re: bt.5: Document exit, zero and delete functions

2020-03-19 Thread Martin Pieuchot
On 19/03/20(Thu) 17:43, Klemens Nanni wrote: > Index: bt.5 > === > RCS file: /cvs/src/usr.sbin/btrace/bt.5,v > retrieving revision 1.3 > diff -u -p -r1.3 bt.5 > --- bt.5 18 Mar 2020 20:19:42 - 1.3 > +++ bt.5 19 Mar 2

bt.5: Document exit, zero and delete functions

2020-03-19 Thread Klemens Nanni
regress already uses them. Feedback? OK? Index: bt.5 === RCS file: /cvs/src/usr.sbin/btrace/bt.5,v retrieving revision 1.3 diff -u -p -r1.3 bt.5 --- bt.518 Mar 2020 20:19:42 - 1.3 +++ bt.519 Mar 2020 16:41:46