On Sat, Jan 08, 2022 at 09:59:10AM +, Jason McIntyre wrote:
> On Sat, Jan 08, 2022 at 02:38:05PM +1100, Jonathan Gray wrote:
> > dwc2, drm and microcode purposefully excluded
> >
>
> morning.
>
> no need for breakfast after reading this one!
>
> the spelling checks out. i have a few tweaks though:
>
> acpireg.h:
> rsdp_signaturee is a change to the actual #define. not sure if that
> changes anything.
there are no other references to that define
>
> if_wi_ieee.h:
> "weirdity" should probably just be "oddity", but whatever
>
> wdcvar.h:
> channels-specific data -> channel-specific data
>
> pcppi.c:
> normally it's be to quick -> normally it's too quick
tb@ suggested this as well
>
> if_iwmreg.h:
> allows Tx with narrower BW then requested -> ... than requested
>
> pciide.c:
> timings setups -> timing setups
>
> cgtwelve.c/tvtwo.c/zx.c:
> advertize -> advertise: although i dislike the "z" spelling myself,
> it is not incorrect. generally -ise -> -ize seems to be preferred in US
> english.
I think this is an exception?
>
> zx.c:
> a 8-bit plane -> an 8-bit plane
>
> if_atu.c:
> "requeres" line has a double full stop,
> as does if_atureg.h "psuedo" line
The .. in this file seems to be for indicating a range of values
thanks, adding the below, pcppi part already included
diff --git sys/dev/ic/if_wi_ieee.h sys/dev/ic/if_wi_ieee.h
index 3ece9a1e4cf..434351fc64a 100644
--- sys/dev/ic/if_wi_ieee.h
+++ sys/dev/ic/if_wi_ieee.h
@@ -440,7 +440,7 @@ struct wi_rx_frame {
u_int8_twi_addr4[6];
u_int16_t wi_dat_len;
/*
-* another weirdity with the drivers. they append a 802.3 header which
+* another oddity with the drivers. they append a 802.3 header which
* is somewhat redundant, since all the same data is provided in the
* 802.11 header.
*/
diff --git sys/dev/ic/wdcvar.h sys/dev/ic/wdcvar.h
index f39b7879712..f146dde8936 100644
--- sys/dev/ic/wdcvar.h
+++ sys/dev/ic/wdcvar.h
@@ -167,7 +167,7 @@ struct wdc_softc { /* Per controller state */
u_int8_t DMA_cap; /* highest DMA mode supported */
u_int8_t UDMA_cap; /* highest UDMA mode supported */
int nchannels; /* Number of channels on this controller */
- struct channel_softc **channels; /* channels-specific data (array) */
+ struct channel_softc **channels; /* channel-specific data (array) */
u_int16_t quirks; /* per-device oddities */
#define WDC_QUIRK_NOSHORTDMA 0x0001 /* can't do short DMA transfers */
#define WDC_QUIRK_NOATA0x0002 /* skip attaching ATA disks */
diff --git sys/dev/pci/if_iwmreg.h sys/dev/pci/if_iwmreg.h
index 5293af8525b..7c4005ab77a 100644
--- sys/dev/pci/if_iwmreg.h
+++ sys/dev/pci/if_iwmreg.h
@@ -4671,7 +4671,7 @@ enum {
#define IWM_LQ_FLAG_RTS_BW_SIG_DYNAMIC (2 << IWM_LQ_FLAG_RTS_BW_SIG_POS)
/* Bit 6: (0) No dynamic BW selection (1) Allow dynamic BW selection
- * Dynamic BW selection allows Tx with narrower BW then requested in rates
+ * Dynamic BW selection allows Tx with narrower BW than requested in rates
*/
#define IWM_LQ_FLAG_DYNAMIC_BW_POS 6
#define IWM_LQ_FLAG_DYNAMIC_BW_MSK (1 << IWM_LQ_FLAG_DYNAMIC_BW_POS)
diff --git sys/dev/pci/pciide.c sys/dev/pci/pciide.c
index 905ed3e7ae1..e03218fb815 100644
--- sys/dev/pci/pciide.c
+++ sys/dev/pci/pciide.c
@@ -3190,8 +3190,8 @@ piix_setup_idetim_drvs(struct ata_drive_datas *drvp)
u_int8_t drive = drvp->drive;
/*
-* If drive is using UDMA, timings setups are independent
-* So just check DMA and PIO here.
+* If drive is using UDMA, timing setup is independent
+* so just check DMA and PIO here.
*/
if (drvp->drive_flags & DRIVE_DMA) {
/* if mode = DMA mode 0, use compatible timings */
diff --git sys/dev/sbus/zx.c sys/dev/sbus/zx.c
index b97f80fa779..abb1f1afc8d 100644
--- sys/dev/sbus/zx.c
+++ sys/dev/sbus/zx.c
@@ -318,7 +318,7 @@ zx_ioctl(void *dev, u_long cmd, caddr_t data, int flags,
struct proc *p)
/*
* Note that, although the emulation (text) mode is running in
-* a 8-bit plane, we advertise the frame buffer as the full-blown
+* an 8-bit plane, we advertise the frame buffer as the full-blown
* 32-bit beast it is.
*/
switch (cmd) {
diff --git sys/dev/usb/if_atu.c sys/dev/usb/if_atu.c
index b77f5b00258..b2f687e92ef 100644
--- sys/dev/usb/if_atu.c
+++ sys/dev/usb/if_atu.c
@@ -1280,7 +1280,7 @@ atu_attach(struct device *parent, struct device *self,
void *aux)
* Check in the interface descriptor if we're in DFU mode
* If we're in DFU mode, we upload the external firmware
* If we're not, the PC must have rebooted without power-cycling
-* the device.. I've tried this out, a reboot only requires the
+* the device. I've tried this out, a reboot only requires the
* external firmware to be
