>> just a comment:
>>
>> drivers with firmware have often had special parameters to the stop or
>> reset functions to indicate a difference between "stop moving traffic"
>> or "shut it all down". We seem to keep switching this back and forth.
>> Reason is we've had some very bizzare failure
On Thu, Jan 24, 2019 at 04:35:02AM -0700, Theo de Raadt wrote:
> just a comment:
>
> drivers with firmware have often had special parameters to the stop or
> reset functions to indicate a difference between "stop moving traffic"
> or "shut it all down". We seem to keep switching this back and
just a comment:
drivers with firmware have often had special parameters to the stop or
reset functions to indicate a difference between "stop moving traffic"
or "shut it all down". We seem to keep switching this back and forth.
Reason is we've had some very bizzare failure conditions in drivers,
On Thu, Jan 24, 2019 at 10:28:56AM +0100, Klemens Nanni wrote:
> Since introduction in 2007, `disable' has been unused. Looking at
> iwm(4) shows a simple `void iwm_stop(struct ifnet *)' as well.
>
> OK?
Yes. This has always bothered me.
I just never got around to removing it.
Since introduction in 2007, `disable' has been unused. Looking at
iwm(4) shows a simple `void iwm_stop(struct ifnet *)' as well.
OK?
Index: if_iwn.c
===
RCS file: /cvs/src/sys/dev/pci/if_iwn.c,v
retrieving revision 1.205
diff -u -p