On Wed, Sep 29, 2010 at 08:45:48PM -0400, Kenneth R Westerback wrote:
> On Thu, Sep 30, 2010 at 04:12:20AM +0600, Alexandr Shadchin wrote:
> > On Thu, Sep 30, 2010 at 02:50:54AM +0600, Alexandr Shadchin wrote:
> > > On Mon, Sep 27, 2010 at 11:42:35PM +0600, Alexandr Shadchin wrote:
> > > > On Fri,
On Wednesday 29 September 2010 15:10:56 Landry Breuil wrote:
> On Wed, Sep 29, 2010 at 06:53:33PM +0100, Nicholas Marriott wrote:
> > this reads fine and works fine for me
> >
> > although i don't really agree with all this return () and comment
> > changing.. if everyone did that there would be to
On Wed, Sep 29, 2010 at 06:53:33PM +0100, Nicholas Marriott wrote:
> this reads fine and works fine for me
>
> although i don't really agree with all this return () and comment
> changing.. if everyone did that there would be tons of unnecessary
> changes, the existing style is fine... but anyway,
this reads fine and works fine for me
although i don't really agree with all this return () and comment
changing.. if everyone did that there would be tons of unnecessary
changes, the existing style is fine... but anyway, meh, the diff works
cheers
On Thu, Sep 30, 2010 at 04:12:20AM +0600, Alex
On Thu, Sep 30, 2010 at 02:50:54AM +0600, Alexandr Shadchin wrote:
> On Mon, Sep 27, 2010 at 11:42:35PM +0600, Alexandr Shadchin wrote:
> > On Fri, Sep 24, 2010 at 05:40:37PM +0400, Alexandr Shadchin wrote:
> > > Hi!
> > >
> > > Paul Irofti proposed to split the diff in a few easy steps.
> > > Ste
On Mon, Sep 27, 2010 at 11:42:35PM +0600, Alexandr Shadchin wrote:
> On Fri, Sep 24, 2010 at 05:40:37PM +0400, Alexandr Shadchin wrote:
> > Hi!
> >
> > Paul Irofti proposed to split the diff in a few easy steps.
> > Step 1 - merge drivers pms and pmsi.
> >
>
> Step 2 - cleanup, standardization o
> Date: Wed, 29 Sep 2010 03:21:21 +0600
> From: Alexandr Shadchin
>
> On Mon, Sep 27, 2010 at 01:10:58PM -0700, Matthew Dempsky wrote:
> > On Mon, Sep 27, 2010 at 10:42 AM, Alexandr Shadchin
> > wrote:
> > >if (pa->pa_slot != PCKBC_AUX_SLOT)
> > > -return (0);
> > > +return 0
> On Mon, Sep 27, 2010 at 01:10:58PM -0700, Matthew Dempsky wrote:
> > On Mon, Sep 27, 2010 at 10:42 AM, Alexandr Shadchin
> > wrote:
> > >if (pa->pa_slot != PCKBC_AUX_SLOT)
> > > -return (0);
> > > +return 0;
> >
> > "return (x)" is proper KNF. Please don't undo it.
>
> I h
On Mon, Sep 27, 2010 at 01:10:58PM -0700, Matthew Dempsky wrote:
> On Mon, Sep 27, 2010 at 10:42 AM, Alexandr Shadchin
> wrote:
> >if (pa->pa_slot != PCKBC_AUX_SLOT)
> > -return (0);
> > +return 0;
>
> "return (x)" is proper KNF. Please don't undo it.
I have recently seen mo
On Mon, Sep 27, 2010 at 08:28:36PM +, Miod Vallat wrote:
> > On Mon, Sep 27, 2010 at 10:42 AM, Alexandr Shadchin
> > wrote:
> > >if (pa->pa_slot != PCKBC_AUX_SLOT)
> > > - return (0);
> > > + return 0;
> >
> > "return (x)" is proper KNF. Please don't undo
On Mon, Sep 27, 2010 at 08:28:36PM +, Miod Vallat wrote:
> > On Mon, Sep 27, 2010 at 10:42 AM, Alexandr Shadchin
> > wrote:
> > >if (pa->pa_slot != PCKBC_AUX_SLOT)
> > > - return (0);
> > > + return 0;
> >
> > "return (x)" is proper KNF. Please don't undo
> On Mon, Sep 27, 2010 at 10:42 AM, Alexandr Shadchin
> wrote:
> >if (pa->pa_slot != PCKBC_AUX_SLOT)
> > - return (0);
> > + return 0;
>
> "return (x)" is proper KNF. Please don't undo it.
Actually, return with braces is old KNF, just like K&R function
declar
On Mon, Sep 27, 2010 at 10:42 AM, Alexandr Shadchin
wrote:
>if (pa->pa_slot != PCKBC_AUX_SLOT)
> - return (0);
> + return 0;
"return (x)" is proper KNF. Please don't undo it.
On Fri, Sep 24, 2010 at 05:40:37PM +0400, Alexandr Shadchin wrote:
> Hi!
>
> Paul Irofti proposed to split the diff in a few easy steps.
> Step 1 - merge drivers pms and pmsi.
>
Step 2 - cleanup, standardization of interfaces and preparation
for easy addition of new devices. Now the resume of wo
On Sun, Sep 26, 2010 at 07:12:45PM -0400, Kenneth R Westerback wrote:
> The commmitted version breaks my eeePC, as I reported the last
> version I got via email did.
>
> Suspend/resume in text mode seems ok, but after confirming that, I
> did 'startx' and the cursor is stuck in the right part of t
On Sat, Sep 25, 2010 at 02:21:14PM +0600, Alexandr Shadchin wrote:
> New diff for the simple pms/pmsi merge.
>
> --
> Alexandr Shadchin
The commmitted version breaks my eeePC, as I reported the last
version I got via email did.
Suspend/resume in text mode seems ok, but after confirming that, I
On Sun, Sep 26, 2010 at 08:39:23PM +, Miod Vallat wrote:
> Oh, right. For some reason I though you had kept the polling mode and
> not the queueing mode.
>
> Diff commited. Thanks!
>
> Miod
This intermediate version. If the poll is better to keep,
I will correct in future.
--
Alexandr Shad
> > Whey did you get rid of the poll- vs interrupt-driven operation in
> > pms_setintellimode()? It is necessary for proper suspend/resume
> > operation.
> >
> In original pms_intelli.c function pmsi_setintellimode()
> called with the poll = 1 only in pmsiprobe() and pmsiattach().
> In pmsi_chang
On Sun, Sep 26, 2010 at 04:04:45PM +, Miod Vallat wrote:
> > New diff for the simple pms/pmsi merge.
>
> Whey did you get rid of the poll- vs interrupt-driven operation in
> pms_setintellimode()? It is necessary for proper suspend/resume
> operation.
>
> Miod
In original pms_intelli.c functi
> New diff for the simple pms/pmsi merge.
Whey did you get rid of the poll- vs interrupt-driven operation in
pms_setintellimode()? It is necessary for proper suspend/resume
operation.
Miod
New diff for the simple pms/pmsi merge.
--
Alexandr Shadchin
Index: distrib/notes/sparc64/hardware
===
RCS file: /cvs/src/distrib/notes/sparc64/hardware,v
retrieving revision 1.151
diff -u -p -r1.151 hardware
--- distrib/notes/spar
Hi!
Paul Irofti proposed to split the diff in a few easy steps.
Step 1 - merge drivers pms and pmsi.
--
Alexandr Shadchin
Index: distrib/notes/sparc64/hardware
===
RCS file: /cvs/src/distrib/notes/sparc64/hardware,v
retrieving revi
2010/9/23 Kenneth R Westerback :
>
> Doesn't apply. pckbc/pms.c and pms_intelli.c are rejected on -current.
>
> Ken
>
Regen
--
Alexandr Shadchin
Index: distrib/notes/sparc64/hardware
===
RCS file: /cvs/src/distrib/notes/sparc6
On Wed, Sep 22, 2010 at 09:33:04PM -0400, Kenneth R Westerback wrote:
> I haven't confirmed w/o the diff, but with the diff I have a problem
> on my eeePC 1000HE. I boot, then suspend with FN-ZZ, then resume
> by hitting a key, then I type 'startx'. At this point I experience
> a long delay before
2010/9/23 Kenneth R Westerback :
> I haven't confirmed w/o the diff, but with the diff I have a problem
> on my eeePC 1000HE. I boot, then suspend with FN-ZZ, then resume
> by hitting a key, then I type 'startx'. At this point I experience
> a long delay before X actually starts.
>
> Ken
>
Tr
I haven't confirmed w/o the diff, but with the diff I have a problem
on my eeePC 1000HE. I boot, then suspend with FN-ZZ, then resume
by hitting a key, then I type 'startx'. At this point I experience
a long delay before X actually starts.
Ken
On Wed, Sep 22, 2010 at 03:24:28AM +0600, Alexandr Shadchin wrote:
> Sorry, forgot to fix previous diff. Attached correct diff
The revised version not only works for me (Dell Studio amd64 laptop), but
even cures the bug that the internal trackpad (pms) locks up during
suspend/resume.
Thanks!
Sorry, forgot to fix previous diff. Attached correct diff
Index: distrib/notes/sparc64/hardware
===
RCS file: /cvs/src/distrib/notes/sparc64/hardware,v
retrieving revision 1.151
diff -u -p -r1.151 hardware
--- distrib/notes/sparc64/h
Hi!
Merge pms and pmsi + added support for some of mouse.
Tested on i386 and amd64.
Please test, comment, commit, flame, etc ... :)
--
Alexandr Shadchin
Index: distrib/notes/sparc64/hardware
===
RCS file: /cvs/src/distrib/notes
29 matches
Mail list logo
