Re: ospf6d: simplify lsa_snap()

2020-01-23 Thread Sebastian Benoit
Remi Locherer(remi.loche...@relo.ch) on 2020.01.22 06:49:53 +0100: > On Wed, Jan 22, 2020 at 12:56:00AM +0100, Claudio Jeker wrote: > > On Tue, Jan 21, 2020 at 03:58:58PM +0100, Remi Locherer wrote: > > > On Tue, Jan 21, 2020 at 01:09:30PM +0100, Denis Fondras wrote: > > > > On Tue, Jan 21, 2020 at

Re: ospf6d: simplify lsa_snap()

2020-01-21 Thread Remi Locherer
On Wed, Jan 22, 2020 at 12:56:00AM +0100, Claudio Jeker wrote: > On Tue, Jan 21, 2020 at 03:58:58PM +0100, Remi Locherer wrote: > > On Tue, Jan 21, 2020 at 01:09:30PM +0100, Denis Fondras wrote: > > > On Tue, Jan 21, 2020 at 09:35:06AM +0100, Remi Locherer wrote: > > > > > @@ -235,6 +233,7 @@ lsa_c

Re: ospf6d: simplify lsa_snap()

2020-01-21 Thread Claudio Jeker
On Tue, Jan 21, 2020 at 03:58:58PM +0100, Remi Locherer wrote: > On Tue, Jan 21, 2020 at 01:09:30PM +0100, Denis Fondras wrote: > > On Tue, Jan 21, 2020 at 09:35:06AM +0100, Remi Locherer wrote: > > > > @@ -235,6 +233,7 @@ lsa_check(struct rde_nbr *nbr, struct ls > > > > case LSA_TYPE_NETWO

Re: ospf6d: simplify lsa_snap()

2020-01-21 Thread Remi Locherer
On Tue, Jan 21, 2020 at 01:09:30PM +0100, Denis Fondras wrote: > On Tue, Jan 21, 2020 at 09:35:06AM +0100, Remi Locherer wrote: > > > @@ -235,6 +233,7 @@ lsa_check(struct rde_nbr *nbr, struct ls > > > case LSA_TYPE_NETWORK: > > > if ((len % sizeof(u_int32_t)) || > > > len

Re: ospf6d: simplify lsa_snap()

2020-01-21 Thread Denis Fondras
On Tue, Jan 21, 2020 at 09:35:06AM +0100, Remi Locherer wrote: > > @@ -235,6 +233,7 @@ lsa_check(struct rde_nbr *nbr, struct ls > > case LSA_TYPE_NETWORK: > > if ((len % sizeof(u_int32_t)) || > > len < sizeof(lsa->hdr) + sizeof(u_int32_t)) { > > + l

Re: ospf6d: simplify lsa_snap()

2020-01-21 Thread Remi Locherer
On Mon, Jan 20, 2020 at 05:03:34PM +0100, Denis Fondras wrote: > No need to pass peerid to lsa_snap() > > While at it, remove unused variable. ok iremi@ with a small comment below. > > Index: rde.c > === > RCS file: /cvs/src/usr.sb

ospf6d: simplify lsa_snap()

2020-01-20 Thread Denis Fondras
No need to pass peerid to lsa_snap() While at it, remove unused variable. Index: rde.c === RCS file: /cvs/src/usr.sbin/ospf6d/rde.c,v retrieving revision 1.82 diff -u -p -r1.82 rde.c --- rde.c 2 Jan 2020 10:16:46 - 1.