Re: pf.conf, comments and continuation lines

2011-06-15 Thread Stuart Henderson
so something like this... ok mandoc@ Index: sbin/isakmpd/isakmpd.conf.5 === RCS file: /cvs/src/sbin/isakmpd/isakmpd.conf.5,v retrieving revision 1.127 diff -u -p -r1.127 isakmpd.conf.5 --- sbin/isakmpd/isakmpd.conf.5 22 Sep 2010 13:45

Re: pf.conf, comments and continuation lines

2011-06-15 Thread patrick keshishian
On Wed, Jun 15, 2011 at 11:16:18AM +0100, Jason McIntyre wrote: > On Wed, Jun 15, 2011 at 11:09:35AM +0100, Stuart Henderson wrote: > > On 2011/06/15 10:03, Jason McIntyre wrote: > > > so i guess we're looking for a text only (i.e. no example) solution. > > > here is another stab. > > > > nicely c

Re: pf.conf, comments and continuation lines

2011-06-15 Thread Richard Toohey
On 15/06/2011, at 10:16 PM, Jason McIntyre wrote: > On Wed, Jun 15, 2011 at 11:09:35AM +0100, Stuart Henderson wrote: >> On 2011/06/15 10:03, Jason McIntyre wrote: >>> so i guess we're looking for a text only (i.e. no example) solution. >>> here is another stab. >> >> nicely crafted words, this i

Re: pf.conf, comments and continuation lines

2011-06-15 Thread Jason McIntyre
On Wed, Jun 15, 2011 at 11:09:35AM +0100, Stuart Henderson wrote: > On 2011/06/15 10:03, Jason McIntyre wrote: > > so i guess we're looking for a text only (i.e. no example) solution. > > here is another stab. > > nicely crafted words, this is good. ok sthen@ > > I'll handle the other copies of t

Re: pf.conf, comments and continuation lines

2011-06-15 Thread Stuart Henderson
On 2011/06/15 10:03, Jason McIntyre wrote: > so i guess we're looking for a text only (i.e. no example) solution. > here is another stab. nicely crafted words, this is good. ok sthen@ I'll handle the other copies of this if you like. > Index: pf.conf.5 > =

Re: pf.conf, comments and continuation lines

2011-06-15 Thread Jason McIntyre
On Wed, Jun 15, 2011 at 09:37:25AM +0100, Stuart Henderson wrote: > > perhaps a small number of people, but it can be a very serious > issue indeed. particularly for pf.conf it needs to be crystal clear. > compare output from these two: > > $ cat << EOF | pfctl -nvf - > pass out quick on lan \ >

Re: pf.conf, comments and continuation lines

2011-06-15 Thread Stuart Henderson
On 2011/06/15 09:18, Jason McIntyre wrote: > > > > You're right about it getting copied to other places, there are 9 > > copies in tree and I'd rather not come up with an example for each, > > so I would be happier to have it in the text rather than as an > > example if it can be done clearly, but

Re: pf.conf, comments and continuation lines

2011-06-15 Thread Jason McIntyre
On Tue, Jun 14, 2011 at 10:58:31PM +0100, Stuart Henderson wrote: > > > > so i'm not fussed. i'll leave it to stuart to decide whether the example > > is actually needed or not. i suppose if it is different to the shell, it > > will confuse people. > > I think it needs to be mentioned explicitly a

Re: pf.conf, comments and continuation lines

2011-06-14 Thread Florian Obser
On 06/14/2011 11:58 PM, Stuart Henderson wrote: > On 2011/06/14 15:43, Jason McIntyre wrote: >> On Tue, Jun 14, 2011 at 03:58:46PM +0200, Florian Obser wrote: >>> if you want to document it, i'd prefer to try and tuck it in nice and neat, without an example. how about rearranging the

Re: pf.conf, comments and continuation lines

2011-06-14 Thread Marco S Hyman
> so I would be happier to have it in the text rather than as an > example if it can be done clearly, but I haven't managed it... For pf and pf like code: Notice: Line continuation processing occurs BEFORE comment removal. For ksh and ksh like code: Notice: Comments are removed BEFORE lin

Re: pf.conf, comments and continuation lines

2011-06-14 Thread Stuart Henderson
On 2011/06/14 15:43, Jason McIntyre wrote: > On Tue, Jun 14, 2011 at 03:58:46PM +0200, Florian Obser wrote: > > > > > > > > if you want to document it, i'd prefer to try and tuck it in nice and > > > neat, without an example. how about rearranging the section to something > > > like this: > > >

Re: pf.conf, comments and continuation lines

2011-06-14 Thread Jason McIntyre
On Tue, Jun 14, 2011 at 03:58:46PM +0200, Florian Obser wrote: > > > > > if you want to document it, i'd prefer to try and tuck it in nice and > > neat, without an example. how about rearranging the section to something > > like this: > > > > Comments can be put anywhere in the file usin

Re: pf.conf, comments and continuation lines

2011-06-14 Thread Florian Obser
On 06/14/2011 12:54 PM, Jason McIntyre wrote: > On Tue, Jun 14, 2011 at 09:59:22AM +0100, Stuart Henderson wrote: >> On 2011/06/14 09:33, Florian Obser wrote: >>> anyone? >> >> This is just how it works. >> >> http://thread.gmane.org/gmane.os.openbsd.misc/144553/focus=144586 >> but doesn't exp

Re: pf.conf, comments and continuation lines

2011-06-14 Thread Jason McIntyre
On Tue, Jun 14, 2011 at 09:59:22AM +0100, Stuart Henderson wrote: > On 2011/06/14 09:33, Florian Obser wrote: > > anyone? > > This is just how it works. > > http://thread.gmane.org/gmane.os.openbsd.misc/144553/focus=144586 > > > > but doesn't explain the semantics of continuation lines. I don't

Re: pf.conf, comments and continuation lines

2011-06-14 Thread Stuart Henderson
On 2011/06/14 09:33, Florian Obser wrote: > anyone? This is just how it works. http://thread.gmane.org/gmane.os.openbsd.misc/144553/focus=144586 > > but doesn't explain the semantics of continuation lines. I don't feel > > qualified to provide a patch for pf.conf(5). How about this? I tried a f

Re: pf.conf, comments and continuation lines

2011-06-14 Thread Florian Obser
anyone? On 05/19/2011 03:31 PM, Florian Obser wrote: > Hi, > > I'm not sure if this is a bug or a feature. Consider the following pf.conf: > > # foo > # bar > > #pass out \ > pass out log \ > label "foo#bar"\ > tag "FOO#BAZ" > > > pass out \ > label "foo#bar"\ > tag FOO#BAZ > > # /sb