Re: pfsync and option WITH_PF_LOCK

2017-06-11 Thread Hrvoje Popovski
On 9.6.2017. 16:31, Alexandr Nedvedicky wrote: >> Hi all, >> >> with this diff i don't see any traces as before. >> > > thanks a lot for quick testing. > > regards > sasha > Hi, i'm running latest snapshot with WITH_PF_LOCK in production and for now everything is fine .. will see tomorrow when

Re: pfsync and option WITH_PF_LOCK

2017-06-09 Thread Alexandr Nedvedicky
On Fri, Jun 09, 2017 at 03:48:49PM +0200, Hrvoje Popovski wrote: > On 9.6.2017. 14:55, Alexandr Nedvedicky wrote: > > Hello, > > > > > > On Fri, Jun 09, 2017 at 01:11:01PM +0200, Alexander Bluhm wrote: > >> On Fri, Jun 09, 2017 at 10:55:46AM +0200, Alexandr Nedvedicky wrote: > >>> would it make s

Re: pfsync and option WITH_PF_LOCK

2017-06-09 Thread Hrvoje Popovski
On 9.6.2017. 14:55, Alexandr Nedvedicky wrote: > Hello, > > > On Fri, Jun 09, 2017 at 01:11:01PM +0200, Alexander Bluhm wrote: >> On Fri, Jun 09, 2017 at 10:55:46AM +0200, Alexandr Nedvedicky wrote: >>> would it make sense to commit a poor man's solution below, before pfsync(4) >>> will get to sh

Re: pfsync and option WITH_PF_LOCK

2017-06-09 Thread Alexandr Nedvedicky
Hello, On Fri, Jun 09, 2017 at 01:11:01PM +0200, Alexander Bluhm wrote: > On Fri, Jun 09, 2017 at 10:55:46AM +0200, Alexandr Nedvedicky wrote: > > would it make sense to commit a poor man's solution below, before pfsync(4) > > will get to shape? The idea is to grab PF_LOCK, just before we pass th

Re: pfsync and option WITH_PF_LOCK

2017-06-09 Thread Alexander Bluhm
On Fri, Jun 09, 2017 at 10:55:46AM +0200, Alexandr Nedvedicky wrote: > would it make sense to commit a poor man's solution below, before pfsync(4) > will get to shape? The idea is to grab PF_LOCK, just before we pass the data > to PF for further processing. Whatever helps to make progress with pf

Re: pfsync and option WITH_PF_LOCK

2017-06-09 Thread Alexandr Nedvedicky
Hello, would it make sense to commit a poor man's solution below, before pfsync(4) will get to shape? The idea is to grab PF_LOCK, just before we pass the data to PF for further processing. regards sasha 8<---8<---8<--8< --- src/sys/net/if_

Re: pfsync and option WITH_PF_LOCK

2017-06-06 Thread Martin Pieuchot
On 06/06/17(Tue) 17:32, Hrvoje Popovski wrote: > Hi all, > > i'm getting these traces with "option WITH_PF_LOCK" enaled. > Setup is quite standard, trunk, vlan, carp, pfsync > > > splassert: pf_state_insert: want 1 have 0 > splassert: pf_remove_state: want 1 have 0 This is a known issue.

pfsync and option WITH_PF_LOCK

2017-06-06 Thread Hrvoje Popovski
Hi all, i'm getting these traces with "option WITH_PF_LOCK" enaled. Setup is quite standard, trunk, vlan, carp, pfsync splassert: pf_state_insert: want 1 have 0 splassert: pf_remove_state: want 1 have 0 with kern.splassert=2 splassert: pf_state_insert: want 1 have 0 Starting stack trace.