Re: r1.21 of sys/net/hfsc.c cripples networking speed

2015-04-24 Thread David Gwynne

 On 24 Apr 2015, at 3:39 pm, Theo de Raadt dera...@cvs.openbsd.org wrote:
 
 After updating one of my machines to a more recent snapshot I noticed that
 networking speed was reduced and that the machine was 'less' responsive.
 
 Be aware there is a fairly expensive debugging diff in the snapshots
 (it is not actually commited).

yeah. have you tried the speed of a current kernel you've built yourself?

dlg



Re: r1.21 of sys/net/hfsc.c cripples networking speed

2015-04-24 Thread Björn Ketelaars
On Fri 24/04/2015 16:25, David Gwynne wrote:
 
  On 24 Apr 2015, at 3:39 pm, Theo de Raadt dera...@cvs.openbsd.org wrote:
  
  After updating one of my machines to a more recent snapshot I noticed that
  networking speed was reduced and that the machine was 'less' responsive.
  
  Be aware there is a fairly expensive debugging diff in the snapshots
  (it is not actually commited).
 
 yeah. have you tried the speed of a current kernel you've built yourself?
 
 dlg

Just tested a current kernel without a hitch. Guess my observation is the result
from the fairly expensive debugging diff. Sorry for the noise...

For future references: is it possible to see if a kernel from snapshots contains
'non committed' code?

-- 
Björn Ketelaars
GPG key: 0x4F0E5F21



Re: r1.21 of sys/net/hfsc.c cripples networking speed

2015-04-24 Thread Theo de Raadt
 For future references: is it possible to see if a kernel from snapshots 
 contains
 'non committed' code?

No.

It is rare.  However the process has been a great success, so it will
be done every once in a while.




r1.21 of sys/net/hfsc.c cripples networking speed

2015-04-23 Thread Björn Ketelaars
Hello,

After updating one of my machines to a more recent snapshot I noticed that
networking speed was reduced and that the machine was 'less' responsive. Quick
look in systat revealed that softnet was hammering the processor (90% interrupt
on CPU0). After reverting to a backup (older kernel) the issue with softnet
claiming the processor was gone.

I once more attempted the more recent kernel disabling queuing in pf (wild
guess). This resolved my issue with networking speed. After some digging in the
CVS log I noticed that revision 1.21 of sys/net/hfsc.c [0] altered code related
to pf queueing.

A test, using a kernel without the above changeset, results in a machine that is
behaving as expected. As I do not understand the changed code I was wondering if
there is a reason why the commit has such an impact on the system resulting in
a decreased networking speed? 

[0]
http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/sys/net/hfsc.c.diff?r1=1.20r2=1.21f=h
-- 
Björn Ketelaars
GPG key: 0x4F0E5F21



Re: r1.21 of sys/net/hfsc.c cripples networking speed

2015-04-23 Thread Theo de Raadt
 After updating one of my machines to a more recent snapshot I noticed that
 networking speed was reduced and that the machine was 'less' responsive.

Be aware there is a fairly expensive debugging diff in the snapshots
(it is not actually commited).