On Wed, May 08, 2019 at 05:31:37PM +0200, Ingo Schwarze wrote:
> Thank you again for doing this work.
+1
> Either way, this seems mature enough for getting it in.
> IMHO, no need to resend it again.
I concur; Ingo's nits are fine.
Feel free to go ahead and commit with OK kn.
Hi Alexandr,
Alexandr Nedvedicky wrote on Wed, May 08, 2019 at 04:55:57PM +0200:
> below is third iteration of pf.conf.5 manpage.
OK schwarze@
A few final nits inline.
Thank you again for doing this work.
Ingo
> diff --git a/share/man/man5/pf.conf.5 b/share/man/man5/pf.conf.5
[...]
> @@
Hello,
below is third iteration of pf.conf.5 manpage. The new addresses
issues as follows:
all excessive "'pfctl -F Reset' ..." are gone.
I've added simple sentence/paragraph at the end of OPTIONS
section:
+.Pp
+.Dq pfctl -F Reset
+restores default values for
On Tue, Apr 30, 2019 at 02:02:12PM +0200, Ingo Schwarze wrote:
>
> > or .Li instead of .Dq maybe
>
> Please don't. We just deprecated .Li (to simplify the language,
> such that authors need to learn fewer macros) and mdoc(7) now says:
>
>Li word ...
> Request a typewriter (literal)
Hi Alexandr,
here are a few additional minor remarks...
Alexandr Nedvedicky wrote on Mon, Apr 29, 2019 at 08:59:55PM +0200:
> diff --git a/sbin/pfctl/pfctl.8 b/sbin/pfctl/pfctl.8
> index b7e941991ba..5e2c57f6bc2 100644
> --- a/sbin/pfctl/pfctl.8
> +++ b/sbin/pfctl/pfctl.8
> @@ -198,7 +198,11 @@
Hi,
Jason McIntyre wrote on Mon, Apr 29, 2019 at 09:53:03PM +0100:
> ah, so singular is correct. but it needs an article of some sort. how
> about:
>
> .Xr pfctl 8
> .Fl F Cm Reset
> restores this value to its default.
>
> to be honest, i don;t like it when we Xr like this,
On Mon, Apr 29, 2019 at 08:59:55PM +0200, Alexandr Nedvedicky wrote:
> attaching updated diff this time.
Lots of good stuff, thanks! I'm sold on mentioning the various defaults
but not quite sure yet whether it's worthwhile to vary on
"pfctl -F Reset restores the default" over and over again (I
On Mon, Apr 29, 2019 at 08:55:40PM +0200, Alexandr Nedvedicky wrote:
> > > @@ -1165,6 +1168,11 @@ and
> > > These keywords correspond to the similar (LOG_) values specified to the
> > > .Xr syslog 3
> > > library routine.
> > > +The default value is
> > > +.Cm err .
> > > +.Xr pfctl 8
> > >
Hello,
hit sent too fast...
attaching updated diff this time.
thanks and
regards
sashan
8<---8<---8<--8<
diff --git a/sbin/pfctl/pfctl.8 b/sbin/pfctl/pfctl.8
index b7e941991ba..5e2c57f6bc2 100644
--- a/sbin/pfctl/pfctl.8
+++
Hello,
comments inline.
> > +section 'OPTIONS', for details.
>
> probably just
>
> See
> .Xr pf.conf.5
> .Sx OPTIONS
> for details.
fixed
> > Set the debug
> > .Ar level ,
> > @@ -1165,6 +1168,11 @@ and
> > These keywords correspond to the similar (LOG_)
On Mon, Apr 29, 2019 at 07:48:35PM +0200, Alexandr Nedvedicky wrote:
> Hello,
>
> sorry for extra delay.
>
>
> > i have to say upfront that i dislike this idea of dividing options into
> > classes and then for every option, altering the text to something
> > unwieldy like:
> >
> > This
Hello,
sorry for extra delay.
> i have to say upfront that i dislike this idea of dividing options into
> classes and then for every option, altering the text to something
> unwieldy like:
>
> This runtime option...
>
> it reads very poorly, and this page is big enough as is without
On Thu, Apr 18, 2019 at 02:40:09AM +0200, Alexandr Nedvedicky wrote:
> Hello Ingo,
>
> thank you for all your suggestions. I've accepted all of them.
> updated diff is below.
>
> let me just share some thoughts and clarifications here.
>
morning.
i have to say upfront that i dislike this idea
Hello Ingo,
thank you for all your suggestions. I've accepted all of them.
updated diff is below.
let me just share some thoughts and clarifications here.
>
> I don't feel strongly about mentioning the defaults either way.
> But i tend to think that if something is important enough to provide
Hi Alexandr,
Alexandr Nedvedicky wrote on Wed, Apr 17, 2019 at 12:09:10AM +0200:
> my oracle fellow pointed out [1] a PF documentation can be improved
> a bit, when it comes to newly introduced 'pfctl -FR' (a reset flush
> modifier). I've decided to make manpage changes in separate diff as
> I
Hello,
my oracle fellow pointed out [1] a PF documentation can be improved a bit, when
it comes to newly introduced 'pfctl -FR' (a reset flush modifier). I've
decided to make manpage changes in separate diff as I expect some discussion on
how much detailed the manpage should be. The diff here
16 matches
Mail list logo
