Re: CVS commit: src/sys/kern

2019-09-13 Thread Martin Husemann
On Sat, Sep 14, 2019 at 06:26:34AM +, Martin Husemann wrote: > > Log Message: > > Accept root device specification as NAME=label [..] > Why is this needed? > > I have been using > > config netbsd root on "wedge:Guru-Root" type ffs > > for ages (in the netbsd-7 branch

Re: CVS commit: src/sys/kern

2019-09-13 Thread Martin Husemann
On Fri, Sep 13, 2019 at 01:33:20AM +, Emmanuel Dreyfus wrote: > Module Name: src > Committed By: manu > Date: Fri Sep 13 01:33:20 UTC 2019 > > Modified Files: > src/sys/kern: kern_subr.c > > Log Message: > Accept root device specification as NAME=label > > > To generate a dif

Re: NCHNAMLEN vnode cache limitation removal

2019-09-13 Thread Mouse
> [...], because fexecve is causing rumbles about doing significantly > more reverse lookups. Why is everyone so concerned about finding "the" name of an inode, or indeed any name for an inode? As far as I can tell there has never been any promise that any given inode has any names pointing to it

Re: NCHNAMLEN vnode cache limitation removal

2019-09-13 Thread Rhialto
On Fri 13 Sep 2019 at 18:04:06 +, David Holland wrote: > On Wed, Sep 11, 2019 at 09:43:18AM +0300, Jason Thorpe wrote: > > Another advantage of de-duping the name strings is that you can > > compare names by testing pointer equivalence. > > I'd expect that trying to dedup the strings would d

Re: NCHNAMLEN vnode cache limitation removal

2019-09-13 Thread Christos Zoulas
In article <20190913180602.gb20...@netbsd.org>, David Holland wrote: >On Wed, Sep 11, 2019 at 03:53:18PM +0700, Robert Elz wrote: > > What's more interesting to me is to know just how many long names people > > are seeing which are currently excluded from the cache, and would benefit > > from the

Re: NCHNAMLEN vnode cache limitation removal

2019-09-13 Thread David Holland
On Wed, Sep 11, 2019 at 03:53:18PM +0700, Robert Elz wrote: > What's more interesting to me is to know just how many long names people > are seeing which are currently excluded from the cache, and would benefit > from the change - that is, what percentage of all lookups fail in the > cache for

Re: NCHNAMLEN vnode cache limitation removal

2019-09-13 Thread David Holland
On Wed, Sep 11, 2019 at 09:43:18AM +0300, Jason Thorpe wrote: > > I'm confused; nothing in there should lead to duplicate entries... > > Duplicate names != duplicate entries. > [...] > Another advantage of de-duping the name strings is that you can > compare names by testing pointer equivale

Re: build.sh sets with xz (was Re: vfs cache timing changes)

2019-09-13 Thread Tom Spindler (moof)
On Fri, Sep 13, 2019 at 06:59:42AM -0400, Greg Troxel wrote: > (I have not really been building current so am unclear on the xz > details.) > > I'd like us to keep somewhat separate the notions of: > > someone is doing build.sh release > > someone wants min-size sets at the expense of a lot

Re: build.sh sets with xz (was Re: vfs cache timing changes)

2019-09-13 Thread Greg Troxel
Martin Husemann writes: > On Fri, Sep 13, 2019 at 06:59:42AM -0400, Greg Troxel wrote: >> I'd like us to keep somewhat separate the notions of: >> >> someone is doing build.sh release >> >> someone wants min-size sets at the expense of a lot of cpu time >> >> >> I regularly do build.sh re

Re: build.sh sets with xz (was Re: vfs cache timing changes)

2019-09-13 Thread Joerg Sonnenberger
On Fri, Sep 13, 2019 at 07:06:59AM +0200, Martin Husemann wrote: > I am not sure whether the xz compiled in tools supports the "-T threads" > option, but if it does, we can add "-T 0" to the default args and see how > much that improves things. Jörg, do you know this? It doesn't currently, since i

Re: build.sh sets with xz (was Re: vfs cache timing changes)

2019-09-13 Thread Martin Husemann
On Fri, Sep 13, 2019 at 01:15:07PM +0200, Martin Husemann wrote: > The default is MKDEBUG=no so you probably will not notice the compression > difference that much. > > If you set MKDEBUG=yes you can just as easily set USE_XZ_SETS=no > (or USE_PIGZGZIP=yes if you have pigz installed). Or (evil ha

Re: build.sh sets with xz (was Re: vfs cache timing changes)

2019-09-13 Thread Martin Husemann
On Fri, Sep 13, 2019 at 06:59:42AM -0400, Greg Troxel wrote: > I'd like us to keep somewhat separate the notions of: > > someone is doing build.sh release > > someone wants min-size sets at the expense of a lot of cpu time > > > I regularly do build.sh release, and rsync the releasedir bits

Re: build.sh sets with xz (was Re: vfs cache timing changes)

2019-09-13 Thread Greg Troxel
"Tom Spindler (moof)" writes: >> PS: The xz compression for the debug set takes 36 minutes on my machine. >> We shoudl do something about it. Matt to use -T for more parallelism? > > On older machines, xz's default settings are pretty much unusable, > and USE_XZ_SETS=no (or USE_PIGZGZIP=yes) is a