Re: Proposal, again: Disable autoload of compat_xyz modules

2019-09-27 Thread Christos Zoulas
In article <20190927125444.gb12...@pony.stderr.spb.ru>, Valery Ushakov wrote: > >May be we should take a look at how SNMP did tables in MIB, b/c we are >trying to create just such a table indexed by module name. I think it is simpler than that. > >Also, I'm not that sure about autoload of compa

Re: panic: UBSan: Undefined Behavior in /syzkaller/managers/netbsd-kubsan/kernel/sys/kern/kern_rndq.c:LINE, negation of -ADD Reply-To:

2019-09-27 Thread Rhialto
On Fri 27 Sep 2019 at 21:12:13 +0200, Kamil Rytarowski wrote: > Thank you for the analysis. Please prepare a patch and commit. Please > add in the message: > > Reported-by: syzbot+68c37d09c833f8ec1...@syzkaller.appspotmail.com How about this patch. I managed to avoid getting into 64-bit calculati

Re: panic: UBSan: Undefined Behavior in /syzkaller/managers/netbsd-kubsan/kernel/sys/kern/kern_rndq.c:LINE, negation of -ADD Reply-To:

2019-09-27 Thread Kamil Rytarowski
On 27.09.2019 20:50, Rhialto wrote: > On Fri 27 Sep 2019 at 15:53:47 +0200, Kamil Rytarowski wrote: >> On 27.09.2019 10:19, Rhialto wrote: >>> On Thu 26 Sep 2019 at 01:15:23 +0200, Kamil Rytarowski wrote: Is this patch correct? http://netbsd.org/~kamil/patch-00168-kern_rndq.c-avoid-o

Re: panic: UBSan: Undefined Behavior in /syzkaller/managers/netbsd-kubsan/kernel/sys/kern/kern_rndq.c:LINE, negation of -ADD Reply-To:

2019-09-27 Thread Rhialto
On Fri 27 Sep 2019 at 15:53:47 +0200, Kamil Rytarowski wrote: > On 27.09.2019 10:19, Rhialto wrote: > > On Thu 26 Sep 2019 at 01:15:23 +0200, Kamil Rytarowski wrote: > >> Is this patch correct? > >> > >> http://netbsd.org/~kamil/patch-00168-kern_rndq.c-avoid-overflow.txt > >> > >> This code will ma

Re: Proposal, again: Disable autoload of compat_xyz modules

2019-09-27 Thread Edgar Fuß
> I guess the main fear is that the attacker can put a malicious (and likely > explicitly crafted for a certain bug in NetBSD's linux compat) binary on > your machine and exectue it. Yes, I guess that's the (valid) point. My impression (I stay corrected) is that compat_linux is mostly used to run

Re: Proposal, again: Disable autoload of compat_xyz modules

2019-09-27 Thread Edgar Fuß
> and I'm making a proposal to disable this feature, to prevent this trouble > in the future. Nothing controversial about that, it just makes sense. > > You are not worth my time. Would you mind taking a deep breath and realize that I'm NOT OBJECTING to your proposal? I was just trying to say t

Re: Proposal, again: Disable autoload of compat_xyz modules

2019-09-27 Thread maya
On Fri, Sep 27, 2019 at 12:41:53AM -0400, Mouse wrote: > > Do you want to contribute and do all the actual dirty work for once, > > or you're just here to talk and give your random opinions on things > > you've never invested yourself in? What is your background? What is > > your portfolio? > >

Re: Proposal, again: Disable autoload of compat_xyz modules

2019-09-27 Thread Paul Goyette
On Fri, 27 Sep 2019, Valery Ushakov wrote: On Fri, Sep 27, 2019 at 11:36:08 -, Christos Zoulas wrote: } I propose something very slightly different that can preserve the current } functionality with user action: } } 1. Remove them from standard kernels in architectures where modules are }

Re: Proposal, again: Disable autoload of compat_xyz modules

2019-09-27 Thread Valery Ushakov
On Fri, Sep 27, 2019 at 11:36:08 -, Christos Zoulas wrote: > >} I propose something very slightly different that can preserve the current > >} functionality with user action: > >} > >} 1. Remove them from standard kernels in architectures where modules are > >}supported. Users can add the

Re: panic: UBSan: Undefined Behavior in /syzkaller/managers/netbsd-kubsan/kernel/sys/kern/kern_rndq.c:LINE, negation of -ADD

2019-09-27 Thread Kamil Rytarowski
On 27.09.2019 10:19, Rhialto wrote: > On Thu 26 Sep 2019 at 01:15:23 +0200, Kamil Rytarowski wrote: >> Is this patch correct? >> >> http://netbsd.org/~kamil/patch-00168-kern_rndq.c-avoid-overflow.txt >> >> This code will map the corner case into defined semantics, treating >> delta INT32_MIN as INT

Re: Proposal, again: Disable autoload of compat_xyz modules

2019-09-27 Thread Valery Ushakov
On Fri, Sep 27, 2019 at 10:57:12 +0200, Jarom?r Dole?ek wrote: > Le jeu. 26 sept. 2019 ? 18:08, Manuel Bouyer a ?crit > : > > > > On Thu, Sep 26, 2019 at 05:10:01PM +0200, Maxime Villard wrote: > > > issues for a clearly marginal use case, and given the current general > > ^

Re: Proposal, again: Disable autoload of compat_xyz modules

2019-09-27 Thread Christos Zoulas
In article <201909262031.x8qkvnpv021...@server.cornerstoneservice.ca>, John Nemeth wrote: >On Sep 26, 7:40pm, Christos Zoulas wrote: >} In article <390f4c81-bf1c-443f-f7a9-a379c46b7...@m00nbsd.net>, >} Maxime Villard wrote: >} >I recently made a big set of changes to fix many bugs and vulnerab

Re: Proposal, again: Disable autoload of compat_xyz modules

2019-09-27 Thread tlaronde
On Fri, Sep 27, 2019 at 08:30:40AM +0200, Martin Husemann wrote: > On Thu, Sep 26, 2019 at 09:40:22PM +0200, tlaro...@polynum.com wrote: > > If the vulnerabilities can only be exploited by running Linux binaries, > > IMHO, the point is moot: the ones that don't run Linux binaries are not > > affect

Re: Proposal, again: Disable autoload of compat_xyz modules

2019-09-27 Thread Manuel Bouyer
On Fri, Sep 27, 2019 at 10:57:12AM +0200, Jaromír Dole?ek wrote: > [...] > Given the history, to me it's completely clear compat_linux shouldn't > be on by default. Any possible linux-specific exploits should only be > problem for people actually explicitly enabling it. Let's just stop > pretending

Re: Proposal, again: Disable autoload of compat_xyz modules

2019-09-27 Thread Jaromír Doleček
Le jeu. 26 sept. 2019 à 18:08, Manuel Bouyer a écrit : > > On Thu, Sep 26, 2019 at 05:10:01PM +0200, Maxime Villard wrote: > > issues for a clearly marginal use case, and given the current general > ^^^ > > This is where we dissagree. You guess it's marginal bu

Re: panic: UBSan: Undefined Behavior in /syzkaller/managers/netbsd-kubsan/kernel/sys/kern/kern_rndq.c:LINE, negation of -ADD

2019-09-27 Thread Rhialto
On Thu 26 Sep 2019 at 01:15:23 +0200, Kamil Rytarowski wrote: > Is this patch correct? > > http://netbsd.org/~kamil/patch-00168-kern_rndq.c-avoid-overflow.txt > > This code will map the corner case into defined semantics, treating > delta INT32_MIN as INT32_MIN+1. I don't know if it is important

[no subject]

2019-09-27 Thread Thomas Mueller
from Kamil Rytarowski: > I have managed to get light cross-toolchain producing Linux binaries. > The only dependency is musl (+gmake to build it). Is it necessary to use musl, as opposed to uClibc-ng or glibc? Did you cross-compile from NetBSD to get the cross-toolchain, or did you need some L