Re: GNU vs C99 extern inline

2011-04-20 Thread Iain Hibbert
On Tue, 19 Apr 2011, David Young wrote: 2. kern/kern_sleepq.c:sleepq_insert() The only place this is called aside from that file is compat_sa.c so its probably a gross invasion of the API. Probably a gross invasion. considering what to do about this one, I thought to make it static

Re: GNU vs C99 extern inline

2011-04-19 Thread David Young
On Sat, Apr 16, 2011 at 09:27:41PM +0100, Iain Hibbert wrote: however, I'm not that enamoured of the name, and considering the following (mostly MI) instances that I have found: 1. dev/ic/ad1848.c:ad_read() ad_write() ad_xread()

Re: GNU vs C99 extern inline

2011-04-17 Thread Iain Hibbert
On Sun, 17 Apr 2011, Joerg Sonnenberger wrote: On Sat, Apr 16, 2011 at 09:27:41PM +0100, Iain Hibbert wrote: returning to GNUC vs C99 semantics for inline functions, this is now partly handled with a __c99inline keyword but there are several files in the kernel containing functions marked

GNU vs C99 extern inline

2011-04-16 Thread Iain Hibbert
Hi returning to GNUC vs C99 semantics for inline functions, this is now partly handled with a __c99inline keyword but there are several files in the kernel containing functions marked inline that yet require external linkage as they are also called from other source modules.. this is provided by

Re: GNU vs C99 extern inline

2011-04-16 Thread Joerg Sonnenberger
On Sat, Apr 16, 2011 at 09:27:41PM +0100, Iain Hibbert wrote: returning to GNUC vs C99 semantics for inline functions, this is now partly handled with a __c99inline keyword but there are several files in the kernel containing functions marked inline that yet require external linkage as they