Make vnd(4) work on sparse files

2011-06-24 Thread J. Hannken-Illjes
With the attached diff vnd(4) devices will work on sparse files. - Make the strategy decision a device flag and set to VNF_USE_VN_RDWR for files known to be sparse. - Change handle_with_rdwr() to use POSIX_FADV_NOREUSE advise to disable read ahead. - Keep the amount of mapped pages below 1

Re: Make vnd(4) work on sparse files

2011-06-24 Thread J. Hannken-Illjes
... this time with a diff attached: With the attached diff vnd(4) devices will work on sparse files. - Make the strategy decision a device flag and set to VNF_USE_VN_RDWR for files known to be sparse. - Change handle_with_rdwr() to use POSIX_FADV_NOREUSE advise to disable read ahead. - Keep the

Re: LOCKDEBUG panic: lockdebug_alloc: already initialized

2011-07-02 Thread J. Hannken-Illjes
Looks like the mutex linux_futex.c::futex_lock is missing a mutex_destroy() on module unload to make LOCKDEBUG happy. -- Juergen Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany) On Jul 2, 2011, at 6:29 PM, dieter roelants wrote: On Fri, 1 Jul 2011 13:53:01 +0200 dieter

Make VOP_BWRITE() work with layered fs

2011-07-07 Thread J. Hannken-Illjes
With the attached diff VOP_BWRITE() arguments get changed as - VOP_BWRITE(struct buf *) + VOP_BWRITE(struct vnode *, struct buf *) and all calls become VOP_BWRITE(bp-b_vp, bp). With this change layered file systems no longer treat it special as it is now possible to descend on the

fcntl() F_GETLK semantics vs. test t_vnops.c

2011-07-22 Thread J. Hannken-Illjes
The test fcntl_getlock_pids() from fs/vfs/t_vnops.c assumes fcntl(fd, F_GETLK, lock) returns the blocking lock with the lowest start offset. Our documentation and POSIX.1 document it returning the first lock that blocks but doesn't call for any specific order. Should I fix fcntl() to return the

Re: fcntl() F_GETLK semantics vs. test t_vnops.c

2011-07-22 Thread J. Hannken-Illjes
On Jul 22, 2011, at 12:13 PM, Alexander Nasonov wrote: J. Hannken-Illjes wrote: The test fcntl_getlock_pids() from fs/vfs/t_vnops.c assumes fcntl(fd, F_GETLK, lock) returns the blocking lock with the lowest start offset. Our documentation and POSIX.1 document it returning the first lock

Re: pmap_kenter_pa: mapping already present

2011-08-09 Thread J. Hannken-Illjes
It is a bug that should finally get its PR :-) pmap_pdp_ctor() abuses pmap_kenter_pa() to change the protection of an already existing mapping. According to rmind this is because on x86 pmap_protect() does not work for pmap_kernel(). -- Juergen Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU

Re: panic with 5.99.55 starting postgres

2011-08-26 Thread J. Hannken-Illjes
On Aug 25, 2011, at 11:18 PM, Darren Reed wrote: starting postgres panic's my system every time with this panic: panic: kernel diagnostic assertion uvm_page_locked_p(pg e ../../../../arch/x86/x86/pmap.c, line 3214 From the pmap.c that was used to compile the kernel is this extract,

May pool_cache_get() ever return NULL?

2011-10-06 Thread J. Hannken-Illjes
A short question: Given a pool initialized with pool = pool_cache_init(SIZE, 0, 0, 0, desc, NULL, IPL_NONE, NULL, NULL, NULL); will pool_cache_get(pool, PR_WAITOK) ever return NULL? -- Juergen Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

VOP_GETATTR: locking protocol change proposal

2011-10-09 Thread J . Hannken-Illjes
The vnode locking requirement currently allows to call VOP_GETATTR() on an unlocked vnode. This is orthogonal to all other operations that read data or metadata and want at least a shared lock. It also asks for trouble as the attributes may change while the operation is in progress. With the

Re: VOP_GETATTR: locking protocol change proposal

2011-10-09 Thread J. Hannken-Illjes
On Oct 9, 2011, at 5:02 PM, Emmanuel Dreyfus wrote: J. Hannken-Illjes hann...@eis.cs.tu-bs.de wrote: With the attached diff the locking protocol requests at least a shared lock and all calls to VOP_GETATTR() outside of file systems respect it. Please look at pn_sizemtx in src/fs/puffs

Re: PUFFS deadlock

2012-02-03 Thread J. Hannken-Illjes
On Feb 3, 2012, at 5:45 PM, Emmanuel Dreyfus wrote: Emmanuel Dreyfus m...@netbsd.org wrote: What about adding a timeout in struct puffs_msgpark and use it for inactive operations? Returning EAGAIN from puffs_vnop_inactive seems an easy way to work around this deadlock. I reply to myself.

Re: PUFFS deadlock

2012-02-03 Thread J. Hannken-Illjes
On Feb 3, 2012, at 7:23 PM, Emmanuel Dreyfus wrote: J. Hannken-Illjes hann...@eis.cs.tu-bs.de wrote: So this is on 5.x ? Yes, this is on netbsd-5 For -current the getnewvnode()-getcleanvnode() path has been replaced with a cleaner thread so getnewvnode() always gets a new vnode

Re: PUFFS deadlock

2012-02-03 Thread J. Hannken-Illjes
On Feb 3, 2012, at 8:44 PM, Emmanuel Dreyfus wrote: J. Hannken-Illjes hann...@eis.cs.tu-bs.de wrote: kern/vfs_vnode.c rev. 1.12 and 1.13 should be sufficient -- but it needs some testing on netbsd-5. kern/vfs_vnode.c does not even exist on netbsd-5, I guess it means

Re: Snapshots in tmpfs

2012-02-23 Thread J. Hannken-Illjes
On Feb 22, 2012, at 1:52 PM, Martin Husemann wrote: Note that we already have file system snapshots for ffs file systems, see fss(4). They are used for backup purposes (atomically create a snapshot, while the file system is busy, then backup the now quiet snapshot) - among others. Right --

Re: CVS commit: src

2012-03-14 Thread J. Hannken-Illjes
On Mar 14, 2012, at 10:55 AM, Martin Husemann wrote: On Tue, Mar 13, 2012 at 06:41:18PM +, Elad Efrat wrote: Log Message: Replace the remaining KAUTH_GENERIC_ISSUSER authorization calls with something meaningful. All relevant documentation has been updated or written. Most of these

Re: CVS commit: src

2012-03-16 Thread J. Hannken-Illjes
On Mar 14, 2012, at 10:55 AM, Martin Husemann wrote: On Tue, Mar 13, 2012 at 06:41:18PM +, Elad Efrat wrote: Log Message: Replace the remaining KAUTH_GENERIC_ISSUSER authorization calls with something meaningful. All relevant documentation has been updated or written. Most of these

Re: selectively disabling atime updates?

2012-05-31 Thread J. Hannken-Illjes
A null mount should do the job and this fstab entry should work: /path/to/orig /path/to/ovarlay null ro,noatime -- Juergen Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany) On May 31, 2012, at 2:14 PM, Edgar Fuß wrote: Walking a directory tree (e.g. during a

Re: selectively disabling atime updates?

2012-06-11 Thread J. Hannken-Illjes
On Jun 11, 2012, at 3:45 PM, Edgar Fuß wrote: This makes me think that /etc/daily should take similar steps, whatever they turn out to be. Yes, allthough my RAIDframe performance test results show that the effect decreases with larger block sizes. I can think of two ways to acheive this

Re: fss status (was: selectively disabling atime updates?)

2012-06-11 Thread J. Hannken-Illjes
On Jun 11, 2012, at 5:17 PM, Edgar Fuß wrote: No, snapshots are supported in 6.0. Ah, great! Someone should adjust the ffsconfig(8) man page, then: $ man fssconfig | tail -5 BUGS The fss(4) driver is experimental. Be sure you have a backup before you use it. NetBSD 6.0_BETA

Re: selectively disabling atime updates?

2012-06-11 Thread J. Hannken-Illjes
On Jun 11, 2012, at 8:25 PM, Manuel Bouyer wrote: On Mon, Jun 11, 2012 at 01:18:17PM -0400, Greg Troxel wrote: Thor Lancelot Simon t...@panix.com writes: On Mon, Jun 11, 2012 at 05:52:27PM +0200, Edgar Fu? wrote: Yes, but I have to question whether and why it would improve performance in

Re: fss: Inappropriate ioctl for device (on dk*)

2012-07-28 Thread J. Hannken-Illjes
On Jul 28, 2012, at 1:08 AM, Edgar Fuß wrote: Now, additionally to fssconfig -c not working at all for me (it does work without -c), it now looks that it doesn't work on wedges: snip That's on 6.0_BETA2/amd64. Should work on wedges for -current, try attached patch for NetBSD-5 or -6. For me

Re: fss: Inappropriate ioctl for device (on dk*)

2012-07-28 Thread J. Hannken-Illjes
On Jul 28, 2012, at 5:21 PM, Edgar Fuß wrote: For me (on -current/i386) `fssconfig -c' works Since it's uninitialized memory, that may well be true. The `-c' flag just sets an (initialized) pointer to a function and has nothing to do with setting fss.fss_flags. Please ktrace without `-c'.

Re: fss: Inappropriate ioctl for device (on dk*)

2012-07-28 Thread J. Hannken-Illjes
On Jul 28, 2012, at 5:51 PM, Edgar Fuß wrote: try attached patch for NetBSD-5 or -6. Ah, thanks! I applied the first chunk (I already applied something equivalent to the second myself) and now it works on wedges. Can this be pulled up to 6, please? Requested pullup to NetBSD-5 and

Re: NFS panic

2012-10-25 Thread J. Hannken-Illjes
On Oct 24, 2012, at 5:44 PM, Manuel Bouyer wrote: On Wed, Oct 24, 2012 at 04:07:34PM +0200, Manuel Bouyer wrote: Hello, I just got this panic on a NFS server: uvm_fault(0xfe9069ecf468, 0x0, 1) - e fatal page fault in supervisor mode trap type 6 code 0 rip 804bd391 cs 8 rflags

Re: NFS panic

2012-11-08 Thread J. Hannken-Illjes
try the attached diff that brings back the fix. --J. Hannken-Illjes -hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany) vget.diff Description: Binary data

Re: NFS panic

2012-11-10 Thread J. Hannken-Illjes
On Nov 10, 2012, at 12:20 PM, Manuel Bouyer bou...@antioche.eu.org wrote: On Thu, Nov 08, 2012 at 12:45:55PM +0100, J. Hannken-Illjes wrote: To make it short, Manuels fix was right, me removing it and trying to get it done in vn_lock() is wrong. While vget() vs. cleanvnode() (the cleaner

Re: tstile lockup

2012-11-19 Thread J. Hannken-Illjes
time? -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: tstile lockup

2012-11-19 Thread J. Hannken-Illjes
running `svn ...' as `lockstat -T rwlock svn ...'. By chance we get more information on lock congestion. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: Making forced unmounts work

2012-11-27 Thread J. Hannken-Illjes
On Nov 28, 2012, at 3:59 AM, David Young dyo...@pobox.com wrote: On Mon, Nov 26, 2012 at 03:06:34PM +0100, J. Hannken-Illjes wrote: Comments or objections? I'm wondering if this will fix the bugs in 'mount -u -r /xyz' where a FFS is mounted read-write at /xyz? Sorry, I don't remember any

Re: Problem identified: WAPL/RAIDframe performance problems

2012-11-28 Thread J. Hannken-Illjes
cross the logs end they already come ordered. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: Problem identified: WAPL/RAIDframe performance problems

2012-11-28 Thread J. Hannken-Illjes
. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: Problem identified: WAPL/RAIDframe performance problems

2012-11-28 Thread J. Hannken-Illjes
way to improve that is to copy everything first into a large buffer. Not very efficient. Needing to copy say 8 Mbytes of data and writing it in big chunks will be much faster than writing it many smaller unaligned segments. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: Problem identified: WAPL/RAIDframe performance problems

2012-11-28 Thread J. Hannken-Illjes
. These writes have sizes between 512 bytes and the file system block size. Problem is these writes are not multiples of and are not aligned to file system block size. Collecting the data and writing MAXPHYS bytes aligned to MAXPHYS should improve wapbl on raid. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de

Re: Making forced unmounts work

2012-11-29 Thread J. Hannken-Illjes
On Nov 29, 2012, at 5:17 PM, David Holland dholland-t...@netbsd.org wrote: On Mon, Nov 26, 2012 at 03:06:34PM +0100, J. Hannken-Illjes wrote: In short the attached diff: - Adds a new kernel-internal errno ERESTARTVOP and changes VCALL() to restart a vnode operation once it returns

Re: Making forced unmounts work

2012-12-02 Thread J . Hannken-Illjes
On Dec 2, 2012, at 5:00 AM, David Holland dholland-t...@netbsd.org wrote: On Thu, Nov 29, 2012 at 06:19:37PM +0100, J. Hannken-Illjes wrote: In short the attached diff: - Adds a new kernel-internal errno ERESTARTVOP and changes VCALL() to restart a vnode operation once it returns

Re: wapbl_flush() speedup

2012-12-04 Thread J. Hannken-Illjes
On Dec 4, 2012, at 8:10 PM, Michael van Elst mlel...@serpens.de wrote: hann...@eis.cs.tu-bs.de (J. Hannken-Illjes) writes: The attached diff tries to coalesce writes to the journal in MAXPHYS sized and aligned blocks. [...] Comments or objections anyone? + * Write data to the log

Re: wapbl_flush() speedup

2012-12-04 Thread J. Hannken-Illjes
On Dec 4, 2012, at 10:11 PM, David Laight da...@l8s.co.uk wrote: On Tue, Dec 04, 2012 at 09:53:11PM +0100, J. Hannken-Illjes wrote: On Dec 4, 2012, at 8:10 PM, Michael van Elst mlel...@serpens.de wrote: hann...@eis.cs.tu-bs.de (J. Hannken-Illjes) writes: The attached diff tries

Re: wapbl_flush() speedup

2012-12-05 Thread J. Hannken-Illjes
(names and comments) is attached. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany) Index: vfs_wapbl.c === RCS file: /cvsroot/src/sys/kern/vfs_wapbl.c,v retrieving revision 1.53 diff -p -u -2 -r1.53 vfs_wapbl.c

Re: Making forced unmounts work

2012-12-05 Thread J. Hannken-Illjes
. David wants forced unmounts to work even if a thread gets stuck permanently in a vnode operation. I don't see a way to safely reclaim a vnode from a file system when this vnode is in use by another thread. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: Making forced unmounts work

2012-12-06 Thread J. Hannken-Illjes
On Dec 6, 2012, at 8:32 AM, Michael van Elst mlel...@serpens.de wrote: hann...@eis.cs.tu-bs.de (J. Hannken-Illjes) writes: David wants forced unmounts to work even if a thread gets stuck permanently in a vnode operation. How can it get stuck (short of bugs) ? Here we are talking about

Re: Making forced unmounts work

2012-12-06 Thread J. Hannken-Illjes
it possible to suspend it. I did not dig deeper but as the nfs client already has timeout mechanisms it should be possible to cover this kind of problem. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: Making forced unmounts work

2012-12-08 Thread J. Hannken-Illjes
device currently mounted. In this case the disk driver should error out and all threads should come back with an I/O-error. If this is not the case the driver is buggy. - Refcount and other bugs ... should be fixed ... -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Fstrans rewrite without rwlock

2013-01-13 Thread J . Hannken-Illjes
-- comments? -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany) vfs_trans.c Description: Binary data

Re: Fstrans rewrite without rwlock

2013-01-13 Thread J. Hannken-Illjes
On Jan 13, 2013, at 7:24 PM, Greg Troxel g...@ir.bbn.com wrote: J. Hannken-Illjes hann...@eis.cs.tu-bs.de writes: Attached is a complete rewrite based on passive serialization and condvars. The fast paths (fstrans_start/fstrans_done on a file system not suspended or suspending

Making spec_node table opaque

2013-02-08 Thread J. Hannken-Illjes
diagnostic checks vp == ... sd_bdevvp will not fire. Otherwise any vnode matching the criteria gets returned. Comments or objections? -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany) spec_dev.diff Description: Binary data

Re: [GSoC 2013] Implement file system flags to scrub data blocks before deletion

2013-05-17 Thread J. Hannken-Illjes
not planning to implement undelete instead, unless it is really wanted. Mrs. S.P.Zeidler suggested I posted here, yet I started on tech-security, I apologize and hope discussion won't diverge. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: device vnodes, and structural confusion

2013-06-17 Thread J. Hannken-Illjes
device nodes to be flushed. More on that when my ideas solidify a bit. -- David A. Holland dholl...@netbsd.org -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: NFS over-quota not detected if utimes() called before fsync()/close()

2013-08-01 Thread J. Hannken-Illjes
an error for all errors. No - nfs_vinvalbuf() returns zero or EINTR, there are no other errors. Does vinvalbuf() return an error from fsync here thats gets missed because vinvalbuf() loops until it returns zero? -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

NFS client fix - was NFS over-quota not detected if utimes() called before fsync()/close()

2013-08-06 Thread J. Hannken-Illjes
On Aug 1, 2013, at 10:31 AM, J. Hannken-Illjes hann...@eis.cs.tu-bs.de wrote: On Jul 31, 2013, at 10:04 PM, Christos Zoulas chris...@astron.com wrote: In article 20130730211200.gd96...@trav.math.uni-bonn.de, Edgar Fuß e...@math.uni-bonn.de wrote: I think the problem is in nfs_setattr

Re: [GSoC 2013] Implement file system flags to scrub data blocks before deletion

2013-09-17 Thread J. Hannken-Illjes
need to read page(s) from backing store and VOP_GETPAGES() takes and releases the GLOCK. So ubc_zerorange() has to be called before taking the GLOCK. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: high load, no bottleneck

2013-09-17 Thread J. Hannken-Illjes
nfsrv_fhtovp nfsrv_write nfssvc_nfsd sys_nfssvc What are your clients doing? Which vnode(s) are your nfsd threads waiting on (first arg to vn_lock)? -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: fixing the vnode lifecycle

2013-09-25 Thread J. Hannken-Illjes
that all the crap like VI_INACTNOW needs to go away. I see no reason that the vnode cache shouldn't just lock the vnode with the normal vnode lock while calling VOP_INACTIVE. This is the protocol already: locked on entry and unlocked on return -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU

Vnode API cleanup pass 1

2013-10-21 Thread J . Hannken-Illjes
) { return v_usecount MASK; } Comments or objections anyone? -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany) vnapi.diff Description: Binary data

Re: fsck_ffs -X, panic: wapbl_register_deallocation: out of resources

2013-10-30 Thread J. Hannken-Illjes
works fine. File system internal snapshots are expensive on large file systems as we have to build and clean a copy of all meta data. You could try file system external snapshots (-x /path/to/backup). -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Replace VI_INACT*

2013-11-19 Thread J. Hannken-Illjes
. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany) vi_changing.diff Description: Binary data

Re: Processes get stuck in layerfs in NetBSD 6.99.28 i386

2013-12-07 Thread J. Hannken-Illjes
/pbulk/dev/pts type ptyfs (local) Could you drop to ddb and get the stack trace of this thread and threads in tstile? ps /l gives a thread list with STRUCT LWP * bt /a 0x give a stack trace for this lwp -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: physio split the request.. cannot proceed

2013-12-23 Thread J. Hannken-Illjes
: tape records bigger than MAXPHYS (most time 64k) don't work. It means physio() broke the request into MAXPHYS chunks and the tape driver needs the full request at once to read or write a record. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: physio split the request.. cannot proceed

2013-12-23 Thread J. Hannken-Illjes
On Dec 23, 2013, at 11:15 AM, Emmanuel Dreyfus m...@netbsd.org wrote: On Mon, Dec 23, 2013 at 11:11:10AM +0100, J. Hannken-Illjes wrote: In short: tape records bigger than MAXPHYS (most time 64k) don't work. Is it a NetBSD limitation that should be fixed in NetBSD, or an non standard

Re: physio split the request.. cannot proceed

2013-12-23 Thread J. Hannken-Illjes
On Dec 23, 2013, at 11:59 AM, Emmanuel Dreyfus m...@netbsd.org wrote: On Mon, Dec 23, 2013 at 11:11:10AM +0100, J. Hannken-Illjes wrote: In short: tape records bigger than MAXPHYS (most time 64k) don't work. I adjusted the function that detects tape block size so that it is capped

Re: physio split the request.. cannot proceed

2013-12-23 Thread J. Hannken-Illjes
On Dec 23, 2013, at 1:54 PM, m...@netbsd.org (Emmanuel Dreyfus) wrote: J. Hannken-Illjes hann...@eis.cs.tu-bs.de wrote: According to T10.ORG scsi commands a3/a4 for sequential devices are optional: OP DTLPWROMAEBKVF Description A3 OOO O OOMOOOM MAINTENANCE IN A4 OOO O OOO

Re: physio split the request.. cannot proceed

2013-12-23 Thread J. Hannken-Illjes
On Dec 23, 2013, at 3:00 PM, Emmanuel Dreyfus m...@netbsd.org wrote: On Mon, Dec 23, 2013 at 02:54:42PM +0100, J. Hannken-Illjes wrote: This is XS_SHORTSENSE (it also matches retsts being 0x04). It is an atapi drive? No, SAS through the mpii driver. That doesn't make sense -- as far

Vnode API cleanup pass 2a

2013-12-30 Thread J. Hannken-Illjes
operations to return unlocked (and referenced) vnodes. The attached diff implements this change for operations create, mknod, mkdir and symlink. It passes the atf test suite and some file system stress tests I use here. Comments or objections anyone? -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU

Re: Vnode API cleanup pass 2a

2013-12-30 Thread J. Hannken-Illjes
On Dec 30, 2013, at 4:12 PM, Taylor R Campbell campbell+netbsd-tech-k...@mumble.net wrote: Date: Mon, 30 Dec 2013 11:35:48 +0100 From: J. Hannken-Illjes hann...@eis.cs.tu-bs.de The layered file systems hashlists currently have to work on locked vnodes as the vnode operations

Re: Vnode API cleanup pass 2a

2013-12-31 Thread J . Hannken-Illjes
On Dec 30, 2013, at 10:58 PM, David Holland dholland-t...@netbsd.org wrote: On Mon, Dec 30, 2013 at 11:35:48AM +0100, J. Hannken-Illjes wrote: The layered file systems hashlists currently have to work on locked vnodes as the vnode operations returning vnodes return them locked. This leads

Re: Vnode API cleanup pass 2a

2014-01-04 Thread J. Hannken-Illjes
On Dec 31, 2013, at 11:34 AM, J. Hannken-Illjes hann...@eis.cs.tu-bs.de wrote: On Dec 30, 2013, at 10:58 PM, David Holland dholland-t...@netbsd.org wrote: On Mon, Dec 30, 2013 at 11:35:48AM +0100, J. Hannken-Illjes wrote: The layered file systems hashlists currently have to work on locked

Re: Vnode API cleanup pass 2a

2014-01-07 Thread J. Hannken-Illjes
On Jan 7, 2014, at 5:29 AM, David Holland dholland-t...@netbsd.org wrote: On Tue, Dec 31, 2013 at 11:34:27AM +0100, J. Hannken-Illjes wrote: The layered file systems hashlists currently have to work on locked vnodes as the vnode operations returning vnodes return them locked. This leads

Re: Vnode API cleanup pass 2a

2014-01-07 Thread J. Hannken-Illjes
On Jan 7, 2014, at 5:30 AM, David Holland dholland-t...@netbsd.org wrote: On Mon, Dec 30, 2013 at 05:26:14PM +0100, J. Hannken-Illjes wrote: This seems to largely add code to file systems to mess with locking further, rather than reducing that code. What do you mean with mess here? Can

Re: Vnode API cleanup pass 2a

2014-01-08 Thread J. Hannken-Illjes
is to commit next monday, 2014-01-13 -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: Vnode API cleanup pass 2a

2014-01-13 Thread J . Hannken-Illjes
On Jan 13, 2014, at 8:39 AM, David Holland dholland-t...@netbsd.org wrote: On Tue, Jan 07, 2014 at 11:30:40AM +0100, J. Hannken-Illjes wrote: (also, while this is minor I think I'd rather have vop_mkdir_args_v2 and/or vop_mkdir_desc_v2 rather than vop_mkdir2_args and vop_mkdir2_desc

Re: Vnode API cleanup pass 2a

2014-01-14 Thread J. Hannken-Illjes
On Jan 14, 2014, at 5:54 AM, David Holland dholland-t...@netbsd.org wrote: On Mon, Jan 13, 2014 at 04:06:02PM +0100, J. Hannken-Illjes wrote: snip Even though it looks like we don't need creation ops to return with locked directory at the moment it may be better to do this change now so

Re: Vnode API cleanup pass 2a

2014-01-15 Thread J. Hannken-Illjes
On Jan 14, 2014, at 5:12 PM, J. Hannken-Illjes hann...@eis.cs.tu-bs.de wrote: On Jan 14, 2014, at 5:54 AM, David Holland dholland-t...@netbsd.org wrote: On Mon, Jan 13, 2014 at 04:06:02PM +0100, J. Hannken-Illjes wrote: snip Even though it looks like we don't need creation ops to return

Re: Vnode API cleanup pass 2a

2014-01-16 Thread J. Hannken-Illjes
On Jan 16, 2014, at 2:45 PM, Taylor R Campbell campbell+netbsd-tech-k...@mumble.net wrote: Date: Thu, 16 Jan 2014 07:07:56 + From: David Holland dholland-t...@netbsd.org On Wed, Jan 15, 2014 at 04:31:07PM +0100, J. Hannken-Illjes wrote: I put a diff to http://www.netbsd.org

Re: Vnode API cleanup pass 2a

2014-01-20 Thread J . Hannken-Illjes
Back to vnode creation operations returning unlocked vnodes I put a new diff to http://www.netbsd.org/~hannken/vnode-pass2a-4.diff Any more objections or OK to commit? -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: Vnode API cleanup pass 2a

2014-01-21 Thread J . Hannken-Illjes
On Jan 20, 2014, at 5:02 PM, Taylor R Campbell campbell+netbsd-tech-k...@mumble.net wrote: Date: Mon, 20 Jan 2014 16:01:07 +0100 From: J. Hannken-Illjes hann...@eis.cs.tu-bs.de Back to vnode creation operations returning unlocked vnodes I put a new diff to http://www.netbsd.org

Vnode API change: VOP_LOOKUP

2014-02-03 Thread J . Hannken-Illjes
gets replaced or enhanced with a vnode/inode hash list that looks up vnodes without locking them. Diff at: http://www.netbsd.org/~hannken/vnode-pass2b-1.diff Comments or objections anyone? -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: Vnode API change: VOP_LOOKUP

2014-02-06 Thread J. Hannken-Illjes
On Feb 6, 2014, at 4:52 PM, Taylor R Campbell campbell+netbsd-tech-k...@mumble.net wrote: Date: Mon, 3 Feb 2014 12:04:27 +0100 From: J. Hannken-Illjes hann...@eis.cs.tu-bs.de As announced some weeks ago here comes the API change to VOP_LOOKUP: Change vnode operation lookup

Re: Vnode API change: VOP_LOOKUP

2014-02-06 Thread J. Hannken-Illjes
On Feb 6, 2014, at 4:23 PM, Taylor R Campbell campbell+netbsd-tech-k...@mumble.net wrote: Date: Mon, 3 Feb 2014 12:04:27 +0100 From: J. Hannken-Illjes hann...@eis.cs.tu-bs.de As announced some weeks ago here comes the API change to VOP_LOOKUP: Change vnode operation lookup

Vnode API change: VOP_LOCK

2014-02-21 Thread J. Hannken-Illjes
or objections anyone? -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: Vnode API change: VOP_LOCK

2014-02-21 Thread J. Hannken-Illjes
with formatting.) Deadfs is a pseudo file system for vnodes no longer attached to a real file system, they either are inactive and have been reclaimed or a forced unmount or revoke reclaimed them from their file system. These nodes still need an operations vector and this vector is deadfs. -- J. Hannken-Illjes

Add a dead mount

2014-02-23 Thread J. Hannken-Illjes
? -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: Vnode API change: VOP_LOCK

2014-02-26 Thread J . Hannken-Illjes
On Feb 25, 2014, at 10:28 PM, Taylor R Campbell campbell+netbsd-tech-k...@mumble.net wrote: Date: Tue, 25 Feb 2014 15:11:04 +0100 From: J. Hannken-Illjes hann...@eis.cs.tu-bs.de I'm quite sure we cannot kill ALL instances of LK_RETRY as OK, perhaps not yet. But: - at least

Re: rototilling the vnode life cycle

2014-02-28 Thread J. Hannken-Illjes
count. Later we got the freelist holding held vnodes -- this list was never recycled from. Later yamt changed it to recycle held vnodes after trying to recycle free nodes. So I suppose we are free to (re-)define hold counts or simply remove them if they don't get needed. -- J. Hannken-Illjes - hann

Re: rototilling the vnode life cycle

2014-02-28 Thread J. Hannken-Illjes
for example will fall through to vgone. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Vnode API change: mnt_vnodelist traversal

2014-03-03 Thread J. Hannken-Illjes
() is at http://www.netbsd.org/~hannken/vnode-pass4-1.diff Once all operations are converted, vmark() / vunmark() will go and man pages will be updated. Comments or objections anyone? -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: Vnode API change: mnt_vnodelist traversal

2014-03-03 Thread J. Hannken-Illjes
On Mar 3, 2014, at 3:28 PM, Taylor R Campbell campbell+netbsd-tech-k...@mumble.net wrote: Date: Mon, 3 Mar 2014 11:11:04 +0100 From: J. Hannken-Illjes hann...@eis.cs.tu-bs.de Add an interface to iterate over a vnode list: void vfs_vnode_iterator_init(struct mount *mp, void

Re: Vnode API change: mnt_vnodelist traversal

2014-03-03 Thread J. Hannken-Illjes
On Mar 3, 2014, at 4:11 PM, Taylor R Campbell campbell+netbsd-tech-k...@mumble.net wrote: Date: Mon, 3 Mar 2014 15:55:16 +0100 From: J. Hannken-Illjes hann...@eis.cs.tu-bs.de On Mar 3, 2014, at 3:28 PM, Taylor R Campbell campbell+netbsd-tech-k...@mumble.net wrote: /* mount.h

Re: Vnode API change: mnt_vnodelist traversal

2014-03-03 Thread J. Hannken-Illjes
On Mar 3, 2014, at 4:25 PM, Taylor R Campbell campbell+netbsd-tech-k...@mumble.net wrote: Date: Mon, 3 Mar 2014 16:19:40 +0100 From: J. Hannken-Illjes hann...@eis.cs.tu-bs.de On Mar 3, 2014, at 4:11 PM, Taylor R Campbell campbell+netbsd-tech-k...@mumble.net wrote: That is exactly

Vnode API change: VI_CLEAN and VI_XLOCK

2014-03-21 Thread J. Hannken-Illjes
is at http://www.netbsd.org/~hannken/vnode-pass5-1.diff Comments or objections anyone? -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: Vnode API change: VI_CLEAN and VI_XLOCK

2014-03-21 Thread J. Hannken-Illjes
On Mar 21, 2014, at 3:07 PM, Taylor R Campbell campbell+netbsd-tech-k...@mumble.net wrote: Date: Fri, 21 Mar 2014 11:10:54 +0100 From: J. Hannken-Illjes hann...@eis.cs.tu-bs.de The vnode flags VI_CLEAN and VI_XLOCK are used in file systems to check for reclaimed or reclaiming

Re: DIOCDISCARD, fdiscard, and fallocate

2014-03-24 Thread J. Hannken-Illjes
); This will now be: if (vdead_check(vp, VDEAD_NOWAIT) == 0 vp-v_specnode != NULL) There is no need to unlock/relock the vnode here. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Vnode API change: add global vnode cache

2014-04-06 Thread J. Hannken-Illjes
://www.netbsd.org/~hannken/vnode-pass6-1.diff Comments or objections anyone? -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)

Re: Vnode API change: add global vnode cache

2014-04-06 Thread J. Hannken-Illjes
On 06 Apr 2014, at 21:12, David Holland dholland-t...@netbsd.org wrote: On Sun, Apr 06, 2014 at 12:14:24PM +0200, J. Hannken-Illjes wrote: Currently all file systems have to implement their own cache of vnode / fs node pairs. Most file systems use a copy and pasted version of ufs_ihash

Re: Vnode API change: add global vnode cache

2014-04-07 Thread J. Hannken-Illjes
On 07 Apr 2014, at 03:22, Taylor R Campbell campbell+netbsd-tech-k...@mumble.net wrote: Date: Sun, 6 Apr 2014 12:14:24 +0200 From: J. Hannken-Illjes hann...@eis.cs.tu-bs.de Currently all file systems have to implement their own cache of vnode / fs node pairs. Most file systems use

Re: Vnode API change: add global vnode cache

2014-04-07 Thread J. Hannken-Illjes
On 07 Apr 2014, at 17:44, Mindaugas Rasiukevicius rm...@netbsd.org wrote: J. Hannken-Illjes hann...@eis.cs.tu-bs.de wrote: Currently all file systems have to implement their own cache of vnode / fs node pairs. Most file systems use a copy and pasted version of ufs_ihash. So add a global

Re: Vnode API change: add global vnode cache

2014-04-07 Thread J. Hannken-Illjes
On 07 Apr 2014, at 18:02, Taylor R Campbell campbell+netbsd-tech-k...@mumble.net wrote: Date: Mon, 7 Apr 2014 15:51:00 +0200 From: J. Hannken-Illjes hann...@eis.cs.tu-bs.de On 07 Apr 2014, at 03:22, Taylor R Campbell campbell+netbsd-tech-k...@mumble.net wrote: Is the plan to nix

Re: Vnode API change: add global vnode cache

2014-04-07 Thread J. Hannken-Illjes
On 07 Apr 2014, at 18:38, Taylor R Campbell campbell+netbsd-tech-k...@mumble.net wrote: Date: Mon, 7 Apr 2014 18:32:02 +0200 From: J. Hannken-Illjes hann...@eis.cs.tu-bs.de On 07 Apr 2014, at 18:02, Taylor R Campbell campbell+netbsd-tech-k...@mumble.net wrote: In that case

Re: Vnode API change: add global vnode cache

2014-04-08 Thread J. Hannken-Illjes
On 07 Apr 2014, at 19:28, Chuck Silvers c...@chuq.com wrote: On Sun, Apr 06, 2014 at 12:14:24PM +0200, J. Hannken-Illjes wrote: Currently all file systems have to implement their own cache of vnode / fs node pairs. Most file systems use a copy and pasted version of ufs_ihash. So add

Re: Vnode API change: add global vnode cache

2014-04-09 Thread J. Hannken-Illjes
On 07 Apr 2014, at 18:02, Taylor R Campbell campbell+netbsd-tech-k...@mumble.net wrote: Date: Mon, 7 Apr 2014 15:51:00 +0200 From: J. Hannken-Illjes hann...@eis.cs.tu-bs.de On 07 Apr 2014, at 03:22, Taylor R Campbell campbell+netbsd-tech-k...@mumble.net wrote: Is the plan to nix

Re: Vnode API change: add global vnode cache

2014-04-09 Thread J. Hannken-Illjes
On 09 Apr 2014, at 15:57, Taylor R Campbell campbell+netbsd-tech-k...@mumble.net wrote: Date: Wed, 9 Apr 2014 11:10:37 +0200 From: J. Hannken-Illjes hann...@eis.cs.tu-bs.de There is no need to do this VI_CHANGING etc. here. Primary goal of the vnode cache is to always initialise

  1   2   3   >