re: [PATCH] Move DRM-driver firmware from base to its own set, gpufw

2021-09-25 Thread matthew green
this looks good.  thanks for doing it.

> Comments:
> Switched to a single MK tunable for it - that is probably unneeded.
> Might be an issue for not obsoleting directories on non-DRM archs.

please put back the separate firmwares -- there are x86-only
ones coming so we want to be able to choose them more easily,
and it would be nice if i hvae a nvidia-only setup to be able
to turn off amd/intel etc, i my special build.

thanks.


.mrg.


Re: [PATCH] Move DRM-driver firmware from base to its own set, gpufw

2021-09-23 Thread Joerg Sonnenberger
On Thu, Sep 23, 2021 at 02:43:22PM +, coypu wrote:
> This set is only installed on amd64,i386,evbarm.

I wonder if we shouldn't allow re-triggering firmware load via either
sysctl or drvctl and just move them to outside root. Even the option to
load them from pkgsrc might be useful.

Joerg


Re: [PATCH] Move DRM-driver firmware from base to its own set, gpufw

2021-09-23 Thread coypu
On Thu, Sep 23, 2021 at 02:43:23PM +, coypu wrote:
> Might be an issue for not obsoleting directories on non-DRM archs.

So it wasn't, they are created unconditionally, so I need this
additional change:


---
Squash - directories are created unconditionally. Put back in base/mi

---
 distrib/sets/lists/base/mi  | 4 
 distrib/sets/lists/gpufw/mi | 3 ---
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/distrib/sets/lists/base/mi b/distrib/sets/lists/base/mi
index 167969606ea6..d409096cef1c 100644
--- a/distrib/sets/lists/base/mi
+++ b/distrib/sets/lists/base/mi
@@ -265,6 +265,9 @@
 ./libdata/firmware/if_wpi/README.iwlwifi-3945-ucodebase-firmware-root  
firmware
 ./libdata/firmware/if_wpi/ipw3945.ucodebase-obsolete   
obsolete,firmware
 ./libdata/firmware/if_wpi/iwlwifi-3945.ucode   base-firmware-root  
firmware
+./libdata/firmware/nouveau base-firmware-usr
+./libdata/firmware/nouveau/nvidia  base-firmware-usr
+./libdata/firmware/nouveau/nvidia/gm206
base-firmware-usr
 ./libdata/firmware/nvidia  base-firmware-root
 ./libdata/firmware/nvidia/tegra124 base-firmware-root
 ./libdata/firmware/nvidia/tegra124/LICENCE.nvidia  base-firmware-root  
tegrafirmware
@@ -282,6 +285,7 @@
 ./libdata/firmware/qat/qat_c62x_mmp.binbase-firmware-root  
firmware
 ./libdata/firmware/qat/qat_d15xx.bin   base-firmware-root  firmware
 ./libdata/firmware/qat/qat_d15xx_mmp.bin   base-firmware-root  firmware
+./libdata/firmware/radeon  base-firmware-usr
 ./libdata/firmware/ral base-firmware-root
 ./libdata/firmware/ral/ral-license base-firmware-root  firmware
 ./libdata/firmware/ral/ral-rt2561  base-firmware-root  firmware
diff --git a/distrib/sets/lists/gpufw/mi b/distrib/sets/lists/gpufw/mi
index 6d14ba5dae86..856eff5b7d45 100644
--- a/distrib/sets/lists/gpufw/mi
+++ b/distrib/sets/lists/gpufw/mi
@@ -3,15 +3,12 @@
 # Note: don't delete entries from here - mark them as "obsolete" instead.
 #
 ./etc/mtree/set.gpufw  base-gpufw
-./libdata/firmware/nouveau  base-gpufw
-./libdata/firmware/nouveau/nvidia   base-gpufw
 ./libdata/firmware/nouveau/nvidia/LICENCE.nvidiabase-gpufw   
gpufirmware
 ./libdata/firmware/nouveau/nvidia/gm206 base-gpufw
 ./libdata/firmware/nouveau/nvidia/gm206/fecs_data.bin   base-gpufw   
gpufirmware
 ./libdata/firmware/nouveau/nvidia/gm206/fecs_inst.bin   base-gpufw   
gpufirmware
 ./libdata/firmware/nouveau/nvidia/gm206/gpccs_data.bin  base-gpufw   
gpufirmware
 ./libdata/firmware/nouveau/nvidia/gm206/gpccs_inst.bin  base-gpufw   
gpufirmware
-./libdata/firmware/radeon  base-gpufw
 ./libdata/firmware/radeon/ARUBA_me.bin base-gpufw  gpufirmware
 ./libdata/firmware/radeon/ARUBA_pfp.binbase-gpufw  
gpufirmware
 ./libdata/firmware/radeon/ARUBA_rlc.binbase-gpufw  
gpufirmware
-- 
2.28.0




Re: [PATCH] Move DRM-driver firmware from base to its own set, gpufw

2021-09-23 Thread Martin Husemann
On Thu, Sep 23, 2021 at 05:10:46PM +, co...@sdf.org wrote:
> Hi David,
> 
> On Thu, Sep 23, 2021 at 05:41:45PM +0100, David Brownlee wrote:
> > If gpu firmware is somewhat special, is there any sense in moving it
> > to /usr/libdata/firmware/gpu/... ?
> 
> It's not particularly special, but only some platforms have DRM drivers
> and it is about to get fat with the addition of amdgpu firmware.

I like the proposal.

I was about to suggest (while we are touching it) to split out the other
firmware to a separate set, but when I looked it is just 31 MB (and
that already includes some firmware that will move to the gpu set) on 
non-x86, which even with a small SD card as root on some evbarm SoC
is not that bad.

Martin


Re: [PATCH] Move DRM-driver firmware from base to its own set, gpufw

2021-09-23 Thread coypu
Hi David,

On Thu, Sep 23, 2021 at 05:41:45PM +0100, David Brownlee wrote:
> If gpu firmware is somewhat special, is there any sense in moving it
> to /usr/libdata/firmware/gpu/... ?

It's not particularly special, but only some platforms have DRM drivers
and it is about to get fat with the addition of amdgpu firmware.


Re: [PATCH] Move DRM-driver firmware from base to its own set, gpufw

2021-09-23 Thread David Brownlee
On Thu, 23 Sept 2021 at 17:57, Robert Swindells  wrote:
>
> David Brownlee  wrote:
> >
> >If gpu firmware is somewhat special, is there any sense in moving it
> >to /usr/libdata/firmware/gpu/... ?
>
> No.
>
> It needs to be in /libdata so that it is guaranteed to be on the boot
> filesystem.

Apologies - read that as libdata/firmware -> libdata/firmware/gpu

David


Re: [PATCH] Move DRM-driver firmware from base to its own set, gpufw

2021-09-23 Thread Robert Swindells


David Brownlee  wrote:
>
>If gpu firmware is somewhat special, is there any sense in moving it
>to /usr/libdata/firmware/gpu/... ?

No.

It needs to be in /libdata so that it is guaranteed to be on the boot
filesystem.


Re: [PATCH] Move DRM-driver firmware from base to its own set, gpufw

2021-09-23 Thread David Brownlee
If gpu firmware is somewhat special, is there any sense in moving it
to /usr/libdata/firmware/gpu/... ?

David