re: ./build.sh -k feature request (was Re: GENERIC Kernel Build errors with -fsanitize=undefined option enabled)

2018-06-26 Thread matthew green
why can't you just use "nbmake-$foo -k " instead of enabling an option that will lead to odd build issues and support requests. i'd really rather avoid this option in build.sh itself. .mrg.

Re: ./build.sh -k feature request (was Re: GENERIC Kernel Build errors with -fsanitize=undefined option enabled)

2018-06-26 Thread Martin Husemann
On Mon, Jun 25, 2018 at 10:44:36PM +0200, Kamil Rytarowski wrote: > I propose to ensure that MAKEFLAGS is possible to be set from a command > line, from the ./build.sh command line using -V. > > The build process has various stages and after a single failure there > can be false positives in next

Re: ./build.sh -k feature request (was Re: GENERIC Kernel Build errors with -fsanitize=undefined option enabled)

2018-06-25 Thread Mouse
> The full release build is a number of substeps. It makes sense to > use -k for the main build of the system, after the tools build, to > get the "find all problems" property you want. But it's not clear to > me that it makes sense to build the main system if the tool build > fails. In make(1)

Re: ./build.sh -k feature request (was Re: GENERIC Kernel Build errors with -fsanitize=undefined option enabled)

2018-06-25 Thread Kamil Rytarowski
On 25.06.2018 22:33, Reinoud Zandijk wrote: > On Mon, Jun 25, 2018 at 10:29:30PM +0200, Kamil Rytarowski wrote: >> I'm usually going the other direction. If I hit a problem and an issue >> is not visible from a multi-job build (multiple processes print onto the >> same screen concurrently), I go

Re: ./build.sh -k feature request (was Re: GENERIC Kernel Build errors with -fsanitize=undefined option enabled)

2018-06-25 Thread Reinoud Zandijk
On Mon, Jun 25, 2018 at 10:29:30PM +0200, Kamil Rytarowski wrote: > I'm usually going the other direction. If I hit a problem and an issue > is not visible from a multi-job build (multiple processes print onto the > same screen concurrently), I go for -j1. If this is still no enough I > change the

Re: ./build.sh -k feature request (was Re: GENERIC Kernel Build errors with -fsanitize=undefined option enabled)

2018-06-25 Thread Greg Troxel
[grudgingly keeping tech-kern and current-users both :-] Reinoud Zandijk writes: > @@ -1084,6 +1084,9 @@ Usage: ${progname} [-EhnoPRrUuxy] [-a ar > Should not be used without expert knowledge of the build > system. > -h Print this help message. > -j

Re: ./build.sh -k feature request (was Re: GENERIC Kernel Build errors with -fsanitize=undefined option enabled)

2018-06-25 Thread Kamil Rytarowski
On 25.06.2018 20:23, Reinoud Zandijk wrote: > On Sun, Jun 24, 2018 at 10:01:42PM +0200, Reinoud Zandijk wrote: >> On Wed, May 30, 2018 at 07:11:19PM +0800, Harry Pantazis wrote: >>> Continuing.. >>> >>> This first errors are located in >>> src/sys/external/bsd/drm2/dist/drm/i915/intel_ddi.c and

Re: ./build.sh -k feature request (was Re: GENERIC Kernel Build errors with -fsanitize=undefined option enabled)

2018-06-25 Thread Mouse
>> Attached patch will do, objections against me comitting it? It >> allows all that is buildable to be build and the failing files to be >> compiled later when patched with the -u option. > I don't really like this. I would not be surprised if this broke > things in interesting ways for full

Re: ./build.sh -k feature request (was Re: GENERIC Kernel Build errors with -fsanitize=undefined option enabled)

2018-06-25 Thread Joerg Sonnenberger
On Mon, Jun 25, 2018 at 08:23:22PM +0200, Reinoud Zandijk wrote: > On Sun, Jun 24, 2018 at 10:01:42PM +0200, Reinoud Zandijk wrote: > > On Wed, May 30, 2018 at 07:11:19PM +0800, Harry Pantazis wrote: > > > Continuing.. > > > > > > This first errors are located in > > >

Re: ./build.sh -k feature request (was Re: GENERIC Kernel Build errors with -fsanitize=undefined option enabled)

2018-06-25 Thread Reinoud Zandijk
the patch: Index: build.sh === RCS file: /cvsroot/src/build.sh,v retrieving revision 1.327 diff -u -p -r1.327 build.sh --- build.sh2 May 2018 07:34:44 - 1.327 +++ build.sh25 Jun 2018 18:26:34 - @@ -1027,7

Re: ./build.sh -k feature request (was Re: GENERIC Kernel Build errors with -fsanitize=undefined option enabled)

2018-06-25 Thread Reinoud Zandijk
On Sun, Jun 24, 2018 at 10:01:42PM +0200, Reinoud Zandijk wrote: > On Wed, May 30, 2018 at 07:11:19PM +0800, Harry Pantazis wrote: > > Continuing.. > > > > This first errors are located in > > src/sys/external/bsd/drm2/dist/drm/i915/intel_ddi.c and are specific to > > the switch statement