thread safe ipsp_address

2015-04-14 Thread Mike Belopuhov
Not sure it's worth the effort, but these printfs are sometimes useful. Anyone's willing to OK? diff --git sys/netinet/ip_ah.c sys/netinet/ip_ah.c index f66ea31..d1e270c 100644 --- sys/netinet/ip_ah.c +++ sys/netinet/ip_ah.c @@ -531,10 +531,13 @@ ah_input(struct mbuf *m, struct tdb *tdb, int

Re: [NEW] Driver for the Araneus Alea II USB TRNG

2015-04-14 Thread Martin Pieuchot
On 14/04/15(Tue) 07:40, attila wrote: [...] Feedback most welcome. See below. /* -*- mode:c; tab-width:8; indent-tabs-mode:t; c-basic-offset:8 -*- */ We do not include editor settings in files, the first line should contain: /* $OpenBSD$ */ Which will be expanded by CVS. /* *

Re: File protection, second attempt

2015-04-14 Thread Mike Belopuhov
On 14 April 2015 at 17:19, kanonenvogel@gmail.com kanonenvogel@gmail.com wrote: Ok, I split my huge patch to some small. f_flag and f_iflags are not affected by this patch set, because they are under mp lock this time. And just for lulz, I made sys_pipe, sys_pipe2 syscalls and

struct sigcontext in a sa_sigaction handler

2015-04-14 Thread Jan Stary
The SYNOPSIS of sigaction(2) cites the sa_sigaction function as void (*__sa_sigaction)(int, siginfo_t *, void *); yet in the examples, the declaration is void handler(int sig, siginfo_t *sip, struct sigcontext *scp); with the role of sigcontext described. This is a

Re: xhci, thinkpad usb ports, uhub0: device problem

2015-04-14 Thread Martin Pieuchot
On 13/04/15(Mon) 22:39, Rafal Brodewicz wrote: Hi tech@ Enabling usb3 support in my ThinkPad T440s causes dock station usb ports to stop working. I see uhub0: device problem, disabling port 3 message in dmesg. dmesg with usb3 on and off included. Seems that the hub in your dock fails to

Re: struct sigcontext in a sa_sigaction handler

2015-04-14 Thread Todd C. Miller
The situation is a little complicated. POSIX defines the third argument to the sa_sigaction handler as void * and says it may be cast to ucontext_t. On OpenBSD, it is really a pointer to struct sigcontext but this is really an implementation detail. - todd Index: lib/libc/sys/sigaction.2

Re: struct sigcontext in a sa_sigaction handler

2015-04-14 Thread Theo de Raadt
The situation is a little complicated. POSIX defines the third argument to the sa_sigaction handler as void * and says it may be cast to ucontext_t. On OpenBSD, it is really a pointer to struct sigcontext but this is really an implementation detail. I had some reservations, but into this

comment typos

2015-04-14 Thread Jan Stary
Comments matter the most. Jan --- /usr/include/sys/siginfo.h Tue Aug 13 07:52:26 2013 +++ ./siginfo.h Tue Apr 14 17:07:06 2015 @@ -135,7 +135,7 @@ typedef struct { int si_errno; /* error from errno.h */ union { int

Re: autoinstall(8) tweaks

2015-04-14 Thread Theo de Raadt
Note: I don't use the auto-layout except on throwaway test installs as it never seems to give me the layout I need, and except for laptops I would prefer to never use the interactive installer at all. The real problem here is that many people choose 1 partition. Which implies trusting that

Multiple cmsghdrs in msghdr

2015-04-14 Thread William Orr
Hey, I was debugging a few CPython test failures yesterday, and I noticed that attaching multiple cmsg structures causes unp_internalize to return EINVAL. I've looked in unix(4) and sendmsg(2), and this caveat isn't documented anywhere. I looked at other OSes, and Linux supports this, FreeBSD

atoi - strtonum

2015-04-14 Thread Theo de Raadt
This rather large diff takes a swing at atoi() in the tree; converting many of them to strtonum(). strtonum() is not a perfect API. But atoi() is far worse, as is strtol() -- if endptr is unchecked (quite common). The same extends to the rest of that family of functions. Please reserve any

Question about TCP_ECN code in tcp_input.c

2015-04-14 Thread David Bar
Hello, I've been reading the code in tcp_input.c, and am a bit puzzled by the code ifdef'ed under TCP_ECN. There's something which seems odd to me with the places in the code which update tp-snd_last, and their relation to TCP_ECN and TCP_SACK. I'll be grateful if someone could take the time and

Re: tcp keep-alives sent without timestamps

2015-04-14 Thread Mike Belopuhov
On Tue, Apr 14, 2015 at 19:40 +0300, Lauri Tirkkonen wrote: Synopsis:tcp keep-alives sent without timestamps Category:kernel Environment: System : OpenBSD 5.7 Details : OpenBSD 5.7-current (GENERIC) #860: Mon Apr 13 20:58:42 MDT 2015

Re: tcp keep-alives sent without timestamps

2015-04-14 Thread Lauri Tirkkonen
On Tue, Apr 14 2015 20:40:58 +0200, Mike Belopuhov wrote: According to 3.2 in RFC 7323: Once TSopt has been successfully negotiated, that is both SYN and SYN,ACK contain TSopt, the TSopt MUST be sent in every non-RST segment for the duration of the connection, and SHOULD be sent in

Re: [NEW] Driver for the Araneus Alea II USB TRNG

2015-04-14 Thread attila
Martin Pieuchot m...@openbsd.org writes: On 14/04/15(Tue) 07:40, attila wrote: [...] Feedback most welcome. See below. /* -*- mode:c; tab-width:8; indent-tabs-mode:t; c-basic-offset:8 -*- */ We do not include editor settings in files, the first line should contain: /*$OpenBSD$ */

Re: struct sigcontext in a sa_sigaction handler

2015-04-14 Thread Mark Kettenis
From: Todd C. Miller todd.mil...@courtesan.com Date: Tue, 14 Apr 2015 10:52:47 -0600 The situation is a little complicated. POSIX defines the third argument to the sa_sigaction handler as void * and says it may be cast to ucontext_t. On OpenBSD, it is really a pointer to struct

Re: man, man.conf and /usr/ports/infrastructure/man

2015-04-14 Thread Marc Espie
On Sun, Apr 12, 2015 at 04:43:31PM -0400, dan mclaughlin wrote: it seems that /usr/ports/infrastructure/man is not searched by default, and there is no example in man.conf for it. given that some pages like dpb(1) are there, and referenced thruout a number of pages (eg bsd.port.mk), this seems

Re: [NEW] Driver for the Araneus Alea II USB TRNG

2015-04-14 Thread attila
Hi tech@, I balled the copyright and license up a bit (thanks to deraadt@ and bcallah@ for pointing this out). I apologize to grange@ and mbalmer@ for not carrying along their copyright notices when I obviously cribbed liberally from their code in uow.c and umbg.c, respectively. Updated driver

Re: Tying time_t to pacman

2015-04-14 Thread Marc Espie
On Mon, Apr 13, 2015 at 06:10:36PM -0600, Theo de Raadt wrote: I don't normally do this. http://motherboard.vice.com/read/32-bit-integers-and-why-old-computers-matter This does a really good job educating people on integer overflow :) In our non-pacman universe, the ports guys really did

Re: struct sigcontext in a sa_sigaction handler

2015-04-14 Thread Philip Guenther
On Tue, Apr 14, 2015 at 2:59 PM, Mark Kettenis mark.kette...@xs4all.nl wrote: From: Todd C. Miller todd.mil...@courtesan.com The situation is a little complicated. POSIX defines the third argument to the sa_sigaction handler as void * and says it may be cast to ucontext_t. On OpenBSD, it is

Re: autoinstall(8) tweaks

2015-04-14 Thread Ryan McBride
On Thu, Apr 09, 2015 at 04:27:17AM -0600, Theo de Raadt wrote: But it seems people are expected to build a custom bsd.rd if they want something different so I'll bow out of this conversation. No, the situation is that less than 1% of the user community apparently have a secret usage case,