Re: ktrace: Allow appending to FIFOs

2017-06-20 Thread Ted Unangst
Klemens Nanni wrote: > I wanted to quickly debug some program without actually dumping to disk > by using FIFOs, however ktrace(2) wouldn't accept anything but regular > files. > > Are there any pitfalls or limitations I am currently not aware of that > justify this strict behaviour? oh, neat,

Re: Trapsleds

2017-06-20 Thread Todd Mortimer
> 2. This patch also hits NOP sleds > 8 bytes on i386. We could also hit > the NOP sleds between 3 and 7 bytes if there are no objections. The attached diff implements the same trapsled mechanism for i386 and amd64 for all padding sequences between 3 and 15 bytes. I have put this through a

pf statekey inp assertion failed

2017-06-20 Thread Alexander Bluhm
Hi, I saw a crash on an OpenBSD 6.1 based system when a kassert in pf_state_key_unref() was triggert. kernel diagnostic assertion "(sk->inp == NULL) || (sk->inp->inp_pf_sk == NULL)" failed: file "../../../../../net/pf.c", line 7155 panic() at panic+0xfe

Re: pf statekey inp assertion failed

2017-06-20 Thread David Hill
On Wed, Jun 21, 2017 at 01:21:50AM +0200, Alexander Bluhm wrote: > Hi, > > I saw a crash on an OpenBSD 6.1 based system when a kassert in > pf_state_key_unref() was triggert. > > kernel diagnostic assertion "(sk->inp == NULL) || (sk->inp->inp_pf_sk == > NULL)" > failed: file

Re: ktrace: Allow appending to FIFOs

2017-06-20 Thread Klemens Nanni
On Tue, Jun 20, 2017 at 09:10:17PM -0400, Ted Unangst wrote: Klemens Nanni wrote: I wanted to quickly debug some program without actually dumping to disk by using FIFOs, however ktrace(2) wouldn't accept anything but regular files. Are there any pitfalls or limitations I am currently not aware

Re: vi(1): documenting :s

2017-06-20 Thread Anthony J. Bentley
Hi, Jason McIntyre writes: > shouldn;t it be that we should show the suspend command as > > sus[pend] > > the shortest "s" matches "substitute", right. so we show it as > > s[ubstitute] > > i cannot find any text that describes what "su" *should* match though, > so i'm not sure.

Re: vi(1): documenting :s

2017-06-20 Thread Jason McIntyre
On Tue, Jun 20, 2017 at 01:30:35AM -0600, Anthony J. Bentley wrote: > Hi, > > Jason McIntyre writes: > > shouldn;t it be that we should show the suspend command as > > > > sus[pend] > > > > the shortest "s" matches "substitute", right. so we show it as > > > > s[ubstitute] > > > > i

Re: switch libkvm bits from hand rolled RBT updates to proper RBT api use

2017-06-20 Thread Mark Kettenis
> Date: Tue, 20 Jun 2017 11:04:58 +1000 > From: David Gwynne > > now RBT is in userland, we can actually use the API instead of hand > rolling the copying of the tree topology. > > ok? ok kettenis@ > Index: lib/libkvm/kvm_proc.c >

Fix possible fault in sysctl_file()

2017-06-20 Thread Gerhard Roth
Hi, file pointer may be incompletely initialized after falloc(). For example, sys_socket() initializes 'f_flag', 'f_type', and 'f_ops' but may sleep then in socreate() before assigning 'f_data'. That is why there is the FIF_LARVAL flag, that is check by the macro FILE_IS_USABLE(). Of the three

Re: remove redundant flag from iwm(4)

2017-06-20 Thread Stefan Sperling
On Mon, Jun 19, 2017 at 02:10:50PM +0200, Mark Kettenis wrote: > > Date: Mon, 19 Jun 2017 13:02:58 +0200 > > From: Stefan Sperling > > > > On Mon, Jun 19, 2017 at 11:57:36AM +0200, Mark Kettenis wrote: > > > > @@ -7450,7 +7444,7 @@ iwm_init_task(void *arg1) > > > > } > >

Re: remove redundant flag from iwm(4)

2017-06-20 Thread Mark Kettenis
> Date: Tue, 20 Jun 2017 13:34:57 +0200 > From: Stefan Sperling > > This fixed diff matches what was intended, and it still works (tested > switching between networks and suspend/resume). ok kettenis@ > Index: sys/dev/pci/if_iwm.c >

Re: Fix possible fault in sysctl_file()

2017-06-20 Thread Alexander Bluhm
On Tue, Jun 20, 2017 at 01:51:07PM +0200, Gerhard Roth wrote: > The fix is rather straightforward. OK bluhm@ > Index: sys/kern/kern_sysctl.c > === > RCS file: /cvs/src/sys/kern/kern_sysctl.c,v > retrieving revision 1.328 > diff -u

ktrace: Allow appending to FIFOs

2017-06-20 Thread Klemens Nanni
I wanted to quickly debug some program without actually dumping to disk by using FIFOs, however ktrace(2) wouldn't accept anything but regular files. Are there any pitfalls or limitations I am currently not aware of that justify this strict behaviour? $ ln -s some.file link $

Re: locate/mklocatedb.sh: remove unused option

2017-06-20 Thread Michal Mazurek
Bump. These scripts could use a little refreshing. On 22:34:57, 12.06.17, Michal Mazurek wrote: > This script has an option called -presort or -nosort, that appears to > never be used, so remove it. This makes the $sort* options unneeded, > remove them too. > > The script itself is used by

ksh ^T transpose-chars

2017-06-20 Thread Bryan Steele
In ksh(1), ^T is documented to be bounded to transpose-chars while in emacs mode, not "x_stuff". While here, remove these poorly described functions as well.. -Bryan. Index: emacs.c === RCS file: /cvs/src/bin/ksh/emacs.c,v

Re: ksh ^T transpose-chars

2017-06-20 Thread Anton Lindqvist
On Tue, Jun 20, 2017 at 12:51:38PM -0400, Bryan Steele wrote: > In ksh(1), ^T is documented to be bounded to transpose-chars while > in emacs mode, not "x_stuff". While here, remove these poorly > described functions as well.. This change would break any existing user defined binding to either