Re: TIOCSTI

2017-06-28 Thread Jeremie Courreges-Anglas
Theo de Raadt writes: > Back around 1989, Ken Stauffer and I found a kernel security hole in > SunOS (the "open 3" bug) and used it along with TIOCSTI. > > That bug was fixed at least twice: we reported it and it was fixed in > SunOS, then when *BSD code became available I

tty(4): mention TIOCSTAT

2017-06-28 Thread Anton Lindqvist
Hi, A first stab at documenting the TIOCSTAT ioctl. The paragraph is taken from termios(4) as is and could might be reworked. The parameter is as stated unused but consistent with the definition of TIOCSTAT in sys/sys/ttycom.h. Comments? OK? Index: tty.4

Fix compilation warning/error when using ACPIVIDEO_DEBUG

2017-06-28 Thread Fasse
When building OpenBSD with the ACPIVIDEO_DEBUG option set the compilation fails: cc1: warnings being treated as errors /usr/src/sys/dev/acpi/acpivideo.c: In function 'acpivideo_set_policy': /usr/src/sys/dev/acpi/acpivideo.c:136: warning: format '%X' expects type 'unsigned int', but argument 3

Re: [patch] increase command buffer ksh

2017-06-28 Thread Anton Lindqvist
On Wed, Jun 28, 2017 at 07:36:54PM +0200, Martijn van Duren wrote: > On 06/28/17 19:00, Theo de Raadt wrote: > > Sounds good. > > > > It might be nice to determine if these two variables should be one, > > ie. tied together better. > > I was thinking the same thing. Both are used for input line

Re: ssl.8 and subject altnames

2017-06-28 Thread Ted Unangst
Stuart Henderson wrote: > On 2017/06/27 18:11, Ted Unangst wrote: > > so chrome at least has gotten pretty uppity about certs that lack subject > > altnames. > > Oh that's going to be hilarious. There are at least valid reasons for > doing this (e.g. nameConstraints don't work with CN). I have

Re: tty(4): mention TIOCSTAT

2017-06-28 Thread Todd C. Miller
On Wed, 28 Jun 2017 15:35:36 -0600, "Theo de Raadt" wrote: > Nope. It requires a parameter. lukem messed this up two decades ago, > he should have used _IO but used the wrong one. Ah right, I missed that it is _IOW. OK millert@ as-is then. - todd

Re: tty(4): mention TIOCSTAT

2017-06-28 Thread Theo de Raadt
>> Nope. It requires a parameter. lukem messed this up two decades ago, >> he should have used _IO but used the wrong one. > >Ah right, I missed that it is _IOW. OK millert@ as-is then. Two weeks ago, it took 2 hours for me to notice it. Annoying.

Re: tty(4): mention TIOCSTAT

2017-06-28 Thread Theo de Raadt
> On Wed, 28 Jun 2017 22:48:47 +0200, Anton Lindqvist wrote: > > > A first stab at documenting the TIOCSTAT ioctl. The paragraph is taken > > from termios(4) as is and could might be reworked. The parameter is as > > stated unused but consistent with the definition of TIOCSTAT in > >

Re: tty(4): mention TIOCSTAT

2017-06-28 Thread Todd C. Miller
On Wed, 28 Jun 2017 22:48:47 +0200, Anton Lindqvist wrote: > A first stab at documenting the TIOCSTAT ioctl. The paragraph is taken > from termios(4) as is and could might be reworked. The parameter is as > stated unused but consistent with the definition of TIOCSTAT in > sys/sys/ttycom.h. I

file: Simplify Makefile

2017-06-28 Thread Klemens Nanni
No need for multiple echos or xargs (wich runs cat only once anyway) here. The {post-,}magic files stay unchanged. In magic target don't specify dependencies twice. OK? Index: Makefile === RCS file:

Re: no-depends for real, the juicy part

2017-06-28 Thread Marc Espie
Add this for games/hack, found by krw@ Index: Makefile === RCS file: /cvs/src/games/hack/Makefile,v retrieving revision 1.14 diff -u -p -r1.14 Makefile --- Makefile24 Nov 2015 03:10:10 - 1.14 +++ Makefile29 Jun 2017

Re: clang integrated asm crash while building mozilla/firefox

2017-06-28 Thread Marc Espie
On Tue, Jun 27, 2017 at 11:32:44AM +0200, Marc Espie wrote: > I've attached the files that clang gives to reproduce the crash. > > I also got a similar crash in firefox-esr. > > Funnily enough, it happened after the recent update to both, BUT the crashes > seem to be unrelated ? > > The sysv

Re: remove errant ifstated whitespace

2017-06-28 Thread Sebastian Benoit
commited, thx Rob Pierce(r...@2keys.ca) on 2017.06.27 21:33:06 -0400: > > Index: ifstated.c > === > RCS file: /cvs/src/usr.sbin/ifstated/ifstated.c,v > retrieving revision 1.43 > diff -u -p -r1.43 ifstated.c > --- ifstated.c

no-depends for real, the juicy part

2017-06-28 Thread Marc Espie
This is the actual patch that more or less neuters depends. So this gets rid of all internals for depend/beforedepend/afterdepend. NOTE that this does not *remove* the 'make depend' stage, just it won't do anything except for a few select parts (old gcc3 and mesa in particular depend on it).

TIOCSTI

2017-06-28 Thread Theo de Raadt
Back around 1989, Ken Stauffer and I found a kernel security hole in SunOS (the "open 3" bug) and used it along with TIOCSTI. That bug was fixed at least twice: we reported it and it was fixed in SunOS, then when *BSD code became available I found it was still unfixed and fixed it myself, and I

Re: dhcp-options(5) conflict with dhcpd.conf(5)

2017-06-28 Thread Klemens Nanni
On Mon, Jun 26, 2017 at 08:26:03PM -0500, Edgar Pettijohn wrote: I found the following conflict between dhcp-options(5) and dhcpd.conf(5). From dhcpd.conf: As you can see in Example 2, it's legal to specify host addresses in parameters as hostnames rather than as numeric IP addresses. If

remove noises at reboot in azalia(4)

2017-06-28 Thread Manuel Giraud
Hi, This patch removes noises in speaker (or headphone) when rebooting (tested on only one Conexant CX20724 chip) Index: azalia.c === RCS file: /cvs/src/sys/dev/pci/azalia.c,v retrieving revision 1.235 diff -u -p -r1.235 azalia.c

Re: dhcp-options(5) conflict with dhcpd.conf(5)

2017-06-28 Thread Jason McIntyre
On Mon, Jun 26, 2017 at 08:26:03PM -0500, Edgar Pettijohn wrote: > I found the following conflict between dhcp-options(5) and dhcpd.conf(5). > > > From dhcpd.conf: > > As you can see in Example 2, it's legal to specify host addresses in > parameters as hostnames rather than as numeric IP

[patch] increase command buffer ksh

2017-06-28 Thread Martijn van Duren
Hello tech@, On monday I was playing with the build environment of PHP and all of a sudden I couldn't finish the command because the command buffer was full, so I was forced to use bash to finish what I set out to do. Of course I'd rather stay on ksh, so here's a patch (guided by anton@) which

Re: [patch] increase command buffer ksh

2017-06-28 Thread Theo de Raadt
Sounds good. It might be nice to determine if these two variables should be one, ie. tied together better. > Hello tech@, > > On monday I was playing with the build environment of PHP and all of a > sudden I couldn't finish the command because the command buffer was > full, so I was forced to

Re: fix stdin input for file(1)

2017-06-28 Thread Nicholas Marriott
Ouch. ok nicm You can add this regress test as well: Index: regress/usr.bin/file//Makefile === RCS file: /cvs/src/regress/usr.bin/file/Makefile,v retrieving revision 1.7 diff -u -p -r1.7 Makefile --- regress/usr.bin/file//Makefile

fix stdin input for file(1)

2017-06-28 Thread Bryan Steele
My latest commit broke support for stdin input, whoops. ok? Index: file.c === RCS file: /cvs/src/usr.bin/file/file.c,v retrieving revision 1.62 diff -u -p -u -r1.62 file.c --- file.c 28 Jun 2017 15:42:49 - 1.62 +++

ssl.8 and subject altnames

2017-06-28 Thread Ted Unangst
so chrome at least has gotten pretty uppity about certs that lack subject altnames. following the instructions in ssl.8 is no longer sufficient. here's a short hint about how to fix this. Index: ssl.8 === RCS file:

Re: tweak {event,evtimer,signal}_pending manpage

2017-06-28 Thread Ingo Schwarze
Hi David, David Gwynne wrote on Tue, Jun 27, 2017 at 11:55:43AM +1000: > the timeval argument is not const. esp since thats how the remaining > time is provided to the caller. Right, event_pending(..., tv) calls timeradd(..., tv), see timeradd(2), so OK schwarze@ FWIW. Yours, Ingo > Index:

Re: [patch] increase command buffer ksh

2017-06-28 Thread Martijn van Duren
On 06/28/17 19:00, Theo de Raadt wrote: > Sounds good. > > It might be nice to determine if these two variables should be one, > ie. tied together better. I was thinking the same thing. Both are used for input line buffering, so I reckon that's sane. Identical checksum compared to previous

Re: ssl.8 and subject altnames

2017-06-28 Thread Stuart Henderson
On 2017/06/27 18:11, Ted Unangst wrote: > so chrome at least has gotten pretty uppity about certs that lack subject > altnames. Oh that's going to be hilarious. There are at least valid reasons for doing this (e.g. nameConstraints don't work with CN). > > Index: ssl.8 >

Re: kernel relinking at install/upgrade time

2017-06-28 Thread Sebastien Marie
On Wed, Jun 28, 2017 at 08:58:13AM +0200, Sebastien Marie wrote: > > - should /$MODE.site to ran after "generating sha256 from /bsd" and > before "relinking to create an unique kernel" ? it should let "make > newbsd" detect /bsd modification, and not relinking the kernel. small

Re: kernel relinking at install/upgrade time

2017-06-28 Thread Sebastien Marie
On Mon, Jun 26, 2017 at 02:35:55PM -0600, Theo de Raadt wrote: > There is a diff in snapshots which does kernel relinking during > install or upgrade. > > Really amazing... > I have an issue regarding kernel relinking during upgrade. Not a big chunk, but I prefer to report it to see the better