csh(1): zap redundant assignment

Comments? OK? Index: lex.c === RCS file: /cvs/src/bin/csh/lex.c,v retrieving revision 1.24 diff -u -p -r1.24 lex.c --- lex.c 23 Jan 2017 04:53:15 - 1.24 +++ lex.c 30 Aug 2017 07:09:50 - @@ -1426,7 +1426,6 @@

Re: [patch] kbd should give an error unless we're root

On Tue, Aug 29 2017, Jesper Wallin wrote: > Hi, > > I noticed that kbd(8) lets you list all available keyboard encodings > with the -l flag. However, we get no error and no list unless we're > running this as root. I apologize if this is intended and I fail to > understand

Re: csh(1): zap redundant assignment

On Wed, Aug 30 2017, Anton Lindqvist wrote: > Comments? OK? Sure. > Index: lex.c > === > RCS file: /cvs/src/bin/csh/lex.c,v > retrieving revision 1.24 > diff -u -p -r1.24 lex.c > --- lex.c 23 Jan 2017

Re: [patch] kbd should give an error unless we're root

On Wed, Aug 30, 2017 at 08:14:16AM +0200, Jeremie Courreges-Anglas wrote: > > Well, the behavior of kbd depends on the permissions of the device > files, not on the fact that you're root or not. Maybe something like > this would be more appropriate? > Ah, you're absolutely right! No idea why,

Re: i386 zzz broken, Was: CVS: cvs.openbsd.org: src

On Tue, Aug 29, 2017 at 04:32:04PM -0700, Mike Larkin wrote: > On Mon, Aug 28, 2017 at 11:18:13PM +0300, li...@wrant.com wrote: > > Mon, 28 Aug 2017 10:16:58 -0600 (MDT) Ted Unangst > > > CVSROOT: /cvs > > > Module name: src > > > Changes by: t...@cvs.openbsd.org

Unbreak DEBUG for nfsd(8)

Hi, Unbreak DEBUG for nfsd(8), this one was caught with cppcheck. It has been broken for about 7 years ago when a couple of errx calls, which had string format arguments, were replaced by syslog calls. OK? Index: nfsd.c === RCS

Re: change closelog(3) description

On Wed, 30 Aug 2017 20:04:57 +0200, Alexander Bluhm wrote: > On Wed, Aug 30, 2017 at 10:35:16AM -0600, Todd C. Miller wrote: > > We don't actually have any log file descriptors since we have > > sendsyslog(2) so make the description a bit more generic. > > It is also closer to what POSIX says. >

Re: ksh(1): drop needless chunk

On Wed, Aug 30, 2017 at 07:25:45PM +0200, Jeremie Courreges-Anglas wrote: > > I don't think this is relevant. > it probably isn;t relevant. i guess it's not helpful either, in such a big page. but it is a bit of the author's character. i'm not sure it's worth removing it. jmc > > Index:

Re: change closelog(3) description

On Wed, Aug 30, 2017 at 12:09:13PM -0600, Todd C. Miller wrote: > On Wed, 30 Aug 2017 20:04:57 +0200, Alexander Bluhm wrote: > > > On Wed, Aug 30, 2017 at 10:35:16AM -0600, Todd C. Miller wrote: > > > We don't actually have any log file descriptors since we have > > > sendsyslog(2) so make the

Re: ksh: add support for HISTCONTROL ignorespace & ignoredups

Looks good to me. Do we want to document this as an extension in the manual? We're not very good about documenting extensions to traditional ksh behavior. - todd

Re: ksh: add support for HISTCONTROL ignorespace & ignoredups

On Wed, 30 Aug 2017 18:50:26 +0200, Jeremie Courreges-Anglas wrote: > On Wed, Aug 30 2017, "Todd C. Miller" wrote: > > Looks good to me. Do we want to document this as an extension in > > the manual? We're not very good about documenting extensions to > > traditional

Re: strtok_r(3): mention standards

On Mon, Aug 28 2017, Jeremie Courreges-Anglas wrote: > On Mon, Aug 28 2017, "Todd C. Miller" wrote: >> On Mon, 28 Aug 2017 14:29:18 +0200, Jeremie Courreges-Anglas wrote: >> >>> IIUC strtok_r appeared in IEEE Std 1003.1c-1995, the diff below >>>

ksh(1): drop needless chunk

I don't think this is relevant. Index: ksh.1 === RCS file: /cvs/src/bin/ksh/ksh.1,v retrieving revision 1.195 diff -u -p -r1.195 ksh.1 --- ksh.1 30 Aug 2017 17:08:45 - 1.195 +++ ksh.1 30 Aug 2017 17:23:59 -

change closelog(3) description

We don't actually have any log file descriptors since we have sendsyslog(2) so make the description a bit more generic. It is also closer to what POSIX says. OK? - todd Index: lib/libc/gen/syslog.3 === RCS file:

Re: Unbreak DEBUG for nfsd(8)

On Wed, Aug 30, 2017 at 05:54:16PM +0100, Ricardo Mestre wrote: > Hi, > > Unbreak DEBUG for nfsd(8), this one was caught with cppcheck. > > It has been broken for about 7 years ago when a couple of errx calls, which > had > string format arguments, were replaced by syslog calls. Can you

Re: change closelog(3) description

On Wed, Aug 30, 2017 at 10:35:16AM -0600, Todd C. Miller wrote: > We don't actually have any log file descriptors since we have > sendsyslog(2) so make the description a bit more generic. > It is also closer to what POSIX says. > > OK? The term "log file" could be misunderstood as refering to a

tcpdump: decode RSN beacon elements

This makes tcpdump -v -y IEEE802_11_RADIO decode RSN beacon elements. Before: rsn 0x010fac04010fac04010fac02 After: rsn= Code which generates this element can be found in ieee80211_add_rsn_body() in the file sys/net80211/ieee80211_output.c. ok? Index: print-802_11.c

ksh: kill emacs-usemeta

As mentioned in https://marc.info/?l=openbsd-tech=150401359712984=2 emacs-usemeta isn't used since some time already. I have a diff that just hides the flag but I changed my mind. The people who use the saved output of "set +o" from an earlier ksh might be negatively affected, but that's a bit

Re: i386 zzz broken, Was: CVS: cvs.openbsd.org: src

On Tue, Aug 29, 2017 at 07:25:33PM -0700, Chris Cappuccio wrote: > li...@wrant.com [li...@wrant.com] wrote: > > > > Please let me know if you want me to generate some dumps or similar, but > > unfortunately, I can't yet test patches or handle compilation on my own. > > I realise my info on this

Re: Remove the no longer true CAVEATS section in rasops.9

> Date: Wed, 30 Aug 2017 07:53:39 +0200 > From: Frederic Cambus > > Hi tech@, > > Remove the CAVEATS section in rasops.9, which no longer holds truth. > > Comments? OK? > > Index: share/man/man9/rasops.9 > === >

[PATCH] Move definition of IMSG_DATA_SIZE() to imsg.h

There is a bunch of programs that define IMSG_DATA_SIZE() themselves in a similar fashion. This patch reduces code duplication a bit. --- lib/libutil/imsg.h | 1 + sbin/iked/iked.h | 1 - usr.sbin/httpd/httpd.h | 1 - usr.sbin/relayd/relayd.h | 1 - usr.sbin/snmpd/snmpd.h | 1 -

Re: change closelog(3) description

> > On Wed, Aug 30, 2017 at 10:35:16AM -0600, Todd C. Miller wrote: > > > We don't actually have any log file descriptors since we have > > > sendsyslog(2) so make the description a bit more generic. > > > It is also closer to what POSIX says. > > > > > > OK? > > > > The term "log file" could be

Re: change closelog(3) description

On Wed, 30 Aug 2017 12:24:38 -0600, "Theo de Raadt" wrote: > How about "discard resources", or something more nebulous. Especially > if it frightens signal handler authors. I understand what you are getting at but that seems so vague as to be unhelpful. - todd

Re: Unbreak DEBUG for nfsd(8)

On 19:30 Wed 30 Aug , Otto Moerbeek wrote: > On Wed, Aug 30, 2017 at 05:54:16PM +0100, Ricardo Mestre wrote: > > > Hi, > > > > Unbreak DEBUG for nfsd(8), this one was caught with cppcheck. > > > > It has been broken for about 7 years ago when a couple of errx calls, which > > had > >

Re: change closelog(3) description

On Wed, 30 Aug 2017 12:49:43 -0600, "Theo de Raadt" wrote: > > > How about "discard resources", or something more nebulous. Especially > > > if it frightens signal handler authors. > > > > I understand what you are getting at but that seems so vague as to > > be unhelpful. > > Precisely how is

Re: change closelog(3) description

On Wed, Aug 30, 2017 at 12:09:13PM -0600, Todd C. Miller wrote: > The > .Fn closelog > function will close any file descriptors opened by the > .Fn openlog , > .Fn openlog_r , > .Fn syslog > or > .Fn syslog_r > functions. > > What do you think? OK bluhm@

Re: change closelog(3) description

> > How about "discard resources", or something more nebulous. Especially > > if it frightens signal handler authors. > > I understand what you are getting at but that seems so vague as to > be unhelpful. Precisely how is it vague? The manual is telling people to follow an open/close idiom,

Re: softraid: export rebuild status to sensor

On Wed, Aug 30, 2017 at 02:20:31PM +0200, Patrick Wildt wrote: > Hi, > > like our other hardware raid controller drivers, softraid should > report the rebuild state properly. Currently the sensor exports > the drive state in that case as "unknown", which is misleading. > > ok? > makes sense

Re: i386 zzz broken, Was: CVS: cvs.openbsd.org: src

On Wed, Aug 30, 2017 at 12:48:20AM -0700, Mike Larkin wrote: > On Tue, Aug 29, 2017 at 04:32:04PM -0700, Mike Larkin wrote: > > On Mon, Aug 28, 2017 at 11:18:13PM +0300, li...@wrant.com wrote: > > > Mon, 28 Aug 2017 10:16:58 -0600 (MDT) Ted Unangst > > > > CVSROOT:/cvs >

delaying the start of ifstated in /etc/rc

Depending on the use case for ifstated, dependencies may exist with other daemons for performing interface checks and/or external tests. For example, one might use ifstated to check a dhcpd enabled interface, or connectivity to a vmd virtual machine. Does anyone have any objections with delaying

[PATCH] VMD: Ensure disk is a regular file prior to vm boot

Add check(s) in vmd/vmctl to ensure a VM's disk are regular files. Tested with the following: vmctl start "test1" -d /dev/sd3c #block device vmctl start "test2" -d /dev/rsd3c #char device vmctl start "test3" -d fifo #named pipe Comments? Ok? diff --git usr.sbin/vmctl/vmctl.c

[PATCH] vm.conf: Clarify VM name constraints

Add VM name constraints to match those in vmctl.8 manpage. Comments? Ok? diff --git usr.sbin/vmd/vm.conf.5 usr.sbin/vmd/vm.conf.5 index d1e68dbce5d..77a7a4e8cea 100644 --- usr.sbin/vmd/vm.conf.5 +++ usr.sbin/vmd/vm.conf.5 @@ -108,7 +108,9 @@ section starts with a declaration of the virtual

Re: ksh: add support for HISTCONTROL ignorespace & ignoredups

On Wed, Aug 30 2017, "Todd C. Miller" wrote: > Looks good to me. Do we want to document this as an extension in > the manual? We're not very good about documenting extensions to > traditional ksh behavior. I'm not against this but I'm not thrilled either. If anyone

Re: i386 zzz broken, Was: CVS: cvs.openbsd.org: src

On 2017/08/30 09:04, Florian Obser wrote: > On Tue, Aug 29, 2017 at 07:25:33PM -0700, Chris Cappuccio wrote: > > li...@wrant.com [li...@wrant.com] wrote: > > > > > > Please let me know if you want me to generate some dumps or similar, but > > > unfortunately, I can't yet test patches or handle

Re: ksh: add support for HISTCONTROL ignorespace & ignoredups

Hi Jeremie, Am 30.08.2017 13:04 schrieb Jeremie Courreges-Anglas: This implements a feature I miss from bash. What I care about: - not clog the history with repeated commands - easily prevent some commands to go in the history The diff below implements HISTCONTROL for this, user-facing

pflogd(8) fork+exec

fork+exec model for pflogd(8); moves pcap init to the re-exec'd privsep parent and uses 'legit' fdpassing primitives to send the bpf fd to the unprivileged child process. I've tried to keep this difff small so that it can go in, there's more work to be done in the future, but this will let things

Re: ksh: kill emacs-usemeta

On Wed, Aug 30 2017, Jeremie Courreges-Anglas wrote: > On Wed, Aug 30 2017, Jeremie Courreges-Anglas wrote: >> As mentioned in https://marc.info/?l=openbsd-tech=150401359712984=2 >> emacs-usemeta isn't used since some time already. I have a diff that >> just

ksh: add support for HISTCONTROL ignorespace & ignoredups

This implements a feature I miss from bash. What I care about: - not clog the history with repeated commands - easily prevent some commands to go in the history The diff below implements HISTCONTROL for this, user-facing behavior based on bash. The default ksh behavior doesn't change. I did

Re: ksh: kill emacs-usemeta

On Wed, Aug 30 2017, Jeremie Courreges-Anglas wrote: > As mentioned in https://marc.info/?l=openbsd-tech=150401359712984=2 > emacs-usemeta isn't used since some time already. I have a diff that > just hides the flag but I changed my mind. The people who use the saved > output

softraid: export rebuild status to sensor

Hi, like our other hardware raid controller drivers, softraid should report the rebuild state properly. Currently the sensor exports the drive state in that case as "unknown", which is misleading. ok? Patrick diff --git a/sys/dev/softraid.c b/sys/dev/softraid.c index 1593c76bdcd..280e832f849

Re: ksh: add support for HISTCONTROL ignorespace & ignoredups

Yes, please! Il 30 agosto 2017 13:04:02 CEST, Jeremie Courreges-Anglas ha scritto: > >This implements a feature I miss from bash. What I care about: >- not clog the history with repeated commands >- easily prevent some commands to go in the history > >The diff below implements

OpenBSD Errata: August 30th, 2017 (net80211)

Errata patches for the wireless stack have been released for OpenBSD 6.1 and 6.0. State transition errors could cause reinstallation of old WPA keys. Binary updates for the amd64 and i386 platforms are available via the syspatch utility. Source code patches can be found on the respective errata

lock(1): wipe hash before exit in one-time password case

Hi, In the one-time password case we want to wipe the hash itself before exit, right? This must have slipped through when tedu@ patiently rewrote and committed my botched patch a little while back. -- Scott Cheloha P.S. I didn't botch it this time, right? Index: usr.bin/lock/lock.c

Re: [PATCH] VMD: Ensure disk is a regular file prior to vm boot

Hi Carlos, Doesn't this mean that, even though it might not be possible to do this today (is it?), you're effectively disabling the usage of physical disks for VMs, i.e. equivalent of a raw disk device used in other hypervisors? Regards, Raf On Thu, Aug 31, 2017 at 12:56:20AM BST, Carlos