Re: Refactor TCP partial ACK handling

On 21/10/17(Sat) 15:17, Mike Belopuhov wrote: > On Fri, Oct 20, 2017 at 22:59 +0200, Klemens Nanni wrote: > > The comments for both void tcp_{sack,newreno}_partialack() still mention > > tp->snd_last and return value bits. > > > > Good eyes! It made me spot a mistake I made by folding two lines

Re: [PATCH 2/2] VMD: Handle vm-induced powerdown better

On Tue, Oct 10, 2017 at 03:46:57PM -0700, Carlos Cardenas wrote: > The VMD parent process didn't handle the case of a VM exiting > with a non 0 return properly (i.e. EIO). > > diff --git usr.sbin/vmd/vmd.c usr.sbin/vmd/vmd.c > index f1abc54d9a3..dcff6de0c0e 100644 > --- usr.sbin/vmd/vmd.c > +++

Re: [PATCH 1/2] VMD: Prevent Disappearing VM from vmctl status

On Tue, Oct 10, 2017 at 03:46:56PM -0700, Carlos Cardenas wrote: > Remove terminate_vm/vm_remove logic from vmm_dispatch_parent. This > logic is present in vmm_sighdlr when a VM process has signaled > SIGCHLD for proper cleanup. > > diff --git usr.sbin/vmd/vmm.c usr.sbin/vmd/vmm.c > index

Re: libfuse: patch to prevent fuse-zip from dumping core

On 18/10/17(Wed) 14:33, Helg Bredow wrote: > On Wed, 18 Oct 2017 15:03:21 +0200 > Martin Pieuchot wrote: > > > On 18/10/17(Wed) 12:51, Helg Bredow wrote: > > > On Wed, 18 Oct 2017 10:04:07 +0200 > > > Martin Pieuchot wrote: > > > > > > > On 17/10/17(Tue)

Re: kqueue_scan() in parallel

On 23/10/17(Mon) 21:58, Alexander Bluhm wrote: > On Wed, Oct 18, 2017 at 11:22:01AM +0200, Martin Pieuchot wrote: > > Diff below is the last version of my kqueue diff to allow grabbing the > > solock() and possibly sleeping, inside kqueue_scan(). > > I wonder why you don't call knote_release()

Re: Refactor TCP partial ACK handling

On 24/10/17(Tue) 12:27, Mike Belopuhov wrote: > On Tue, Oct 24, 2017 at 12:05 +0200, Martin Pieuchot wrote: > > On 21/10/17(Sat) 15:17, Mike Belopuhov wrote: > > > On Fri, Oct 20, 2017 at 22:59 +0200, Klemens Nanni wrote: > > > > The comments for both void tcp_{sack,newreno}_partialack() still

Re: Refactor TCP partial ACK handling

On Tue, Oct 24, 2017 at 12:05 +0200, Martin Pieuchot wrote: > On 21/10/17(Sat) 15:17, Mike Belopuhov wrote: > > On Fri, Oct 20, 2017 at 22:59 +0200, Klemens Nanni wrote: > > > The comments for both void tcp_{sack,newreno}_partialack() still mention > > > tp->snd_last and return value bits. > > >

[patch]Use BUFSIZE instead of hard-code in netcat.c

Hi tech@, Use BUFSIZE instead of hard-code in netcat.c, FYI. Thanks! Best Regards Nan Xiao Index: netcat.c === RCS file: /cvs/src/usr.bin/nc/netcat.c,v retrieving revision 1.187 diff -u -p -r1.187 netcat.c --- netcat.c15 Jul

Re: kqueue_scan() in parallel

On Tue, Oct 24, 2017 at 11:14:22AM +0200, Martin Pieuchot wrote: > This is not a problem. The way knote_acquire() is designed is to sleep > for a small amount of time, 1 * hz for the moment. Ah yes, I see the hz now. So there cannot be starvation. This is a best effort algorithm, we do not

Re: dd: exit nonzero on receipt of SIGINT

Hi, Scott Cheloha wrote on Mon, Oct 23, 2017 at 09:01:04PM -0500: > Per this bit from POSIX on dd(1): >> For SIGINT, the dd utility shall interrupt its current processing, >> write status information to standard error, and exit as though >> terminated by SIGINT. It shall take the standard

Re: dd: exit nonzero on receipt of SIGINT

> So when calling _exit() explicitly, we have to pass a status > of 128 + signo indeed. I agree with your analysis. ok

Re: refill msk(4) rx ring from a timeout when there's no mbufs

> Date: Tue, 24 Oct 2017 09:37:38 +1000 > From: David Gwynne > > theo pointed out the timeout should be cancelled when the interface > goes down. this adds a timeout_del in msk_stop. Hmm, you didn't attach a new diff... Commenting on the previous diff; do we really need to

Re: Refactor TCP partial ACK handling

On Tue, Oct 24, 2017 at 03:21:08PM +0200, Mike Belopuhov wrote: > I didn't do it because tcp_var.h is where tcp keeps all of it's prototypes > but I don't mind moving them into tcp_input.c. Any objections? Otherwise > I'll check in the diff below. Regression tests pass. OK bluhm@ > diff --git

ikev2: follow rfc5903 correctly (ECP Groups)

Hi, in the final RFC 5903 the computation for the DH shared secret changed. Instead of the full point, only the X point is included. Unfortunately this is a backwards incompatible change, so older ikeds won't be com- patible with this change is committed. Of course only if you use ECP. Anyway,

Re: [patch]Use BUFSIZE instead of hard-code in netcat.c

Actually, I think "plen = sizeof(buf);" may be better. Best Regards Nan Xiao On Tue, Oct 24, 2017 at 8:52 PM, Alexander Bluhm wrote: > On Tue, Oct 24, 2017 at 07:44:02PM +0800, Nan Xiao wrote: >> Use BUFSIZE instead of hard-code in netcat.c, FYI. Thanks! > > As this

Re: [patch]Use BUFSIZE instead of hard-code in netcat.c

On Tue, Oct 24, 2017 at 07:44:02PM +0800, Nan Xiao wrote: > Use BUFSIZE instead of hard-code in netcat.c, FYI. Thanks! As this buffer is used with MSG_PEEK and its content is discarded, the size does not really matter. The complicated logic seems to be a leftover from the -j jumbo option. I

Re: Refactor TCP partial ACK handling

On Tue, Oct 24, 2017 at 13:37 +0200, Martin Pieuchot wrote: > On 24/10/17(Tue) 12:27, Mike Belopuhov wrote: > > On Tue, Oct 24, 2017 at 12:05 +0200, Martin Pieuchot wrote: > > > On 21/10/17(Sat) 15:17, Mike Belopuhov wrote: > > > > On Fri, Oct 20, 2017 at 22:59 +0200, Klemens Nanni wrote: > > > >

isakmpd: DH grp19-21 & 25-30 plumbing

Since 2010 isakmpd(8) and iked(8) share the same Diffie-Hellman implementation based on libcrypto. In 2014 reyk@ synced these two implementations bringing support for DH groups 27-30 using Brainpool curves. Sadly the necessary plumbing and documentation was missing. So here's a diff to make

sparc64 kernel inline

Some of the sparc64 use "extern inline". That doesn't work for compilers that implement proper C99 inline semantics as you may end up with undefined references if you don't provide an actual implementation. Use "static inline" instead, just like we do in similar cases on other architectures.

fuselib: patch to check for NULL in fuse_parse_cmdline()

Arguments to fuse_parse_cmdline() are not checked for NULL before assignment. This patch performs the check. Index: fuse.c === RCS file: /cvs/src/lib/libfuse/fuse.c,v retrieving revision 1.30 diff -u -p -u -p -r1.30 fuse.c ---

Re: [patch]Use BUFSIZE instead of hard-code in netcat.c

Ouch! I misunderstood the patch by @bluhm, please ignore my previous mail! I am very sorry for disrupting! Best Regards Nan Xiao On Tue, Oct 24, 2017 at 9:30 PM, Nan Xiao wrote: > Actually, I think "plen = sizeof(buf);" may be better. > Best Regards > Nan Xiao > > > On

Dumping IPsec flows w/ radix-tree

Diff below switches the logic of the NET_KEY_SPD_DUMP sysctl(2) to iterate over the SPD table instead of the global list of policies `ipsec_policy_head'. This will allow us to get rid of the global list, which makes future MP work easier. Since we're now iterating over a tree, this diff changes

Re: Dumping IPsec flows w/ radix-tree

On Tue, 24 Oct 2017 15:46:43 +0200, Martin Pieuchot wrote: > Since we're now iterating over a tree, this diff changes the output > of ipsecctl(8) a bit. But I'd say it's a feature, it allows us to > see how flows are ordered, which is useful for debugging ;) > It is also useful to compare

Add Sparkfun ATtiny programmer in to usbdevs

Hi, as the topic states. On Linux lsusb's iProduct shows: iProduct2 FabISP And on OpenBSD: iProduct2 (error) So in that sense the naming might be a bit off. Adding the lines below in to uftdi.c doesn't make it work yet, so more love is needed: RCS file:

patch: syndaemon hangs on SIGINT

Hi guys, syndaemon goes into an infinite loop whenever it receives a SIGINT signal. An explanation and a patch are proposed below. In the file: xenocara/driver/xf86-input-synaptics/tools/syndaemon.c the program uses a signal handling function which in turn calls kill(getpid(), signum), thus

Re: tftpd(8): diff for ip path rewrite

On Mon, Oct 23 2017, Jan Klemkow wrote: > On Sun, Oct 22, 2017 at 09:32:54PM +, Jeremie Courreges-Anglas wrote: >> On Sat, Oct 21 2017, Jan Klemkow wrote: >> > On Fri, Oct 20, 2017 at 12:04:41PM +, Jeremie Courreges-Anglas wrote: >> >> On Fri,

Re: patch: syndaemon hangs on SIGINT

This has fixed the hanging processes on my laptop. On Tue, Oct 24, 2017 at 11:55 AM, Luca Castagnini < ilfigliodellaparolaavu...@gmail.com> wrote: > Hi guys, > > syndaemon goes into an infinite loop whenever it receives a SIGINT signal. > An explanation and a patch are proposed below. > > In the

Re: Refactor TCP partial ACK handling

On Tue, Oct 24, 2017 at 03:21:08PM +0200, Mike Belopuhov wrote: > I didn't do it because tcp_var.h is where tcp keeps all of it's prototypes > but I don't mind moving them into tcp_input.c. Any objections? Otherwise > I'll check in the diff below. ok job@

Remove TCP_FACK

Dear all, This patch builds upon the work shared in the following email. Mike's patch is a prerequisite to apply this patch. Date: Tue, 24 Oct 2017 15:21:08 +0200 From: Mike Belopuhov Subject: Re: Refactor TCP partial ACK handling TCP_FACK was