Re: athn(4) USB open firmware support

2018-02-04 Thread Stefan Sperling
On Sun, Feb 04, 2018 at 12:01:58AM +0100, Stefan Sperling wrote: > I have also briefly tested hostap with both AR9271 and AR7010 and it > now seems to work well enough to justify removing the BUGS section from > the athn(4) page. I have to retract the above statement. I've done some more testing a

Re: ospfd: depend on interface (new feature)

2018-02-04 Thread Remi Locherer
On Sun, Feb 04, 2018 at 05:19:59AM +0100, Claudio Jeker wrote: > On Sun, Feb 04, 2018 at 12:42:22AM +0100, Remi Locherer wrote: > > Hi > > > > This adds a new feature to ospfd: depend on interface. > > > > A ospfd.conf using it looks like this: > > > > --%<-- > > redistribute default depend on c

Re: ospfd: depend on interface (new feature)

2018-02-04 Thread Stuart Henderson
On 2018/02/04 02:56, Kapetanakis Giannis wrote: > On 04/02/18 01:42, Remi Locherer wrote: > > Hi > > > > This adds a new feature to ospfd: depend on interface. > > > > A ospfd.conf using it looks like this: > > > > --%<-- > > redistribute default depend on carp0 > > area 0.0.0.0 { > > interf

cron: don't close crontab_fd twice

2018-02-04 Thread Theo Buehler
The load_user() function gets a file descriptor from process_crontab(). It fdopen()s it directly and fclose()s the resulting stream. Then process_crontab() closes the stream a second time before exiting. Since crontab_fd is not load_user()'s descriptor, let's dup it before opening the stream. Ind

Re: sleep(1): better error messages

2018-02-04 Thread Theo de Raadt
> Exiting with EINVAL is really unusual. It went into r1.9. Unless > I'm missing something I think we can just exit with 1, which is > consistent with what other utilities do. No kidding, that's a definate bug.

Re: athn(4) USB open firmware support

2018-02-04 Thread Stefan Sperling
On Sun, Feb 04, 2018 at 11:15:01AM +0100, Stefan Sperling wrote: > On Sun, Feb 04, 2018 at 12:01:58AM +0100, Stefan Sperling wrote: > > I have also briefly tested hostap with both AR9271 and AR7010 and it > > now seems to work well enough to justify removing the BUGS section from > > the athn(4) pa

Re: ospfd: depend on interface (new feature)

2018-02-04 Thread Kapetanakis Giannis
On 04/02/18 17:52, Stuart Henderson wrote: On 2018/02/04 02:56, Kapetanakis Giannis wrote: On 04/02/18 01:42, Remi Locherer wrote: Hi This adds a new feature to ospfd: depend on interface. If I understand this right, someone could use this combined with pfsync, to wait for states full sync b

Re: ospfd: depend on interface (new feature)

2018-02-04 Thread Stuart Henderson
On 2018/02/04 23:04, Kapetanakis Giannis wrote: > On 04/02/18 17:52, Stuart Henderson wrote: > > On 2018/02/04 02:56, Kapetanakis Giannis wrote: > > > On 04/02/18 01:42, Remi Locherer wrote: > > > > Hi > > > > > > > > This adds a new feature to ospfd: depend on interface. > > > > > > > If I under

ssh: don't close fds multiple times and don't close(-1)

2018-02-04 Thread Theo Buehler
In channel_close_fd(), the file descriptors for the socket, stdin, stdout and stderr aren't necessarily distinct, so closing them results in EBADF. In addition, the diff adds a couple of positivity checks to avoid calling close(-1). Index: usr.bin/ssh/channels.c ===

Re: amd64: much earlier Intel microcode loading

2018-02-04 Thread Patrick Wildt
On Wed, Jan 31, 2018 at 05:12:03PM +0100, Patrick Wildt wrote: > Hi, > > this diff allows us to load the Intel microcode much earlier. So far > we load it after the CPUs have identified and then have to update the > CPU flags afterwards. This is not good since we have to assume that > those upda

daily(8): don't fail silently if backup disk is unavailable

2018-02-04 Thread Theo Buehler
After a power failure, my apu2 booted, but its sdmmc controller didn't attach properly. A few days later I was wondering why I didn't get the usual dump output from the backup of the root filesystem in my daily mails. It turns out that daily(8) fails silently if it can't find the backup volume. Si

Re: amd64: much earlier Intel microcode loading

2018-02-04 Thread Mike Larkin
On Mon, Feb 05, 2018 at 11:02:27AM +1300, Patrick Wildt wrote: > On Wed, Jan 31, 2018 at 05:12:03PM +0100, Patrick Wildt wrote: > > Hi, > > > > this diff allows us to load the Intel microcode much earlier. So far > > we load it after the CPUs have identified and then have to update the > > CPU fl

Re: cron: don't close crontab_fd twice

2018-02-04 Thread Todd C. Miller
On Mon, 05 Feb 2018 09:21:32 +1300, Theo Buehler wrote: > The load_user() function gets a file descriptor from process_crontab(). > It fdopen()s it directly and fclose()s the resulting stream. Then > process_crontab() closes the stream a second time before exiting. > > Since crontab_fd is not load

Re: cron: don't close crontab_fd twice

2018-02-04 Thread Theo Buehler
On Sun, Feb 04, 2018 at 07:19:57PM -0700, Todd C. Miller wrote: > On Mon, 05 Feb 2018 09:21:32 +1300, Theo Buehler wrote: > > > The load_user() function gets a file descriptor from process_crontab(). > > It fdopen()s it directly and fclose()s the resulting stream. Then > > process_crontab() closes

Update ifconfig(8): wpaakms implies wpa option

2018-02-04 Thread James Jerkins
Update the ifconfig(8) man page to state that the wpa option is implied when the wpaakms option is set. Changed in ifconfig.c revision 1.354. Index: ifconfig.8 === RCS file: /cvs/src/sbin/ifconfig/ifconfig.8,v retrieving revision 1

Re: ssh: don't close fds multiple times and don't close(-1)

2018-02-04 Thread Damien Miller
ok djm On Mon, 5 Feb 2018, Theo Buehler wrote: > In channel_close_fd(), the file descriptors for the socket, stdin, > stdout and stderr aren't necessarily distinct, so closing them results > in EBADF. In addition, the diff adds a couple of positivity checks to > avoid calling close(-1). > > Inde

Re: Update ifconfig(8): wpaakms implies wpa option

2018-02-04 Thread Theo de Raadt
I don't see the point of these details. Documenting every behaviour makes the manual page hard to read. > Update the ifconfig(8) man page to state that the wpa option is > implied when the wpaakms option is set. > > Changed in ifconfig.c revision 1.354. > > Index: ifconfig.8 >

Re: athn(4) USB open firmware support

2018-02-04 Thread Kevin Lo
On Sun, Feb 04, 2018 at 09:54:35PM +0100, Stefan Sperling wrote: > > On Sun, Feb 04, 2018 at 11:15:01AM +0100, Stefan Sperling wrote: > > On Sun, Feb 04, 2018 at 12:01:58AM +0100, Stefan Sperling wrote: > > > I have also briefly tested hostap with both AR9271 and AR7010 and it > > > now seems to w

rework ppp and pptp processing in tcpdump

2018-02-04 Thread David Gwynne
i think i was looking at gre and pptp packets, and ended up going down a rabbit hole in ppp parsing. the original aim was probably to print the ppp payload in pptp packets, which tcpdump now does. eg: 23:52:00.197893 call 24 seq 7: gre-ppp-payload (gre encap) 23:52:00.198930 call 1 seq 7 ack 7: