Re: Fix descriptions of smtps vs smtp+tls in smtpd.conf.5

2018-10-25 Thread Gilles Chehade
On Thu, Oct 25, 2018 at 07:24:33AM +0100, Raf Czlonka wrote: > On Thu, Oct 25, 2018 at 07:11:47AM BST, Gilles Chehade wrote: > > > > smtpd will _always_ display a 'starttls' log line when the TLS channel > > starts, > > disregarding if TLS was started at connect time (smtps) or within the > >

Re: Fix descriptions of smtps vs smtp+tls in smtpd.conf.5

2018-10-25 Thread Gilles Chehade
On Mon, Oct 22, 2018 at 08:37:25PM -0400, trondd wrote: > Unless I'm confused, it seems the description of the smarthosts smtps and > smtp+tls are revered in the smtpd.conf man page. > You are confused ;-) > My log seemed to back this up. When using smtp+tls, which the man page said > uses

Re: Fix descriptions of smtps vs smtp+tls in smtpd.conf.5

2018-10-25 Thread Raf Czlonka
On Thu, Oct 25, 2018 at 07:11:47AM BST, Gilles Chehade wrote: > > smtpd will _always_ display a 'starttls' log line when the TLS channel starts, > disregarding if TLS was started at connect time (smtps) or within the protocol > (smtp+tls, or even smtp since it does opportunistic tls). > I guess

bgpd: replace some more walkers with rib_dump

2018-10-25 Thread Claudio Jeker
Next step on my quest to make the RIB code better. This changes the following things: - network_flush is now using rib_dump_new to walk the Adj-RIB-In and remove all dynamically added announcements - peer_flush got generalized and is now used also in peer_down. It also uses a rib_dump_new call

Re: bgpd, use correct size for ASPATH_HEADER_SIZE

2018-10-25 Thread Denis Fondras
On Thu, Oct 25, 2018 at 10:57:58AM +0200, Claudio Jeker wrote: > Currently struct aspath is defined with a placeholder for the dynamic data > part. > struct aspath { > LIST_ENTRY(aspath) entry; > int refcnt; /* reference count */ > u_int16_t

Re: Fix descriptions of smtps vs smtp+tls in smtpd.conf.5

2018-10-25 Thread trondd
On Thu, October 25, 2018 2:24 am, Raf Czlonka wrote: > On Thu, Oct 25, 2018 at 07:11:47AM BST, Gilles Chehade wrote: >> >> smtpd will _always_ display a 'starttls' log line when the TLS channel >> starts, >> disregarding if TLS was started at connect time (smtps) or within the >> protocol >>

Re: bgplg: allow neighbors with space in name

2018-10-25 Thread Stuart Henderson
On 2018/10/24 17:38, Denis Fondras wrote: > I have peers with description containing spaces but bgplg won't accept that by > default. > > I'd like some comments on that diff. > It is OK for bgplgsh (show ip bgp in "Peer 1" feels OK) but not for bgplg as I > have to quote the peer description in

Re: unveil getconf

2018-10-25 Thread Todd C. Miller
On Thu, 25 Oct 2018 11:19:34 +0100, Ricardo Mestre wrote: > The code path were we pass `pathname' in the arguments is already limited > with pledge(2), but since we know exactly what it is then we can go further > and also unveil(2) it with read permissions. OK millert@ - todd

Re: bgplg: allow neighbors with space in name

2018-10-25 Thread Theo de Raadt
Stuart Henderson wrote: > On 2018/10/24 17:38, Denis Fondras wrote: > > I have peers with description containing spaces but bgplg won't accept that > > by > > default. > > > > I'd like some comments on that diff. > > It is OK for bgplgsh (show ip bgp in "Peer 1" feels OK) but not for bgplg >

Re: /bin/df align inode output

2018-10-25 Thread Todd C. Miller
With your patch the mount point is offset by a space from the "Mounted on" header. - todd

Re: bgplg: allow neighbors with space in name

2018-10-25 Thread Denis Fondras
On Thu, Oct 25, 2018 at 02:04:10PM +0100, Stuart Henderson wrote: > On 2018/10/24 17:38, Denis Fondras wrote: > > I have peers with description containing spaces but bgplg won't accept that > > by > > default. > > > > I'd like some comments on that diff. > > It is OK for bgplgsh (show ip bgp in

Re: bgplg: allow neighbors with space in name

2018-10-25 Thread Tom Smyth
Hello Denis, Stuart, all, I think what Stuart is saying regarding double quotes makes sense we try to avoid spaces where possible makes life easier ... Thanks Tom Smyth On Thu, 25 Oct 2018 at 14:06, Stuart Henderson wrote: > > On 2018/10/24 17:38, Denis Fondras wrote: > > I have peers with

Re: bgpd: replace some more walkers with rib_dump

2018-10-25 Thread Claudio Jeker
On Thu, Oct 25, 2018 at 09:04:18PM +0200, Denis Fondras wrote: > On Thu, Oct 25, 2018 at 08:51:30AM +0200, Claudio Jeker wrote: > > Next step on my quest to make the RIB code better. > > This changes the following things: > > - network_flush is now using rib_dump_new to walk the Adj-RIB-In and > >

The X hole

2018-10-25 Thread Theo de Raadt
In his role at X.org in the security team, Matthieu says he became aware of this bug on the 11th. He did not tell any of us at OpenBSD. We were made aware bit more than 1 hour before public information went out. We were in the midst of an early OpenBSD release. If we had known, the OpenBSD 6.4

Add new PCI product IDs

2018-10-25 Thread Peter Ezetta
Hello, Diff below adds product IDs for the Nvidia Quadro M1200 Mobile graphics card and the Intel Xeon E3-1200 v6 7th gen Host Bridge (for mobile). Index: pcidevs === RCS file: /cvs/src/sys/dev/pci/pcidevs,v retrieving revision

bgplg: fix crash (error 500)

2018-10-25 Thread Denis Fondras
Just make sure arg is not NULL in lg_getarg() before accessing. It happens when input contains an invalid character. Unrelated but while at it, abort earlier in lg_arg2argv() if there is no argument available. Index: bgplg.c === RCS

Re: bgpd: replace some more walkers with rib_dump

2018-10-25 Thread Denis Fondras
On Thu, Oct 25, 2018 at 08:51:30AM +0200, Claudio Jeker wrote: > Next step on my quest to make the RIB code better. > This changes the following things: > - network_flush is now using rib_dump_new to walk the Adj-RIB-In and > remove all dynamically added announcements > - peer_flush got

unveil getconf

2018-10-25 Thread Ricardo Mestre
Hi, The code path were we pass `pathname' in the arguments is already limited with pledge(2), but since we know exactly what it is then we can go further and also unveil(2) it with read permissions. Comments? OK? Index: getconf.c

/bin/df align inode output

2018-10-25 Thread Solene Rapenne
the following diff makes df printing aligned inode informations. before patch solene@t480 /usr/src/bin/df $ df -ik Filesystem 1K-blocks Used Avail Capacity iused ifree %iused Mounted on /dev/sd2a 102887813786283957414%2227 153675 1% / /dev/sd2l

Re: Reuse VM ids.

2018-10-25 Thread Reyk Floeter
On Tue, Oct 23, 2018 at 10:21:08PM -0700, Ori Bernstein wrote: > On Mon, 8 Oct 2018 07:59:15 -0700, Bob Beck wrote: > > > works here and I like it. but probably for after unlock > > > > It's after unlock -- pinging for OKs. > Not yet. Please include the VM's uid in the claim, e.g.

make nc(4) print what went wrong with unix domain sockets

2018-10-25 Thread David Gwynne
nc looks like it just does nothing without it. it's nice to see things like "No such file" or "Permission denied". ok? Index: netcat.c === RCS file: /cvs/src/usr.bin/nc/netcat.c,v retrieving revision 1.191 diff -u -p -r1.191

Re: Add PCI ID for VirtualBox NVMe

2018-10-25 Thread Mike Larkin
On Thu, Jul 19, 2018 at 07:19:55PM -0500, Andrew Daugherity wrote: > This is strictly a cosmetic change, as it already gets bound to > nvme(4) and works properly, but is currently identified as an unknown > product. > > > diff --git a/sys/dev/pci/pcidevs b/sys/dev/pci/pcidevs > index

unveil kvm_mkdb

2018-10-25 Thread Ricardo Mestre
Hi, If we pass `file' via args then we need to unveil(2) it with read permission, otherwise if omitted we need to unveil(2) both _PATH_UNIX and _PATH_KSYMS with same permissions. Unconditionally we need to also unveil(2) dbdir, which by default is _PATH_VARDB but can be changed via args (-o

bgpd, use correct size for ASPATH_HEADER_SIZE

2018-10-25 Thread Claudio Jeker
Currently struct aspath is defined with a placeholder for the dynamic data part. struct aspath { LIST_ENTRY(aspath) entry; int refcnt; /* reference count */ u_int16_t len;/* total length of aspath in octets */ u_int16_t

Re: unveil bdftopcf

2018-10-25 Thread Ricardo Mestre
Something like this then? If it's too much burden to keep these local patches I can drop it, no problem. Index: bdftopcf.c === RCS file: /cvs/xenocara/app/bdftopcf/bdftopcf.c,v retrieving revision 1.5 diff -u -p -u -r1.5 bdftopcf.c