Re: inteldrm(4): uvm write-combining support

2018-10-27 Thread Jonathan Gray
On Fri, Oct 26, 2018 at 09:47:51PM +0200, Mark Kettenis wrote: > Diff below adds support to uvm to create wtite-combining mappings and > uses this to implement support for the I915_MMAP_WC flag in > inteldrm(4). With this diff I can re-enable support for the > I915_PARAM_MMAP_VERSION. > > Please

ld.lld/ld.bfd difference in -rpath management

2018-10-27 Thread Sebastien Marie
Hi, I am sending this email on tech@, as I assume it could be interesting for base developers to be aware of a slightly difference between ld.bfd and ld.lld regarding -rpath option (and as I sent a previous mail on ports@ and not everybody follow ports@). while I investigated a problem on

Re: ld.lld/ld.bfd difference in -rpath management

2018-10-27 Thread Mark Kettenis
> Date: Sat, 27 Oct 2018 10:00:01 +0200 > From: Sebastien Marie > > Hi, > > I am sending this email on tech@, as I assume it could be interesting > for base developers to be aware of a slightly difference between ld.bfd > and ld.lld regarding -rpath option (and as I sent a previous mail on >

Re: Regression in "Add support to create and convert disk images from existing images"

2018-10-27 Thread Anton Lindqvist
On Wed, Oct 24, 2018 at 05:51:08PM +0200, Anton Lindqvist wrote: > On Mon, Oct 22, 2018 at 11:05:13AM -0700, Greg Steuck wrote: > > Hi Reyk & Anton, > > > > I upgraded the syzkaller machine from Oct 11 to Oct 21 snapshot and started > > seeing: > > Oct 22 10:00:21 ci-openbsd vmd[15707]: qc2_open:

Re: inteldrm(4): uvm write-combining support

2018-10-27 Thread Mark Kettenis
> Date: Sat, 27 Oct 2018 17:16:57 +1100 > From: Jonathan Gray > > On Fri, Oct 26, 2018 at 09:47:51PM +0200, Mark Kettenis wrote: > > Diff below adds support to uvm to create wtite-combining mappings and > > uses this to implement support for the I915_MMAP_WC flag in > > inteldrm(4). With this

Re: ld.lld/ld.bfd difference in -rpath management

2018-10-27 Thread Marc Espie
On Sat, Oct 27, 2018 at 01:01:10PM +0200, Mark Kettenis wrote: > > Correct. More recent GNU linkers behave the same way as lld, which is > why I think the change in behaviour is a good thing. > > It is possible to make ld.lld emit DT_RPATH by passing > -Wl,-disable-new-dtags. And if you pass

bgplg: keep all args on submit

2018-10-27 Thread Denis Fondras
When submitting a command in bgplg(8), argument is not kept in its entirety (split on space) which can be annoying ie. when querying extended community. Fix this by printing request before splitting. Index: bgplg.c === RCS file:

Re: top: merge duplicate username parsing code into filteruser()

2018-10-27 Thread Klemens Nanni
On Sat, Oct 27, 2018 at 06:28:41PM +0200, Klemens Nanni wrote: > + } else > + uidp = > + ps.huid = -1; And here I was sloppy. Sorry. Index: top.c === RCS file: /cvs/src/usr.bin/top/top.c,v retrieving

top: merge duplicate username parsing code into filteruser()

2018-10-27 Thread Klemens Nanni
Reduce four almost identical uid_from_user(3) calls into one by handling negation once in a way show/hide agnostic way. I want to add support for UIDs besides usernames, so this diff is a preliminary cleanup to allow for this feature addition to happen in the newly introduced function. The

Re: top: merge duplicate username parsing code into filteruser()

2018-10-27 Thread Klemens Nanni
On Sat, Oct 27, 2018 at 06:05:33PM +0200, Klemens Nanni wrote: > Reduce four almost identical uid_from_user(3) calls into one by handling > negation once in a way show/hide agnostic way. > > I want to add support for UIDs besides usernames, so this diff is a > preliminary cleanup to allow for

Re: Qcow2: Clean up logging/error handling

2018-10-27 Thread Mike Larkin
On Sun, Oct 28, 2018 at 12:58:57AM +0200, Reyk Floeter wrote: > Most of these are fatal and log_debug. Keep the __func__ there! But we’ll > remove it from other logging functions where it was never intended to be used > and potentially reword the warnings nicely. > > Reyk > Yep. If I added

Re: Qcow2: Clean up logging/error handling

2018-10-27 Thread Ori Bernstein
On Wed, 24 Oct 2018 16:23:29 +0800, Michael Mikonos wrote: > On Tue, Oct 23, 2018 at 09:44:24PM -0700, Ori Bernstein wrote: > > This patch turns most warnings into errors, and uses the > > appropriate fatal/fatalx so that we don't print bogus error > > strings. It also adds checks for

Re: Reuse VM ids.

2018-10-27 Thread Ori Bernstein
On Fri, 26 Oct 2018 01:57:15 +0200, Reyk Floeter wrote: > On Tue, Oct 23, 2018 at 10:21:08PM -0700, Ori Bernstein wrote: > > On Mon, 8 Oct 2018 07:59:15 -0700, Bob Beck wrote: > > > > > works here and I like it. but probably for after unlock > > > > > > > It's after unlock -- pinging for

Re: unveil ospfd's parent proc

2018-10-27 Thread Theo de Raadt
Remi Locherer wrote: > On Fri, Oct 26, 2018 at 10:19:01AM -0600, Theo de Raadt wrote: > > Remi Locherer wrote: > > > > > On Fri, Oct 26, 2018 at 06:01:40PM +0200, Florian Obser wrote: > > > > This breaks usage of the "include" keyword. Something that all the > > > > parse.y daemons support. >

Re: Qcow2: Clean up logging/error handling

2018-10-27 Thread Theo de Raadt
I quite dislike when software uses __func__ to tell me what internal function had an error. Why should a user see an error with the string virtio_qcow2_get_base, qc2_open, qc2_pwrite, etc? It feels unpolished.

Re: Qcow2: Clean up logging/error handling

2018-10-27 Thread Ori Bernstein
On Sat, 27 Oct 2018 16:15:32 -0600, "Theo de Raadt" wrote: > I quite dislike when software uses __func__ to tell me what internal > function had an error. > > Why should a user see an error with the string virtio_qcow2_get_base, > qc2_open, qc2_pwrite, etc? > > It feels unpolished. >

Re: Qcow2: Clean up logging/error handling

2018-10-27 Thread Theo de Raadt
> > I quite dislike when software uses __func__ to tell me what internal > > function had an error. > > > > Why should a user see an error with the string virtio_qcow2_get_base, > > qc2_open, qc2_pwrite, etc? > > > > It feels unpolished. > > > > Possibly, but it is consistent with the rest of

Re: Qcow2: Clean up logging/error handling

2018-10-27 Thread Reyk Floeter
Most of these are fatal and log_debug. Keep the __func__ there! But we’ll remove it from other logging functions where it was never intended to be used and potentially reword the warnings nicely. Reyk > Am 28.10.2018 um 00:39 schrieb Ori Bernstein : > >> On Sat, 27 Oct 2018 16:15:32 -0600,

Re: unveil ospfd's parent proc

2018-10-27 Thread Remi Locherer
On Fri, Oct 26, 2018 at 10:19:01AM -0600, Theo de Raadt wrote: > Remi Locherer wrote: > > > On Fri, Oct 26, 2018 at 06:01:40PM +0200, Florian Obser wrote: > > > This breaks usage of the "include" keyword. Something that all the > > > parse.y daemons support. > > > > > > > Oh, of course! > >

Re: user land system spinning time

2018-10-27 Thread Chris Bennett
On Mon, Oct 08, 2018 at 09:44:35PM +0200, Alexander Bluhm wrote: > Hi, > > On May 14 we did split kernel spinning time from system time. Goal > was to see what the kernel is doing. > > I just realized that user land time accounting has also changed. > The commit changed system time of a process