change reboot behaviour in vmd

2018-12-06 Thread Claudio Jeker
So doing autoinstall with -B net is great but one thing I was missing is changing the reboot behaviour of vmd to exit at a guest reboot. I came up with this minimal diff that does the trick for me. Now maybe it would be better to have a proper flag for this instead of overloading vmc_bootdevice

malloc: simplify "not my pool" lock dance

2018-12-06 Thread Otto Moerbeek
Hi, This simpifies the lock dance when a free is done for a pointer not in "my pool". Should reduce lock contention. Please review & test, especially with multithread heavy apps. -Otto Index: malloc.c === RCS file:

Re: bgpd refactor aspath_match a bit

2018-12-06 Thread Claudio Jeker
On Wed, Nov 28, 2018 at 10:35:37AM +0100, Claudio Jeker wrote: > On Tue, Nov 27, 2018 at 06:55:51PM +0100, Job Snijders wrote: > > On Tue, Nov 27, 2018 at 06:23:53PM +0100, Claudio Jeker wrote: > > > On Tue, Nov 27, 2018 at 04:21:53PM +0100, Job Snijders wrote: > > > > On Fri, Nov 23, 2018 at

[Patch] Specify unit for 'every' in ifstated.conf.5

2018-12-06 Thread Ross L Richardson
The number is in seconds, but that's currently not specified. Wording which preserved "frequency" but made sense with "seconds" eluded me, so I changed things to refer to "interval". Ross Index: ifstated.conf.5 === RCS

nsd 4.1.26

2018-12-06 Thread Florian Obser
tests, OKs? diff --git Makefile.in Makefile.in index 16d193f766d..fbfc44be33b 100644 --- Makefile.in +++ Makefile.in @@ -29,6 +29,8 @@ nsdconfigfile = @nsd_conf_file@ zonesdir = @zonesdir@ chrootdir= @chrootdir@ user = @user@ +DNSTAP_SRC=@DNSTAP_SRC@ +DNSTAP_OBJ=@DNSTAP_OBJ@ # override $U

ktrace buglet

2018-12-06 Thread Ted Unangst
ktrace -C will return an error if you don't have a ktrace.out file because sys_ktrace tries to open it whenever it has a filename, even if it won't be used. I think it is more consistent to require it be null, so that we aren't opening files we won't be using. man page and utility diff below.

Re: option kcov + GENERIC.MP -> silent crash

2018-12-06 Thread Greg Steuck
> Here's a new diff taking a different approach. Keeping tracing off until > all secondary CPUs have booted solves the issue of accessing curcpu() > too early. Another issue was then discovered, curproc can be NULL before > the idle thread tied the current CPU has started. Currently running with >

Re: [Patch] Specify unit for 'every' in ifstated.conf.5

2018-12-06 Thread Stuart Henderson
On 2018/12/06 13:01, Ted Unangst wrote: > Jason McIntyre wrote: > > On Thu, Dec 06, 2018 at 10:21:47PM +1100, Ross L Richardson wrote: > > > > > > The number is in seconds, but that's currently not specified. > > > > > > Wording which preserved "frequency" but made sense with "seconds" > > >

Re: Importing FreeBSD eMMC code

2018-12-06 Thread Ted Unangst
Heppler, J. Scott wrote: > Is there interest in installing/booting OpenBSD on eMMC? this is expected to work.

Re: be more strict when parsing netmasks for IPv6

2018-12-06 Thread Claudio Jeker
On Thu, Dec 06, 2018 at 08:04:54PM +0100, Remi Locherer wrote: > On Thu, Dec 06, 2018 at 03:24:52PM +0100, Claudio Jeker wrote: > > On Wed, Dec 05, 2018 at 11:53:48PM +0100, Remi Locherer wrote: > > > On Wed, Dec 05, 2018 at 09:22:22AM +0100, Claudio Jeker wrote: > > > > When parsing a network

Re: bail early in nd6_na_output() if not carp master

2018-12-06 Thread Claudio Jeker
On Thu, Dec 06, 2018 at 08:03:01PM +0100, Florian Obser wrote: > Spotted this when reviewing Claudio's m_align diff and wondered why we > bail right at the end just before we send the packet. Is there stuff > happening before that's important? Turns out no. > > (I suspect this is a belt for

bail early in nd6_na_output() if not carp master

2018-12-06 Thread Florian Obser
Spotted this when reviewing Claudio's m_align diff and wondered why we bail right at the end just before we send the packet. Is there stuff happening before that's important? Turns out no. (I suspect this is a belt for suspenders somewhere else in the stack and we never get here on a carp backup

Re: diff: ftpd(8): fix for sign-compare compiler warnings

2018-12-06 Thread Jan Klemkow
On Tue, Nov 27, 2018 at 09:03:15AM +0100, Theo Buehler wrote: > On Sun, Nov 25, 2018 at 12:32:23AM +0100, Jan Klemkow wrote: > > This diff fixes some -Wsign-compare compiler warnings in ftpd(8) by > > using the right types for 'i' and 'len'. One warning is left, but I > > don't see that it's

Re: ktrace buglet

2018-12-06 Thread Klemens Nanni
On Thu, Dec 06, 2018 at 03:33:06PM -0500, Ted Unangst wrote: > ktrace -C will return an error if you don't have a ktrace.out file because > sys_ktrace tries to open it whenever it has a filename, even if it won't be > used. I think it is more consistent to require it be null, so that we aren't >

Re: be more strict when parsing netmasks for IPv6

2018-12-06 Thread Remi Locherer
On Thu, Dec 06, 2018 at 03:24:52PM +0100, Claudio Jeker wrote: > On Wed, Dec 05, 2018 at 11:53:48PM +0100, Remi Locherer wrote: > > On Wed, Dec 05, 2018 at 09:22:22AM +0100, Claudio Jeker wrote: > > > When parsing a network mask into prefixlen be more paranoid and make sure > > > no value bigger

Importing FreeBSD eMMC code

2018-12-06 Thread Heppler, J. Scott
The market is being flooded with Win10 netbooks, NAS, NUC-type devices that use eMMC. I suspect this is due to the eMMC being filled with multiple backups from Microsofts' update process and being returned for failure to update. The devices are relatively cheap. Leveno, Acer, Asus and HP all

Re: Remove no longer used M_ALIGN and MH_ALIGN

2018-12-06 Thread Klemens Nanni
OK

Re: Importing FreeBSD eMMC code

2018-12-06 Thread Heppler, J. Scott
I'll add my dmesg from an HP Stream 14 cb112wm OpenBSD 6.4-current (RAMDISK_CD) #465: Wed Nov 28 22:26:21 MST 2018 dera...@amd64.openbsd.org:/usr/src/sys/arch/amd64/compile/RAMDISK_CD real mem = 8128622592 (7752MB) avail mem = 7878479872 (7513MB) mainbus0 at root bios0 at mainbus0: SMBIOS

Re: relayd and TLS client cert verification

2018-12-06 Thread Rivo Nurges
Hi! I have planned to do it myself for quite long time but never got around doing it. In my testing it works great. I have patch on top of this which allows to pass remote certificate and/or parts of it to backend hosts via http headers. Rivo On Thu, 2018-12-06 at 05:17 +, Ashe Connor

Re: relayd and TLS client cert verification

2018-12-06 Thread Ashe Connor
On Thu, Dec 06, 2018 at 12:46:33PM +, Rivo Nurges wrote: > I have planned to do it myself for quite long time but never got around > doing it. In my testing it works great. Excellent, I'm glad to hear! > I have patch on top of this which allows to pass remote certificate > and/or parts of

Re: find -not

2018-12-06 Thread Todd C. Miller
On Wed, 05 Dec 2018 22:52:13 -0500, "Ted Unangst" wrote: > Seen in the wild. Alias for ! that's friendlier to the shell. OK millert@ - todd

Re: [Patch] Specify unit for 'every' in ifstated.conf.5

2018-12-06 Thread Ross L Richardson
Whilst I agree with Otto (and others), how about making it really simple by avoiding technical terms? Ross Index: ifstated.conf.5 === RCS file: /cvs/src/usr.sbin/ifstated/ifstated.conf.5,v retrieving revision 1.13 diff -u -p

Re: [Patch] Specify unit for 'every' in ifstated.conf.5

2018-12-06 Thread Jason McIntyre
On Fri, Dec 07, 2018 at 02:56:03PM +1100, Ross L Richardson wrote: > > Whilst I agree with Otto (and others), how about making it really simple > by avoiding technical terms? > > Ross > > > Index: ifstated.conf.5 > === > RCS

sed(1) make -i behave a little nicer

2018-12-06 Thread Martijn van Duren
I ran into a few minor nuisances with sed's -i mode, which are mostly compatible with gnu sed, but I reckon we should address. The problem is sed works by writing the output to a second file in the same directory as the original and after completion renaming the file to the original. This has

Re: be more strict when parsing netmasks for IPv6

2018-12-06 Thread Florian Obser
On Thu, Dec 06, 2018 at 03:24:52PM +0100, Claudio Jeker wrote: > On Wed, Dec 05, 2018 at 11:53:48PM +0100, Remi Locherer wrote: > > On Wed, Dec 05, 2018 at 09:22:22AM +0100, Claudio Jeker wrote: > > > When parsing a network mask into prefixlen be more paranoid and make sure > > > no value bigger

Re: [Patch] Specify unit for 'every' in ifstated.conf.5

2018-12-06 Thread Ted Unangst
Jason McIntyre wrote: > On Thu, Dec 06, 2018 at 10:21:47PM +1100, Ross L Richardson wrote: > > > > The number is in seconds, but that's currently not specified. > > > > Wording which preserved "frequency" but made sense with "seconds" > > eluded me, so I changed things to refer to "interval". >

Re: [Patch] Specify unit for 'every' in ifstated.conf.5

2018-12-06 Thread Jason McIntyre
On Thu, Dec 06, 2018 at 06:40:28PM +0100, Otto Moerbeek wrote: > On Thu, Dec 06, 2018 at 05:33:21PM +, Jason McIntyre wrote: > > > On Thu, Dec 06, 2018 at 06:26:36PM +0100, Otto Moerbeek wrote: > > > On Thu, Dec 06, 2018 at 05:22:36PM +, Jason McIntyre wrote: > > > > > > > On Thu, Dec

Re: [Patch] Specify unit for 'every' in ifstated.conf.5

2018-12-06 Thread Jason McIntyre
On Thu, Dec 06, 2018 at 01:01:49PM -0500, Ted Unangst wrote: > Jason McIntyre wrote: > > On Thu, Dec 06, 2018 at 10:21:47PM +1100, Ross L Richardson wrote: > > > > > > The number is in seconds, but that's currently not specified. > > > > > > Wording which preserved "frequency" but made sense

Re: [Patch] Specify unit for 'every' in ifstated.conf.5

2018-12-06 Thread Jason McIntyre
On Thu, Dec 06, 2018 at 10:21:47PM +1100, Ross L Richardson wrote: > > The number is in seconds, but that's currently not specified. > > Wording which preserved "frequency" but made sense with "seconds" > eluded me, so I changed things to refer to "interval". > > > Ross > > > > Index:

Re: [Patch] Specify unit for 'every' in ifstated.conf.5

2018-12-06 Thread Otto Moerbeek
On Thu, Dec 06, 2018 at 05:09:23PM +, Jason McIntyre wrote: > On Thu, Dec 06, 2018 at 10:21:47PM +1100, Ross L Richardson wrote: > > > > The number is in seconds, but that's currently not specified. > > > > Wording which preserved "frequency" but made sense with "seconds" > > eluded me, so

Re: [Patch] Specify unit for 'every' in ifstated.conf.5

2018-12-06 Thread Jason McIntyre
On Thu, Dec 06, 2018 at 06:17:16PM +0100, Otto Moerbeek wrote: > On Thu, Dec 06, 2018 at 05:09:23PM +, Jason McIntyre wrote: > > > On Thu, Dec 06, 2018 at 10:21:47PM +1100, Ross L Richardson wrote: > > > > > > The number is in seconds, but that's currently not specified. > > > > > > Wording

Re: [Patch] Specify unit for 'every' in ifstated.conf.5

2018-12-06 Thread Otto Moerbeek
On Thu, Dec 06, 2018 at 05:22:36PM +, Jason McIntyre wrote: > On Thu, Dec 06, 2018 at 06:17:16PM +0100, Otto Moerbeek wrote: > > On Thu, Dec 06, 2018 at 05:09:23PM +, Jason McIntyre wrote: > > > > > On Thu, Dec 06, 2018 at 10:21:47PM +1100, Ross L Richardson wrote: > > > > > > > > The

Re: [Patch] Specify unit for 'every' in ifstated.conf.5

2018-12-06 Thread Jason McIntyre
On Thu, Dec 06, 2018 at 06:26:36PM +0100, Otto Moerbeek wrote: > On Thu, Dec 06, 2018 at 05:22:36PM +, Jason McIntyre wrote: > > > On Thu, Dec 06, 2018 at 06:17:16PM +0100, Otto Moerbeek wrote: > > > On Thu, Dec 06, 2018 at 05:09:23PM +, Jason McIntyre wrote: > > > > > > > On Thu, Dec

Re: [Patch] Specify unit for 'every' in ifstated.conf.5

2018-12-06 Thread Otto Moerbeek
On Thu, Dec 06, 2018 at 05:33:21PM +, Jason McIntyre wrote: > On Thu, Dec 06, 2018 at 06:26:36PM +0100, Otto Moerbeek wrote: > > On Thu, Dec 06, 2018 at 05:22:36PM +, Jason McIntyre wrote: > > > > > On Thu, Dec 06, 2018 at 06:17:16PM +0100, Otto Moerbeek wrote: > > > > On Thu, Dec 06,

Remove no longer used M_ALIGN and MH_ALIGN

2018-12-06 Thread Claudio Jeker
All the references to the M_ALIGN and MH_ALIGN macros are gone. Time to bring them behind the shed and free them. OK? -- :wq Claudio Index: sys/sys/mbuf.h === RCS file: /cvs/src/sys/sys/mbuf.h,v retrieving revision 1.240 diff -u -p

Re: sed(1) Add support for "-" file

2018-12-06 Thread Todd C. Miller
This has the side effect of closing stdin on EOF but I don't think that is a problem. OK millert@ - todd

Re: be more strict when parsing netmasks for IPv6

2018-12-06 Thread Claudio Jeker
On Wed, Dec 05, 2018 at 11:53:48PM +0100, Remi Locherer wrote: > On Wed, Dec 05, 2018 at 09:22:22AM +0100, Claudio Jeker wrote: > > When parsing a network mask into prefixlen be more paranoid and make sure > > no value bigger then 128 is returned. In general this should never happen > > but if it

Re: be more strict when parsing netmasks for IPv6

2018-12-06 Thread Claudio Jeker
On Thu, Dec 06, 2018 at 05:14:45PM +0100, Florian Obser wrote: > On Thu, Dec 06, 2018 at 03:24:52PM +0100, Claudio Jeker wrote: > > On Wed, Dec 05, 2018 at 11:53:48PM +0100, Remi Locherer wrote: > > > On Wed, Dec 05, 2018 at 09:22:22AM +0100, Claudio Jeker wrote: > > > > When parsing a network