Hello,
On Mon, Jan 27, 2020 at 08:54:19PM +0100, Björn Ketelaars wrote:
> Replace custom TAILQ concatenation loop by TAILQ_CONCAT(3).
>
> Comments/OK?
looks good to me.
OK sashan@
Florian Obser(flor...@openbsd.org) on 2020.01.27 19:57:41 +0100:
> On Mon, Jan 27, 2020 at 10:33:49AM -0700, Todd C. Miller wrote:
> > On Mon, 27 Jan 2020 10:05:41 +1100, Jonathan Gray wrote:
> >
> > > On Sun, Jan 26, 2020 at 11:59:33AM -0500, David Goerger wrote:
> > > > This diff teaches du(1)
Replace custom TAILQ concatenation loop by TAILQ_CONCAT(3).
Comments/OK?
diff --git usr.sbin/snmpd/control.c usr.sbin/snmpd/control.c
index 54b58bbb7b6..dda18c1bad5 100644
--- usr.sbin/snmpd/control.c
+++ usr.sbin/snmpd/control.c
@@ -487,10 +487,7 @@ control_dispatch_agentx(int fd, short event,
Replace custom TAILQ concatenation loop by TAILQ_CONCAT(3).
Comments/OK?
diff --git usr.sbin/ldapd/search.c usr.sbin/ldapd/search.c
index 3033823eb18..887af5fb6a1 100644
--- usr.sbin/ldapd/search.c
+++ usr.sbin/ldapd/search.c
@@ -764,11 +764,8 @@ search_planner(struct namespace *ns, struct
Replace custom TAILQ concatenation loop by TAILQ_CONCAT(3).
Comments/OK?
diff --git usr.sbin/bgpd/config.c usr.sbin/bgpd/config.c
index cb43afb81fe..fc81a3efd3b 100644
--- usr.sbin/bgpd/config.c
+++ usr.sbin/bgpd/config.c
@@ -195,7 +195,6 @@ void
merge_config(struct bgpd_config *xconf, struct
On Mon, 27 Jan 2020 10:05:41 +1100, Jonathan Gray wrote:
> On Sun, Jan 26, 2020 at 11:59:33AM -0500, David Goerger wrote:
> > This diff teaches du(1) the -m flag, report disk usage in megabytes.
> > This brings us in line with implementations in the other BSDs, Linux,
> > and Illumos.
>
> Why
On Mon, 27 Jan 2020 20:01:24 +0100, =?utf-8?B?QmrDtnJu?= Ketelaars wrote:
> I build a kernel using the diff below and gave it a spin. So far it
> didn't blow up.
>
> I was wondering if it makes sense to address these custom concatenations
> and provide diffs, or is this considered nitpicking?
I
Replace custom TAILQ concatenation loop by TAILQ_CONCAT(3).
Comments/OK?
diff --git sbin/unwind/frontend.c sbin/unwind/frontend.c
index b64036c4332..d2b69084db7 100644
--- sbin/unwind/frontend.c
+++ sbin/unwind/frontend.c
@@ -1011,10 +1011,7 @@ merge_tas(struct trust_anchor_head *newh, struct
On Mon, Jan 27, 2020 at 08:54:19PM +0100, Björn Ketelaars wrote:
> Replace custom TAILQ concatenation loop by TAILQ_CONCAT(3).
OK kn
cheloha@ recently replaced custom TAILQ concatenation loops in pool(9)
with TAILQ_CONCAT(3) [0]. I was curious as how often these custom
concatenations loops are used and grepped src. I found a couple of them.
One being in sys/ufs/ffs/ffs_softdep.c, and the others in userland.
I build a kernel
Replace custom TAILQ concatenation loop by TAILQ_CONCAT(3).
Comments/OK?
diff --git sbin/pfctl/parse.y sbin/pfctl/parse.y
index d524f9e92bc..67de79215e4 100644
--- sbin/pfctl/parse.y
+++ sbin/pfctl/parse.y
@@ -5637,16 +5637,11 @@ mv_rules(struct pf_ruleset *src, struct pf_ruleset *dst)
{
3 changes in rde_lsdb.c
- lsa_find_lsid() has redondant parameters
- call to lsa_self() can be simplified (== ospfd)
- update debug messages to be more suitable
Index: rde.c
===
RCS file: /cvs/src/usr.sbin/ospf6d/rde.c,v
retrieving
On Mon, Jan 27, 2020 at 10:33:49AM -0700, Todd C. Miller wrote:
> On Mon, 27 Jan 2020 10:05:41 +1100, Jonathan Gray wrote:
>
> > On Sun, Jan 26, 2020 at 11:59:33AM -0500, David Goerger wrote:
> > > This diff teaches du(1) the -m flag, report disk usage in megabytes.
> > > This brings us in line
On 2019/11/29 iked and isakmpd were changed from installing "USE" flows
for inbound IPsec to "REQUIRE" flows, so that unencrypted packets are
rejected.
Normally this is good but I ran into a corner case.
I have a tunnel from my workstation to private subnets behind a remote
router. That remote
On Mon, Jan 27, 2020 at 10:34:56PM +0100, Sebastian Benoit wrote:
> Florian Obser(flor...@openbsd.org) on 2020.01.27 19:57:41 +0100:
> > On Mon, Jan 27, 2020 at 10:33:49AM -0700, Todd C. Miller wrote:
> > > On Mon, 27 Jan 2020 10:05:41 +1100, Jonathan Gray wrote:
> > >
> > > > On Sun, Jan 26,
Bj??rn Ketelaars(bjorn.ketela...@hydroxide.nl) on 2020.01.27 20:53:52 +0100:
> Replace custom TAILQ concatenation loop by TAILQ_CONCAT(3).
>
> Comments/OK?
reads ok benno@
> diff --git usr.sbin/snmpd/control.c usr.sbin/snmpd/control.c
> index 54b58bbb7b6..dda18c1bad5 100644
> ---
On Tue, 28 Jan 2020 15:00:39 +1100, Jonathan Gray wrote:
> There are several commands which have a -k flag for scaling to
> kilobytes.
>
> For example:
> df
> du
> ls
> pstat
> quot
> swapctl
>
> Going down the list of unit names kmgtpezy some of these flags are
> already used. So it would be
Bj??rn Ketelaars(bjorn.ketela...@hydroxide.nl) on 2020.01.27 20:52:36 +0100:
> Replace custom TAILQ concatenation loop by TAILQ_CONCAT(3).
>
> Comments/OK?
reads ok benno@
> diff --git sbin/unwind/frontend.c sbin/unwind/frontend.c
> index b64036c4332..d2b69084db7 100644
> ---
Bj??rn Ketelaars(bjorn.ketela...@hydroxide.nl) on 2020.01.27 20:53:06 +0100:
> Replace custom TAILQ concatenation loop by TAILQ_CONCAT(3).
>
> Comments/OK?
ok benno@
> diff --git usr.sbin/bgpd/config.c usr.sbin/bgpd/config.c
> index cb43afb81fe..fc81a3efd3b 100644
> --- usr.sbin/bgpd/config.c
>
On Mon, 27 Jan 2020 10:33:49 -0700, Todd C. Miller
wrote:
> For example, I often do:
>
> du -sk * | sort -rn | head
>
> to see the largest disk users.
>
> However, output in kilobytes is less useful than it used to be due
> to larger files now being common.
Can't you achieve what you
20 matches
Mail list logo