sparc64 cpu uvm_km_valloc()

2020-12-20 Thread Jonathan Matthew
Continuing to convert uvm_km_valloc() calls to km_alloc(), sparc64's struct cpu_info wants to be allocated on an 8 page boundary, so it needs a custom kmem_va_mode. My T5120 didn't blow up with this, so I think it works. ok? Index: arch/sparc64/sparc64/cpu.c

Re: IPsec PMTU and reject route

2020-12-20 Thread Claudio Jeker
On Sun, Dec 20, 2020 at 01:01:58AM +0100, Alexander Bluhm wrote: > Hi, > > In revision 1.87 of ip_icmp.c claudio@ added ignoring reject routes > to icmp_mtudisc_clone(). Otherwise TCP would clone these routes > for PMTU discovery. They will not work, even after dynamic routing > has found a

Re: [diff] src/usr.sbin/smtpd: add a forward-file option

2020-12-20 Thread Sebastien Marie
On Sat, Dec 19, 2020 at 11:19:10PM -0700, Theo de Raadt wrote: > There are thousands of people with smtpd configurations, and sysmerge > is not going to handle this. > > We cannot expect them all to change their files. This is madness. Well, it wouldn't be the first time. But I agree that such

Re: dig vs ipv6 (scoped) addresses

2020-12-20 Thread Florian Obser
On Thu, Dec 17, 2020 at 12:15:16PM +0100, Otto Moerbeek wrote: > Hi, > > as noted on misc dig does not like to talk to local link addresses. > This fixes that case. While investigating I also found another bug: Thanks for looking into this. Looks like I got distracted while ripping out

kdump: show scope for v6 addresses if set

2020-12-20 Thread Otto Moerbeek
Hi, scope is there, just not shown. While there, use proper constants for two sizes. -Otto Index: ktrstruct.c === RCS file: /cvs/src/usr.bin/kdump/ktrstruct.c,v retrieving revision 1.28 diff -u -p -r1.28 ktrstruct.c ---

Re: [diff] src/usr.sbin/smtpd: add a forward-file option

2020-12-20 Thread Gilles CHEHADE
> On 20 Dec 2020, at 07:13, Sebastien Marie wrote: > > On Sat, Dec 19, 2020 at 10:36:32PM +, gil...@poolp.org wrote: >> Hello, >> >> Whenever a rule with a local action (mbox, maildir, lmtp or mda) is matched, >> smtpd will >> attempt to search for a ~/.forward file in the recipient

Re: [diff] src/usr.sbin/smtpd: add a forward-file option

2020-12-20 Thread Gilles CHEHADE
> On 20 Dec 2020, at 02:09, Todd C. Miller wrote: > > I like this direction but I worry about breaking existing configs. > How are we going to alert existing users that they need to update > their configs if the behavior silently changes? > > - todd I agree and this diff was more to suggest

Re: [diff] src/usr.sbin/smtpd: add a forward-file option

2020-12-20 Thread Gilles CHEHADE
> On 20 Dec 2020, at 10:03, Gilles CHEHADE wrote: > > >> On 20 Dec 2020, at 07:19, Theo de Raadt wrote: >> >> There are thousands of people with smtpd configurations, and sysmerge >> is not going to handle this. >> >> We cannot expect them all to change their files. This is madness. >>

Re: [diff] src/usr.sbin/smtpd: add a forward-file option

2020-12-20 Thread Gilles CHEHADE
> On 20 Dec 2020, at 10:14, Sebastien Marie wrote: > > On Sat, Dec 19, 2020 at 11:19:10PM -0700, Theo de Raadt wrote: >> There are thousands of people with smtpd configurations, and sysmerge >> is not going to handle this. >> >> We cannot expect them all to change their files. This is

Re: kdump: show scope for v6 addresses if set

2020-12-20 Thread Florian Obser
On Sun, Dec 20, 2020 at 02:34:09PM +0100, Claudio Jeker wrote: > On Sun, Dec 20, 2020 at 01:39:57PM +0100, Otto Moerbeek wrote: > > Hi, > > > > scope is there, just not shown. While there, use proper constants for > > two sizes. > > > > -Otto > > > > > > Index: ktrstruct.c > >

Re: dig vs ipv6 (scoped) addresses

2020-12-20 Thread Otto Moerbeek
On Sun, Dec 20, 2020 at 10:48:01AM +0100, Florian Obser wrote: > On Thu, Dec 17, 2020 at 12:15:16PM +0100, Otto Moerbeek wrote: > > Hi, > > > > > as noted on misc dig does not like to talk to local link addresses. > > This fixes that case. While investigating I also found another bug: > >

dig(1): nuke isc_sockaddr_fromin{,6}

2020-12-20 Thread Florian Obser
Rewrite parse_netprefix to no longer use isc_sockaddr_fromin{,6}. Since this was the last user of those functions we can delete them. That turd seems to be reasonably shiny with this... OK? diff --git dighost.c dighost.c index 116de3a1c6d..b822a92c756 100644 --- dighost.c +++ dighost.c @@

Re: [diff] src/usr.sbin/smtpd: add a forward-file option

2020-12-20 Thread Gilles CHEHADE
> On 20 Dec 2020, at 07:19, Theo de Raadt wrote: > > There are thousands of people with smtpd configurations, and sysmerge > is not going to handle this. > > We cannot expect them all to change their files. This is madness. > > Gilles, I think you should be adding an option that blocks it

Re: [diff] src/usr.sbin/smtpd: add a forward-file option

2020-12-20 Thread Gilles CHEHADE
> On 20 Dec 2020, at 03:21, Theo de Raadt wrote: > > Todd C. Miller wrote: > >> I like this direction but I worry about breaking existing configs. >> How are we going to alert existing users that they need to update >> their configs if the behavior silently changes? > > I think the

Re: kdump: show scope for v6 addresses if set

2020-12-20 Thread Claudio Jeker
On Sun, Dec 20, 2020 at 01:39:57PM +0100, Otto Moerbeek wrote: > Hi, > > scope is there, just not shown. While there, use proper constants for > two sizes. > > -Otto > > > Index: ktrstruct.c > === > RCS file:

Re: kdump: show scope for v6 addresses if set

2020-12-20 Thread Otto Moerbeek
On Sun, Dec 20, 2020 at 02:34:09PM +0100, Claudio Jeker wrote: > On Sun, Dec 20, 2020 at 01:39:57PM +0100, Otto Moerbeek wrote: > > Hi, > > > > scope is there, just not shown. While there, use proper constants for > > two sizes. > > > > -Otto > > > > > > Index: ktrstruct.c > >

Re: [diff] usr.sbin/smtpd: fix event handling upon exit

2020-12-20 Thread Gilles CHEHADE
Ping ? > On 14 Dec 2020, at 11:34, Gilles Chehade wrote: > > Hello, > > Upon termination, the parent process will call parent_shutdown() which will > in turn call mproc_clear() to properly terminate IPC with child processes. > > In mproc_clear(), event_del() is called but a check is lacking

Re: [diff] src/usr.sbin/smtpd: add a forward-file option

2020-12-20 Thread Chris Bennett
On Sun, Dec 20, 2020 at 09:51:35AM +0100, Gilles CHEHADE wrote: > > > > On 20 Dec 2020, at 07:13, Sebastien Marie wrote: > > > > On Sat, Dec 19, 2020 at 10:36:32PM +, gil...@poolp.org wrote: > >> Hello, > >> > >> Whenever a rule with a local action (mbox, maildir, lmtp or mda) is > >>

Re: sndiod: (mostly) suppress aliasing noise

2020-12-20 Thread Paul Irofti
Hi, Interesting diff. I did not have time to look at it thoroughly, but here are a few observations: - why do you keep the symmetric filter coefficients? (this could halve your while-loop computations too, right?) - the diff's mainlobe look kind of strange at the end, why is that? What

Re: kdump: show scope for v6 addresses if set

2020-12-20 Thread Theo de Raadt
Florian Obser wrote: > On Sun, Dec 20, 2020 at 02:34:09PM +0100, Claudio Jeker wrote: > > On Sun, Dec 20, 2020 at 01:39:57PM +0100, Otto Moerbeek wrote: > > > Hi, > > > > > > scope is there, just not shown. While there, use proper constants for > > > two sizes. > > > > > > -Otto > > > > > >

Re: doas sprinkle some more CFLAGS

2020-12-20 Thread Theo de Raadt
Ted Unangst wrote: > On 2020-12-18, Martijn van Duren wrote: > > So I ended up in doas again, this time with the CFLAGS I use for most of > > my other projects. This popped up a few new not very exciting warnings. > > Diff below compiles clean with both clang and gcc on amd64. > > > static

Re: sigsuspend(2): use "sigsuspend" for sleep string

2020-12-20 Thread Mark Kettenis
> Date: Sun, 20 Dec 2020 14:53:16 -0600 > From: Scott Cheloha > > I want to see if a process is waiting in sigsuspend(2) from top(1). > The current sleep string is "pause", which leaves me wondering what > the process is actually doing. The string "sigsuspend" would make it > unambiguous. > >

Re: [diff] src/usr.sbin/smtpd: add a forward-file option

2020-12-20 Thread Gilles CHEHADE
> On 20 Dec 2020, at 18:15, Chris Bennett > wrote: > > On Sun, Dec 20, 2020 at 09:51:35AM +0100, Gilles CHEHADE wrote: >> >> >>> On 20 Dec 2020, at 07:13, Sebastien Marie wrote: >>> >>> On Sat, Dec 19, 2020 at 10:36:32PM +, gil...@poolp.org wrote: Hello, Whenever a

Re: sigsuspend(2): use "sigsuspend" for sleep string

2020-12-20 Thread Scott Cheloha
On Sun, Dec 20, 2020 at 10:11:07PM +0100, Mark Kettenis wrote: > > Date: Sun, 20 Dec 2020 14:53:16 -0600 > > From: Scott Cheloha > > > > I want to see if a process is waiting in sigsuspend(2) from top(1). > > The current sleep string is "pause", which leaves me wondering what > > the process is

Re: Poison file names

2020-12-20 Thread Daniel Dickman
John, I'm now able to clone the repo from windows following this commit: https://github.com/openbsd/src/commit/6e49571c59fe1f1e78405e5a57a1e8dc40029e00 Two caveats: 1) if you wanted to bisect the repo on windows or checkout any earlier commit than the one above, it won't be possible to do from

[please test] acpi: more *sleep(9) -> *sleep_nsec(9) conversions

2020-12-20 Thread Scott Cheloha
Short version: Please test if this patch breaks suspend or hibernate on your machine. Reply with the results of your test and your dmesg. Both are still working on my Lenovo Thinkpad X1 Carbon Gen 6. Long version: This patch converts the remaining tick sleeps in dev/acpi to nanosecond sleeps.

smtp(1) add authentication

2020-12-20 Thread Martijn van Duren
Playing around with the filter API I want an easier way to send mail with authentication instead of doing the transaction manually via openssl or via bloated mailclients. Turns out we already have all the plumbing in place and just need to hook it up. OK? martijn@ Index: smtpc.c

Re: WITNESS panic: acquiring blockable sleep lock with spinlock or critical section held (rwlock) kmmaplk

2020-12-20 Thread Mark Kettenis
> Date: Sat, 19 Dec 2020 18:07:41 -0300 > From: Martin Pieuchot > > On 18/12/20(Fri) 08:04, Todd C. Miller wrote: > > On Fri, 18 Dec 2020 13:34:39 +0100, Mark Kettenis wrote: > > > > > Anyway, your analysis is right. When a kernel thread wants to use > > > pmap_extract(9) on a userland pmap,

sigsuspend(2): use "sigsuspend" for sleep string

2020-12-20 Thread Scott Cheloha
I want to see if a process is waiting in sigsuspend(2) from top(1). The current sleep string is "pause", which leaves me wondering what the process is actually doing. The string "sigsuspend" would make it unambiguous. ok? Index: kern_sig.c

Re: sndiod: (mostly) suppress aliasing noise

2020-12-20 Thread Alexandre Ratchov
On Sun, Dec 20, 2020 at 05:58:22PM +0200, Paul Irofti wrote: > Hi, > > Interesting diff. > > I did not have time to look at it thoroughly, but here are a few > observations: > Hi, Thanks for looking at this. - why do you keep the symmetric filter coefficients? (this could halve your >

Re: [please test] acpi: more *sleep(9) -> *sleep_nsec(9) conversions

2020-12-20 Thread Greg Steuck
Scott Cheloha writes: > Short version: > > Please test if this patch breaks suspend or hibernate on your > machine. Reply with the results of your test and your dmesg. > > Both are still working on my Lenovo Thinkpad X1 Carbon Gen 6. This breaks resume from zzz on HP EliteBook 840 G1. The

[PATCH] Reduce case duplication in kern_sysctl

2020-12-20 Thread Greg Steuck
I tested this by diff'ing sysctl output before/after on amd64. Since there's a bunch of ifdef'ness I verified RAMDISK still builds. I deliberately didn't fix the indentation to keep this diff a pure line motion (would run over 80 chars otherwise). I can either fix that it in a separate commit or