Re: snmpd(8): New application layer - step towards agentx support

2021-11-21 Thread Martijn van Duren
On Sun, 2021-11-14 at 14:35 +, Stuart Henderson wrote: > On 2021/11/14 11:49, Martijn van Duren wrote: > > sthen@ found an issue when using this diff with netsnmp tools. > > > > The problem was that I put the requestID in the msgID, resulting > > in a mismatch upon receiving the reply. The

Re: snmpd: tweak listen on

2021-11-21 Thread Martijn van Duren
On Sat, 2021-11-20 at 14:17 +, Stuart Henderson wrote: > On 2021/11/20 10:20, Martijn van Duren wrote: > > On Sun, 2021-11-14 at 22:30 +0100, Sebastian Benoit wrote: > > > If there is no obvious reason (i.e. be different because you need it for a > > > specific feature) why not to use the same

Some USB memory allocation cleanup

2021-11-21 Thread Marcus Glocker
A friend of mine is trying to use two full HD cams on a OpenBSD laptop to record his band sessions from two different angles. He can start the first cam fine with 1920x1080, but if he tries to start the second cam with 1920x1080 he runs out of USB memory. That made me look in to the USB memory

Re: asr(3): strip AD flag in responses

2021-11-21 Thread Florian Obser
On 2021-11-20 21:16 +01, Otto Moerbeek wrote: > On Sat, Nov 20, 2021 at 06:44:58PM +0100, Florian Obser wrote: > >> On 2021-11-20 18:41 +01, Florian Obser wrote: >> > On 2021-11-20 18:19 +01, Florian Obser wrote: >> > >> >> +/* >> >> + * Clear AD flag in the answer. >> >> + */ >> >> +static

Re: Explicitly tag commands in vi(1)

2021-11-21 Thread Ingo Schwarze
Hi Simon, Simon Branch wrote on Sat, Nov 20, 2021 at 03:10:22PM -0800: > Here's a diff that adds explicit .Tg macros to vi(1), We don't want that: $ man -O tag=Tg mdoc [...] In most cases, adding a Tg macro would be redundant because mandoc(1) is able to automatically tag most

ksh: diff to add tab completion for '..'

2021-11-21 Thread Luís Henriques
Hi! I always found it annoying that, in ksh, doing: $ ls .. followed by TAB doesn't allow me to list the options (i.e. show files/dirs in '..'). I need to do add a trailing '/' to this 'ls' command in order to have the completions listed. This diff makes this work without the trailing '/',

Re: tee(1): increase read buffer to MAXBSIZE bytes

2021-11-21 Thread Scott Cheloha
On Fri, Nov 19, 2021 at 08:40:37PM -0700, Theo de Raadt wrote: > Scott Cheloha wrote: > > > On Fri, Nov 19, 2021 at 07:42:18PM -0700, Theo de Raadt wrote: > > > +#include /* for MAXBSIZE */ > > > > > > No way, that is non-POSIX namespace. We are going in precisely the > > > opposite > > >

Re: asr(3): strip AD flag in responses

2021-11-21 Thread Jeremie Courreges-Anglas
On Sat, Nov 20 2021, Florian Obser wrote: > On 2021-11-20 17:05 +01, Jeremie Courreges-Anglas wrote: [...] >> Index: lib/libc/asr/getrrsetbyname_async.c >> === >> RCS file: /home/cvs/src/lib/libc/asr/getrrsetbyname_async.c,v >>

Re: IPsec tdb ref counting

2021-11-21 Thread Alexander Bluhm
Updated tdb refcounting diff after merging with mvs@'s commit. Index: net/if_bridge.c === RCS file: /data/mirror/openbsd/cvs/src/sys/net/if_bridge.c,v retrieving revision 1.358 diff -u -p -r1.358 if_bridge.c --- net/if_bridge.c

libkeynote: prepare for opaque EVP_PKEY, fix some leaks

2021-11-21 Thread Theo Buehler
The fix I need introduces the use of EVP_PKEY_get0_RSA(). Ownership handling in this scope is a bit wonky: X509_get_pubkey() increments the refcount of pPublicKey. What we actually want is a reference of its pkey.rsa. So use X509_get0_pubkey() instead and up the refcount of the RSA. Finally,

Re: vmm(4): copyout guest regs, irqready on VM_EXIT_NONE

2021-11-21 Thread Mike Larkin
On Sat, Nov 20, 2021 at 09:14:31PM -0500, Dave Voutila wrote: > The below diff fixes an issue reported by kn@ on bugs@ [1]. joshe@ also > observed the issue and confirmed the below diff resolves it. > > The symptoms were quite odd: errors from fdc(4) during an OpenBSD guest > booting under

Re: rge(4) diff copying over re(4) rev 1.211

2021-11-21 Thread Greg Steuck
OK gnezdo@ Brad Smith writes: > Being that rge(4) is derived from re(4) it looks like it has the same > issues as fixed in re(4) rev 1.211. > > revision 1.211 > date: 2021/05/17 11:59:53; author: visa; state: Exp; lines: +4 -1; > commitid: aS9a9xwYauxPaauQ; > Fix mbuf leaks after reception

Re: asr(3): strip AD flag in responses

2021-11-21 Thread Jeremie Courreges-Anglas
On Sun, Nov 21 2021, Jeremie Courreges-Anglas wrote: > On Sat, Nov 20 2021, Florian Obser wrote: [...] >>> Index: lib/libc/asr/res_mkquery.c >>> === >>> RCS file: /home/cvs/src/lib/libc/asr/res_mkquery.c,v >>> retrieving revision

acme-client: another trivial accessor conversion

2021-11-21 Thread Theo Buehler
bio->num_write aka BIO_number_written(bio). Straightforward. The main reason I'm asking is that keeping the two else results in overlong lines and awkward line wrapping. So I decided to drop them hoping that's acceptable. Otherwise please tell me the preferred way to wrap the lines in this part of

Re: asr(3): strip AD flag in responses

2021-11-21 Thread Otto Moerbeek
On Sun, Nov 21, 2021 at 04:51:45PM +0100, Florian Obser wrote: > On 2021-11-20 21:16 +01, Otto Moerbeek wrote: > > On Sat, Nov 20, 2021 at 06:44:58PM +0100, Florian Obser wrote: > > > >> On 2021-11-20 18:41 +01, Florian Obser wrote: > >> > On 2021-11-20 18:19 +01, Florian Obser wrote: > >> > >

Re: asr(3): strip AD flag in responses

2021-11-21 Thread Theo de Raadt
Otto Moerbeek wrote: > > right. So I have tried my patch (without the memcpy dance) on sparc64 > > over udp and tcp and I have also tracked this down in the code. This > > should be fine as is. ar->ar_data comes directly out of malloc > > (reallocarray) in ensure_ibuf() and the struct is defined

PMTU in IPsec IPv6 in IPv6 tunnel

2021-11-21 Thread Alexander Bluhm
Hi, Path MTU discovery for IPv6 in IPv6 tunnel over IPsec does not work. Sending ICMP6 too big is not implemented. Copying the code from ip_forward() fixes it. While there, do some cleanup. - #ifdef IPSEC makes no sense. While IPsec needs this code, only the route and interface are used and

Re: vmm(4): copyout guest regs, irqready on VM_EXIT_NONE

2021-11-21 Thread Dave Voutila
Mike Larkin writes: > On Sat, Nov 20, 2021 at 09:14:31PM -0500, Dave Voutila wrote: >> The below diff fixes an issue reported by kn@ on bugs@ [1]. joshe@ also >> observed the issue and confirmed the below diff resolves it. >> >> The symptoms were quite odd: errors from fdc(4) during an OpenBSD

Re: tee(1): increase read buffer to MAXBSIZE bytes

2021-11-21 Thread Theo de Raadt
Scott Cheloha wrote: > The point of diminishing returns on my machine is 128K. ... > So, is 128K ok? Any objections? Many of us have forgotten that our testing machines are at the fast end of the curve. I recommend 64K. I suspect that is still the sweet spot for userland. Above 64K, I think

Re: acme-client: another trivial accessor conversion

2021-11-21 Thread Florian Obser
I'm not a huge fan of these long if else if chains in this code base, so fine by me. OK On 2021-11-22 00:18 +01, Theo Buehler wrote: > bio->num_write aka BIO_number_written(bio). Straightforward. The main > reason I'm asking is that keeping the two else results in overlong lines > and awkward

Re: tee(1): increase read buffer to MAXBSIZE bytes

2021-11-21 Thread gwes
On 11/21/21 10:36 PM, Theo de Raadt wrote: Scott Cheloha wrote: The point of diminishing returns on my machine is 128K. ... So, is 128K ok? Any objections? Many of us have forgotten that our testing machines are at the fast end of the curve. I recommend 64K. I suspect that is still