Re: converting perl stuff to v5.36

On Sun, May 07, 2023 at 07:21:11PM -0700, Philip Guenther wrote: > Yeah, the downside of signatures is that by default it makes adding > parameters a breaking change and can thus calcify the interface. Something > for authors of shared modules that have callbacks to carefully consider. :/ So

Re: malloc: less unlock/lock dancing

On Thu, May 04, 2023 at 03:40:35PM +0200, Otto Moerbeek wrote: > On Thu, Apr 27, 2023 at 02:17:10PM +0200, Otto Moerbeek wrote: > > > This was introduced to not stall other threads while mmap is called by > > a thread. But now that mmap is unlocked, I believe it is no longer > > useful. > > > >

smtpd: nits to reduce the diff with -portable

As per subject, here's a few misc nits that would reduce the difference with -portable. There's some printing of time_t via casting to long long, some missing includes (even if in tree it builds nevertheless) and a const for a variable (no idea how it went there in -portable but it's not wrong so

acme-client.conf example: more explicit clue to test with staging server

espie mentioned that the clue to use the staging server could be more explicit. Maybe this is enough and not too intrusive? Index: examples/acme-client.conf === RCS file: /cvs/src/etc/examples/acme-client.conf,v retrieving revision

Re: acme-client.conf example: more explicit clue to test with staging server

We put *a lot* of work in so that a simple search & replace of example.com in acme-client.conf and httpd.conf examples would give a working configuration. So I would object to the previous diff. I'm not convinced this one will help(*) but no objection from me either. *) People don't read, we

Re: converting perl stuff to v5.36

On Mon, May 08, 2023 at 01:23:25AM -0400, George Koehler wrote: > On Sun, 7 May 2023 19:21:11 -0700 > Philip Guenther wrote: > > > On Sun, May 7, 2023 at 6:13 AM Marc Espie > > wrote: > > > > > I'm actually wondering whether keeping the prototype is worth it. > > ... > > For plain subs, I

Re: software tcp send offloading

On Tue, May 09, 2023 at 09:56:36AM +0200, Alexander Bluhm wrote: > On Sun, May 07, 2023 at 09:00:31PM +0200, Alexander Bluhm wrote: > > Not sure if I addressed all corner cases already. I think IPsec > > is missing. > > Updated diff: > - parts have been commited > - works with IPsec now Thanks

Re: acme-client.conf example: more explicit clue to test with staging server

On Tue, May 09, 2023 at 08:48:06PM +0200, Theo Buehler wrote: > espie mentioned that the clue to use the staging server could be more > explicit. > Maybe this is enough and not too intrusive? Some expressed concern that it should be done the other way around, i.e., leave the default at

Re: acme-client.conf example: more explicit clue to test with staging server

On Tue, 09 May 2023 21:45:30 +0200, Theo Buehler wrote: > Some expressed concern that it should be done the other way around, > i.e., leave the default at letsencrypt. Perhaps it's indeed better > this way to avoid creating servers with bad certs. OK millert@ for this version - todd

Re: smtpd: nits to reduce the diff with -portable

On Wed, 10 May 2023 00:55:54 +0200, Omar Polo wrote: > As per subject, here's a few misc nits that would reduce the > difference with -portable. There's some printing of time_t via > casting to long long, some missing includes (even if in tree it builds > nevertheless) and a const for a variable

vmm/vmd: use anon shared mappings for devices

tech@, The diff below adds a new ioctl for vmm(4) that allows an emulated device process request vmm(4) enter a shared mapping in its vmspace so it can access guest memory without using a shared mapping backed by a named file. Similar to the vm creation ioctl (VMM_IOC_CREATE), the caller

Re: Partial chains for rpki-client

On Mon, May 08, 2023 at 02:01:52PM +0200, Theo Buehler wrote: > The diff below is based on a hint by beck and was discussed extensively > with beck, claudio and job during and after m2k23. It results in a quite > significant reduction of the runtime of an ordinary rpki-client run as > usually done

Re: software tcp send offloading

On Sun, May 07, 2023 at 09:00:31PM +0200, Alexander Bluhm wrote: > Not sure if I addressed all corner cases already. I think IPsec > is missing. Updated diff: - parts have been commited - works with IPsec now - some bugs fixed - sysctl net.inet.tcp.tso - netstat TSO counter If you test this,

rpki-client: use OpenSSL 1.1 ASN1_TIME API

beck ported the OpenSSL ASN1_TIME API to use the ASN1_time* API under the hood, so for LibreSSL the diff here is a noop. This allows us to eliminate most of the gross openssl hacks in regress. The unistd.h thing is still needed because of STACK_OF discrepancies, but the reacharound into libcrypto

bgplgd fix for invalid

This is the minimal change to handle the rename of invalid to disqualified in bgpctl. Maybe the QS argument should also be changed which makes the diff a lot bigger. -- :wq Claudio Index: qs.c === RCS file:

Re: bgplgd fix for invalid

On Tue, May 09, 2023 at 04:19:01PM +0200, Claudio Jeker wrote: > This is the minimal change to handle the rename of invalid to disqualified > in bgpctl. ok > > Maybe the QS argument should also be changed which makes the diff a lot > bigger. I think we should land the minimal fix first, since