Re: smtpd: nits to reduce the diff with -portable

2023-05-10 Thread Omar Polo
On 2023/05/10 09:30:12 +0200, Theo Buehler wrote: > > I forgot to include one off_t cast since it was in a different > > directory and -even if off topic because it's not in portable- instead > > of "const"-ify only tz why don't mark as const also the two arrays day > > and month? > > ok. > >

Re: malloc: less unlock/lock dancing

2023-05-10 Thread Otto Moerbeek
On Tue, May 09, 2023 at 09:55:32PM +0200, Theo Buehler wrote: > On Thu, May 04, 2023 at 03:40:35PM +0200, Otto Moerbeek wrote: > > On Thu, Apr 27, 2023 at 02:17:10PM +0200, Otto Moerbeek wrote: > > > > > This was introduced to not stall other threads while mmap is called by > > > a thread. But

Re: malloc: less unlock/lock dancing

2023-05-10 Thread Theo Buehler
> Thanks! It has been committed. I doubt though if the Go runtime uses > libc malloc. I don't know if the pure Go runtime uses libc malloc. However, some of the test code involves cgo and calls into various C libraries including libcrypto. So it definitely exercised malloc in a threaded

Re: smtpd: nits to reduce the diff with -portable

2023-05-10 Thread Theo Buehler
On Wed, May 10, 2023 at 09:25:43AM +0200, Omar Polo wrote: > On 2023/05/09 19:41:51 -0600, "Todd C. Miller" wrote: > > On Wed, 10 May 2023 00:55:54 +0200, Omar Polo wrote: > > > > > As per subject, here's a few misc nits that would reduce the > > > difference with -portable. There's some

Re: smtpd: nits to reduce the diff with -portable

2023-05-10 Thread Omar Polo
On 2023/05/09 19:41:51 -0600, "Todd C. Miller" wrote: > On Wed, 10 May 2023 00:55:54 +0200, Omar Polo wrote: > > > As per subject, here's a few misc nits that would reduce the > > difference with -portable. There's some printing of time_t via > > casting to long long, some missing includes

Re: smtpd: nits to reduce the diff with -portable

2023-05-10 Thread Todd C . Miller
On Wed, 10 May 2023 09:25:43 +0200, Omar Polo wrote: > I forgot to include one off_t cast since it was in a different > directory and -even if off topic because it's not in portable- instead > of "const"-ify only tz why don't mark as const also the two arrays day > and month? Sure. OK millert@

Re: software tcp send offloading

2023-05-10 Thread Hrvoje Popovski
On 9.5.2023. 9:56, Alexander Bluhm wrote: > On Sun, May 07, 2023 at 09:00:31PM +0200, Alexander Bluhm wrote: >> Not sure if I addressed all corner cases already. I think IPsec >> is missing. > Updated diff: > - parts have been commited > - works with IPsec now > - some bugs fixed > - sysctl

Re: malloc: less unlock/lock dancing

2023-05-10 Thread Otto Moerbeek
On Wed, May 10, 2023 at 10:08:09AM +0200, Theo Buehler wrote: > > Thanks! It has been committed. I doubt though if the Go runtime uses > > libc malloc. > > I don't know if the pure Go runtime uses libc malloc. However, some > of the test code involves cgo and calls into various C libraries >

seperate LRO/TSO flags

2023-05-10 Thread Jan Klemkow
Hi, This diff introduces separate flags for TCP offloading. We split this into LRO (large receive offloading) and TSO (TCP segmentation offloading). Thus, we are able to turn it on/off separately. For ifconfig(8) we use "tcprecvoffload" and "tcpsendoffload". So, the user has a better insight

openrsync: Fix a file descriptor leak

2023-05-10 Thread Josiah Frentsos
Index: main.c === RCS file: /cvs/src/usr.bin/rsync/main.c,v retrieving revision 1.68 diff -u -p -r1.68 main.c --- main.c 28 Apr 2023 10:24:38 - 1.68 +++ main.c 10 May 2023 17:43:23 - @@ -602,6 +602,7 @@ basedir:

Re: [patch] Discontinued Toshiba dynadock lines for usbdevs and udl driver

2023-05-10 Thread Miod Vallat
> Good Day, > > https://uk.dynabook.com/discontinued-products/pa3542e-2prp/ > > one more device with old (probably DL-160, but unsure so leaving > DLUNK) DisplayLink chip. works ok. Patch applied, thanks! Miod

Re: seperate LRO/TSO flags

2023-05-10 Thread Jan Klemkow
On Wed, May 10, 2023 at 11:13:04AM -0600, Todd C. Miller wrote: > On Wed, 10 May 2023 19:03:58 +0200, Jan Klemkow wrote: > > This diff introduces separate flags for TCP offloading. We split this > > into LRO (large receive offloading) and TSO (TCP segmentation > > offloading). Thus, we are able

Re: seperate LRO/TSO flags

2023-05-10 Thread Todd C . Miller
On Wed, 10 May 2023 20:55:24 +0200, Jan Klemkow wrote: > For tcprecvoffload and ix(4) it's not possible to enable/disable it per > address family. Its just one flag for the hardware. > > For tcpsendoffload its possible, but I won't do that till its necessary. > > Why would you want to

Re: seperate LRO/TSO flags

2023-05-10 Thread Todd C . Miller
On Wed, 10 May 2023 19:03:58 +0200, Jan Klemkow wrote: > This diff introduces separate flags for TCP offloading. We split this > into LRO (large receive offloading) and TSO (TCP segmentation > offloading). Thus, we are able to turn it on/off separately. > > For ifconfig(8) we use

sigsuspend.2: document behavior for discarded signals

2023-05-10 Thread Todd C . Miller
The sigsuspend(2) man page doesn't spell out explicitly what happens for signals that are discarded, either as the default action or where the handler is set to SIG_IGN. I think it should. OK? - todd Index: lib/libc/sys/sigsuspend.2

rpki-client: provide more diagnostics to the operator

2023-05-10 Thread Job Snijders
Hi folks, Without this changeset, rpki-client will display diagnostic information about missing files like so: $ doas rpki-client -t /etc/rpki/lacnic.tal -H repository.lacnic.net rpki-client:

Re: rpki-client: provide more diagnostics to the operator

2023-05-10 Thread Theo Buehler
> $ doas rpki-client -t /etc/rpki/ripe.tal -H rpki.ripe.net -H > chloe.sobornost.net > rpki-client: > .rrdp/436FC6BD7B32853E42FCE5FD95B31D5E3EC1C32C46B7518C2067D568E7EAC119/chloe.sobornost.net/rpki/RIPE-nljobsnijders/cb/5EjPZ8Kw2_h5hRqKpwmjdnq7Tq8.roa: > bad file digest for

rc.shutdown.8: document stopping vmd(8)

2023-05-10 Thread Klemens Nanni
Came here after reading /etc/rc wrt. the shutdown sequence. Feedback? Index: rc.shutdown.8 === RCS file: /cvs/src/share/man/man8/rc.shutdown.8,v retrieving revision 1.16 diff -u -p -r1.16 rc.shutdown.8 --- rc.shutdown.8 16 May

Re: syscall(SYS_sysctl) broken in 7.3

2023-05-10 Thread Philip Guenther
On Wed, May 10, 2023 at 1:29 PM Alexander Bluhm wrote: > We use Perl syscall(2) function to implement sysctl(2) system calls. > This is broken since OpenBSD 7.3. A sample program looks like this: > ... > kdump shows two problems: > 1. The mib is not printed correctly. > 2. The final argument

Re: vmm/vmd: use anon shared mappings for devices

2023-05-10 Thread Mike Larkin
On Tue, May 09, 2023 at 06:12:55AM -0400, Dave Voutila wrote: > tech@, > > The diff below adds a new ioctl for vmm(4) that allows an emulated > device process request vmm(4) enter a shared mapping in its vmspace so > it can access guest memory without using a shared mapping backed by a > named

Re: Status of Virtual Function driver for Intel 82599 series port?

2023-05-10 Thread Yuichiro NAITO
On 4/30/23 04:04, Paul B. Henson wrote: > https://marc.info/?l=openbsd-tech=167160269008839=2 > > The port doesn't appear to be merged yet, and there's no activity on the > thread since December, so I was just wondering what the current status > of this is? If there's any further testing needed I

syscall(SYS_sysctl) broken in 7.3

2023-05-10 Thread Alexander Bluhm
Hi, We use Perl syscall(2) function to implement sysctl(2) system calls. This is broken since OpenBSD 7.3. A sample program looks like this: #!/usr/bin/perl use constant SYS_sysctl => 202; # net.inet6.ip6.soiikey my @mib = (4, 24, 41, 54); my $miblen = scalar(@mib); my $mib = pack("i$miblen",